GitLab

- Remove some unused values.
- Document the rest.

Bug: 762357
Change-Id: Id32abd4474b58c9577c12757944fb879319673c8
Reviewed-on: https://chromium-review.googlesource.com/1096514
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566659}

Specifically ScheduleEmbed(), ScheduleEmbedForExistingClient() and
EmbedUsingToken().

BUG=837702
TEST=covered by test
TBR=tsepez@chromium.org

Change-Id: I5a7922ec0c14cf3f0c3b6632794eb2a6f6a9963a
Reviewed-on: https://chromium-review.googlesource.com/1096662Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566658}

This involved:
- Adding icons for keyboard and voice input states.
- Modifying DialogPlate view hierarchy (see details in bug).
- Removing spacing between child views in AssistantMainView.
- Modifying suggestion chip alignment within container.

As a result of the new spec, much of the complexity in ActionView is
no longer needed as it no longer needs to account for a keyboard
input modality state. That will be cleaned up in a follow up CL.

See bug for additional details/demos.

Bug: b:110061195
Change-Id: I087014029c0c590d3965cd1d4bb47b0332c30cc5
Reviewed-on: https://chromium-review.googlesource.com/1096661
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566657}

Add method to the CastContentWindow::Delegate to receive notification
when a swipe from the left is released before resulting in a completed
back.

Bug: internal b/109888887
Test: manual
Change-Id: I73a451efa0c02d1f0f0d4b0e7d92268c061ea483
Reviewed-on: https://chromium-review.googlesource.com/1098075Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566656}

A VDA client should not ReusePictureBuffer() on a dismissed picture buffer.
VDA doesn't have to handle this case.

BUG=chromium:834170
TEST=VDA unittest on eve and kevin
TEST=VDA unittest on non-Chrome OS platforms in CQ.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia3bc2534684b5448c01fdc86d7efc7db4389c21c
Reviewed-on: https://chromium-review.googlesource.com/1063890Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566655}

This CL fixes an issue where closure compilations may not rebuild if
only their externs files change.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie18c5e658742e4025658d082477a9ab87291e065
Reviewed-on: https://chromium-review.googlesource.com/1096809Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566654}

TestInProcessContextProvider was not calling

context is lockable. This change updates TestInProcessContextProvider
to optionally support locking, and set up the ContextCacheController
if locking is requested.

ContextCacheController: :SetLock, which is required in cases where the
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I54d1de3768bf958dea944101565fefb99ff2602e
Reviewed-on: https://chromium-review.googlesource.com/1097945Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566653}

Bug: 851163
Change-Id: I2537e17a74492375c78ab210dfbdb56652040eb7
Reviewed-on: https://chromium-review.googlesource.com/1098034
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566652}

Rather than directly linking Content Shell and Content Shell Helper
agasint the Content Shell Framework, to be loaded by dyld, this change
has the executables dlopen the framework at runtime.

This is done to match how Chrome is loaded, which is a prequisite for
using the V2 sandbox in Content Shell.

No-Presubmit: True
Bug: 850735
Test: Build content_shell and //content test suites. Both launch and pass.
Change-Id: Id843d99877166fbf91d0df55d9976f6019149da8
Reviewed-on: https://chromium-review.googlesource.com/1093569Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566651}

It's never used.

BUG=none
TEST=none

Change-Id: If4677c56c51f33fe58eb97a4f03a72c087af8297
Reviewed-on: https://chromium-review.googlesource.com/1097949Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566650}

The suite needed to be a subclass of ChromeViewsTestBase to access the
correct LayoutProvider.

Bug: 846410
Change-Id: I51952fd6451b4efcfe26de14ffe73480f1892705
Reviewed-on: https://chromium-review.googlesource.com/1098218
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566649}

Also added integration tests, and moved existing delete tests to be in
one file specific to testing context menu items (context_menu.js).

Test: browser_test --gtest-filter="ContextMenu/FilesApp*"
Bug: 719959
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5c8d2e71697ecdc273f8d41d9b919b5be12b1519
Reviewed-on: https://chromium-review.googlesource.com/1068769Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566648}

BUG=731417,731456

Change-Id: I9fbb2c34f149380a9b98dfc1bfc7ad56041f6fd6
Reviewed-on: https://chromium-review.googlesource.com/1098307Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566647}

Bug: 733662
Change-Id: Id2697199199a67c022d4661e1142c9a237ed8f25
Reviewed-on: https://chromium-review.googlesource.com/1096684Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#566646}

Bug: b/74442987
Test: build cast_shell
Change-Id: Id8b10f928176682ac940dffdaadbbe2853e41cca
Reviewed-on: https://chromium-review.googlesource.com/1096354Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Yuanyao Zhong <yyzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566645}

In order to simplify how we configure tests, it would be good if
every test target was invoked the same way on every platform.

Today, on Android, CrOS, and Fuchsia, we generate wrapper scripts
for every test target and put them in $root_build_dir/bin; these
scripts are responsible for setting up the environment (devices,
VMs, etc.) and invoking the test directly.

This CL continues this pattern and generates wrappers that will
work on Linux, Mac, and Win following the same pattern (on Windows,
the wrappers will be bin/run_base_unittests.bat instead of
bin/run_base_unittests).

As a proof of concept, this CL switches url_unittests to run via
the wrapper. Assuming this change lands and sticks, in follow-up
changes we'll convert the others as well.

This design should also help us eventually get rid of
gn_isolate_map.pyl; in order to do that, we will also need to
not translate between ninja target names and GN labels, but
that will require changes to GN.

Bug: 816629
Change-Id: I66f8ca78472564ee46cc8d3d012591a275566d1f
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/736162
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566644}

Based of design doc: [1].
Left a couple TODO for a part 2 so this cl does not get too large.
Moves a bunch of code out of PositionWindows to a new function
which can be shared with the Nudging function.

[1] https://docs.google.com/document/d/1YhbbW-Amm_TxlyHQWOG0Q1AjRar2-kTCCi8WO4_q0Zc/edit#heading=h.5ugemo7p04z9

Test: 
Bug: 843273
Change-Id: I7d9355af7414f1f2a3a8c86338a3919be6dbbd9d
Reviewed-on: https://chromium-review.googlesource.com/1066494Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566643}

And rename all names that were derived from this name (i.e. variable
names and other related classes) to no longer mention LevelDBWrapper as
well. Left alone the code in content/renderer/dom_storage for now, as
all that code will get moved/renamed as part of actually onion-souping
this anyway, so changing things now is just code churn for no good
reason.

Bug: 809771
Change-Id: I5d8675f98bf19eb0e14329c42f7312f0b33fe982
Reviewed-on: https://chromium-review.googlesource.com/1096274Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566642}

Previously required both external mouse and keyboard to suppress tablet
mode. That has changed in doc [1].

[1] https://docs.google.com/document/d/1TIiQ_30SRc0PZrYVWUgRieTrW1m-7tWsKb6XPKq6UPk/edit?ts=5b1f00c4#

Test: manual
Bug: 811999
Change-Id: I10d076ec08fc16dd370fca81b4846faf302d4950
Reviewed-on: https://chromium-review.googlesource.com/1098033
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566641}

The current domstorage implementation has an optimization to make
reverse iterating over all the keys in a storage area fast. Keeping that
optimization after onion-souping would be tricky, so add a use counter
to see how many pages actually do anything that hits this case.

Bug: 781870
Change-Id: Ie5b83858842c01d9ac4d8fb8dc31cdaf5738d3ee
Reviewed-on: https://chromium-review.googlesource.com/1098025Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566640}

This change removes the reference in onAddPrinterTap_ to
addPrinterErrorMessage which was removed in https://crrev.com/c/1060341.

Bug: chromium:848055
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5084eac9896331c71c58a9cac2851d1ce14f56ec
Reviewed-on: https://chromium-review.googlesource.com/1089207
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566639}

This CL adds barebones implementation of chrome://process-internals
WebUI, which only shows the current Site Isolation mode and list
of origins isolated by policy or command line.

Bug: 850087
Change-Id: I14b8e20bc763488e8b4ea433599125c96c5ba8d3
Reviewed-on: https://chromium-review.googlesource.com/1091167
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566638}

Also adds a few more comments on things.

R=weiliangc@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4e368c6e22aeddc37617d1a38a98012fa8668a71
Reviewed-on: https://chromium-review.googlesource.com/1097422Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566637}

Methods SubmitFrameMetadata(), SubmitSlice(), and SubmitDecode() updated to return
an enum rather than simply true/false. This allows for future changes that will
handle encrypted media when the key necessary for decryption is not currently
available and needs to be provided before decryption can continue.

BUG=837455

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2238178b5643acb99c8254c8cca75ad8ba2bcb11
Reviewed-on: https://chromium-review.googlesource.com/1080211Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566636}

This reverts commit 703de90c.

Reason for revert: lint errors (http://crbug.com/852189)

Original change's description:
> Check if ARCore is installed or needs update.
> 
> When requesting a session and after the camera permission is confirmed
> to have been granted, check if ARCore is installed and if the version
> used in Chromium is compatible with it. If ARCore is not installed
> or an update is required, a prompt will be shown.
> 
> Bug: 838954
> Change-Id: I35ae39041e7958743bba9cc1c71f5af817bf4240
> Reviewed-on: https://chromium-review.googlesource.com/1074494
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Commit-Queue: Iker Jamardo <ijamardo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566589}

TBR=ddorwin@chromium.org,vollick@chromium.org,pkasting@chromium.org,yfriedman@chromium.org,bshe@chromium.org,mthiesse@chromium.org,estade@chromium.org,twellington@chromium.org,agrieve@chromium.org,klausw@chromium.org,billorr@chromium.org,lincolnfrog@chromium.org,ijamardo@chromium.org

Change-Id: I1f88a1de68d4929a842a4c7bf95aa90a7f48bcba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 838954
Bug: 852189
Reviewed-on: https://chromium-review.googlesource.com/1098335Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566635}

Bug: 719959
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ff560a2d842e91be024d265fd8599675636c16e
Reviewed-on: https://chromium-review.googlesource.com/1088350
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566634}

ProduceTextureDirectCHROMIUM is always called after GenMailboxCHROMIUM
(or equivalently gpu::Mailbox::Generate()), so merge both calls into a
single one. This isn't intended to change any behavior.

Note, TakeFrontBuffer still takes an explicitly generated gpu::Mailbox.

Bug: 847674
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7227ddffba6291c1efe3ed589bfbc6166f3319fe
Reviewed-on: https://chromium-review.googlesource.com/1089695
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566633}

Before, one must guess from context which delegate was called:

t=2141 [st=  0] +REQUEST_ALIVE  [dt=301]
                 --> priority = "HIGHEST"
                 --> url = "https://example.com/"
t=2141 [st=  0]    URL_REQUEST_DELEGATE  [dt=1]
t=2142 [st=  1]   +URL_REQUEST_START_JOB  [dt=298]
                   --> load_flags = 18432 (MAIN_FRAME_DEPRECATED | MAYBE_USER_GESTURE)
                   --> method = "GET"
                   --> url = "https://example.com/"
t=2142 [st=  1]      URL_REQUEST_DELEGATE  [dt=0]
t=2142 [st=  1]      HTTP_CACHE_GET_BACKEND  [dt=0]
t=2142 [st=  1]      HTTP_CACHE_OPEN_ENTRY  [dt=0]
                     --> net_error = -2 (ERR_FAILED)

Now it is spelled out explicitly:

t=2141 [st=  0] +REQUEST_ALIVE  [dt=301]
                 --> priority = "HIGHEST"
                 --> url = "https://example.com/"
t=2141 [st=  0]    NETWORK_DELEGATE_BEFORE_URL_REQUEST  [dt=1]
t=2142 [st=  1]   +URL_REQUEST_START_JOB  [dt=298]
                   --> load_flags = 18432 (MAIN_FRAME_DEPRECATED | MAYBE_USER_GESTURE)
                   --> method = "GET"
                   --> url = "https://example.com/"
t=2142 [st=  1]      NETWORK_DELEGATE_BEFORE_START_TRANSACTION  [dt=0]
t=2142 [st=  1]      HTTP_CACHE_GET_BACKEND  [dt=0]
t=2142 [st=  1]      HTTP_CACHE_OPEN_ENTRY  [dt=0]
                     --> net_error = -2 (ERR_FAILED)

(Okay, I cheated and made the "before" example by editting the "after" one, but
whatever.)

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie5fe7b4405c2389eaece479ff1c93774fe18b8ba
Reviewed-on: https://chromium-review.googlesource.com/1096083Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566632}

This reverts commit b048769f.

Reason for revert: chromium.memory cros msan

Original change's description:
> Enable guest/offline signin links in views login network error screen.
> 
> This CL also disables the LoginScreenLocalePolicyTest.LoginLocaleEnforcedByPolicy
> browser test. It seems to be related to a pre-existing bug: crbug/844572
> 
> Bug: 839593
> Change-Id: I022bf1603ba54386c3686aebd3868d6dee0cd993
> Reviewed-on: https://chromium-review.googlesource.com/1093881
> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566197}

TBR=jdufault@chromium.org,qnnguyen@chromium.org

Change-Id: I03db3d2a5389bced6efbda91219c020ba4f19c68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839593
Reviewed-on: https://chromium-review.googlesource.com/1098275Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566631}

Some of the Notify* functions don't even have implementations anymore.

Bug: none
Change-Id: I7f4c7c9abbe73baaa0eccc769cd3cc5286634658
Reviewed-on: https://chromium-review.googlesource.com/1087585
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566630}

ARC IMEs don't cover the shelf and a user uses the ime menu bubble or
the ime menu in the system menu to switch IMEs because ARC IMEs may not
support switching IME from their UI.
Therefore, ARC IMEs should be placed behind the shelf container.
This CL adds new container window for ARC IMEs.

Bug: 845079
Change-Id: I22fb3bba33e99685d8427c97255258a92a24c8b8
Reviewed-on: https://chromium-review.googlesource.com/1088716Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566629}

The tests were added when interactive_ui_tests were only being run on Views
code. Subsequently, when interactive_ui_tests was switched to Cocoa code, the
tests failed.

There were two test bugs:
* In Cocoa, using Cmd+2 to select the second tab is asynchronous, but the test
  was not waiting.
* The test was dispatching events by sending them directly to the NSWindow. This
  is incorrect - the events should be sent to NSApp.

Bug: 852064
Change-Id: I4cf73724954a90edcfe4dd5a0f4a56fcd13df4a2
Reviewed-on: https://chromium-review.googlesource.com/1097847Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566628}

ProxyResolvingClientSocket can remove QUIC proxies from ProxyList, and continue
connecting with an empty ProxyList.

This CL fixes this and adds a regression test.

Bug: 849300
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie30c8c3fb23b9b025586aff5f1c20fba073d0bee
Reviewed-on: https://chromium-review.googlesource.com/1096259Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566627}

When entering RTL text in the omnibox, if you start typing,
pull down the notification shade (hides the omnibox dropdown),
rotate the phone, and then hide the notification shade, then
the suggestions could be in a wonky state.

To work around this, we can tell the listview to destroy all
of it's views to avoid them being reused.  There is some sort
of cache that no amount of relayout/invalidates were fixing,
so this is the shortest term solution.  I think the longer
term fix is to rewrite SuggestionView, but I couldn't see
any obviously wrong things with it either.

BUG=851839

Change-Id: Ie88cf3395ccc4b92e8a8777474584e061f66b3aa
Reviewed-on: https://chromium-review.googlesource.com/1097944Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566626}

Found by a locally-hacked-up generation script (
https://chromium-review.googlesource.com/c/chromium/src/+/1097616).

This has no effect in practice.

Bug: 843511
Change-Id: I2cd2194216511c4e6c7839f4b0a1174d7b834aee
Reviewed-on: https://chromium-review.googlesource.com/1097621Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566625}

1. Make ArcBluetoothBridge as a bluetooth pairing delegate in order to
receive incoming paring requests and handle it properly. The previous
handling of RequestPasskey falls into BluetoothNotificationController
which incorrectly cancels the pairing.

2. Use exiting UI dialog BluetoothPairingDialog for user to enter the
passcode/confirm pairing etc.

Bug: b/34892353
Change-Id: I161b84b0f3dc11f41cebd544a6c241432fea7ec6
Reviewed-on: https://chromium-review.googlesource.com/1086366Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566624}

Also fix unittest from last CL to test the desired code path.

BUG=internal b/110058717
TEST=cast_bluetooth_unittests, manual

Change-Id: Ib54c0627d90e7fb589e131e009298c362d25dbfd
Reviewed-on: https://chromium-review.googlesource.com/1096614
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566623}

See bug 832289 for the big picture. This is just one step in a
multi-patch refactoring.

The goal of this patch is to delete most of the table and grid
related subclasses in Blink accessibility and reimplement the
behavior in AXObject and AXLayoutObject instead.

This is not meant to be more efficient yet. Some of the
functions to compute the column or row index require a full
table scan, for example - but it's no worse than before.

However, eliminating the subclasses will make it much easier
to incrementally remove functionality from Blink and move it
to ui/accessibility/ax_table_info.

In addition, this refactoring will make it easy to support
tables made out of AOM virtual nodes.

Bug: 832289
Change-Id: If9349c7d0a62dfccdbe43fdd8a2d0d127abf4601
Tbr: mkwst@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1083854
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566622}

RFC 5746 has been published for 8 years now. No doubt this means
everyone doing renegotiations has supported this by now!

Bug: 850800
Change-Id: Ic5c9eaee55e60c9315bc9126be5e64ce0f9828da
Reviewed-on: https://chromium-review.googlesource.com/1091957Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566621}

add_event_listener_options_resolved.h includes
add_event_listener_options.h. There's a race condition:
add_event_listener_options_resolved.h can be compiled before
add_event_listener_options.h is generated. Fix this by making
third_party/blink/renderer/core/dom:dom depend on the generating step.

Change-Id: I0a6405c1c7fcea40feb6a8c91403b3ebe5a4d3ad
Reviewed-on: https://chromium-review.googlesource.com/1093956
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566620}