- 30 Oct, 2017 40 commits
-
-
Mihai Sardarescu authored
Chrome desktop and Chrome OS use the Gaia programmatic_auth endpoint for signing in users to Chrome. This endpoint is currently being deprecated on the Google infrastructure. The programmatic_auth endpoint was only used for the full-tab sign-in page, which was presented in rare cases (sign-in flow starting from apps / extensions / incognito / some particular case from settings). This CL adds an experiment to remove the usage of the programmatic_auth endpoint from Chrome desktop. It changes the full-tab sign-in page to present the embedded GAIA web sign-in page. Internal design doc: https://docs.google.com/a/google.com/document/d/1cnoG1Jo-CZZVlFULOYrcJLoyTmID-gCgkXkT5hW2tpg/edit?usp=sharing Bug: 775009 Change-Id: Ibfdec11972674228250b4d803e23f029a49d8cb9 Reviewed-on: https://chromium-review.googlesource.com/737994Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#512469}
-
Scott Chen authored
When a locked supervising user has no local credentials, the password input will be hidden. However, the code currently still tries to focus that input as the mainInput of the user pod, which puts tab navigation in a limbo state. This CL adds a check in DesktopUserPod to focus the correct element instead of the hidden input while tabbing, when there's no local creds. Bug: 617062 Change-Id: Ia4e6edcecf8e25813debcdd89dcf72186f04be76 Reviewed-on: https://chromium-review.googlesource.com/741749Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#512468}
-
Yoshifumi Inoue authored
This patch gets rid of unused member variable |emits_original_text_| from |SimplifiedBackwardsTextIterator|, because it is always |false|, for improving code health. Change-Id: I6c0e8e6921ed40e98c84ced9d74675f5d305f84d Reviewed-on: https://chromium-review.googlesource.com/742765 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#512467}
-
Benoit Lize authored
This commits adds a new option to extract_symbols.py, --reached-symbols-file, taking a list of reached symbols. It maps this list with the page-level attribution, and represents it visually. Bug: 758566 Change-Id: I76948ea3a2fae983479ab7e0750239a74a971ee9 Reviewed-on: https://chromium-review.googlesource.com/739504 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#512466}
-
Mikhail Pozdnyakov authored
Change-Id: Ia0f6eec2eaef86d3c91730d44aa603d6eb47473d Reviewed-on: https://chromium-review.googlesource.com/741594Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alexander Shalamov <alexander.shalamov@intel.com> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#512465}
-
zhuoyu.qian authored
As the comment in network_quality.h by tbansal@, replace kInvalidThroughput with INVALID_RTT_THROUGHPUT. BUG= R=tbansal@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Signed-off-by:
zhuoyu.qian <zhuoyu.qian@samsung.com> Change-Id: I148b149e6787b79a8e7ffda4f7446854d63662bf Reviewed-on: https://chromium-review.googlesource.com/734926 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#512464}
-
Hajime Hoshi authored
Bug: 777775 Change-Id: I261e8ece3e2f29237eb84922e5f8aaa0acd4a013 Reviewed-on: https://chromium-review.googlesource.com/742780Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512463}
-
Mihai Sardarescu authored
It looks like in some cases, WebViewGuest does not remove itselfs from the observers of the embedded zoom controller. This leads to a crash (see attached bug). This CL always removes the WebViewGuest from the observers of the embedded zoom controller (removing an observer that is not present in an observer list is a no-op). Bug: 779059 Change-Id: I12e828b7d90e172653f8be457517db6809803c67 Reviewed-on: https://chromium-review.googlesource.com/741714 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#512462}
-
Jean-François Geyelin authored
Bug: None. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ida21121192a922c1c2280f5093e992a3ce3366c0 Reviewed-on: https://chromium-review.googlesource.com/740124 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Elodie Banel <lod@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#512461}
-
cm.sanchi authored
Remove chrome:: namespace in chrome/browser/internal_auth.h BUG=289619 Change-Id: I0cefaef24a561805c39daf692fc933cac2c86d0b Reviewed-on: https://chromium-review.googlesource.com/739401 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#512460}
-
Ken Rockot authored
This changes the Network Service-enabled browser-side navigation path to always send a default subresource URLLoaderFactory to the render frame on navigation commit. In addition to sending a default ULF, we also send one for blobs. Ultimately the idea here is to have the browser, at navigation time, send a frame everything it will need to request any accessible subresources, making it easier to reason about what subresource capabilities any given frame has. This set of capabilities is encapsulated by a new URLLoaderFactoryBundle type, which can be serialized over mojom and is now passed in new-document navigation commit messages. Follow-up usage of URLLoaderFactoryBundle will support loading things like file:// and chrome-extension:// subresources when appropriate. Note that this does not yet change how workers acquire ULFs for their own resource requests. Bug: 721414,759230 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I47b0897c7c012292633d5f08c874a18cc0fb1dcb Reviewed-on: https://chromium-review.googlesource.com/740904 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#512459}
-
Yoshifumi Inoue authored
This patch changes |SimplifiedBackwardsTextIterator| to hold |TextBehavior| in member variable as replacement of |bool| member |stop_on_form_controls_| as preparation of using other behavior options. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/741303 Move text-security CSS property handling to TextIterator Bug: 778507 Change-Id: I94d9bcf743d684d2121a1df1fda91ea6f6c65427 Reviewed-on: https://chromium-review.googlesource.com/741103Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#512458}
-
Daniel Cheng authored
Change-Id: I64e56fe66cc445d3784b58cee2253448ae5dcc3e Reviewed-on: https://chromium-review.googlesource.com/740973 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#512457}
-
John Rummell authored
Adds a cdm::FileIO implementation that can be used by mojo CDMs to read and write files. Files are obtained from the mojo CdmStorage interface. BUG=479923,776911 TEST=updated browser_test and new unit tests pass Change-Id: Ib150058407d6db1d0ba2cabf4d5eb3f4a051232c Reviewed-on: https://chromium-review.googlesource.com/706211Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#512456}
-
Hajime Hoshi authored
Bug: 696905 Change-Id: I12008dc1431d370e45df3fcd6d38184457133bd9 Reviewed-on: https://chromium-review.googlesource.com/741661Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512455}
-
Sergey Ulanov authored
The new SDK contians bugfixes for media_client library to avoid crashing when playing audio. Bug: 772488 Change-Id: I3c6139a4e75c5a86c363c3773a599e9dba270dd6 Reviewed-on: https://chromium-review.googlesource.com/739764 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#512454}
-
Gyuyoung Kim authored
scoped_refptr can be used in blink now. This CL is to replace some remaining uses of WTF::RefPtr with scoped_refptr in blink. Bug: 763844 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5925ee3793a94fe947be943e3206fe1d9a4f862e Reviewed-on: https://chromium-review.googlesource.com/742768Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#512453}
-
Hayato Ito authored
Introduce Source/core/dom/ng directory, and put in-development implementations of Incremental Shadow DOM there. As the first step, add an experimental implementation of flat tree traversal, which makes slots participate in a flat tree. Once Incremental Shadow DOM is ready to launch, the contents of this directory would be merged to Source/core/dom, and this directory will be removed. I also changed the status of IncrementalShadowDOM runtime flag from "test" to "<missing>", as LayoutNG does, because I don't want to enable the flag in layout tests in default. TBR=haraken@chromium.org Bug: 776656 Change-Id: I19348959829865aad754b5ba4947b345d8c1246d Reviewed-on: https://chromium-review.googlesource.com/737969 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512452}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/52d748d48b4d..c0775e4e6ac1 $ git log 52d748d48..c0775e4e6 --date=short --no-merges --format='%ad %ae %s' 2017-10-26 benjhayden Fix add_reserved_diagnostics Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie438aca3bd6ffbe81b2ff50181f97821f4d36ac8 Reviewed-on: https://chromium-review.googlesource.com/742246 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512451}
-
Owen Lin authored
BUG=755889 TEST=None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1780b6b54fa6de50594c995170724d888abc64ae Reviewed-on: https://chromium-review.googlesource.com/720737 Commit-Queue: Owen Lin <owenlin@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#512450}
-
Yoshifumi Inoue authored
This patch introduces |RepeatString()| to make a string with repeated string, e.g. RepeatString(3, "abc") returns "abcabcabc". This patch is a preparation of the patch[1]. [1] http://crrev.com/c/741303 Move text-security CSS property handling to TextIterator Bug: 778507 Change-Id: I6324914fe228252ad611005be8b413b635edaa11 Reviewed-on: https://chromium-review.googlesource.com/741210Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#512449}
-
Darren Shen authored
This patch adds the new CSSMathValue subclasses CSSMathNegate and CSSMathInvert. Note that we only implement the constructor and attributes. More complicated things like typing or arithmetic will be done in a later patch. Spec: https://drafts.css-houdini.org/css-typed-om-1/#complex-numeric Bug: 776173 Change-Id: I7183df9c269db6eb799f93d39c0d8b1e541f7991 Reviewed-on: https://chromium-review.googlesource.com/743201 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#512448}
-
Hidehiko Abe authored
Along with the change, now PowerManagerClient starts to report error to its callers, instead of ignoring errors. Instead, callers starts to handle errors. BUG=739622 TEST=Build/Ran bots. Change-Id: Ib59431b1ca2136b10f06382f97801fe7cba33e5d Reviewed-on: https://chromium-review.googlesource.com/735281Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512447}
-
Siddhartha authored
debug: :StackTrace is used in line 664. Change-Id: If061f891d3ef4454aad07fc3135d93830ee781db Reviewed-on: https://chromium-review.googlesource.com/740261 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#512446}
-
Owen Lin authored
BUG=755889 TEST=None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib5a80303c67429b9cc7d69d7e8fd917bc775a903 Reviewed-on: https://chromium-review.googlesource.com/720736 Commit-Queue: Owen Lin <owenlin@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512445}
-
Hidehiko Abe authored
BUG=739622 TEST=Build. Change-Id: Ia4de1be02605f55ab9de874ce438092173139015 Reviewed-on: https://chromium-review.googlesource.com/737671Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512444}
-
Eddy Mead authored
I think this should fix the non-deterministic build issues Bug: 779001,779033 Change-Id: I0779b54d38a3fc8db2c71206fdafbcd2dc428dac Reviewed-on: https://chromium-review.googlesource.com/743163 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#512443}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9048063d. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/4246 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=qyearsley@chromium.org No-Export: true Change-Id: If98d89964f87dbbb80b2ad09b64cab3cd620586d Reviewed-on: https://chromium-review.googlesource.com/742528 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512442}
-
Yoshifumi Inoue authored
This patch introduces |EmitsSmallXForTextSecurity| behavior to |TextIteratorBehavior| to get "x" characters for |Text| node having CSS property "-webkit-text-security" other than "none" from |TextIterator|. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/741303 Move text-security CSS property handling to TextIterator Bug: 778507 Change-Id: I1a7699bf5806d3746ed0917879d7a8ee4f7b41dc Reviewed-on: https://chromium-review.googlesource.com/740926Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#512441}
-
Darren Shen authored
Currently, when given a list value, CSSStyleValue.parse returns null, but the spec says to take the first entry: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse Bug: 779422 Change-Id: I9f80d1876b9390f1d2684c271d3db3ef4192ddd3 Reviewed-on: https://chromium-review.googlesource.com/743101Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#512440}
-
shinyak authored
We'd like to have a goma canary builder which always use cl.exe. I'll convrt CrWin7Goma(clbr) to CrWinClexeGoma. Let me add mb config for CrWinClexeGoma first. It is the same as CrWin7Goma(clbr) + no_clang. Bug: 777705 Change-Id: I4584c92597765f72b2d8681568c7f3aaa37c217b Reviewed-on: https://chromium-review.googlesource.com/734342Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#512439}
-
Darren Shen authored
Currently we return null when calling CSSStyleValue.parse with an invalid cssText. The spec says to throw a SyntaxError: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse Bug: 775806 Change-Id: Iab99af48ce162fa1810ac678e63475e1660d9d95 Reviewed-on: https://chromium-review.googlesource.com/743082Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#512438}
-
Yoichi Osato authored
It just calls SelectionTemplate<Strategy>::ShowTreeForThis(). Bug: Change-Id: I46190e5a51cfc77c101ac255c9606d165552746d Reviewed-on: https://chromium-review.googlesource.com/741284 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#512437}
-
Christopher Lam authored
This CL adds a HostedAppButtonContainer which currently houses a menu button which launches the app menu. This menu will later be tailored to hosted apps and the container will also show content setting indicators. Bug: 762401 Change-Id: I2cde2d0208e7afefd0508ffdf1ab8261f82c1f17 Reviewed-on: https://chromium-review.googlesource.com/701857 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#512436}
-
Zhenyao Mo authored
Otherwise event observer like SystemInfoHandler could be stuck and time out. BUG=778680,744658 TEST=bots, perf tests TBR=piman@chromium.org,kbr@chromium.org,nednguyen@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I35dbc51f83ff1f1592e46152ec4a5c47f8b4376a Reviewed-on: https://chromium-review.googlesource.com/743041 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#512435}
-
Raymes Khoury authored
Currently we check the feature policy for midi in the PermissionService. This means that we can't easily return a specific error message for denial due to FP. Also, several permission features do not use the PermissionService codepath and need to be checked individually anyway, so it seems more appropriate to do this for all permissions. This CL adds these checks to NavigatorWebMIDI.cpp. It also logs a console warning when the feature is disabled to help inform developers. Furthermore, a UseCounter counts how many times the feature has been blocked due to Feature Policy. This CL was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/739882 because it broke layout tests on the site isolation bots. This issue has been worked around, see crbug.com/779433. Bug: 689802 Change-Id: I3ce66d6dc7dec644d8c11f23001ca73558970bf0 Tbr: timloh@chromium.org, toyoshim@chromium.org Reviewed-on: https://chromium-review.googlesource.com/743142Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#512434}
-
junweifu authored
Load com base functions dynamically at runtime with core_winrt_util. Request face detection failed if it's not supported. Add unittest and make sure work in win10 bots with using win10_chromium_x64_rel_ng in PRESUBMIT.py . Link Face Detection demo[2] here. Split original large CL[1] up in smaller subpatches including this CL. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 [2] https://codepen.io/miguelao/pen/PmJWro BUG=767021 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ice003ac398379b60e0668c14a7cec75195be0441 Reviewed-on: https://chromium-review.googlesource.com/724745 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512433}
-
Bugs Nash authored
Since methods change between header files, blank lines between methods were adding excessive whitespace. Diff of generated files: https://gist.github.com/BugsNash/132e77773a10adc029123fa39b630e1a/revisions NB generated diff for ComputedStyleBase.cpp should be ignored, these are not due to this patch but are the result of a non deterministic bug Bug: 545324 Change-Id: Icc402d76690ea0c4ac5a424e2beb8f017df884f5 Reviewed-on: https://chromium-review.googlesource.com/743161Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#512432}
-
John Z Wu authored
Nothing will be compiled yet. Bug: 763797 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2fd69181b3bbb36bcb913dd540bcc9e8ef37454d Reviewed-on: https://chromium-review.googlesource.com/741091Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#512431}
-
Darren Shen authored
CSSParserObserverWrapper was used as an interface between CSSParserObserver and CSSParserTokenRanges for inspector parsing. Since we no longer use CSSParserTokenRanges for inspector parsing, we can delete this class and use CSSParserObserver directly. Bug: 661854 Change-Id: I099e2db34437ce666274508396f1e6eb9915382c Reviewed-on: https://chromium-review.googlesource.com/688974 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#512430}
-