- 12 Nov, 2020 40 commits
-
-
John Delaney authored
What: Adds some early exit/flow control logic in the backing filter function which prevents doing registerable domain lookups when they are not necessary. Why: Currently these lookups are performed for every origin, even if there are no registerable domains to compare against, and if it is already matching an origin rule. These lookups are somewhat expensive and require several string operations. Change-Id: I79e2af8baf9c884b7de7811080e970bcc364d274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521101 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#826799}
-
David Dorwin authored
Although PolicyBlocklistNavigationThrottle uses Safe Sites, blocklists and Safe Sites are conceptually different. Also, Safe Sites does not require Prefs, which makes it easier to use outside //chrome. Also extract SafeSearchService from PolicyBlocklistService. Bug: 1147231 Change-Id: I4e2714478177bebcf26a07ed0e6230aa67e0792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530145 Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826798}
-
Eugene But authored
Add BreakpadServerParameterPrefix_ prefix to the key Bug: 1103752 Change-Id: Ieb4b33d600a57571fb0bbf87326d8c60cc18b800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533841 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826797}
-
Mark Mentovai authored
In order to avoid a delay (15 seconds is typical) the first time the Widevine CDM is loaded, ask Rosetta to translate the Widevine CDM and other required modules when Widevine is first registered. This happens at browser launch, and probably also when Widevine is component-updated. Bug: 1142017, 1145672, 1145792 Change-Id: If5e52f7e08e987dc5da57dd0b1476d25a467b152 CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533506 Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826796}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Id3b5163a21a8896bb80de37999a5d8a33f4c164b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533408 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826795}
-
rajendrant authored
Robots rules should consider the path and query parameters of the URL to decide whether the URL is allowed. Bug: 1144836 Change-Id: I15caeedfdc498cb361491ba66fe12956065daf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533418 Auto-Submit: rajendrant <rajendrant@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#826794}
-
Bartek Nowierski authored
As of crrev.com/c/2522934, |commit| is equivalent to |accessibility!=PageInaccessible|. Change-Id: Ia6b665017f4c06240922d1aa1a5764caf4b40c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522933 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#826793}
-
Gayane Petrosyan authored
Bug: None Change-Id: I07f79c46658bb206a084a21a09e7b2c1b9308a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532724Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#826792}
-
Sami Kyostila authored
Replace the explicit memcpy loops for converting between Skia and Java bitmaps with SkBitmap::{read,write}Pixels. We also adjust some fields of JavaBitmap to make their data types more obvious. Bug: 1144462 Change-Id: Ibc07ec546b38cb5650dc9a1e272e834b3579216a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532250 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#826791}
-
Nico Weber authored
This is a reland of ca288e0c chrome/browser/component_updater/widevine_cdm_component_installer.cc is only built if ENABLE_WIDEVINE_CDM_COMPONENT is set, so we should reference functions therein in that case. Fixes the unbranded arm build. The reland is exactly the same as the original change for branded builds. Original change's description: > Offer to install Rosetta for Widevine if it's not already installed > > If a page wants a CDM and it's unavailable, show an infobar. If > the user agrees, install Rosetta for them. > > Bug: 1145792, 1142017 > Change-Id: I92f030c2dbb5d9b092b84252fddee6f7ad55a436 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527771 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826636} TBR=xhwang Bug: 1145792 Bug: 1142017 Cq-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: I73404d403df152ef8d5738368e094c24ae250128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534392Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826790}
-
Nazerke authored
This CL adds webStateObservers into the TabStripMediator to update tabs titles in the TabStripViewController. Bug: 1136834,1128249 Change-Id: I7fa4c9a73a35a719dcbbf7d26278a497e9d16cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521186 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#826789}
-
Alexander Dunaev authored
Bug: 1109112 Change-Id: Iceda57cc2e066dbc1c7c6cb9a0957854a1173547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530995 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
-
Chris Sharp authored
Updated the following policies: BackForwardCacheEnabled BrowserNetworkTimeQueriesEnabled CloudPrintWarningsSuppressed CommandLineFlagSecurityWarningsEnabled ContextualSearchEnabled Bug: 1139306 Change-Id: I1448966a521c38d64b27d7cca05cc52f7e8964b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522170 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826787}
-
Mark Mentovai authored
Bug: 1142017 Change-Id: If168a204fe418043292952aa1d3edbf257f53c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533587 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826786}
-
Chris Sharp authored
Updated the following policies: AbusiveExperienceInterventionEnforce AccessibilityImageLabelsEnabled AllowFileSelectionDialogs AllowScreenWakeLocks AllowWakeLocks Bug: 1139306 Change-Id: If656ba0095e11a54cb94997d8d1f751792a10e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521491 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#826785}
-
Bartek Nowierski authored
If GigaCage is disabled, PartitionAllocGetSlotOffset() triggers a DCHECK which checks if the pointer is in the GigaCage's normal bucket pool. Change-Id: I9ea2683944ee308b9055a2c182e7bb5387c5fc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534992 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#826784}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a2ac3a70. With Chromium commits locally applied on WPT: 50d5488e "Revert "webauthn: move create credential tests for residentKey/credProps to WPT"" c0e73fce "[webcodecs] Make sure callbacks aren't called after encoder.reset()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I3600388ccad0872bd368e55697cbf9deb3343fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534710Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826783}
-
Antonio Sartori authored
The content::PolicyContainerHost is a class containing some policy data and implementing a mojo interface to change that data. As we add more policies to the PolicyContainerHost, it becomes cleaner to separate the raw data (the policies) into a separate struct (DocumentPolicies), which the PolicyContainerHost owns. This will also make it easier to store the DocumentPolicies in places where we don't need the mojo logic (for example, in the FrameNavigationEntry). Bug: 1130587 Change-Id: Ic46a3189f9f6939fbdb279916a9c1288942ce271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529165 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826782}
-
Liquan (Max) Gu authored
PRService#updateWith() lets mSpec parse and save the updated details. Now that the details have been saved to mSpec, we should use mSpec's details instead using the original details. This would make the code more logical and less error-prone as we use mSpec's details as the single source of truth. Bug: 1131059 Change-Id: Ib36e9a67880097ea6be14a2148b57b59b6c6bdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533144 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826781}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53d3c085a784..4fb2d48fe563 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic866784dec4ae1fde6827032841608ee58d170a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826780}
-
Benoit Lize authored
TLS access on Windows sets the last error, even in case of success. This is causing issues with calling code which expects malloc() to not change the last error. Work around it by saving the last error. Issue found by tasak@. Bug: 998048 Change-Id: I64fa7dc44abfae39d3d91d9d8e6dbb9e2721d136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529150 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85179e8d9484..8e6646c31e9d 2020-11-12 jec@google.com [devtools] Fix typo in release notes 2020-11-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5e2b755fcb2321e9a8354b66f9508188674d3fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534795Reviewed-by:
-
Christoph Schwering authored
Autofill uses lots of hard-coded regexps for parsing. PatternProvider provides a cleaner API with page-language-dependent patterns. This CL migrates the existing parsing code to the new pattern provider in an equivalence-preserving way. The behaviour is only enabled if either of the following features is enabled: * kAutofillUsePageLanguageToSelectFieldParsingPatterns * kAutofillApplyNegativePatternsForFieldTypeDetectionHeuristics The code is not entirely ready for use because of an infrastructure issue: all relevant tests must mock a PatternProvider that synchronously loads the JSON. Otherwise they're prone to race conditions. In a follow-up CL we'll solve this issue. Change-Id: I235d2b599585522e1a1bea1cd25185ae209f5965 Bug: 1147624, 1147608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465847Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#826777}
-
Maksim Moskvitin authored
Bug: 1138388 Change-Id: I49409684460a7890b8f82547d1b887c76e676ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532077 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
edchin authored
Design doc: go/bling-phishguard This CL compiles these files in iOS: password_reuse_detection_manager.h/cc password_reuse_detector.h/cc password_reuse_detector_consumer.h/cc password_store_signin_notifier.h/cc password_reuse_detector_unittest.cc password_reuse_detection_manager_unittest.cc This CL constitutes the minimum changes necessary to compile the above files, and successfully pass the unittests. There should be no runtime changes in iOS or other platforms in this CL. Bug: 1147962 Change-Id: I2eda6d2032dbcd6c80f9516aa19216e1a9da7ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533401Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826775}
-
Clemens Arbesser authored
This CL ensures that legacy lite scripts will continue to work and send the correct metrics values. This is in case we have to deactivate the new trigger scripts. Once the new trigger scripts are deemed stable, we can remove those metrics and special handling. Bug: b/171776026 Change-Id: If8f4fd56517b01f1aef7e908a096cf49788c208b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532225 Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#826774}
-
Tanmoy Mollik authored
Batch tests in BookmarkEditTest to reduce runtime of chrome_public_test_apk. Bug: 1145843 Change-Id: I51db09cba8262f92476caa4aabb7693947ab9d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523328Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826773}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=andypaicu@chromium.org Bug: 1145565 Change-Id: I9075e3c8594c64f0a4a4d2b5e5320e1d21308e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533135 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826772}
-
Tomasz Konieczny authored
Timestamps for corresponding OS and chrome dumps need to be equal so that they can be matched afterwards. Bug: 1144103 Change-Id: Ib4d4375563b6ac6f983773bc85416c597186f1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521152Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#826771}
-
Robbie Gibson authored
Before, |fractionVisibleOfLastItem| was only updated on scroll, so the plus button only appeared/was hidden on scroll. It should also be updated when tabs are added or removed. Bug: 1094335 Change-Id: I2e187c8b41ba69b3cb1e3a1d0b4158a82e43809c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529112 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826770}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605139151-e048243497dbd74335652a6b91001809f760c8c3.profdata to chrome-linux-master-1605182400-0a4bd93b21630824fe02bcc8b97bd908ea587b84.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I27718ad5a2206c4a6640e94ac3242ed209e17ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534793Reviewed-by:
-
Illia Klimov authored
As part of the Flash/Plugins deprecation, the PLUGINS_DATA becomes obsolete. This CL removes ContentSettingsType::PLUGINS_DATA. Bug: 1135846 Change-Id: I907f3123c6146c3432de7f39de35d2175e2a021c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532303 Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=tangltom@chromium.org Bug: 1145565 Change-Id: Ic7a1ab744690cf6d3ab830baf4b2f2a9474bb8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532661 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#826767}
-
Friedrich Horschig authored
Instead of using sizes relative to font sizes, use a static icon size of 32x32 (outer box of the halo). A static size is used for other icons as well (most notably the favicons) and isn't subject to rounding errors which cause "misalignments" by single pixels. This also ensures that the spinner isn't distorted for reasonable font sizes (for font sizes > 34, the entire layout is falling apart, so it's not worth to even think about the slightly distorted spinner). All default font sizes (Very Small to Very Large) and custom font sizes with minimum font sizes aren't affected in any case anymore. Screenshots in the first linked bug. Bug: 1144629, 1145943, 1145931 Change-Id: I1a4222b92bd3a42615c36a01f1e3ad0cc5feadc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532584Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#826766}
-
Leo Lai authored
crypthome used to do the job but attestaion only judges the EMK/EUK type with emptiness of account id, so we have to filter out the account id for EMK. BUG=b:173060033 TEST=unit_tests and check if the following 3 cases are tested: KEY_DEVICE with non-empty account id, KEY_DEVICE w/ empty account id, and KEY_USER w/ account id. Change-Id: I273e8e53304ee4a9a2740f12135a00c02eae6c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531807Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=jdonnelly@chromium.org Bug: 1145565 Change-Id: Id17e64fb0132a99c583e2670c5cd84fb2f34bc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533154 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826764}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=kmilka@chromium.org Bug: 1145565 Change-Id: Ib3a00c095ae3210e9ca78c073685b48863388d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532659 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826763}
-
Yann Dago authored
Bug: 1129065 Change-Id: Id6bfec1b133937037ba8fe4bb32d469af5a27b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521096Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#826762}
-
rbpotter authored
Privet printing is deprecated. Move it behind a flag that is disabled by default. Remove warnings that refer to December 2020, as all cloud and privet printing is now either removed or disabled by default, and M88 will be released in 2021. TBR=thestig@chromium.org Bug: 1112576 Change-Id: If86cdea73382bff36ed9a425fdf65d642f4a0907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528935 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#826761}
-
Nazerke authored
This CL updates the favicon image in the tabstrip cell by pushing the data from Mediator to the UI via tabFaviconDataSource by the model items for the cell - GridItems (re-used from TabGrid). Bug: 1136834,1128249 Change-Id: I5008df41819b7770e05d933145d26e7f40d8369b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513213 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
-
