- 30 Jul, 2018 28 commits
-
-
Giovanni Ortuño Urquidi authored
WebApplicationInfo is not moveable so wwhen calling std::move() on it, we make a copy. To avoid this, wrap WebApplicationInfo in a unique_ptr. Bug: 864904 Change-Id: I3568101b8ee209786b18127e515b694729aa2ed2 Reviewed-on: https://chromium-review.googlesource.com/1154733Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#578983}
-
Alexey Baskakov authored
Bug: 860581 Change-Id: Ice0a693c6a8a4a247d9cd191967e0f88af2d4bf4 Reviewed-on: https://chromium-review.googlesource.com/1154735Reviewed-by:
-
Keiichi Watanabe authored
This patch makes Chrome work before/after https://crrev.com/c/1134934 (for chromiumos-overlay), https://crrev.com/c/1136336 (for v3.14) and http://crrev.com/c/1134929 (for v4.4) are merged, which change ChromeOS-specific controls' IDs to avoid cofliction with upstream. By calling QUERY_CTRL for new IDs, Chrome can detect whether the CLs are already merged at run-time. If they are not merged yet, Chrome will use old control IDs instead. This patch is needed because we cannot land the kernel change at the same time as new Chrome build. After new ChromeOS build contains these CLs, this patch should be reverted. Bug: 819930 Test: Play VP8/VP9 video on veyron_jerry w/o CL:1134934 and CL:1136336 Test: Play VP8/VP9 video on veyron_jerry w/ CL:1134934 and CL:1136336 Test: Play VP8/VP9 video on kevin w/o CL:1134934 and CL:1134929 Test: Play VP8/VP9 video on kevin w/ CL:1134934 and CL:1134929 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I293464d85c4ca28fd3413b89e77e242c0a7648c0 Reviewed-on: https://chromium-review.googlesource.com/1134933 Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#578981}
-
Koji Ishii authored
This patch uses UniteIfNotZero, which incorporates rects if either width *or* height is not zero, to compute LinesBoundingBox for LayoutInline and LayoutText. Using regular Unite, which incorporates rects if width *and* height are not zero, ignores zero-width rects such as empty inline or <br>. The name and logic are ported from LayoutRect to NGPhysicalOffsetRect. This patch fixes two tests, but also require ~300 text rebaselines because heights of such LayoutInline, LayoutText, and their subclasses (such as <br>) are changed. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6488c074dedad71ae5f46fb366ee4a2b9d3cdca5 Reviewed-on: https://chromium-review.googlesource.com/1154240Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578980}
-
Darren Shen authored
In a previous patch, we removed shadows for both docked and floating keyboard so that IME can draw them. Unfortunately, this means that KeyboardController no longer knows which area of the keyboard is the shadow and which is the actual UI, which breaks things like overscrolling. A fix would be to make IME indicate what the actual occluded bounds are through setOccludedBounds. Unfortunately, setOccludedBounds has several problems (e.g. what happens when occluded bounds and visual bounds go out of sync, e.g. when the screen is rotating). This requires some additional thought. So in the meantime, we just draw shadows only for docked mode. This will at least unblock the new UI while we find a permanent solution. Bug: 867775 Change-Id: Iebd8f5edfeac5643fe837b672bf65dab5bfcdb4d Reviewed-on: https://chromium-review.googlesource.com/1152328 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#578979}
-
Kenichi Ishibashi authored
Looks like this test doesn't exist. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I858e13708663f143b56e390af91702d2d3b71492 Reviewed-on: https://chromium-review.googlesource.com/1154610Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578978}
-
Kenichi Ishibashi authored
Update tests for ServiceWorkerControlleeRequestHandler to have better coverage with S13nServiceWorker enabled/disabled. Bug: 860361 Change-Id: Ie4b915fd2aea96afc9880c759d4bcdb82d320892 Reviewed-on: https://chromium-review.googlesource.com/1151070 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Nicholas Verne authored
If Crostini is disabled by policy, IsCrostiniEnabled will now return false. Bug: None Change-Id: I4eb93223c7b3f65280e171f04895a8942186af51 Reviewed-on: https://chromium-review.googlesource.com/1152641Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578976}
-
Timothy Loh authored
This CL adds some tests for the linux package install flow in the File Manager. It also fixes a bug in the CrostiniManager where package progress observers were not correctly removed, as discovered by these tests. Bug: 868221 Change-Id: I2b6adf2530ff43a0b22fe2b552bb877f98fd61c7 Reviewed-on: https://chromium-review.googlesource.com/1152643Reviewed-by:
-
Han Leon authored
This CL is the 1st step of the plan below aiming to eliminate the native struct content::ServiceWorkerResponse defined in content/common/service_worker/service_worker_types.h. 1st step: - Remove the typemapping of blink.mojom.FetchAPIResponse. The mojom struct blink.mojom.FetchAPIResponse describes a Response in terms of the concept from the Fetch spec, currently it's defined under blink/public/platform/modules/fetch/ and is used only by Cache Storage API implementation (by both Browser and Renderer code), as this struct meets the 2 conditions below, it should be fine to go into blink/public/mojom/: - it is expected to be used by both Browser and Renderer code. - it is expected to be passed over Mojo between Browser and Renderer (Blink). But, currently for Chromium Mojo binding variant it is typemapped to content::ServiceWorkerResponse being used in content/browser/cache_storage/, this blocks it being moved to blink/public/mojom/. So we need to remove this typemapping first, this removal also helps reduce 1 user of content::ServiceWorkerResponse. 2nd step: Now we can just move blink.mojom.FetchAPIResponse into blink/public/mojom/fetch/, which makes the next steps possible. 3rd step: - Use blink.mojom.FetchAPIResponse to represent the response a service worker provides to FetchEvent#respondWith. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse in content/common/service_worker/service_worker_fetch_response_callback.mojom. Thus we can reduce another 1 user of content::ServiceWorkerResponse. More importantly, this makes it possible for us to move service_worker_fetch_response_callback.mojom into blink/public/mojom/service_worker/ in future. 4th step: - Use blink.mojom.FetchAPIResponse to represent responses to background fetches. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse defined in content/common/service_worker/service_worker.mojom. Thus we can reduce the last 1 user of content::ServiceWorkerResponse. 5th step: - Remove content::ServiceWorkerResponse and do any left cleanup. BUG=789854 Change-Id: Ibae19bcac50688360426ef8b736a3841ca59ff39 Reviewed-on: https://chromium-review.googlesource.com/1134731Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#578974}
-
Joel Hockey authored
Change-Id: I496c4bd6f0c6cf87dee2a8af7e473160098fa082 Reviewed-on: https://chromium-review.googlesource.com/1154616Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#578973}
-
Tetsui Ohkubo authored
Some feature pod buttons have same action for both the icon and the label. In such case, the label button should not be included in keybaord focus chain. TEST=manual BUG=none Change-Id: I1e2c87c5bfdc18ce4ca233807e94053313e9830d Reviewed-on: https://chromium-review.googlesource.com/1152716Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#578972}
-
Makoto Shimazu authored
This CL adds MimeSniffingThrottle which can intercept the response in ThrottlingURLLoader. Typically mime sniffing happens in network::URLLoader and MimeSniffingThrottle is skipped in this case. If a request goes to a service worker or other interceptors, the MimeSniffngThrottle intercepts the response when a set of the mime type and the url is eligible to sniff the mime type. Sniffable mime types are defined in net::ShouldSniffMimeType(). When a mime type for performance sensitive components like "text/html", "text/javascript",or "text/css" is provided, it doesn't sniff. Bug: 858975 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib6e5b29867494fc0c0876952b4fec2a141288b36 Reviewed-on: https://chromium-review.googlesource.com/1141744Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I89871b65dbe2f2b5202a079f4c4e54c637cf672f Reviewed-on: https://chromium-review.googlesource.com/1154688Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#578970}
-
Jiajia Qin authored
Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib373b6797b780c0294fef471fae7bb7a9deac39a Reviewed-on: https://chromium-review.googlesource.com/1149711Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#578969}
-
Tetsui Ohkubo authored
This CL adds dedicated tooltip strings to feature pod buttons in UnifiedSystemTray. As a feature pod button has two click targets, we have two tooltip strings per each. These strings are approved by UX: http://shortn/_HCw1PLpXw1 TEST=manual BUG=none Change-Id: I76a527d5bbdbe06a8365607e1aa304af50b03c37 Reviewed-on: https://chromium-review.googlesource.com/1152747Reviewed-by:
-
Yuki Awano authored
Bug: None Test: None Change-Id: Ie1241763c6984de48ebaa9d99807489a3e31616e Reviewed-on: https://chromium-review.googlesource.com/1149425 Commit-Queue: Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578967}
-
Makoto Shimazu authored
The service worker has a simple fetch handler which returns a response fetched from the service worker. Bug: 853085 Change-Id: I605a495da3657017e0c43cef63499a523b225f69 Reviewed-on: https://chromium-review.googlesource.com/1152757Reviewed-by:
-
Alan Cutter authored
This CL forces Windows 7 to use the OpaqueBrowserFrameView (instead of GlassBrowserFrameView) for hosted app windows. This is in preparation to consistently support extra hosted app controls in the title bar before we have implemented support for Aero glass titlebars. This change is hidden behind the DesktopPWAWindowing flag. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350562&signed_aid=YMSTIPY7Xl2vwJUHiVXzPw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350563&signed_aid=XwsCSHyIFeGdrm_6R_PkVQ==&inline=1 Bug: 854479 Change-Id: I3232648004ff7b32657afa127fe76924aa4f2950 Reviewed-on: https://chromium-review.googlesource.com/1152722Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#578965}
-
Kenichi Ishibashi authored
These tests are timing out only on msan bots. Move these entries to MSANExpectations so that we can make sure these tests pass on linux bots. Bug: 866965, 856601 Change-Id: I48d15a00a508c989865ebba2fa88987ddcd46c80 Reviewed-on: https://chromium-review.googlesource.com/1154609Reviewed-by:
-
Kenichi Ishibashi authored
When S13nServiceWorker is enabled but NetworkService is disabled, NavigationURLLoaderImpl actually uses URLRequest when a navigation is not intercepted. In that case we have a NavigationData and we can populate it to NavigationHandle. Since some features like Previews use NavigationData to store their data, it would be better to populate it if possible. This fixes following browser_tests: - PreviewsNoScriptBrowserTest.NoScriptPreviewsEnabled - PreviewsNoScriptBrowserTest.NoScriptPreviewsEnabledHttpRedirectToHttps Bug: 866367 Change-Id: Idc85d272772be81dddde9e9e0bdf76f4fadfef8a Reviewed-on: https://chromium-review.googlesource.com/1148094Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Tatsuhisa Yamaguchi authored
Test: manual Bug: 863518,845805 Change-Id: Icb3e74c4ff86e8914d1e4cc43f34552e8647c252 Reviewed-on: https://chromium-review.googlesource.com/1139937Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
Alt-Shift-N was disabled for UnifiedSystemTray. Because we have Alt-Shift-S. https://crrev.com/c/1023500 In response to feedback, the expected behavior of Alt-Shift-N is changed, and now it does the same action as Alt-Shift-S. TEST=manual BUG=none Change-Id: I8314e8205512d70c095b7ca45839f386e7a8fea7 Reviewed-on: https://chromium-review.googlesource.com/1147780Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#578961}
-
Matt Giuca authored
Previously, all percent-encoded sequences in a search engine URL (i.e., containing a "%s") would be decoded, in some cases erroneously changing the meaning of the URL or resulting in an invalid URL. This is fixed by removing the use of URL decoding, and instead directly replacing "%25s" with "%s". There is still one broken case: if the source URL literally contains "%25s" (representing a literal percentage symbol followed by an s), this will erroneously be treated as a query substitution. (This is not a regression; it was always the case.) Fixing this particular issue requires a major refactor. Added proper test cases for this function. Bug: 868214 Change-Id: I88971dc170fdc45db6633ad61b64859a19268751 Reviewed-on: https://chromium-review.googlesource.com/1152723Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#578960}
-
Kenichi Ishibashi authored
Change-Id: I67f20508138ef4690d3b1cb6744f23366b184767 Reviewed-on: https://chromium-review.googlesource.com/1152713Reviewed-by:
-
Takuto Ikuta authored
This is for more than 30 mins compile steps like below builds. 2254s https://ci.chromium.org/b/8939878092028048128 2251s https://ci.chromium.org/b/8939877984227459216 2131s https://ci.chromium.org/b/8939881577503817376 1987s https://ci.chromium.org/b/8939876145878190960 Bug: 804251 Change-Id: I7d98659f30ab009b89b0b95f86079e296dc408fc Reviewed-on: https://chromium-review.googlesource.com/1152719Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#578958}
-
kristipark authored
Bug: 851656 Change-Id: Id9927c2343c6fbdaccdcd385b1b9a50e0176d32c Reviewed-on: https://chromium-review.googlesource.com/1152519 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578957}
-
Kyle Milka authored
If the attribution link is not https or is empty the action_url in theme info should be reset. Otherwise its possible for an old action url to be displayed for a new custom background image. Bug: 868164 Change-Id: I00ca396b665c169410c33730f16c3054ec761c26 Reviewed-on: https://chromium-review.googlesource.com/1152516 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
- 29 Jul, 2018 12 commits
-
-
John Budorick authored
This CL: - groups layout tests by argument sets to reduce the number of driver restarts required when running tests w/ shards that include multiple argument sets. - updates chunking logic to match that used by //base/test/launcher, which should ensure consistent chunking across all swarming shards and ensure stable chunking given consistent chunk parameters. - fixes a small bug in http server execution and teardown. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1120431 Bug: 824539 Change-Id: Ic1a2ab34f38e8d4c15784977de792314d106e484 Reviewed-on: https://chromium-review.googlesource.com/1149418 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#578955}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I4f9fefc477806fff7cb71fd14d59354fb72cb79f Reviewed-on: https://chromium-review.googlesource.com/1154498Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578954}
-
Reid Kleckner authored
This should give us better Pacific time coverage for update.py and package.py changes. R=thakis@chromium.org,hans@chromium.org Change-Id: I713033f33f755fce6b4c8e5aa4387cf2d4b3a245 Reviewed-on: https://chromium-review.googlesource.com/1154043Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#578953}
-
https://crrev.com/574738Christopher Cameron authored
TBR=lgrey Bug: 863817 Change-Id: I64bb71603eb5fba012d17c953e61481c7ee5182b Reviewed-on: https://chromium-review.googlesource.com/1154357Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#578952}
-
Koji Ishii authored
Following bot results are included. 8394 8396 8403 8406 8409 8417 8427 8441 8442 8444 8447 8448 11 lines were removed and 3 lines were deflaked by consecutive results since 8394. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icbab9e03eedf3d624e84b2c704c8a952fd6e05ce Reviewed-on: https://chromium-review.googlesource.com/1152708 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578951}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd0e9db48d2e..823c88d37b4d git log dd0e9db48d2e..823c88d37b4d --date=short --no-merges --format='%ad %ae %s' 2018-07-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@823c88d37b4d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I0362fcd9f4edd1017ea93ba2ec8c9ac911d1b75c Reviewed-on: https://chromium-review.googlesource.com/1154177Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578950}
-
Koji Ishii authored
From a review of build 8447. * css-grid/* are still failures, but turns one of failures into pass, and two failures fail with different values. Rebaseline because wpt wants failures built into expected, and the diff is pure improvements. * fast/parser/entities-in-* are different output of text dump for soft-hyphens. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I35c42c7ec8b7580597f1c3addb8fff95217afb3c Reviewed-on: https://chromium-review.googlesource.com/1154239 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I45de9bb3d758307b16787c6b9d8b35bf9ef62e7d Reviewed-on: https://chromium-review.googlesource.com/1154437 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578948}
-
Peter Boström authored
The current 18dp fixed height results in pushing the total button height on Mac. This doesn't happen by default on Windows as the default font results in equal size_delta values for 18dp and 17dp available height. This probably means that 17dp is the actual available height that doesn't increase the toolbar-button height. Bug: chromium:862514, chromium:868442 Change-Id: I7c07eb987cb5e4f7a0f200dcbe77b2ac72a751f3 Reviewed-on: https://chromium-review.googlesource.com/1153574Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ib9e20055672b7c44bef0ba00106dd3b7017c49cd Reviewed-on: https://chromium-review.googlesource.com/1154352Reviewed-by:
-
Victor Costan authored
This CL uses the passkey idiom recommended in https://abseil.io/tips/134 to restrict APIs in sql::Connection to sql::Recovery. Test APIs are exposed via a peer class, following recommendations in the same tip. This CL also exposes sql::Connection::page_size(). Asides from being used in sql::Recovery, this can be useful in unit tests. It is worth noting that set_page_size() is a widely-used part of the sql::Connection API, so page_size() does not introduce a new concept. Last, in order to make page_size() intuitive, this CL removes the possibility of having sql::Connection::page_size_ be zero. Instead, SQLite is configured with an explicit SQLITE_DEFAULT_PAGE_SIZE (matching the current default), and page_size_ is initialized with sql::Connection::kDefaultPageSize, which is guaranteed to match the SQLite configuration. Bug: none Change-Id: I555a0bcf02f12ee006bbfc1a91080d7c0b8845d4 Reviewed-on: https://chromium-review.googlesource.com/1146768 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#578945}
-
Nigel Tao authored
These are the Web App analogs of external extensions, described at https://developer.chrome.com/apps/external_extensions On start up, *.json files (often but not necessarily named external_extensions.json) are scanned in a number of directories. Prior to this CL, such .json files can install regular extensions (.crx files) or, on Chrome OS, Android apps. New in this CL is being able to install Web Apps (sometimes known as Progressive Web Apps or PWAs). For example, the chrome::DIR_USER_EXTERNAL_EXTENSIONS path (defined in chrome/common/chrome_paths.h) can correspond to file system directory like "$HOME/.config/chromium/test-user/.config/chromium/External Extensions". Placing a foo_bar.json file containing: { "web_app_manifest_url": "https://www.chromestatus.com/static/manifest.json", "web_app_start_url": "https://www.chromestatus.com/features" } in that directory will install the Chrome Platform Status web app. Bug: 855281 Change-Id: I716fead81d407076a0dda32f5c0b3e8869351c83 Reviewed-on: https://chromium-review.googlesource.com/1127214 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#578944}
-
