- 07 Nov, 2019 3 commits
-
-
Sophie Chang authored
This also leaves a ShouldTargetNavigationAndCanApplyOptimization that replaced the existing CanApplyOptimization that did both. This is required for supporting the dev incentives project since they do not have an optimization target. Bug: 969558 Change-Id: If30266c282519697c27bdb35e93d91ad370c70c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899087Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713236}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d87f9edb488..b4b80864f88f Created with: gclient setdep -r src-internal@b4b80864f88f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:922813,chromium:None Change-Id: I30b0ce12b7effb23cced55e19b00af036045b7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902129Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713235}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1171cdd4f791..ed392790fed1 git log 1171cdd4f791..ed392790fed1 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 treehugger-gerrit@google.com Merge "processor: Some more fixes for chromium json export" Created with: gclient setdep -r src/third_party/perfetto@ed392790fed1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: If2ac60b6aa82a8c529b68c6b68c7a8f47472a741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713234}
-
- 06 Nov, 2019 37 commits
-
-
tby authored
There is a bug in the provider for zero state Drive file results that means it returns results even when a search query is issued, messing up the results for a search. This is caused by the result cache being cleared at the wrong time. Bug: 1022150 Change-Id: Ic1382e37a7991284c492963c57681d63f2f02a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902167Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#713233}
-
Tommy Steimel authored
This CL adds media session metadata (title, artist, and album) to the Now Playing Info Center when available. Bug: 936513 Change-Id: Id95728fd4ad1a06b242f6596475315fa65ec913c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902509Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#713232}
-
Nasko Oskov authored
WebUI has moved to be a per-frame object, but the SetWebUIProperty method is still on the RenderViewHost object. This CL moves it to be per-frame, therefore on the RenderFrameHost object, but does not make it available to subframes. The goal is to be a purely code move CL. Bug: 763548, 1002276, 1019739 Change-Id: Ie857a253f750316fe090ac2daa6686376cdb1833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901587Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#713231}
-
Sarthak Shah authored
Currently, this feature flag exists in content. In master CL https://chromium-review.googlesource.com/c/chromium/src/+/1773872, this feature flag is utilized in CreateFromDefaultPlatformCurve to decide whether to use experimental fling curve or existing fling curve, which lives in ui. This CL moves the experimental fling animation flag from content to ui. Bug: 647137 Change-Id: Ia8051ec250ed6c8c8170d41eb3e52b2e32e9ffab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884515Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713230}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3dce06be0e24..714f8cc3ff4b git log 3dce06be0e24..714f8cc3ff4b --date=short --no-merges --format='%ad %ae %s' 2019-11-06 mtklein@google.com add vcmpps 2019-11-06 herb@google.com Improve the dynamic range of SkPackedGlyphID ctor 2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-06 mtklein@google.com unnest matrix multiply Created with: gclient setdep -r src/third_party/skia@714f8cc3ff4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I64caa48b6a8c90eddfd0221ef372fcce8a0c96f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902127Reviewed-by:
-
Mason Freed authored
This CL removes (except for the enum) the kEventPath RAPPOR metric, which was not being used. Bug: 1016906 Change-Id: Iaf10b47805a3054f39568d82a8720f52722d752f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896055Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#713228}
-
Robert Ma authored
TBR=smcgruer Bug: 1022141 Change-Id: I01cd99945a58e8f8cba5ae2bbbcf977ece7f4c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902510Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#713227}
-
Varun Khaneja authored
R=holte Bug: 963165 Change-Id: Iad7981b06d2541623bf58d0db98c314ed9f4ec30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898749 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713226}
-
John Lee authored
Bug: 992972 Change-Id: Ic5490f7444f7783c7874502ea0ce75cdb6ba7576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902237Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#713225}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/33cff37c6035..4dffa04d4f00 git log 33cff37c6035..4dffa04d4f00 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 mbonadei@webrtc.org Revert "Disable goma on GCC bots." 2019-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3cb32697..33f41173 (712927:713078) 2019-11-06 danilchap@webrtc.org Stop using and delete DEPRECATED_SingleThreadedTaskQueueForTesting 2019-11-06 alessiob@webrtc.org RNN VAD: FC layer with SSE2 impl Created with: gclient setdep -r src/third_party/webrtc@4dffa04d4f00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1021931,chromium:None Change-Id: I9b6579ba98806688b0ad7e73ab9c268c22a36743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902126Reviewed-by:
-
Michael Spang authored
Implementations of GetTransformedRootWindowBoundsInPixels() are currently applying the inverse of the desired transformation: the root window transform converts root window pixel coordinates to host pixel coordinates. This function needs to do the reverse: it takes host pixel coordinates, and returns root window pixel coordinates. The reason this was not causing bugs is that in production Chrome OS & Cast both override this function to throw out the origin of the returned rect. Setting the origin to zero after transforming corrects for applying the wrong transformation: the rest of the transformation is a 0, 90, 180, or 270 degree rotation. Since 0 and 180 degree rotations are self-inverses, and a 90 degree and a 270 degree rotation have identical effect on sizes, keeping only the size ensured correct results. Clean up this confusion by inverting the transformation applied by GetTransformedRootWindowBoundsInPixels(). This means that the origin of the transformed rect will automatically be correct (i.e., it will be zero), except during configuration (because bounds & transform aren't updated atomically). We still force the origin to zero to avoid any behavioral change from roundoff. There are some minor discrepancies related to that: - Chrome OS puts the window at origin, and rounds the size down - Cast puts the window at the origin, and rounds the size up - The default implementation allows arbitrary positioning, and takes an enclosing rect These discrepancies are unchanged in this patch. Bug: 1019015 Change-Id: I9bb40872be2fc76f04e63350a67965d44b71cc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885633Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Mason Freed authored
The prior test checked for deprecation messages, which is quite roundabout. This just feature-detects all three features. Change-Id: I7e034061b0c041b6341ec9eae9a5e3ab3b643c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900917 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713222}
-
Sam Goto authored
Design-Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit# Bug: 1015645 Change-Id: I81d0d8971b313bed6829614de431b2943173a0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895319 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#713221}
-
Mustaq Ahmed authored
Bug: 959850 Change-Id: I15d8d20a9fbb9e5670c49d7fb51b36f7d7d6cb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899198Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#713220}
-
Charlene Yan authored
editor bubble. This is a temporary entry point for feedback while dog-fooding the feature. Bug: 1019903, 1015634 Change-Id: Ic51f4d5c58d313a7c2fe0ab7b10687fcd54aaea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890993 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Steven Bennetts authored
This reverts commit 17342442. Reason for revert: This will cause problems on a device as locales/*.pak.gz will not get copied correctly. We need to update chromite first. Original change's description: > chrome_repack_locales: compress .pak files on Chrome OS > > For trivial change to resource_bundle.cc: > TBR=sky@chromium.org > > Bug: 1017864 > Change-Id: I2afbfa8e02f952d03b36112e0093af92753876ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883292 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713205} TBR=stevenjb@chromium.org,agrieve@chromium.org Change-Id: Ia72498979433c12facbb4a797582bd48d18ce83e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902168Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713218}
-
Luke Zielinski authored
Change-Id: I368ce92d78a771b1107e94963e7ed588fcb67ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900561 Commit-Queue: Luke Z <lpz@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#713217}
-
Mohammad Refaat authored
sameSitePolicy property was added to NSHTTPCookie with iOS 13, consider it when switching between canonical cookies and system cookies. Initially use CookieOption with access semantic Strict, but eventually download_session_cookie should update the semantic based on the origin of the request. This CL accommodates the changes that happened recently on the canonical cookie . So in iOS 12 we don't miss cross site non-secure cookies. and on the same time starting from iOS 13 check on same-site policy value and follow chromium rules in sending cookies across requests. Bug: 1018272, 1006785 Change-Id: I77213f528a9f533998e783db897a80a990bea87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890507Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#713216}
-
Frédéric Wang authored
This prepares implementation of the MathML Core specification: https://www.chromestatus.com/feature/5240822173794304 Minimal changes are applied to the build system in order to generate element classes for MathML elements, similarly to how it is currently done for HTML and SVG elements. A folder third_party/blink/renderer/core/mathml is created with the json files describing MathML attributes/elements as well as a simple implementation of a new MathMLElement class. For now, no new MathML attributes/elements are added and MathMLElement derives from Element without performing any implementation change. MathMLElement also contains standard helper functions in its header file. A new experimental feature MathMLCore is also introduced. When it is enabled, the document class will create MathMLElement instances for all MathML elements. When it is disabled, it will continue to just create Element instances. No new tests are added since there is no visible behavior change, independently of whether MathMLCore is enabled or not. Bug: 6606 Change-Id: I59c2ad8f70383716c5514f2ab3c818bdc11cb8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895661Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#713215}
-
Reilly Grant authored
The DeviceSensors.DeviceMotion and DeviceSensors.DeviceOrientation RAPPOR metrics can be replaced by the existing UKM-enabled Blink use counters for this feature. Bug: 1016906 Change-Id: I50cf7ac9ed26ac9b57f47cb8f74b74bb5f133612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898297 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Eric Seckler authored
To enable us to judge the impact of crbug.com/1019181. Bug: 1019181 Change-Id: Iff85c850d61f10f4b5dfbfb6d996a050e99fd806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901469 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Anupam Snigdha authored
Removed the WidgetHostMsg_FocusedNodeTouched IPC message and also removed TryShow/TryHide API calls on Windows. The software input panel is now managed by TSF. It only gets activated when the user has tapped on the editable element. We detect this using the TextInputState updates sent to browser process. Bug: 1007958 Change-Id: Iac45c90c0c6e3d84199b848ba2bda3bd068c39c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868169Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
-
Wei Li authored
We are still anticipating using the histogram and flags through Finch through M81. So set the new expiry milestone to M82. BUG=1021153 Change-Id: I2398ccdc38aa1c05a963f6998aac94ac1ab389b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898814Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#713211}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5703cc70..64036088 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I917b9f528af51970a1c698bf33bcd57aaf2f0de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901966Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713210}
-
Findit authored
This reverts commit d6cbc51d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 713147 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q2Y2JjNTFkYjg3NWU5YzQ0ZGJiYTZlNDgwMDZkMTdlODBmYTI0MzMM Sample Failed Build: https://ci.chromium.org/b/8897502697330603712 Sample Failed Step: content_browsertests Original change's description: > bfcache: Save back-navigation's navigationStart in pageshow event's timestamp > > When a page is restored from the back forward cache, there is > currently no way to know its navigationStart time since we aren't > updating performance.timing.navigationStart (which is undesirable), > even though users of bfcache might want to know the navigationStart > time to measure latency. To solve this, we are modifying the > pageshow event’s timeStamp to correspond to the navigation start of > the history navigation. Note as event.timeStamp is defined as time > elapsed since the beginning of the document lifetime [1], this is > effectively the difference between the initial navigationStart and > the navigation start of the last navigation. > > [1] https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp > > Note that we are only updating this for pageshow events for pages > that were persisted (restored from the back forward cache). > > For more background, see doc at https://docs.google.com/document/d/1XlZhphHW-bNcUPD98T-rfTa-TASI-3xUtxZzThZLJCA/edit?usp=sharing > > Change-Id: I81e399492eaa377ac56c4325e3134b1ff50ae451 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888627 > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Auto-Submit: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Fergal Daly <fergal@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713147} Change-Id: I72f56bc464cc58851bb6669f059cb8907fdef24c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902515 Cr-Commit-Position: refs/heads/master@{#713209}
-
Joe Mason authored
R=proberge Bug: 969139 Change-Id: Ibb65a3b6b70fe8dcc03623c281e8207206107571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900562 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#713208}
-
ckitagawa authored
This CL adds file compression ability to the FileManager and switches from last-accessed to last-modified times. As per discussions lifetime will be tied to other existing lifetime management systems: history or tab lifetime. So the method for deletion based on time is no longer required. Bug: 1010042 Change-Id: Ic8cc956fcee2476f52043edd646e24d399a5815d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862707Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#713207}
-
David Black authored
This CL exposes changes to vertical scroll direction to WebContentsObservers. Note that this CL only notifies scrolls in the vertical plane as the feature that will utilize this API is not interested in what is occurring horizontally. Bug: 1014681 Change-Id: Ie0027ab8cb9d90d54a2c1142189e2a74dd032ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862724 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
-
Steven Bennetts authored
For trivial change to resource_bundle.cc: TBR=sky@chromium.org Bug: 1017864 Change-Id: I2afbfa8e02f952d03b36112e0093af92753876ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883292 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#713205}
-
Taylor Bergquist authored
Introduced new constants for toolbar button height in each mode. There's some possibility of refactoring the toolbar button inset calculations to use these constants instead, as discussed in https: //crbug.com/822967, but that isn't done in this CL. Change-Id: I33c6fb199a5c38b6163c5a45718cbd4bd2d890e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898809 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=vollick@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I67db06d4d193229cd0835e855fe52f9573e9fb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894890 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
yilkal authored
This CL removes WebContentsImpl::frame_count_. Instead of using frame_count_ to count the number of iframes, this cl iterates through the frame tree when loading finishes. Bug: 850328 Change-Id: I0eca46aab70371f296a66f0e7775acd18611acdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857647Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#713202}
-
Robert Kaplow authored
A couple things I'm not certain on: - I kept the ints matching the Stability proto values which may make it easier to convert queries. But, if this ends up being what we use long term, it will look strange. I'm fine either way. - Even more broadly - should we keep the system of putting all these unrelated values together or do the cleaner things and have histograms for each. It does seem pretty convenient this way so opting to keep it. I gave it the name Experimental over something like Stability.Counts2 since it's unclear as a replacement. Bug: 1019780 Change-Id: Id4f12dcb7bb503fe5b8ea024a2c3ee0a80a080c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890955 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Xiaohui Chen authored
Bug: b/135064564 Test: locally build and run with multiple media playing Change-Id: I3814cfc3bc619077ca6781493fd369c27d50eb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899184 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713200}
-
Livvie Lin authored
Follow-up to crrev.com/c/1793260. Adds a test for SSL committed interstitials. Bug: 1017406 Change-Id: I47741700c5233ef6f238b3e2b61692d5a4b10cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900405 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
-
Chase Phillips authored
Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/FvM-qo7BfkI/AvxoE6JpBgAJ This change marks AppCache API use and manifest selection on a secure origin as deprecated. All AppCache tests that used a secure origin have been updated with new expectations showing the console message. Three of the tests became flaky after the change since they wouldn't always run the exact same code paths, which would cause the output to differ and expectations to fail. This CL migrates those tests from testRunner to testharness.js. Bug: 1019951 Change-Id: I4c58206c094ababc92975cc61625139644607504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891461Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#713198}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/41be80f6159c..23247b993215 git log 41be80f6159c..23247b993215 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 danakj@chromium.org Don't fetch tags when fetching to deapply a patch. 2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@23247b993215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1019824 Change-Id: Ia7e8137b1f186174ff3d5ffda638936fc60954ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901802Reviewed-by:
-
