- 04 Jan, 2019 40 commits
-
-
Zakhar Voit authored
* Block IP address and name servers checkboxes and input fields when corresponding settings are enforced by policy and not recommended. * Correctly show policy indicators for these settings. Bug: 847429 Change-Id: I3db8ad751ebe44dff487cc01721019738f72c4e5 Reviewed-on: https://chromium-review.googlesource.com/c/1335487 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#619929}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4f718c120c1e..43f09d829d87 git log 4f718c120c1e..43f09d829d87 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 treehugger-gerrit@google.com Merge "build: Warn to run gn clean after install-build-deps" Created with: gclient setdep -r src/third_party/perfetto@43f09d829d87 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I17ea5c3d4682fb45498f1e6ba969a5090ad6a8ca Reviewed-on: https://chromium-review.googlesource.com/c/1395733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619928}
-
Mugdha Lakhani authored
Access to active fetches is currently behind a feature flag. This CL takes that out, along with all logic around it. Bug: 875201 Change-Id: I0bf0ca8ec3eae7ddc5206b639e6a10897476838a Reviewed-on: https://chromium-review.googlesource.com/c/1388647Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#619927}
-
Gauthier Ambard authored
This CL puts the caption in a scroll view, allowing it to be scrolled when the font size is big. Bug: 916068 Change-Id: I111e1d4e00ea2949c85964999106248dfebb433c Reviewed-on: https://chromium-review.googlesource.com/c/1392187 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619926}
-
edchin authored
There are two unused notifications: - TabModel's didChangeTabSnapshot - SnapshotGenerator's didUpdateSnapshotForWebState: These were redundant observable events. The preferred object to observe is SnapshotCache since this is the source of all retrievals. Bug: 918032 Change-Id: I5f36aa564bb13238ff25ffda899ed09b194d6cac Reviewed-on: https://chromium-review.googlesource.com/c/1394944 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#619925}
-
Jérôme Lebel authored
Bug: 919040 Change-Id: I47e6303a2fadb5e587fa7cfbf362495931ee3328 Reviewed-on: https://chromium-review.googlesource.com/c/1396137Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619924}
-
Henrik Boström authored
Now that the bugs caused by the Resolver having updated have been fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=919035, these tests are no longer expected to be flaky. TBR=hta@chromium.org Bug: 919035 Change-Id: I60c421759c69f60e620d76e862aaad5d858bc489 Reviewed-on: https://chromium-review.googlesource.com/c/1396024Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619923}
-
edchin authored
This CL fixes a retain cycle that was caused by using an ivar in an asynchronous block. The block retains self when an ivar is used. This CL also more broadly replaces ivars with properties in the same file. Bug: 918032 Change-Id: I26c867931ad96574f19420f58465e2d14c43ce43 Reviewed-on: https://chromium-review.googlesource.com/c/1393015Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4df0aae68faa..7172f655e9a4 Created with: gclient setdep -r src-internal@7172f655e9a4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic58741ea0e9a7b4131018bfc7cbfcd7601ea7770 Reviewed-on: https://chromium-review.googlesource.com/c/1395734Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619921}
-
Dominic Battre authored
This CL introduces a new UMA metric PasswordManager.FirstRendererFillingResult to record cases where the browser process instructed the renderer to fill credentials into a form but the renderer fails to fill the credentials. We record the metrics to understand why we fail to fill and prioritize our efforts. This is currently a blind spot. Bug: 918846 Change-Id: Ia146861e3d0056cff2ced970175ea377b687da61 Reviewed-on: https://chromium-review.googlesource.com/c/1394313 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619920}
-
Max Morin authored
Bug: 622387, 919033 Tbr: dtseng Change-Id: I03834f051d3368d2a6f497e918d20bb3e630301e Reviewed-on: https://chromium-review.googlesource.com/c/1396141Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619919}
-
Max Morin authored
Tbr: fsamuel Bug: 914587, 918784 Change-Id: I7d6dbde2c72048d493c1f2e5ca14bfe803f2b91c Reviewed-on: https://chromium-review.googlesource.com/c/1396022Reviewed-by:
-
Roman Aleksandrov authored
Add WallClockTimer implementation to proper update relaunch titles for both - desktop and ChromeOS. Bug: 906689 Change-Id: Ic31766bc6566e935762cb4a1afcaf0967e6ed142 Reviewed-on: https://chromium-review.googlesource.com/c/1356706 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#619917}
-
Rayan Kanso authored
The jobs were sometimes being erased before the icon was updated. The delegate now notifies the clients after the new UI information has been passed along. This adds another internal Job State to the delegate to know when the job was complete. Bug: 917384 Change-Id: I00c599e298e342fbfafaaa9a39d5d7bcdc5cf7ba Reviewed-on: https://chromium-review.googlesource.com/c/1388646 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#619916}
-
Gauthier Ambard authored
This CL adds two EarlGrey test to replace Franky tests. Reland of: https://chromium-review.googlesource.com/c/1392091 Bug: 910345 Change-Id: I1fe9194ca2162d1418774fe90e215c33e9ad0ef0 Reviewed-on: https://chromium-review.googlesource.com/c/1392335 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is a left over of https://crrev.com/c/1355189 ([signin] Delete DiceFixAuthErrors). TBR=droger@chromium.org BUG= 777774 Change-Id: I89b6359df1c8910973ca3bcdc9c9145b89d5d464 Reviewed-on: https://chromium-review.googlesource.com/c/1394666Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#619914}
-
Mattias Nissler authored
This brings the changes from the Chrome OS CL https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1341794 over to the Chrome repository. BUG=chromium:906622 TEST=Compiles and passes tests. Change-Id: I36b4c6d156322ca56d8678b10ac7b46103e3c670 Reviewed-on: https://chromium-review.googlesource.com/c/1346397 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
-
Arthur Hemery authored
After a long struggle to try and make mock interfaces for navigations, (attempt here https://chromium-review.googlesource.com/c/chromium/src/+/1366334), finally settling for a more direct approach that enables finer grain management of callbacks. By wrapping interface calls in functions in the RFHI we are able to override it in the TRFH and have no reliance on mocks. Their only use would have been to manage disconnections natively, but we can, in the rare cases where we need it call the implementations directly. In practice: - 2 new functions wrapper in RFHI - 2 overrides of these functions in the TRFH - 4 storage spaces in TRFH - The same unified callback method in NavigationSimulator With this, we know what navigation interface was called, and what callback was provided. Note: Might implement a structure wrapping all Commit parameters in the future, because this is getting quite nasty to change a simple parameter in there. Bug: 784904 Change-Id: I46dc45e3ada1bc00120f1f45f84f1edb8d43906d Reviewed-on: https://chromium-review.googlesource.com/c/1386104 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#619912}
-
Henrik Boström authored
Caused by import: https://chromium-review.googlesource.com/c/chromium/src/+/1394189 Fixes: - RTCPeerConnection-remote-track-mute.https.html - RTCPeerConnection-track-stats.https.html - RTCPeerConnection-setRemoteDescription-tracks.https.html The remote-track-mute case was already timing out but would have hit a problem but it was there for implementations that gets further. The track-stats problem was in a helper method, it simply caused the helper to not await for the last step, leading to flaky tests using that helper. The SRD-tracks problem had caused Failure instead of Pass, updated the -expected.txt file and fixed the test. TBR=hta@chromium.org Bug: 918768, 919035 Change-Id: I02b855ef411ac1fd7c74d96c8c52aab6fe738201 Reviewed-on: https://chromium-review.googlesource.com/c/1396140 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/399f17e09b4a..4df0aae68faa Created with: gclient setdep -r src-internal@4df0aae68faa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3291af01892ef1deecff9866058e7ce8b63df6a7 Reviewed-on: https://chromium-review.googlesource.com/c/1395731Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1defc430. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 4836c563 "Change web platform test with mouse inputs under "pinterevents/"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I859523cd04fef95831bd3706c1f2054c3bc27d54 Reviewed-on: https://chromium-review.googlesource.com/c/1395981Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619909}
-
Maxim Kolosovskiy authored
Bug: 910546 Change-Id: I2b9e0e7677cbc3f0f4ac7ac2722ba5d01d416efb Reviewed-on: https://chromium-review.googlesource.com/c/1394529 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
For enabling font unique local name matching, Blink needs to access the DWriteFontProxy mojo service directly, not only through Skia. For Blink to have access to the Mojo interface, move the file to Blink Common, the location for shared files between content on the browser side and Blink side. Bug: 889864 Change-Id: I438d6659f3fda7140051a57824e8f3554703d2e3 Reviewed-on: https://chromium-review.googlesource.com/c/1394584 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#619907}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ea56333c1e64..93158ebede89 git log ea56333c1e64..93158ebede89 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 shaobo.yan@intel.com Complete the sampler object to match WebGPU Created with: gclient setdep -r src/third_party/dawn@93158ebede89 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I567a5e7403a8d6205a1050d8ce6b3557c37bb59b Reviewed-on: https://chromium-review.googlesource.com/c/1395730Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ebf0d23ee62e..51771a7cad87 git log ebf0d23ee62e..51771a7cad87 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 perezju@chromium.org [telemetry] Remove TimelineBasedPageTest from record_wpr.py Created with: gclient setdep -r src/third_party/catapult@51771a7cad87 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851948 TBR=sullivan@chromium.org Change-Id: Idb1dee30b43f183728970cdb5b1b6a9cb905b442 Reviewed-on: https://chromium-review.googlesource.com/c/1395729Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2bfcc8d6a43e..399f17e09b4a Created with: gclient setdep -r src-internal@399f17e09b4a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8a98e3c936774ad05393147635bca6a1cb700ccd Reviewed-on: https://chromium-review.googlesource.com/c/1395728Reviewed-by:
-
Henrik Boström authored
The file is still marked as flaky due to https://crbug.com/919035. If this still flakes we should add [ Pass Failure Timeout ] to both "track-stats" lines of the TestExpectations file and investigate in the referenced bug. TBR=hta@chromium.org Bug: 919035 Change-Id: Ief45b6504db40874439c4966eabf0e65d4363ae2 Reviewed-on: https://chromium-review.googlesource.com/c/1396117Reviewed-by:
-
Shu Chen authored
BUG=919011 Change-Id: I0f4d83244dabb164a345f1239e6bd9982dfe9cff Reviewed-on: https://chromium-review.googlesource.com/c/1391657 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#619902}
-
Colin Blundell authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1390012, SigninErrorController is now layered on top of signin internals code rather than being part of it. This CL accordingly move it out of the signin_internals GN target back into the browser target that is layered on top of it. I verified that making this change did not remove any dependencies from the signin_internals target (that would have been a nice side-benefit). Bug: 917836 Change-Id: I5dc4947722c6183c91d3cee3225404919bd4b21a Reviewed-on: https://chromium-review.googlesource.com/c/1391671Reviewed-by:
-
Arthur Hemery authored
Another unit test now uses NavigationSimulator. Bug: 728571 Change-Id: I36254912d9c04d16103f3cbf0b156dc92400c6df Reviewed-on: https://chromium-review.googlesource.com/c/1393324 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619900}
-
Maxim Kolosovskiy authored
TODO: Measure the performance of the button titles heuristics and consider optimisations. Bug: 910546 Change-Id: Ic54111a4d8613578e216bd75deeeb5656871e89d Reviewed-on: https://chromium-review.googlesource.com/c/1392092 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb93e618138a..c519fed6ddce git log fb93e618138a..c519fed6ddce --date=short --no-merges --format='%ad %ae %s' 2019-01-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-01-04 reed@google.com start to build with no paint-text fields Created with: gclient setdep -r src/third_party/skia@c519fed6ddce The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I45389ffca1a01037d18391f4bc2f105bd0447ba7 Reviewed-on: https://chromium-review.googlesource.com/c/1395938Reviewed-by:
-
Joel Hockey authored
Chrome creates the container with default username derived from the email address of the current logged in profile. E.g. test.user@gmail.com gets username 'testuser'. It is possible for users to change the username inside the container. As long as the user keeps uid=1000, this does not cause issues except for the sshfs mount where FilesApp connects to the container using 'sshfs://username@hostname'. Cicerone is now updated to return the container username in ContainerStartedSignal and in SetUpLxdContainerUser. CrostiniManager can now use this for the sshfs mount. Removed crostini_util ContainerHomeDirectoryForProfile which was using the default username. The container homedir is now available in CrostiniManager::GetContainerInfo. Bug: 916297 Change-Id: I27f41647c3b8809170521d741867a8ed430e5476 Reviewed-on: https://chromium-review.googlesource.com/c/1388124 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#619897}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f15d3e50..a8182ff8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie42cb3720e3b99f3a0e009e4bc52d9a16f4d2fd4 Reviewed-on: https://chromium-review.googlesource.com/c/1395980Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619896}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/519dec6ea078..2bfcc8d6a43e Created with: gclient setdep -r src-internal@2bfcc8d6a43e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idc31d530ac3b17d159b3d20bb166629c637b74e1 Reviewed-on: https://chromium-review.googlesource.com/c/1395726Reviewed-by:
-
Reka Norman authored
This CL changes the GetApps function of the app management PageHandler to return the initial apps directly rather than calling onAppsAdded, which simplifies initialisation of the ApiListener. It also changes the onAppsAdded function to onAppAdded. Bug: 906508 Change-Id: I649530920dfcce9d3998d9b2eda0320244ced15c Reviewed-on: https://chromium-review.googlesource.com/c/1393587 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#619894}
-
Dan Beam authored
Screenshots: https://imgur.com/a/mcoKkKc Specs: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit#slide=id.g471d243f08_0_874 There's still a bit of work to be done (notably: buttons), but this gets us closer to Namrata's mocks. To run locally, use --enable-features=WebUIDarkMode --force-dark-mode BUG=883049 R=hcarmona@chromium.org Change-Id: I232adf9b487d8be2042c5123484fdb6f87da13c4 Reviewed-on: https://chromium-review.googlesource.com/c/1377147Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#619893}
-
Prashant Malani authored
Add UMA logging of time taken to complete ML service requests, as well as the time spent before a pending request is cancelled. Also update the existing Smart Dim unit tests to verify that the logging works. Bug: 893425, 914640 Test: - Builds and boots, inference calls checked via logs on nocturne - All related unit tests still pass. Change-Id: I542af752a0133939c65eaa435ed3f5be907140db Reviewed-on: https://chromium-review.googlesource.com/c/1393670Reviewed-by:Jia Meng <jiameng@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#619892}
-
Cecilia Ni authored
This CL extracts permission view header from chrome app permission view and pwa permission view to avoid duplicate code. Bug: 906508 Change-Id: If4335bf7fcf70ec2b5d429f1b632c66839ec6853 Reviewed-on: https://chromium-review.googlesource.com/c/1393127Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/76616a10a786..fb93e618138a git log 76616a10a786..fb93e618138a --date=short --no-merges --format='%ad %ae %s' 2019-01-04 reed@google.com fix conditionals for flag Created with: gclient setdep -r src/third_party/skia@fb93e618138a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I578d39a1dea877a93c261e38533aa2daaad2fe67 Reviewed-on: https://chromium-review.googlesource.com/c/1395725Reviewed-by:
-
