- 08 Jun, 2020 40 commits
-
-
Piotr Pawliczek authored
The URI builder does not support relative paths, i.e. Path must be empty or start with '/' character. This rule was not correctly enforced and this patch adds correct verification of Path component. BUG=none TEST=run unittests on my laptop Change-Id: Ib736aa3a7f80667e1e73a06d527d3996f1246c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236061 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#776277}
-
Lev Rumyantsev authored
Note, that this only affects dual-translator setups. BUG=b:158136570 TEST=tryjob Change-Id: I79247fe91c6969a15d52365190949ceec3d1516b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235735Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Lev Rumyantsev <levarum@google.com> Cr-Commit-Position: refs/heads/master@{#776276}
-
Kyle Horimoto authored
Some concepts had the same message ID (e.g., "Proxy" is shared among multiple network-related searches - Ethernet, Wi-Fi, Cellular). This CL adjusts SearchTagRegistry to support this case by changing search tag ID to be the concatenation of the concept ID and its message ID instead of only using the message ID. Fixed: 1091060 Change-Id: I263f91d2d36f465a5b080c2b7231b8de4cd2ad88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233996 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#776275}
-
Nate Chapin authored
Bug: 1092047 Test: html/semantics/scripting-1/the-template-element/template-element/template-element-clone-into-inactive-document-crash.html Change-Id: I7d515c25294fe661781d14d53053dbf1d3be49f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236245 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776274}
-
Pavel Yatsuk authored
BUG=1088844 Change-Id: I93b49fb61e55ebeed7182eef0b019980869d8e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227613Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#776273}
-
My Nguyen authored
In preparation for moving ui/chromeos/ime to chrome/browser/chromeos/input_method/ui, fix presubmit errors. Error encounter: declaration requires an exit-time destructor Change-Id: I1c386ecba2da151f5b74303b4968495e5ed4fd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228589Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776272}
-
Matthew Mourgos authored
Bug: 1080827 Change-Id: I3169327bd052397aab733636b65fdfe6270484ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236051Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#776271}
-
Mounir Lamouri authored
Bug: None Change-Id: Ic2bed812deec00ba7ef2cbdfb370ec410b77c01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236595Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#776270}
-
Nate Chapin authored
Ensure XSLTProcessor.transformToDocument() does not crash when called on a node from an inactive document Bug: 1092276 Test: xslt/transformToFragment-on-node-from-inactive-document-crash.html Change-Id: I0e3c42d1580eef0a499810f280bb997ef1e61740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236234 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Dale Curtis authored
This C++ test causes thousands of back and forth script execution tasks between the browser and renderer process. Instead we should just kick off the tests in JavaScript all at once and then feed a single result back to C++. This slowness makes it susceptible to issues with repeated script execution and is just generally slow. In local testing, this shaved ~7 seconds off a Windows run (a ~22% reduction in time). Some of the speed up just comes from combining the 2 AVC tests and the 3 MPEG2TS tests. Most of the changes here are mechanical. Simply grouping the not, maybe, and probably results and then using a regex to replace the necessary strings to convert the tests into JavaScript. Ones with extensive comments are converted as is (e.g., AVC1,AVC3 tests) while others with middling comments are converted to a map or list structure. Fixes a real bug with 'video/ogg; codecs="vp8"' reporting unsupported on Android. We allow vp8, just not theora. Bug: 1090770 Change-Id: I85dbb4aede36ee38334108fd05b491746a3defa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233787 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#776268}
-
Stephen Roe authored
This is a reland of 844410d2 Fixed the bug in the timeout case logic. Tested it by reducing the timeout value so that the timeout logic was exercised. Original change's description: > [fuchsia] Add ssh debug messages to the emulator output log file. > > This will give more information on startup connectivity issues. > > Bug: 1063106 > Change-Id: I90590eaeee7aaac19d8e277b42f42ce5cd6b4f85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212987 > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Stephen Roe <steveroe@google.com> > Cr-Commit-Position: refs/heads/master@{#775358} Bug: 1063106 Change-Id: I8a28b9d41d5dce9bd444a04f623f6b260355c6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235990 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#776267}
-
Nigel Tao authored
Bug: 1086733 Change-Id: I3c74a9cf7a98419a17fc70e74d7c8f3607526879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235163Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#776266}
-
Nigel Tao authored
Bug: 1086733 Change-Id: I60b07c0a7fa573c4999c31f49a1c8973bb5ad601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235217Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#776265}
-
Nigel Tao authored
Bug: 1086733 Change-Id: Idb692fb99ac6467746b5239fb83e0c002013a445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235572Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#776264}
-
Emily Stark authored
This CL introduces a couple variations parameters to the existing omnibox flag omnibox-ui-hide-steady-state-url-path-query-and-ref (whose expiration is also bumped in this CL). The variations are: - Reveal path on hover. In this variation, we hide the path until the user hovers over the omnibox for 0.5 seconds. This behavior is implemented in this CL. - Show path until user interaction. In this variation, we'll show the path on page load until the user starts interacting (scrolls, keypress, etc.). This behavior isn't yet implemented. Bug: 1090393 Change-Id: If712040ac6dc0028e1fe69ecc0de2229c83c5663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227256 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#776263}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/08a16c09bcf3..09eb6e249d4e 2020-06-08 ilnik@webrtc.org [VP9 SVC] Round spatial layers dimensions to ensure integer scaling factors are used 2020-06-08 tommi@webrtc.org Remove SetRTCPApplicationSpecificData. 2020-06-08 mbonadei@webrtc.org Use absl_deps in order to preapre to the Abseil component build release. 2020-06-08 sprang@webrtc.org Fixes incorrect padding setting for VP9 SVC. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iacb0054b15ce68128a7eccd534dca945647efc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236377Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776262}
-
Joel Hockey authored
Change-Id: I5c6a219afe20f27d441baac09c63105c613dfec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235167 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#776261}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4e7a485eecb16506bb357e6f80ffbb8c60a96988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236467Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Id795b9748949b12ae08fe1f2ede7c285a756daad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232896Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#776259}
-
Henrique Ferreiro authored
This CL also removes WebString::FromUTF16(NullableString16) and WebString::ToNullableString16(WebString) which, after this change, have no users. Bug: 604860, 1039255 Change-Id: I26e1fe104aa208b2423c0d30112e5af0cb32ea71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232860Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#776258}
-
Mounir Lamouri authored
Bug: 1088918 Change-Id: I18b179b6da4b10a021386d3afb35713de4b5636e Fixes: 1088918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232765Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#776257}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/60bf7bf3310f..93f2980477a5 2020-06-08 tmathmeyer@chromium.org Remove little chevron arrows in favor of the general TabbedPane layout If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:794255 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I70bc1f07d67d8aa09d7d6852255f1f4b938a2c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236322Reviewed-by:
-
Mohamed Amir Yosef authored
Before this CL: the color of the arrow is determined once and doesn't adapt to changes in the theme. After this CL: the arrow color always matches the text color Here is a screenshot for the dark mode on Linux. Before: https://screenshot.googleplex.com/6yK0cmkBQxJ After: https://screenshot.googleplex.com/ctW6pGELa1Y Bug: 1044038 Change-Id: I62a056deb31d4ac87cfa85469fee868210519fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232858 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#776255}
-
Tom Anderson authored
Background: as part of bug 1066670, we're removing usage of Xlib and switching to our own X11 protocol bindings. In Xlib, constants are usually defined as macros: #define GenericEvent 35 Our approach is different: struct GeGenericEvent { static constexpr uint8_t opcode = 35; }; There are many instances of the following snippet: DCHECK_EQ(event.type, GenericEvent); which now need to be changed to: DCHECK_EQ(event.type, GeGenericEvent::opcode); However, this causes a subtle link failure: ld.lld: error: undefined symbol: x11::GeGenericEvent::opcode This is because CheckEqImpl's parameters are passed as const&, but the static constexpr value doesn't have an address. Alternatives considered: * Change uint8_t to int to get the existing int overload of CheckEqImpl. We want to avoid this because using int would imply there are more opcodes than can actually exist in the protocol. * Change *::opcode to be non-constexpr static, defined in source file. This won't work because it's common to switch() over the opcode, and that won't work unless the cases are constexpr values. * Create a separate source file that provides redundant definitions of these constants. This is a hack. This CL extends the existing int-int overload meant to solve this issue to any fundamental type. BUG=1066670 R=thestig Change-Id: If62c845cf590cca484e13cf482a67ef4cdd51cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236220 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#776254}
-
Xinghui Lu authored
Bug: 1077352 Change-Id: Ia70455d12f05f6cbd4ba90a5de74f04a98c79fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231256 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776253}
-
Takumi Fujimoto authored
Add media_router::mojom::Logger, used by Media Router's native components to record event logs. Add LoggerImpl implementing the Mojo interface, which will be owned by MediaRouterMojoImpl in a later patch. Bug: 687380, b/154271334 Change-Id: Idefe67682a3c850ee99ab456083a489e4a400c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079535Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#776252}
-
Josh Simmons authored
Uma has also been added to track the result of querying a specific source for a hint. This also removes the former definition of PerformanceClassForURL. PerformanceClassForURL wasn't called anywhere, so PerformanceClassForURLInternal has been renamed and better documented. Bug:1087123 Change-Id: Iac30bcece87f282f826bbf2eff6b19dd37d0d764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225831 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#776251}
-
John Lee authored
Bug: 1000989 Change-Id: I99eeb765ce372deef7ba03c57edf45f0f14479ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233489 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#776250}
-
Ayu Ishii authored
This change changes GetCookieList to return a list of a new struct called CookieWithAccessResult instead of CookieWithStatus which includes CookieEffectiveSameSite data as well as CookieInclusionStatus but makes it available for extensibility to include other data from cookie access time as well. The struct looks as follows. struct CookieAccessResult { CookieEffectiveSameSite effective_same_site; CookieInclusionStatus status; } struct CookieWithAccessResult { CanonicalCookie cookie; CookieAccessResult access_result; }; Bug: 1065010 Change-Id: I7ac01827fff511b422f5ff5a712d50d5a3885d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212697Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#776249}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ic835373e7de291a5685192d9bace593dbaaff1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235946Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776248}
-
Nazih Almalki authored
Bug: 1060058 Bug: 1087865 Bug: 1091977 Bug: 1091555 Bug: 1091454 Bug: 1091453 Bug: 1091076 Change-Id: I1e6a67c7704b0df984df8fb18af7f236fa6e4ffc Bug: 1087865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235653Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Nazih Almalki <nalmalki@google.com> Cr-Commit-Position: refs/heads/master@{#776247}
-
Liquan (Max) Gu authored
Before: * When the payment app security was neutral, the security icon was empty. * The initial security icon was empty. * The initial content description of the security icon was empty. After: * When the payment app security is neutral, the security icon shows "R.drawable.omnibox_info". * The initial security icon is "R.drawable.omnibox_info". * The initial content description of the security icon is "Your connection to this site is not secure. Site information" Change: * Change the initial security icon and its content description to align with PageInfo's. * Change the security-neutral security icon to align with omnibox's and CCT PH's. Bug: 1091334 Change-Id: If9fbcba624da4375b5ddb3100eb2a6a1363d6205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231705 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#776246}
-
Shakti Sahu authored
We cache an old object in the DownloadProgressInfoBar native while we keep updating the java object. When activity restarts after a theme change, we show the UI from the old object in native. This CL updates the java object as well to fix it. Bug: 1092000 Change-Id: Ic5f12e5e38db2f20a3dd2ce5ec6ce061f88bfa20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233828Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776245}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cab169a237ea..1e6bb06ceaf3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xidachen@google.com,dimich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091337,chromium:1092525 Tbr: xidachen@google.com,dimich@google.com Change-Id: Ice162ce12852e5fa4c57b85ec44d4d151a7e587f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776244}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6370cd416c74..ac68fc0764f5 2020-06-08 lalitm@google.com Merge "ui: fix recording on P" 2020-06-08 lalitm@google.com Merge "docs: add type and id columns to all root tables" 2020-06-08 hjd@google.com Merge "tools/tmux forward ANDROID_ADB_SERVER_PORT" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3ebaea5c85ba4513cc8da68a6d5d53e5e6314367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236319Reviewed-by:
-
Yichen Zhou authored
Add animation smoothness metrics for fade-in/fade-out animation of tab hover card. It uses ThroughputTracker to track throughput and calculate smoothness. Bug: 1060816 Change-Id: I5e9c15a9a5b4320214c1cc27a1deae9230466ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231583Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
David Tseng authored
R=dmazzoni@chromium.org, rni@google.com Change-Id: Id876d13aa592850ea5a771cfe66da80aafbe6d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230932 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776241}
-
James Cook authored
Better explain the feature, and note that the code may be enabled by a field trial even though it defaults to disabled. Bug: none Change-Id: I6e596f1535f86128df67a8f38f715f0140208258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236494 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Mei Liang authored
This CL does the following: * Updates the GTS to show a next TabSuggestion, if any, immediately after dismissing the shown TabSuggestion. * Invalidates all TabSuggestions after the shown TabSuggestion is accepted. * Updates the BaselineTabSuggestionProvider for testing. * Adds a debug variation to chrome:flags for showing grouping and closing suggestion immediately. Change-Id: I2a6b5b498f7b8ecdf69e0cdb787360b077efc40c Bug: 1076538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212547 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776239}
-
Andrew Xu authored
Creating hotseat bounds animation which is triggered by hotseat state change requires the hotseat state transition type. However, the current method to calculate the transition type in HotseatWidget::SetState is hard to reset the stored transition type after the transition completes. In this CL, a scoped class is introduced to set/reset the transition type stored in HotseatWidget. Note that the only place to set the hotseat state then update the hotseat bounds is ShelfLayoutManager::SetState(). It ensures the correctness of this CL. Bug: 1024911 Change-Id: Ie68d182dbf105c4376898e7c0269a620194e6e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235980Reviewed-by:
-
