GitLab

Change-Id: I5455b94c44f8a896879723a3a7630386edbee807
Reviewed-on: https://chromium-review.googlesource.com/565258Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485535}

MTP related fixes caused regression on the behavior when multiple files
selected are double-clicked.
These MTP related fixes were reverted in:
* https://codereview.chromium.org/2973003002/
* https://codereview.chromium.org/2966163005/

This CL restores these reverted CLs while fixes double click regression.

BUG=462989,712121,731483,738803
TEST=
unit: out/Debug/browser_tests '--gtest_filter=FileManagerJsTest.TaskController'
* Verified it fails with the original patches.
manual:
* Transfer files on MTP while selecting many source files.
* Transfer files on MTP while opening context menu.
* Double click multiple selected files.

Change-Id: If61e5f306f821d0bf096c068b01866ce1cfd38c9
Reviewed-on: https://chromium-review.googlesource.com/562912Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485534}

Also:
- Make the crash tests for CSSTransformValue parameterised instead
of repeating the same code for each test.
- Make ToCSSValue return nullptr if the CSSPerspective contains a
negative length to avoid later DCHECK, and add a test for this.

BUG=545318

Review-Url: https://codereview.chromium.org/2953233002
Cr-Commit-Position: refs/heads/master@{#485533}

This will initialize loading the keyboard extension when the RootWindowController calls ActivateKeyboard.

Bug: 724908
Change-Id: I3af07338dd3e619f9ae6d85e0f191890d0cd5a67
Reviewed-on: https://chromium-review.googlesource.com/547921
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485532}

This test has been stable on FYI, and having it on the CQ will
help catch regressions sooner.

Bug: 638141
Change-Id: Ie318f62993402a0f1b89f4aff47c821a0310722f
Reviewed-on: https://chromium-review.googlesource.com/557861Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485531}

This CL does the following:

1. Move SharedBitmap to components/viz/common/quads
2. Move SharedBitmapManager to components/viz/common/resources

All other changes are mechanical updates to includes, namespace, etc.

TBR=junov@chromium.org

Bug: 722935
Change-Id: Iefcc37c250275b577153efa56f0cf6e78314ac94
Reviewed-on: https://chromium-review.googlesource.com/565841
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485530}

|XcodeWriter::CreateProductsProject| in xcode_writer.cc has evolved
into a giant function, so this CL makes it smaller by refactoring the
logic that adds source files to the project for indexing into a
separate function.

Bug: 709289
Change-Id: I19fab218e1af87a87cacf8f65f19c2acf8091713
Reviewed-on: https://chromium-review.googlesource.com/563650Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485529}

BUG=740801
TBR=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2973403002
Cr-Commit-Position: refs/heads/master@{#485528}

This patch moves animations tests that are specific to the Web
Animations API from LayoutTests/animations to a dedicated subdirectory.

BUG=623434

Review-Url: https://codereview.chromium.org/2976613002
Cr-Commit-Position: refs/heads/master@{#485527}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b708a0d15934..fc9479ad5e3b

$ git log b708a0d15..fc9479ad5 --date=short --no-merges --format='%ad %ae %s'
2017-07-10 benjhayden Add related names GenericSet diagnostic.
2017-07-10 martiniss tracing: Fix subtle python bug in job.py
2017-07-10 simonhatch Dashboard - Allow logged in users for oauth.Authorize decorator.
2017-07-10 eakuefner [Tracing] Fix bug with Python dependency handling

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ie1a0d743fd67849a2c479ce68b92ce3600fe6e00
Reviewed-on: https://chromium-review.googlesource.com/566190
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485526}

This patch:
- Added CSSPrpertyTextDecorationLineUtils and moved common function
  ConsumeTextDecorationLine from CSSPropertyParser into it.
- Implemented CSSPropertyAPITextDecorationLine::parseSingleValue,
  moving logic for properties CSSPropertyTextDecorationLine and
  CSSPropertyWebkitTextDecorationsInEffect from
  CSSPropertyParser::ParseSingleValue legacy switch statement
- Added details of API implementation for these properties to
  CSSProperties.json5 for generated files.

Diff for generated files: https://gist.github.com/BugsNash/1f4cae843ee5843e43b46ed3eebf0de6/revisions

Bug: 668012
Change-Id: I5f1d5f6f38d0fee61a6e3116f88e8ea78c7e2b3d
Reviewed-on: https://chromium-review.googlesource.com/565225Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485525}

This patch moves tests related to animation timing (e.g. linear, ease,
steps) from LayoutTests/animations to a dedicated subdirectory.

BUG=623434

Review-Url: https://codereview.chromium.org/2979503002
Cr-Commit-Position: refs/heads/master@{#485524}

This patch Introduces |EphemeralRange| version of |TextIterator::RangeLegnth()|
to simplify call sites which pass start and end positions from |EphemeralRange|
for improving readaiblity.


Change-Id: I7c685c16e8f5abb8a1875aea2dc4cfc494a70acf
Reviewed-on: https://chromium-review.googlesource.com/564911
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485523}

This patch moves tests related to direction (e.g. reverse, alternate)
and fill (e.g. fill forwards, fill backwards) from
LayoutTests/animations to a dedicated subdirectory.

BUG=623434

Review-Url: https://codereview.chromium.org/2975723002
Cr-Commit-Position: refs/heads/master@{#485522}

This patch moves event-related tests from LayoutTests/animations to a
dedicated subdirectory.

BUG=623434

Review-Url: https://codereview.chromium.org/2976603002
Cr-Commit-Position: refs/heads/master@{#485521}

On Android, pages may be shown from a downloaded offline cache. In this
case, the security chip text and icon change. Reflect this in
ToolbarModel.

With this new ability, render the Offline security information in VR.

BUG=735770

Review-Url: https://codereview.chromium.org/2968143003
Cr-Commit-Position: refs/heads/master@{#485520}

Currently Devtools uses widget to highlight elements, i.e.,
windows, widgets, and views. We instead can ui::layer for highlighting
and to support future drawing/animation.

Bug: 730828
Change-Id: Ic84a79c382e2e3a2bcf0b9cba421d2cb9a8e72bc
Reviewed-on: https://chromium-review.googlesource.com/564036
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485519}

The bug this CL intend to fix has a very specific root cause; we were
wrongly assuming that we need to repeat the track sizing algorithm only
if baseline alignment may change the grid container's intrinsic size.

Actually, the spec states that we should run a new iteration of the
sizing algorithm if any of the grid items has changed its min-content
contribution. This affects to the grid item's container, hence the
grid area, but not necessarily to the grid container.

Since we were running the baseline alignment logic after the first run
of the tracks sizing algorithm, we were relying on the extra run to
adjust the grid areas' size based on the resulting baseline alignment
offsets.

This patch fixes the bug by comparing the grid areas's size with the
baseline extent of their items, triggering the extra tracks sizing cycle
when necessary.

BUG=719445

Review-Url: https://codereview.chromium.org/2868283002
Cr-Commit-Position: refs/heads/master@{#485518}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d8c9af47..10d68afb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I36856d299ebcce7ab990297c59e3bff5834ced0a
Reviewed-on: https://chromium-review.googlesource.com/566322Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485517}

Adds pass-through of some command-line options useful for debugging:
--test-launcher-batch-limit to control tests-per-process.
--test-launcher-jobs to control # of parallel test processes.
--single-process-tests to run all tests in a single process.

Also adds the OS_FUCHSIA tag to the test results output.

Change-Id: I4ce99f2a33536ddd9fae4fcb6bf93eab6f38a612
Reviewed-on: https://chromium-review.googlesource.com/564738
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485516}

As we introduce a hierarchical folder structure to Source/build/scripts,
we will need to refer to Jinja templates by their full path. This patch
changes existing generators to use full paths when referring to
templates (see changes to template_expander.py).

There are no changes to generated code.

Bug: 732657
Change-Id: Id95a922587c0cbd858538e70c355d14d0dfa9ce5
Reviewed-on: https://chromium-review.googlesource.com/527851
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485515}

BUG=739458
TBR=altimin@chromium.org

Review-Url: https://codereview.chromium.org/2978473002
Cr-Commit-Position: refs/heads/master@{#485514}

BUG=740786
TBR=twellington@chromium.org

Review-Url: https://codereview.chromium.org/2978563002
Cr-Commit-Position: refs/heads/master@{#485513}

Move tests of animations being responsive to style changes under the
existing animations/responsive test directory. The tests that are
already there are testing responsiveness in interpolations, so they are
moved to an interpolation/ subdirectory.

The tests in the svg-attribute-responsive directory are also moved
under responsive/interpolation/ in order to avoid creating a copy of
the responsive-test.js with different relative path imports.

BUG=623434

Review-Url: https://codereview.chromium.org/2973013002
Cr-Commit-Position: refs/heads/master@{#485512}

Right now, these just test that ConnectionInfoPopupTest.show() and
PageInfoPopupTest.show() can be invoked without crashing.

Bug: 657299
Change-Id: Ic075b86e7d12df9893173bb35692ecc8b7e3df6d
Reviewed-on: https://chromium-review.googlesource.com/557450
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485511}

The previous idiom was to define a subclass to wrap the type, and store
a raw pointer to the subclass. Rather than doing that, just use
WebPrivatePtr.

Bonus fix: WebHTTPBody's assignment operator was accidentally changed to
a no-op. Luckily it appears that this is never called...

Change-Id: I6301f410513b4cd93ca1fcb537d46dd87359bb7a
Reviewed-on: https://chromium-review.googlesource.com/565077
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485510}

No code generated

Bug: 
Change-Id: I516f2d1cecf0a32186b001a0be594c725d137d59
Reviewed-on: https://chromium-review.googlesource.com/560813Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Minh-Duc Nguyen <nmduc@google.com>
Cr-Commit-Position: refs/heads/master@{#485509}

Most of these are related to XHR being unimplemented.

TBR=reillyg@chromium.org

Change-Id: Iad4fbc259e8821e40e95ca42e03b4c174f0921cc
Reviewed-on: https://chromium-review.googlesource.com/566072Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485508}

Added missing unit test for translate_service.cc

Bug: 727459
Change-Id: Iae3cdded7bb934fd59a7248cf342bce85c44ee69
Reviewed-on: https://chromium-review.googlesource.com/564871Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: Jon Napper <napper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485507}

TBR=dimu@chromium.org

Change-Id: I9cfbc912fb68bbe0e12143482fcda533416a325f
Reviewed-on: https://chromium-review.googlesource.com/566324Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485506}

Existing tests for this component don't work. The service worker
registration is for a different browser context, so the tests never
actuallly verify WebAPK-compatibility properly.

This CL revamps the tests by mocking out InstallableManager instead of
WebContents. This allows precise control over the data returned to the
data fetcher so we can verify more scenarios more accurately.

BUG=721881

Review-Url: https://codereview.chromium.org/2960103002
Cr-Commit-Position: refs/heads/master@{#485505}

This is needed to support launching from Daydream 2D.

Bug: 
Change-Id: Icde35d6dfd14e9b3f2432af843e5a2e302dcb944
Reviewed-on: https://chromium-review.googlesource.com/565466Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485504}

When a decode error occurs in a part of a multipart image, the state
transition from kDecodeError to another finished state can occur when
the next part of the multipart image is received.
This CL relaxes the state transition restriction of
ImageResourceContent to allow such state transitions.

Bug: 737392
Change-Id: Icf07899d77994463e9aabedb64f704ef0a9e346d
Reviewed-on: https://chromium-review.googlesource.com/562602Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485503}

Because RemoveClient() can be called due to Oilpan GC in some places
in ResourceFetcher::StartLoad(), and [1] originally intended to
forbid Add/RemoveClient/Observer() only during NotifyStartLoad().

[1] https://codereview.chromium.org/2746343002

Bug: 726315
Change-Id: I30e56a193f06e07903d8227a680d556e01b71117
Reviewed-on: https://chromium-review.googlesource.com/560542Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485502}

font_service::FontLoader makes a sync mojom call when attempting to load fonts.

It is possible for this call to fail if the remote service manager shuts down
before the call completes.

This leaves the calling service in a bad state, where the mojom error has yet
to be received, and where there are no font resources.

In tests this has been exhibited by crashes in some services while they
attempted to perform AuraInit. This change updates PlatformFont to provide a way
to initialize the the static defaults, which returns the success state.

AuraInit is updated to consider the lack of font as a failed init. Calling
services are already set to shutdown on these failures. Allowing us to cleanly
handle this shutdown ordering issue.

TEST=mash_browser_tests

Bug: 738441
Change-Id: I90efe768d5027885d51bc4ac8ba1de895c297f54
Reviewed-on: https://chromium-review.googlesource.com/565031Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485501}

Splits the optimized builtins into their own file, which creates the
interfaces for adding the optimized ARM versions in a follow-up CL.

BUG=672489

Change-Id: I356fb4d166f4773b111f3c61c6206e3d4b4ccd40
Reviewed-on: https://chromium-review.googlesource.com/562754Reviewed-by: Justin Schuh <jschuh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485500}

This patch changes the behavior of the code to not use high filter
quality for upscales. It also refactors the code a bit to ensure that
we don't use medium if we're not scaling, since that would result in
an extra copy of the image memory.

R=ericrk@chromium.org, pdr@chromium.org

Bug: 735174
Change-Id: I30e75731a3f2f89570ef29c972e4b101ec5fe1fc
Reviewed-on: https://chromium-review.googlesource.com/541609
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485499}

This is nothing like what the ultimate, true solution should look like. It does
seem to work for the narrow problem of calling history.pushState in a tight
loop, however.

BUG=394296

Review-Url: https://codereview.chromium.org/2972073002
Cr-Commit-Position: refs/heads/master@{#485498}

- Move zip archiver from ui/file_manager/zip_archiver to
  c/b/resources/chromeos/zip_archiver
- zip_archiver is no longer loaded from resources.pak. zip_archiver will
  be located at /opt/google/chrome/resources/chromeos/zip_archiver on
  device.
- Fix presubmit errors and warnings.
- Fix zip archiver to be built with third_party/minizip.
- Use polymer in chrome://resources.
- Removed some unnecessary files which had presubmit errors or warnings.
- Removed hacks to include module.nmf and pexe in resources.pak.

BUG=359837
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic2c1a39d22b1e12b978d090375248e39961bf58a
Reviewed-on: https://chromium-review.googlesource.com/544361Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@google.com>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485497}

This change adds some headers which are used directly and removes some
headers which are no longer needed.

Bug: none
Change-Id: I9382fdc8d6d925e09b472fbbd5e24ef222d9b46d
Reviewed-on: https://chromium-review.googlesource.com/562507Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485496}