- 31 May, 2019 40 commits
-
-
Danan S authored
Only rollback the changes to arc_app_utils.*, which it turns out we need in another in-flight CL: https://chromium-review.googlesource.com/c/chromium/src/+/1606571 This reverts part of commit 7e1d0290. Bug: 937995 Change-Id: Id8df13e94019fea5b07da6f8d03fea8a736d6be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637646Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#665024}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7ddf2af7635..a3f79ed1d18e Created with: gclient setdep -r src-internal@a3f79ed1d18e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ib0fa4ae02a182216c1136b9f496c6fc02b5f47c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638158Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665023}
-
Yuchen Liu authored
Analyze HEVC stream with class H265Parser. It will be used in mp4 parser to get the correct information on whether the current frame is key frame. Currently it performs check of ITU-T Rec. H.265 (02/2018), section 7.4.2.4.4, Order or NAL units and coded pictures and their association to access units. Bug: 527595 Bug: internal b/114239680 Test: Play mp4 which marks all the video frames as key frame. Change-Id: I975140241f47bcac21afa648f06207fddff3ec19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629755Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665022}
-
Lan Wei authored
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing a pointerevent input tests which have keyboard scroll actions. This is the seventh CL that changes part of the pointerevent input tests. Bug: 606367 Change-Id: Ic468d3bd61569ae4edc9cc2234a5b7056055ff5d TBR=nzolghadr@chromium.org Change-Id: Ic468d3bd61569ae4edc9cc2234a5b7056055ff5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636818Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#665021}
-
Abhishek Arya authored
This reverts commit 6014a0fc. Reason for revert: Used by ClusterFuzz fuzzing bots. Bug: 968862 Original change's description: > clang package: Stop shipping 32-bit asan on win, and 32-bit libraries on linux. > > See "Does anyone use the 32-bit asan runtime on Windows?" on chromium-dev > for Windows. (We sadly still need the 32-bit profile library, so the build > script doesn't get any simpler.) > > We haven't supported 32-bit builds on linux in a while, so those libs should > be safe to remove as well. > > If anyone needs these, shout and we can add them back. > > Also use ' instead of " for strings added in my previous change. > > Linux package size: 48.73MB -> 47.49MB; main build 3924 -> 3526 build steps. > Windows package size 43.49MB -> 41.56MB; 32-bit compiler-rt build 207 -> 18 build steps. > > Bug: 959966 > Change-Id: I8c326dab4e07df69ee734f6390cda7291bfd7642 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635410 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664523} TBR=thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 959966 Change-Id: I1a19aec049993c9f7e2e5075c1d2e864c9d17bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637664Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#665020}
-
Yuwei Huang authored
We can't just remove HostChangeNotificationListener from double signaling hosts since the legacy directory server only notifies host deletion through XMPP, and old clients will only talk to the legacy server. This CL ensures XMPP-based HostChangeNotificationListener is created for both double signaling hosts. Bug: 968828 Change-Id: I234a30cb5162f27a1db9510962f360ff54ae5685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638138 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#665019}
-
Yuwei Huang authored
//remoting/ios/domain uses classes from base but never declares dependency in BUILD.gn, so building it with a clean target directory will fail but rebuilding it will succeed. This CL fixes the issue by adding the missing dependency. Bug: 968845 Change-Id: I28655be4d710e0d8b124650808f9bbf4c41dede6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637663 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
Dan Beam authored
R=dpapad@chromium.org BUG=none Change-Id: I3983d038b3e520245ec61ef0e96cebf3ae2a9b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636607 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#665017}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fa2fd31ebd18..b8451b73557c git log fa2fd31ebd18..b8451b73557c --date=short --no-merges --format='%ad %ae %s' 2019-05-31 rmhasan@google.com Revert "[Typ] Use a file to store sub process output" Created with: gclient setdep -r src/third_party/catapult@b8451b73557c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:960833,chromium:960606,chromium:952105 TBR=sadrul@google.com Change-Id: I22135c17f33a57930d81ff3fb8e4d598dda35eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665016}
-
Meilin Wang authored
This CL sets the hotword locale of the input device with DSP support to the locale stored in user's pref. BUG=960566 TEST=local compile and manually test. Change-Id: I49b6e71371181d4a4c2eccac2244e1f2724ff15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610090Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#665015}
-
Clifford Cheng authored
Bug: 968849 Change-Id: Ie21bb36c547d5ce661cb031b58c9f6ffe7ce692f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637529 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#665014}
-
Andrey Lushnikov authored
R=skyostil, caseq Bug: 925589 Change-Id: I88ac0fc3eaf748d661db296db9926424eb60e4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637607 Auto-Submit: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#665013}
-
Kristi Park authored
Standardize the mini page icon from the backgrounds menu so that it can be reused in the shortcuts menu. Screenshots: https://screenshot.googleplex.com/yAeb8kNfq55.png https://screenshot.googleplex.com/ofXsa1W6knU.png https://screenshot.googleplex.com/H072V7w3hB6.png Bug: 953822 Change-Id: If418265312d62a82433685d4c0471c03263fbbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636262Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665012}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/57dc02a5c268..eb22227c5baf git log 57dc02a5c268..eb22227c5baf --date=short --no-merges --format='%ad %ae %s' 2019-05-30 mellem@webrtc.org Add OnDatgramLost and default value for receive_timestamp. 2019-05-30 steveanton@webrtc.org Explicitly close PeerConnections when using ScopedFieldTrials 2019-05-30 steveanton@webrtc.org Remove some media/ --> pc/ test dependencies Created with: gclient setdep -r src/third_party/webrtc@eb22227c5baf The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic76c2991493a2123bee313f41cf19adc304c7abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637495Reviewed-by:
-
Kristi Park authored
This is mostly the same as mouse support, except: - 'touchstart' must be triggered first. Then, the subsequent 'touchmove' event can start the reorder flow. - There is no touch equivalent for 'mouseover'. Hence, we emulate it by manually checking if we are hovering over another tile using using |document.elementsFromPoint|. Screencast: https://drive.google.com/open?id=1DTbSzrcN9CBzvOWvziHPxz6w7_FIOPqJ Bug: 851335 Change-Id: I2f91576c86c4d825c310612d4def14fa6fc227f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600597 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Charles Zhao authored
Currently TabDiscarder logging happens inside TabManager::DiscardTab which is not ideal. This CL moves the logging to TabActivityWatcher::SortLifecycleUnitWithTabRanker so that we can log exact the queried tabs. Bug: 968366 Change-Id: I1ca457be59c548a3eb88aa209125d48707147a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633894 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#665009}
-
Brian Sheedy authored
Rolls the goldctl revision to pick up the CL that made it more robust to transient HTTP failures. TBR=kbr@chromium.org Bug: 850107 Change-Id: Ie955087b9361093e7afbfe63900ea14241bcdc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636283Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#665008}
-
Pavel Yatsuk authored
BUG=959317 R=skym@chromium.org,mdjones@chromium.org Change-Id: Icb49eaac8aed5f66fbe16d12d615bb1f8567bbaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636854Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#665007}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8fd3d327fa3c..74053b47b03b git log 8fd3d327fa3c..74053b47b03b --date=short --no-merges --format='%ad %ae %s' 2019-05-30 tsepez@chromium.org Remove core/fxcodec from fxbarcode/DEPS 2019-05-30 tsepez@chromium.org Prohibit includes from xfa/fwl to xfa/fxfa 2019-05-30 tsepez@chromium.org Replace CFWL_EditTP dependence on fxfa/ with new AdapaterInterface call. Created with: gclient setdep -r src/third_party/pdfium@74053b47b03b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I03e17807c106dea1cc90cf10fe876634123619fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636679Reviewed-by:
-
Reilly Grant authored
It appears that GetCharacteristicsAsync() will implicitly open a GATT service for exclusive access. We don't want this so this change adds an explicit OpenAsync() call to choose shared access. The test fakes are updated to only support shared access. Bug: 968816 Change-Id: I30af95fe428fad075ae8cbddd3075979a834e65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637192Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665005}
-
Charles Zhao authored
This change gives us the ability to explore different process_types to be scored by TabRanker. We can try (1) to only discard BACKGROUND tabs. or (2) to discard BACKGROUND and PROTECTED_BACKGROUND tabs. Bug: 968391 Change-Id: Idb65c1609ce81aa5c8c3a0b07c8cab1a016384d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633872Reviewed-by:
-
Collin Baker authored
This add a metric for tracking time spent painting the TabStrip at a high level and another for time spent painting TabIcons. The former is logged for each frame the TabStrip paints. The latter is logged every time a TabIcon paints, which can be more often since they sometimes paint to their own layers. These metrics are high-level and not super actionable on their own; they are mainly intended to catch regressions. Change-Id: Ie90f5db94ffab163aaf475c19ea678276db3b308 Bug: 966237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626169 Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#665003}
-
Anne Lim authored
Removed StrikeDatabaseV2 from FieldTrial Configs. Bug: 884817 Change-Id: I3e99b64f1457d97a43b10299a2de41b0869f47a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632600Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#665002}
-
Chase Phillips authored
Tracing metrics are captured when IDBRequest handles a response that effectively completes a callback or action in IndexedDB. Previously, these metrics were marked as done when the response was enqueued which meant the metric didn't account for the time the event needed to be fully dispatched and run. This change updates the metrics so they are recorded once they are dispatched. The result will be that after this change the metrics will all show a regression but in reality they are only being made more accurate now. We expect a future change that directly dispatches events to improve these metrics. Bug: 968536 Change-Id: I1801aa37e6946073f1ecabf795c0d9763bc413d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637304Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#665001}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f404713905ef..a9e9c3dff0c2 git log f404713905ef..a9e9c3dff0c2 --date=short --no-merges --format='%ad %ae %s' 2019-05-30 achuith@chromium.org chromite: Replace cros_run_vm_test with cros_run_test 2019-05-30 cmtice@google.com chromeos_config.py: Remove redundant code adding 'cfi' flags. Created with: gclient setdep -r src/third_party/chromite@a9e9c3dff0c2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Iefc8401cf79fee8b5c94bf4bd09c8f292d426b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637491Reviewed-by:
-
Rakina Zata Amni authored
Previously we didn't clear the bit so on future propagations or when checking for NeedsLayoutTreeUpdateForNodeIncludingDisplayLocked we will return the old value. Bug: 968009 Change-Id: I82fd3ad5668708467741973fe6bff3ae4054f9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636657Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#664999}
-
JunHo Seo authored
A huge(tested on downstream build - chromium68 with gcc 8.2, about 180MB) compile warning messages are printed during building chromium. One of major warning messages is about the -Wpacked-not-aligned warning message. The type of warning is printed for all generated mojom-shared-internal.h files. But all the warnings are false positive because we are checking the correctness by inserting static_asserts(structure size == mojo::internal::kUnionDataSize). To reduce printing too many warnings, suppress the build flag for (!clang and !win) build. Below is a sample message: gen/third_party/blink/public/mojom/blob/data_element.mojom-shared-internal.h:39:7 warning: alignment 1 of 'blink::mojom::internal::DataElement_Data' is less than 8 [-Wpacked-not-aligned] Bug: 819294 Change-Id: Idcb711f6218e00f0450a4c9714dd70dda802ecc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637022Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#664998}
-
Robert Liao authored
Blue buttons were removed in https://chromium.googlesource.com/chromium/src/+/0919936b300874925621c3280be0746fabbc39a1 BUG=642920 Change-Id: I2884314b5dc56afe41b39eac25489c1fbb3a8ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637977 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#664997}
-
Jenny Zhang authored
Add the following UMA metrics for play store search results: 1. How many times play store results have been shown by launcher(impression). 2. The number of the play store apps displayed to user for a query. 3. The index of the app within all play store apps displayed when it is launched. Bug:961473 Change-Id: I65ad8eed7af06e4b5c66f8464b199908bded87ae TBR=xiyuan@chromium.org,holte@chromium.org Change-Id: I65ad8eed7af06e4b5c66f8464b199908bded87ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637847 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#664996}
-
Gyuyoung Kim authored
As the second step to deprecate WTF::CString, the bug has guided to make String::Latin1() return std::string instead of CString. So this cl does below things to do it. - Made String::Latin1() to use std::string internally. - Replaced all uses of Latin1().data() with Latin1().c_str() - Made callers of Latin1() handle the return value with std::string Bug: 950077 Change-Id: I93a92e4685f16e0442da910a02deaf59d691438d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633891Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#664995}
-
Maksym Onufriienko authored
Bug: 922813 Change-Id: Icc342bcf95caba07ce12e72f1b2e7cadcd8684b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626515 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664994}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e6f5583427ea..a7ddf2af7635 Created with: gclient setdep -r src-internal@a7ddf2af7635 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:790671,chromium:790669,chromium:790667,chromium:790665,chromium:790663,chromium:790662 TBR=melandory@google.com,hiroshige@google.com,loyso@google.com Change-Id: I965a85e094612725191667c8bb78ab941a7d75e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637487Reviewed-by:
-
Nigel Tao authored
Before this commit, the tests were brittle, relying on the order (prior to sorting) that apps were presented. Also update the FetchRecommendationsWithContinueReading test code to only call base::Time::Now() once. Now's base/time/time.h comment says: "Watch out, the system might adjust its clock in which case time will actually go backwards. We don't guarantee that times are increasing". The base::Time::Now change isn't necessary to fix the test, but it makes for a more robust test. This fixes `unit_tests --enable-features=AppServiceAsh --gtest_filter="AppSearchProviderTest.FetchRecommendationsWithCont*"`. It fails before and passes after this commit. Note that `unit_tests --gtest_filter="AppSearchProviderTest.FetchRecommendationsWithCont*"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: Iaf6defc23052963e88bc9c27e759a356ef24698e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636664 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
Shimi Zhang authored
This file isn't used anywhere, there is a almost the same copy of it in components/heap_profiling/, which is in use. Bug: None Change-Id: Ia53649c4de7f403c0a37cde28dd05c8d6480fede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635086Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#664991}
-
Ahmed Fakhry authored
The flag will be disabled by default in M-76. BUG=866622 TEST=Manually, AboutFlags*Test* Change-Id: I9a10ad2b933625e7c7e997d1f7e7c3bededc9396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627653 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#664990}
-
Pâris MEULEMAN authored
This CL enforces the constraint that the account_id is not empty in OAuth2TokenServiceDelegate FireRefreshTokenAvailable, FireRefreshTokenRevoked and FireAuthErrorChanged. This is in the interest of adding this semantic constraint to the oauth2_token_service APIs which is already respected by most callsites. There is one case that failed on ChromeOS tests (impacting multiple tests, see first patchset here), in DeviceOAuth2TokenServiceDelegate::DidGetSystemSalt, where the Robot account Id might be empty. This is changed to call FireRefreshTokenAvailable only if the robot account is set. Bug: 960281 Change-Id: I8cc55cdc0f4c9c15c004c7fb20ed9e221ca1030b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619811Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664989}
-
Kelvin Jiang authored
Add "declarativeNetRequestFeedback" permission key which will enable an extension to get feedback on which of its DNR rules have matched. Bug: 967942 Change-Id: I3e55f57074cb091bdf3beb404926effa769e80c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636712 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#664988}
-
Manas Verma authored
Bug: 949269 Change-Id: Iedeb559d1f17a1549f8e4120e5968f8dd55e11a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636286Reviewed-by:
-
Mitsuru Oshima authored
Event.DownEventCount.PerInputFormFactorDestinationCombination Event.DownEventCount.PerDestination* Event.DownEventCount.PerFormFactor* Event.DownEventCount.PerInput* Bug: 960047 Change-Id: Iee591667434bc2f41df7106147db94df636dbfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629608 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#664986}
-
Jun Mukai authored
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tsepez@chromium.org Bug: 958193 Test: trybot Change-Id: Ie4d8a07ece41d026de20de17554a5b323fb95fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632884 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#664985}
-
