GitLab

https://skia.googlesource.com/skia/+log/1e3dad0b17e9f240e4a061208d5368e20527bede..841010f4bd54663e41900359fd32640767e6c8cd

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/559083002

Cr-Commit-Position: refs/heads/master@{#294178}

R=pkl@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/551053002

Cr-Commit-Position: refs/heads/master@{#294177}

Only text that will be sent through an HTML parser needs to be parsed.
Escaping more than that results in & and < and similar in the
output.

R=andrewhayden@chromium.org

BUG=412708

Review URL: https://codereview.chromium.org/562623002

Cr-Commit-Position: refs/heads/master@{#294176}

TBR=jam@chromium.org
BUG=405932

Review URL: https://codereview.chromium.org/495643002

Cr-Commit-Position: refs/heads/master@{#294175}

Revert of Fix test for master device. (patchset #4 id:80001 of https://codereview.chromium.org/538143002/)

Reason for revert:
Breaks key repeat (issue 412655).

Original issue's description:
> Fix test for master device.
>
> BUG=406014
> R=sadrul@chromium.org
>
> Committed: https://crrev.com/817ca9b5c2145d843f6ff154926db79535974778
> Cr-Commit-Position: refs/heads/master@{#293781}

TBR=sadrul@chromium.org,derat@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=406014

Review URL: https://codereview.chromium.org/560853003

Cr-Commit-Position: refs/heads/master@{#294174}

BUG=409995

Review URL: https://codereview.chromium.org/547093002

Cr-Commit-Position: refs/heads/master@{#294173}

Fix more uses of T* conversion operator from scoped_refptr<T> which is now removed.

Please see https://codereview.chromium.org/510323002 for reference.

TEST=ozone_demo and content_shell under Ozone-GBM
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/552133004

Cr-Commit-Position: refs/heads/master@{#294172}

BUG=412764, 268924
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/559093002

Cr-Commit-Position: refs/heads/master@{#294171}

BUG=273089

Review URL: https://codereview.chromium.org/554733003

Cr-Commit-Position: refs/heads/master@{#294170}

ImeTest#testKeyCodesWhileComposingText
ImeTest#testEnterKeyEventWhileComposingText

BUG=411756,315548
TBR=aurimas@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/561773002

Cr-Commit-Position: refs/heads/master@{#294169}

BUG=391846
TEST=Go to whatsmyua.com on an iOS 8 device and verify that the
AppleWebKit and Safari versions in the user agent are the same in
MobileSafari and Chrome for iOS.

Review URL: https://codereview.chromium.org/558163003

Cr-Commit-Position: refs/heads/master@{#294168}

BUG=347967
NOTRY=true
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/556283002

Cr-Commit-Position: refs/heads/master@{#294167}

See tools/gyp/pylib/gyp/input.py:
"Sections mathing the regexp '_(dir|file|path)s?$' are also considered PathSections."

Standard gyp variables should not be named like this.

BUG=

Review URL: https://codereview.chromium.org/552203002

Cr-Commit-Position: refs/heads/master@{#294166}

Measure AsyncResourceHandler browser->render->browser hop time in UMA to
understand the potential performance benefits of handling redirects entiely in
the browser process instead.

BUG=395552

Review URL: https://codereview.chromium.org/555913002

Cr-Commit-Position: refs/heads/master@{#294165}

As suggested by 'aurmias' fixed mentioned comments in issue 541713002
Fixed issues:
1.Using one button for stop and reload option.
2.Removed tabs from chrome_shell_acivity.xml
3.moved resource from chrome/android/java/res to chrome/android/shell/res

BUG=

Review URL: https://codereview.chromium.org/546383002

Cr-Commit-Position: refs/heads/master@{#294164}

Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/554233002

Cr-Commit-Position: refs/heads/master@{#294163}

https://chromium.googlesource.com/chromium/blink/+log/977198858f80a88d01b202011bae58ad68fc988a..d500af4bd27fde579b1dfbe4f2a42c93ec702066
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/563483002

Cr-Commit-Position: refs/heads/master@{#294162}

R=pkl@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/538613005

Cr-Commit-Position: refs/heads/master@{#294161}

This adds braille tests that excercise functionality that run in the background page, with the exception of an integration test that tests the message passing between content scripts and the background page for braille.

BUG=371692

Review URL: https://codereview.chromium.org/484063003

Cr-Commit-Position: refs/heads/master@{#294160}

https://chromium.googlesource.com/chromium/blink/+log/ce96a0374d10cad656dcf95e283e74c5369656d8..977198858f80a88d01b202011bae58ad68fc988a
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/556223002

Cr-Commit-Position: refs/heads/master@{#294159}

BUG=381584
TEST=unit_tests:DeviceOAuth2TokenServiceTest.*

Review URL: https://codereview.chromium.org/552363002

Cr-Commit-Position: refs/heads/master@{#294158}

This CL moves code from chrome/ (ChromeTranslateClient) to the
translate component (ContentTranslateDriver).

BUG=331509

Review URL: https://codereview.chromium.org/558663003

Cr-Commit-Position: refs/heads/master@{#294157}

We need to check this in DocumentThreadableLoader not to send CORS preflight requests to the ServiceWorker.

Blink side is implemented in https://codereview.chromium.org/546263002/.

BUG=411151

Review URL: https://codereview.chromium.org/553603002

Cr-Commit-Position: refs/heads/master@{#294156}

https://chromium.googlesource.com/chromium/blink/+log/a35fa45e4848392d9d768ec88c7931d5099c1df4..ce96a0374d10cad656dcf95e283e74c5369656d8
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/562553002

Cr-Commit-Position: refs/heads/master@{#294155}

https://skia.googlesource.com/skia/+log/8247ec313d87afcdd4da59b1f2f0d24e0983e359..1e3dad0b17e9f240e4a061208d5368e20527bede

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/559953002

Cr-Commit-Position: refs/heads/master@{#294154}

This adds a new build rule for generating Java constants for C++ enums.

BUG=405532
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/484603004

Cr-Commit-Position: refs/heads/master@{#294153}

BUG=411521

Review URL: https://codereview.chromium.org/552713002

Cr-Commit-Position: refs/heads/master@{#294152}

skip_service_worker flag was introduced in https://codereview.chromium.org/527713002/.
But setting this flag of RequestExtraData in RenderFrameImpl::willSendRequest() is looks weird.
This flag should be in RequestInfo and should be set in WebURLLoaderImpl::Context::Start.

BUG=402093

Review URL: https://codereview.chromium.org/547213002

Cr-Commit-Position: refs/heads/master@{#294151}

Revert of ReReland ServiceWorkerCacheStorage::Keys function (patchset #3 id:140001 of https://codereview.chromium.org/543093003/)

Reason for revert:
Linux Valgrind now passes but ChromeOS Valgrind doesn't.  Looks like I need to do more on TearDown.

Original issue's description:
> ReReland ServiceWorkerCacheStorage::Keys function
>
> Suppression (error hash=#E226F7559AD360E7#):
> For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
> {
> <insert_a_suppression_name_here>
> Memcheck:Leak
> fun:_Znw*
> fun:_ZN4base8internal20PostTaskAndReplyImpl16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEESA_
> fun:_ZN4base10TaskRunner16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEES9_
> fun:_ZN10disk_cache15SimpleEntryImpl13CloseInternalEv
> fun:_ZN10disk_cache15SimpleEntryImpl24RunNextOperationIfNeededEv
> fun:_ZN10disk_cache15SimpleEntryImpl21DoomOperationCompleteERKN4base8CallbackIFviEEENS0_5StateEi
> }
> Original CL: https://codereview.chromium.org/477973002/
> Reland: https://codereview.chromium.org/528233003/
>
> The SimpleCache backend wasn't given a chance to finish up a close operation before the IO messageloop closed at the end of functions.  The tests now run the loop in TearDown.
>
> The original patch is PatchSet1 and the fix is PatchSet3.
>
> BUG=392621
>
> Committed: https://crrev.com/bbfe6ce49b8e99b190085dffbf446b474c5f07ff
> Cr-Commit-Position: refs/heads/master@{#294090}

TBR=michaeln@chromium.org,horo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392621

Review URL: https://codereview.chromium.org/562613002

Cr-Commit-Position: refs/heads/master@{#294150}

Navigating directly to chrome://voicesearch in guest mode is causing
a crash, since the HotwordService is NULL in the guest mode. This
patch adds a NULL check on HotwordService to fix the crash.

BUG=411784
TEST=With --new-profile-management enabled, try to open chrome://voicesearch
in guest mode.

Review URL: https://codereview.chromium.org/554603002

Cr-Commit-Position: refs/heads/master@{#294149}

Media unit tests depending on ffmpeg are currently only removed
using OS=="android", but let's remove them based on
media_use_ffmpeg==0 instead.

BUG=410779
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/541553003

Cr-Commit-Position: refs/heads/master@{#294148}

Potential controllees need to observe version change events to make a ready
registration, but, before this patch, those events are sent not to potential
controllees but to pages that have the corresponding registration object
(to be more precise, pages that have the reference to the registration).

After this patch, ServiceWorkerProviderHost sends an IPC message to the
corresponding ServiceWorkerProviderContext when the host gets associated with
a registration and the provider context retains a reference of the registration
so that the potential controllee can observe the version change events.

1) Blink: https://codereview.chromium.org/476043002/
2) Chromium: THIS PATCH
3) Blink: https://codereview.chromium.org/532653002/

BUG=399533
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py --debug http/tests/serviceworker/ (with the patch (3))

Review URL: https://codereview.chromium.org/477593007

Cr-Commit-Position: refs/heads/master@{#294147}

Embedders may want to apply independent filters on layers for their
browser GUI. If they need two instances of a GUI element then they are
forced to add two layers with the same content in them. In the DRL case
an access to DelegatedFrameProvider needed. With this change embedders
can create secondary DRL layers easily.

https://groups.google.com/a/chromium.org/forum/
    /#!topic/graphics-dev/xZPzMnBe6dg

R=sievers@chromium.org,aelias@chromium.org
BUG=

Review URL: https://codereview.chromium.org/527073002

Cr-Commit-Position: refs/heads/master@{#294146}

TEST=n/a
BUG=none

Review URL: https://codereview.chromium.org/560753002

Cr-Commit-Position: refs/heads/master@{#294145}

R=pkl@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/545433002

Cr-Commit-Position: refs/heads/master@{#294144}

Removing a local variable to keep it in the crash dump, that is added in:
http://crrev.com/c7f0b95fefa64b7bb0accea8aafc3fb819bfdcc7

BUG=393634

Review URL: https://codereview.chromium.org/562493004

Cr-Commit-Position: refs/heads/master@{#294143}

Add support for Cmd- (the universal "cancel" shortcut on Mac) to close print dialog.

BUG=249786
R=dpapad@chromium.org

TEST=
1. Open a web page
2. Hit Cmd-P to bring up print dialog.
3. Hit Cmd- and observe.
4. The print dialog should get closed.

Review URL: https://codereview.chromium.org/555733003

Cr-Commit-Position: refs/heads/master@{#294142}

ServiceWorkerRegistration::unregister returns false when the registration is already unregistered. (2/3)

1. [Blink] https://codereview.chromium.org/549093002/
2. [Chromium] this patch
3. [Blink] https://codereview.chromium.org/550093002/

BUG=390894

TEST=content_browsertests --gtest_filter='ServiceWorkerBlackBoxBrowserTest.Registration'
TEST=content_unittests --gtest_filter='ServiceWorkerJobTest.Unregister_NothingRegistered'
TEST=content_unittests --gtest_filter='ServiceWorkerJobTest.ParallelUnreg'

Review URL: https://codereview.chromium.org/554573002

Cr-Commit-Position: refs/heads/master@{#294141}

These functions used to be called asynchronously, and recently switched to be synchronous.
Then it's more readable to expand them to their caller.

BUG=412367

Review URL: https://codereview.chromium.org/560703002

Cr-Commit-Position: refs/heads/master@{#294140}

Cleanup: Use base/files/file_util.h instead of base/file_util.h in cc/, chromecast/, cloud_print/, mojo/, and win8/

TBR=enne@chromium.org,lcwu@chromium.org,vitalybuka@chromium.org,viettrunglluu@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/559743002

Cr-Commit-Position: refs/heads/master@{#294139}