GitLab

Instead of using simple_mock.MockObject for mocking out subprocess, this CL introduces a MockSubprocess class which is more flexible in handling calls. This way we can avoid the problem of having to know in advance how many calls the profiler will make to subprocess.

BUG=375231

Review URL: https://codereview.chromium.org/294893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272023 0039d316-1c4b-4281-b951-d872f2087c98

Existing IsMimeType is replaced with two methods:
- ParseMimeTypeWithoutParameter: Checks grammar and parses given MIME
  type string
- IsValidTopLevelMimeType: Checks if the given top level MIME type is
  valid one or not

BUG=308768

Review URL: https://codereview.chromium.org/54233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302040
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/298853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162827

Review URL: https://codereview.chromium.org/296813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272020 0039d316-1c4b-4281-b951-d872f2087c98

If the SigninManager won't allow signing in, then showing the button makes no sense. The hotdog menu does much the same thing (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/toolbar/wrench_menu_model.cc&l=583)

Mac implementation to follow.

BUG=372812,310640

Review URL: https://codereview.chromium.org/291843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347424

Review URL: https://codereview.chromium.org/286203007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272018 0039d316-1c4b-4281-b951-d872f2087c98

We want to run menus without aura for the mac port of views.
Add the abstract function widget::SetHasActivationShadow so
that SetShadowType invocations can be changed to no longer
depend directly on aura/wm.

BUG=366007

Review URL: https://codereview.chromium.org/290553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272016 0039d316-1c4b-4281-b951-d872f2087c98

util.isDescendantEntry(entryA, entryB) returns false if entryA and entryB is same, so the directory tree failed to update the directory which is notified to get changed.
util.isSameEntry() is added to the condition.
 
BUG=375595
TEST=manually confirmed.

Review URL: https://codereview.chromium.org/299753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272015 0039d316-1c4b-4281-b951-d872f2087c98

This CL converts all BPF_TEST tests that didn't make use of BPF_AUX to
instead use BPF_TEST_C and a proper SandboxBPFPolicy instead of a
SyscallEvaluator.  Simultaneously, it removes a lot of unnecessary
code that was only necessary to support these tests that don't use
BPF_AUX.

Review URL: https://codereview.chromium.org/289193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272014 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272013 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=no warnings output in existing tests
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/291283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272012 0039d316-1c4b-4281-b951-d872f2087c98

r270786 removed DelegatedFrameHost::GetViewBoundsWithResizeLock, but
that was based on the wrong assumption, which is that the resize lock is
always taken at the same time as when RWHI sends the Resize message,
which is not true.

So, reintroduce that logic, although in a saner way. The RWHV is
responsible for throttling, it should be explicit about having 2 sizes:
1- the size that is set by the UI layers
2- the size that the renderer should be resized to.

They are different when throttling.

(1) stays RWHV::GetViewBounds().size().
(2) is introduced as RWHVBase::GetRequestedRendererSize().

BUG=374885

Review URL: https://codereview.chromium.org/299443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272011 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367243

Review URL: https://codereview.chromium.org/299713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272010 0039d316-1c4b-4281-b951-d872f2087c98

Currently, we don't track line numbers correctly in multi-line C-style
comments (/* ... */) and when there are consecutive lines with (only)
C++-style comments.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/293053011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272007 0039d316-1c4b-4281-b951-d872f2087c98

Previously they did not set an origin or replace_id, causing updates
to be turned into adds in the notification UI manager, where it would
DCHECK because the id matched that of an existing notification.

This patch adds a replace_id and origin so that updates can happen
smoothly.

BUG=360591

Review URL: https://codereview.chromium.org/294473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272006 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: breaks linux compile
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Builder&number=31999

BUG=362979
TBR=ananta@chromium.org

Original CL: https://codereview.chromium.org/296643002

Review URL: https://codereview.chromium.org/298923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272005 0039d316-1c4b-4281-b951-d872f2087c98

Package removed: chromeos-0.0.1
Package removed: iceauth-1.0.4
Package removed: internal-0.0.7
Package removed: libICE-1.0.7
Package removed: libSM-1.2.0
Package removed: libXmu-1.1.0
Package removed: libXt-1.1.4
Package removed: python-updater-0.10
Package removed: xauth-1.0.6
Package removed: xinit-1.3.0
Package removed: xrdb-1.0.9

Package added: bootcomplete-login-0.0.1
Package added: chromeos-bsp-x86-alex-0.0.2
Package added: jsoncpp-0.6.0_rc2
Package added: salsa-0.0.1
Package added: tty-0.0.1

Package updated: GoogleKeyboardInput-keyboards from 1.3.1.2 to 1.3.2.1
Package updated: GoogleKeyboardInput-xkb from 1.0.1.2 to 1.0.3.1
Package updated: autotest from 0.0.1 to 0.0.2
Package updated: bluez from 5.4 to 5.17
Package updated: chromeos-chrome from 36.0.1918.0_rc to 36.0.1985.19_rc
Package updated: chromeos-hangul from 1.1.0.0 to 1.2.0.1
Package updated: chromeos-init from 0.0.21 to 0.0.25
Package updated: coreutils from 8.20 to 8.22
Package updated: exfat-utils from 1.0.2_pre395 to 1.0.2_pre401
Package updated: fuse-exfat from 1.0.2_pre395 to 1.0.2_pre401
Package updated: google-breakpad from 1292 to 1303
Package updated: gtalk from 60800085 to 62219080
Package updated: input-tools from 4.1.0.0 to 4.1.2.7
Package updated: iputils from 20100418 to 20121221
Package updated: libnl from 1.1 to 3.2.14
Package updated: openssl from 1.0.1f to 1.0.1g
Package updated: pepper-flash from 13.0.0.182 to 14.0.0.95
Package updated: perf from 3.13 to 3.14
Package updated: python-exec from 10000.1 to 2.0.1

License removed: Source License iceauth/COPYING
License removed: Source License libICE/COPYING
License removed: Source License libSM/COPYING
License removed: Source License libXmu/COPYING
License removed: Source License libXt/COPYING
License removed: Source License xauth/COPYING
License removed: Source License xinit/COPYING
License removed: Source License xrdb/COPYING

R=davidjames@google.com, vapier@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/292743014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272003 0039d316-1c4b-4281-b951-d872f2087c98

TSAN doesn't comprehend the atomic ref count operation.

BUG=239350
TEST=none
TBR=jyasskin
NOTRY=true

Review URL: https://codereview.chromium.org/294663011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272002 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/293033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374725,358235

Review URL: https://codereview.chromium.org/293993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272000 0039d316-1c4b-4281-b951-d872f2087c98

The changes are to use the GetScaleForScaleFactor function to get the scale instead
of GetImageScale. The latter function returns the current display scale on Windows which
causes themes to break. The other change is in the ctor of the BrowserThemePack class
where we add SCALE_FACTOR_100P to the list of supported scales as it is needed for default
theme packs to work correctly.

BUG=362979
R=oshima@chromium.org, pkotwicz@chromium.org, oshima

Review URL: https://codereview.chromium.org/296643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271999 0039d316-1c4b-4281-b951-d872f2087c98

This removes most references to VarPrivate and InstancePrivate from
OOP PDF. These APIs are deprecated and we'd like to remove them.
In most cases where they are currently used, we can simply switch
to using a PostMessage to communicate with the extension. In the
case of modal dialogs, these need to run synchronously from the
perspective of the PDF engine and so PostMessage isn't sufficient.
Right now these calls still use InstancePrivate but we should switch
to using a specific private API eventually.

BUG=303491

Review URL: https://codereview.chromium.org/286933011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271998 0039d316-1c4b-4281-b951-d872f2087c98

Previously keyboard filters were selected using the per-platform
filename exclusion rules, and that doesn't work for PNaCl plugin. Now
both Mac and ChromeOS filters are compiled into the PNaCl plugin and
selected in runtime.

BUG=276739

Review URL: https://codereview.chromium.org/292103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271997 0039d316-1c4b-4281-b951-d872f2087c98

This handles messages from the plugin that indicate that the page should be
navigated to another URL or that the email editor should be opened.

BUG=303491

Review URL: https://codereview.chromium.org/292653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271996 0039d316-1c4b-4281-b951-d872f2087c98

Currently, if both the main and alternate jobs fail, we mark alternate-protocol as broken. However, that's not really "fair" to the alternate-protocol. We should only mark it as broken in the alternate-protocol jobs fails and the main job succeeds.

This is a bit tricky because the two jobs may complete in any order.

Review URL: https://codereview.chromium.org/245663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271994 0039d316-1c4b-4281-b951-d872f2087c98

In terms of previewing on hover, treat password the same as Autofill.
Functions are introduced to handle when a username selection is hovered over,
password and the selected username are previewed, and cleared once preview is done.
This preview also supports "character matching" preview, e.g. type first few letters
of username in, but without affecting the password "inline autocompletion" feature.

R=isherman@chromium.org, tsepez@chromium.org
BUG=63421

Review URL: https://codereview.chromium.org/208453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271993 0039d316-1c4b-4281-b951-d872f2087c98

- Add HttpUrlRequest callback for querying response headers.
- Always close ReadableByteChannel once an HttpUrlRequest is started.

BUG=354143

Review URL: https://codereview.chromium.org/268353013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271992 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/296703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271991 0039d316-1c4b-4281-b951-d872f2087c98

Makes sure all the other functions are properly scoped.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/292283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271989 0039d316-1c4b-4281-b951-d872f2087c98

This limit is a bit arbitrary and may be getting hit by Google Docs, so double it.

BUG=372909

Review URL: https://codereview.chromium.org/288343007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271988 0039d316-1c4b-4281-b951-d872f2087c98

content/common/content_param_traits_macros.h    to
ui/events/ipc/latency_info_param_traits

This way, code that wants to use LatencyInfo over IPC
don't have to depend on content/common, but a rather
smaller target events.gyp:events_ipc.

Also adds latency_info_nacl.gyp for a nacl build that
wants to use LatencyInfo over IPC.
 
BUG=355719
TEST=no functional change. Chrome builds.

Review URL: https://codereview.chromium.org/291443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271987 0039d316-1c4b-4281-b951-d872f2087c98

Make |DesktopWindowTreeHostX11::use_native_frame_| more robust. In particular, this CL ensures that widgets which expect to use the native frame (e.g. v2 apps, task manager) continue to do so even if DesktopWindowTreeHostX11::FrameTypeChanged() is called.

BUG=348437
TEST=None

Review URL: https://codereview.chromium.org/278823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271986 0039d316-1c4b-4281-b951-d872f2087c98

Port forwarding tunnel test revealed a bug in stream_listen_socket on Windows. The last packet was not delivered to DidRead, DidClose was called instead.

BUG=356617

Review URL: https://codereview.chromium.org/285263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271985 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/293963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271982 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271970 0039d316-1c4b-4281-b951-d872f2087c98

Syncs to head as of bebce653e5601ceafa004db0eb6b2c7d4d16f0c0.  The
roll requires us to stop using some deprecated features:
- Replaces av_get_frame_defaults() with av_frame_unref() per docs.
- Switches FFmpegVideoDecoder to use ref-counted frames.
- Removes error concealment settings and disables error resilience
for all platforms except ChromeOS (since it's required for mpeg4).

Avoiding these also allows us to disable some deprecated features
wholesale via #defines.

BUG=119020,236611
TEST=all tests (and regression tests) pass under asan
NOTRY=true
R=jrummell@chromium.org, wolenetz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271945

Review URL: https://codereview.chromium.org/286953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/296153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271968 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=armansito@chromium.org, kalman@chromium.org

Review URL: https://codereview.chromium.org/275863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271967 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the logic to determine whether the Translate bubble is
to be shown. Before this CL, it is not considered the case when the
contents web view is NOT focused. This CL changes this logic to show the
bubble when the content webview and an input element is focused and the
user is NOT trying to show the bubble explicitly. The latter condition
is checked by GetLocationBarView()->IsMouseHovered() because just after
clicking the Translate icon on the Omnibox, the content web view might
still be focused.

BUG=372755
TEST=manual

Review URL: https://codereview.chromium.org/289983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=armansito

Review URL: https://codereview.chromium.org/294163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271965 0039d316-1c4b-4281-b951-d872f2087c98