- 21 Oct, 2020 40 commits
-
-
Charlie Hu authored
This CL updates a broken feature policy spec link. Change-Id: I1b17e473fa9ce146a97a44ef78a8d2ce1e7fb2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490264Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#819482}
-
Daniel Cheng authored
Bug: 1140588 Change-Id: I0fd8db6f30a42205dafe889043012e3de4a4a2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487827Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819481}
-
Daniel Cheng authored
Bug: 1140588 Change-Id: I6df170a66838d46babbcbf44d48c43dcfbe7e9ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488420Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819480}
-
Victor Costan authored
Bug: 1140147 Change-Id: Iccfaf6221f791673f84052b3916ced02cfd677ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489324 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#819479}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. This is in preparation for adding future methods to KeystoreService that return the same type. Bug: 1127505 Change-Id: Ia96d37301533cde335a38771d067c6054c164535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485347Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#819478}
-
Marek Haranczyk authored
1. Add missing ContentClient initialization in ContentTestSuite in death child process case. Repeater does not notify events to test listeners in death child process by design. 2. Add proper appcache tests teardown to avoid leaking test setup configuration to other test, potentially causing crashes if other tests in batch created response without headers. The config enabled relevant headers checking code, which expects headers to exist. BUG=604078 Change-Id: I05adb10ce30a1324ba2a80054808bd0697feb4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478603Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#819477}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e03bf7b4af92..d86ca92685bb 2020-10-21 thestig@chromium.org Disallow more CFX_ScanlineCompositor conversions. 2020-10-21 thestig@chromium.org Move MakeMaybeAlphaRGBFormat() to the only file where it is used. 2020-10-21 tsepez@chromium.org Rename CFX_DIBBase::IsAlphaMask() to IsMask(). 2020-10-21 thestig@chromium.org Add some unit tests for CFX_DIBBase::GetOverlapRect(). 2020-10-21 thestig@chromium.org Remove 2 CPDF_ImageRenderer::Start() parameters. 2020-10-20 tsepez@chromium.org Pass CFX_BitmapCompositor::m_BlendType to compositor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:11398257 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ifa28ba749cf45f20af4d4227d6b0692ebb0680b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819476}
-
Roberto Moura authored
Create a full screen disabler when the view reveal state is not Hidden and set it no a null pointer otherwise. Bug: 1094335 Change-Id: Ibf01f68cd4b76a3ab507cc5d4bb4935064999403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485156 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#819475}
-
Olivier Yiptong authored
Removes the use of DISALLOW_COPY_AND_ASSIGN for FontManager because this macro is deprecated. Change-Id: Ibd14c06b712cef75885a521003d18d668f256312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488985 Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819474}
-
Daniel Cheng authored
This is useful to be able to call non-const methods on an object owned by a SequenceBound, while disallowing the SequenceBound owner itself from being mutated via Reset() and the like. Bug: 1140588 Change-Id: I32924106c061b4b7916885fc6fe14462b43484e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487822 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Eric Orth authored
Parsing and metrics left as TODOs for now. Bug: 1138620 Change-Id: Id8e8ab3947601276479a0970efd215fe550a1d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473162Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#819472}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ee87b994218e..553115ec991c 2020-10-21 leese@chromium.org Support stepping over and out of inline functions with plugin 2020-10-21 almuthanna@google.com Fix Flickering for Performance profiling test 2020-10-21 andoli@chromium.org [ts] Typecheck data-grid/DataGrid.js with TypeScript 2020-10-21 andoli@chromium.org Make template type of data_grid/DataGrid.js more specific to prepare for migration to TS 2020-10-21 patrick.brosset@microsoft.com Grid: Simplify the label color logic to reduce the bundle size 2020-10-21 alcastano@google.com E2E test for report-only CSP issues 2020-10-21 sigurds@chromium.org Refactor fake issue message to proper class.. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1124712,chromium:1136814,chromium:1139223,chromium:1139906,chromium:1140516,chromium:1140926 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I919d20b03d785c2966b64df7cb0d42da53d9ec97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490362Reviewed-by:
-
rbpotter authored
Bug: 1132403 Change-Id: I5325a3d5c2c8bf9698fc2621cf866fcc50374a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488678 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819470}
-
Chan Li authored
This changes the percentage for both CI and try builders. Bug: 1108016 Change-Id: I8a6e0e97c4f936f25ac2b9e046142bed1e72e793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490337Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#819469}
-
Thomas Lukaszewicz authored
Disable consistently flaky SearchEnginePreconnectorNoDelaysBrowserTest.PreconnectSearch test. See build details below for an example of test failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/56178 Tbr: tbansal@chromium.org Bug: 1141028 Change-Id: I9f8c8c38ef9fba0cbb339f8fb0f41baa76a9dd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490408Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819468}
-
Daniel Hosseinian authored
Specifically, test that: - Focus is forwarded to the thumbnail of the active page when focusing on the thumbnail bar. - Pressing the up/down arrows focuses on the correct thumbnails. - Pressing the left/right arrows changes the page. Bug: 1133840 Change-Id: Id689db821cff3c33e9d3ecee103532c5a3ee4b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485564 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/99f9277c5bcb..6029e464cf93 2020-10-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 3ead01191215 to ea52b3c2d270 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: If42fc2dadf1f193e2fabbc3f11d0e493278786ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489668Reviewed-by:
-
v8-ci-autoroll-builder authored
This is a reland of e95f1520 After talking with the v8 team it seems a similar thing happened last week and a reland worked. Attempting the same thing. Original change's description: > Update V8 to version 8.8.149. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/d82ff002..d9ccb94f > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Ic433b4fc8287a7d664817f18b5d81bada20bb87a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489002 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#819313} Change-Id: I53dd864abe324b150e9de89a364431f608087a98 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490382Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819465}
-
Sylvain Defresne authored
In preparation of supporting arm64 simulator build (for Apple Silicon macs), we need to decouple the fact that a build is a simulator build from the `target_cpu`. This was done by introducing a `target_environment` variable that can be set by the user (the default value is set using the same heuristic based on value of `target_cpu` if unset). Configure the bots to be explicit about setting the variable. Bug: 1138425 Change-Id: Idb54c71bdb979469adc4b2dc6d7a78ef184d57c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489645 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Ryan Sturm authored
Change-Id: Ie4336b9525e256df41bb90aa12120ba8cc39905f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488348 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#819463}
-
Haiyang Pan authored
The config "invert_fieldtrials" was missing. TBR=martiniss@chromium.org Bug: 1099916 Change-Id: Ia32c6d76e85e849471c6ab971afffded9d0c9570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490542Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#819462}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b3ad4f25a17..718e25c7f990 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sebsg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sebsg@google.com Change-Id: If904a35624bcf570254b2886224d5f3e6e1cb152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489667Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819461}
-
Regan Hsu authored
Note that OnShouldShowSetupRequiredUiDismissed() was added for the debug UI control which will be added in a later CL. Bug: 1106937 Change-Id: I0b4915827ec690d3f639177d1189fac74da0220f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488613 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Alex Turner authored
While attempts to get src:local font data (including failures in those attempts) are currently instrumented, it is possible to determine local font existence through other means. In particular, FontFace.load() on a FontFace object with a src:local attribute can be used to do this. (The lookup will succeed if the font exists and result in a network error otherwise.) We therefore instrument any attempt to determine a local font's existence by a unique name lookup. We include attempts to lookup the font's data as that would also reveal existence. Bug: 1136959 Change-Id: I7dcd900c541b3c9e20df353f7fe890b4e9352260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477453Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#819459}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e2cbcc956588..45b6de9149c1 2020-10-21 cwallez@chromium.org Dawn infra: update the primary branch to "main" 2020-10-21 cwallez@chromium.org Trivial grammar fix in README.md If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ie44647bd74ffb4ac0a5283455be3d7509699ae9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490363Reviewed-by:
-
Toni Barzic authored
Removes overview enter exit types that are only used for old tablet mode gestures between home screen and overview: kSlideInEnter, kSlideOutExit, kSwipeFromShelf. Note that kSwipeFromShelf is still being referenced from home launcher gesture handler, but these calls are being removed, too (and are not reachable if IsDragFromShelfToHomeOrOverviewEnabled). BUG=1137452 Change-Id: I31730aa30f0c198538b25a15739d5b4f36078ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482423Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#819457}
-
Ryan Sturm authored
This functionality serves a prefetched response from the search prefetch service when the search terms match from the prefetch vs the current navigtation. Bug: 1138643 Change-Id: Icf326fff7e29158d7c197bab8fdb39f6eb30539f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487875 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Akihiro Ota authored
This change adds an output rule for the mark role. If needed, follow-up patches can build off of this change to support associated aria-details elements. We also add tests to confirm behavior, using sample code provided by the Docs team. This change also adds a check for non-existent braille strings in Msgs.getMsg(), since ChromeVox hits the following error without it: "Invalid ChromeVox message id: role_content_insertion_brl" 'marked content'. Fixed: 1126131 Change-Id: If588b3d018ddcab272a265bb63eb4c6119352781 AX-Relnotes: ChromeVox announces elements with role=mark as Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422252 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819455}
-
Peter Kvitek authored
Adding this switch to headless browser tests ensures that proxy related tests are not affected by a platform specific system proxy configuration service. This fixes HeadlessProtocolCompositorBrowserTest.BrowserSetInitialProxyConfig issues when running on Windows. Bug: 1134929 Change-Id: Ib245a4fe660eacaab944521a56ed9f2d1f525b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489779Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#819454}
-
Ryan Sturm authored
This introduces a few basic checks, but does not robustly handle all corner cases. This also does not handle serving the response, but rather just storing it. Bug: 1138639, 1138640 Change-Id: I9e1698156e717754541a9e18f1316c42326b9949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486454 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
-
Dom Schulz authored
It was only used in manifest install of SWAs, which is being deleted in the parent branch. Bug: 1085274 Change-Id: I8c053f82b4e5186c7336d731b8deafa3dbbb95ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485760Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Change-Id: Ie6ee8bfd51acc8317a0ba243d5924f5f87d39359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489501Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#819451}
-
Roberto Moura authored
The tab grid's new tab button is covered by the BVC when the tab grid is visible and the thumb strip feature is enabled. Nudge the new tab button by a distance equal to the height of the BVC that remains visible when the tab grid is showing. Bug: 1094335 Change-Id: I54d7aa20633e109cf41b6bfe46866cecb23584aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487320 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
-
Jacob Kopczynski authored
Bug: 1114563, 1140587 Change-Id: I8f9fc6c41923e439ff148120fd3b3465f4ceacae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490662 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
-
Peter Boström authored
This reverts commit 81f2d6be. Reason for revert: Relanding without ChromeCleanerDialog changes. Original change's description: > Revert "Use set_fixed_width() in c/b/ui/views dialogs" > > This reverts commit a9b6d2bd. > > Reason for revert: Causing builder to fail. First fail was 8 changes after this. > > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 > > Original change's description: > > Use set_fixed_width() in c/b/ui/views dialogs > > > > Does not address subfolders which will be done in separate chunks. > > > > Bug: 1128500 > > Change-Id: Id3caa97d0d59b4700b888c5bca5f89f69d4c64d1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485148 > > Commit-Queue: Peter Boström <pbos@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Auto-Submit: Peter Boström <pbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819061} > > TBR=ellyjones@chromium.org,pbos@chromium.org > > Change-Id: I0d03cb731d03bf7ba11d836769bd2513c25f1366 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1128500,1140866 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489380 > Reviewed-by: Fergal Daly <fergal@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819259} TBR=ellyjones@chromium.org,pbos@chromium.org,fergal@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1128500 Bug: 1140866 Change-Id: Ica91e35d28972e2bff2ecd963b387d86f4975878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490329Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819448}
-
dan sinclair authored
This CL does a combined roll of spirv-tools and headers to deal with new enum additions. Change-Id: I6a97855ff72f67e906ba22ad5a080c9c2b57ebe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490241 Commit-Queue: dsinclair <dsinclair@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: dsinclair <dsinclair@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#819447}
-
Peter Kasting authored
Bug: 772945 Change-Id: I58e8a596aeeca4a78b981600170c134b52c3a214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488909 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#819446}
-
Esmael El-Moslimany authored
Relanding crrev.com/c/2469401 The issue involved the string ID change. I'm reverting that change and will follow-up with change the string IDs. Revert "Revert "WebUI NTP: add recipe task module"" This reverts commit 54354dde. Bug: 1138011 Change-Id: Ifb657544605eb55f44494dc791b7c5945a3116a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488391 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 1132403 Change-Id: Ia84ffd754058cd44ac0f2210837838c8a1fb5a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488394 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Clark DuVall authored
Component build uses cr.so libraries for DFMs instead of partitions. These will just be included as shared libraries in the base module. Bug: 1126301 Change-Id: I6b7090d0443e809c545d12176058affecd3e0cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490330Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819443}
-
