GitLab

Add weidongg@ and newcomer@ to ash/app_list OWNERS after talking to
xiyuan@.

Change-Id: Icee73a00b2354cd2a7b1d29475d1620dfe1fefbf
Reviewed-on: https://chromium-review.googlesource.com/1195893
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587336}

In this CL, we wire up the migration request and response. The workflow of issue request and parse response are executed in thie CL.

Bug: 852904
Change-Id: Ic58c11116c4cc90b44f555269a7a8f6c89483ed9
Reviewed-on: https://chromium-review.googlesource.com/1189169
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587335}

Much of this code is essentially identical. What remains different is just
a couple syscalls (of which there are many variations in threading_pthreads
already), and the implementations of mutexes and condition variables, which
we hope to remove soon (and so have been left where they are).

Bug: 856641
Change-Id: I7c658a0fe65fb6a3428ff4b215397da410d2233a
Reviewed-on: https://chromium-review.googlesource.com/1195713
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587334}

Bug: b:112925587
Test: locally build and test
Change-Id: I6f9385691196319b693cea98a874c7322c330e1a
Reviewed-on: https://chromium-review.googlesource.com/1192361Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587333}

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I004609fbdc2ca0a831f363448784254a34c47809
Reviewed-on: https://chromium-review.googlesource.com/1191093Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587332}

Adding an additional div container on top of the "customize this page"
dialog can make sure the dialog will close only when we click outside
the dialog. Also, clicking on the disabled option will no longer close
the dialog.

Bug: 874828
Change-Id: Ibe16d3e898feefa716cf09e49a52c8a788de254c
Reviewed-on: https://chromium-review.googlesource.com/1195716Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587331}

Implement Loading Journal for Journal storage, and initialize journal
Storage.

Bug: 877993

Change-Id: I08d08747675f1e17ceddd14572f7dbdd073cc64e
Reviewed-on: https://chromium-review.googlesource.com/1188940
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587330}

TBR=thestig@chromium.org (chrome-side changes to content things reviewed by nasko)

Bug: 560446
Change-Id: Ide985dde1d01949445b6c0d23ebdfbe0ad4330f8
Reviewed-on: https://chromium-review.googlesource.com/1194838
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587329}

+ Update grey 50, 100, 200, 300, 400, 600 to the new color
+ Update blue button corner radius to 4dp
+ Make affecting xml files to use pre-defined text styles

Bug: 849126
Change-Id: I44276c6539d2ac1f30a3bd8dcde1dcfc26b103f7
Reviewed-on: https://chromium-review.googlesource.com/1188456
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587328}

BUG=none
R=huangs@chromium.org
TBR=zmin@chromium.org

Change-Id: I40bbef9829a911fd7c4bece2aebb34a3cb74afb8
Reviewed-on: https://chromium-review.googlesource.com/1195088
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587327}

Bug: 872403
Change-Id: Idcaa05e31b7b039cb957d21b95e06d494727669e
Reviewed-on: https://chromium-review.googlesource.com/1195882
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587326}

This change fixes an issue when calling PostTaskWithTraitsAndReply with a
reply that has an unretained pointer to the member class. Because of a race in
tests, SmbService would be torn down and the reply would be run with a pointer
to SmbService resulting in a crash.

Bug: chromium:757625
Change-Id: Ide6b8dd4e05032c504152fafab88ec561d40e30a
Reviewed-on: https://chromium-review.googlesource.com/1195845Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587325}

Right now at TouchActionFilter::FilterGestureEvent, if there is a
GestureTapDown, we append an "O" into the debug string. This CL makes
it append "O1" if the |scrolling_touch_action_| has value, and "O2"
if it doesn't.

TBR=dtapuska@chromium.org

Bug: None
Change-Id: I71cd23cef21e73add2bb5c3f5ec9af0ca7acb4e6
Reviewed-on: https://chromium-review.googlesource.com/1195812Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587324}

The original metrics are deprecated, and new metrics are recorded according to
the WebAPK's distributor from where the WebAPK is installed. The distributor
could be:
- WebApk.ShellApkVersion2.Browser, WebApk.ShellApkVersion2.DevicePolicy, and
  WebApk.ShellApkVersion2.Other.

- WebApk.Session.TotalDuration2.Browser,
  WebApk.Session.TotalDuration2.DevicePolicy, and
  WebApk.Session.TotalDuration2.Other.

Also add the attribute of distributor in WebApkInfo.

Change-Id: I47bfaae24d0c44135de1eeab283b20fcd0d52f47
Reviewed-on: https://chromium-review.googlesource.com/1191702
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587323}

I ran the test locally a 100 times and could not repro, but I
found we weren't clearing out the dialog reference in the
dismiss calls (just the dialog on dismiss handler), so this
makes it happen always.  This also adds the logic to wait for the
dialog to be null to avoid any races in the android handling of
dialog dismissal.

BUG=878651

Change-Id: Id4ae17479b9e4ad29b67e6fd9da9673ddc8a7ee6
Reviewed-on: https://chromium-review.googlesource.com/1195744Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587322}

This function was only used in a single test which ensured that it was
called. Removing it.

TBR=sadrul for uninteresting chnage (removing unused interface fn) in power_event_observer.cc
TBR=thakis for uninteresting change (removing unused interface fn) in chrome/browser/*

Bug: 835353
Change-Id: Icdd8b073e84f54a43d31d2de1690ed6280c194bb
Reviewed-on: https://chromium-review.googlesource.com/1195671Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587321}

These DCHECK()s cause a crash on login when debug mode is enabled (see
https://crbug.com/878653).

Bug: 878653
Change-Id: Iae62dc0bd75018a175299efbae3cb616ae21bc5c
Reviewed-on: https://chromium-review.googlesource.com/1195931Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587320}

Changed the icon and action link text per spec.

Bug: 852577
Change-Id: I7d3a260ead0d1c0affcbde35a343bacd0f5b34c7
Reviewed-on: https://chromium-review.googlesource.com/1195923Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587319}

I've seen DCHECK failures for on_current_move_finished_.is_null().
After debugging some, I've noticed that sometimes the window
is destroyed (thus in_flight_map_ clears its change_id) before
the callback is called. This means the ongoing window move never
finishes and the next attempt of window move causes DCHECK failures.

Bug: 867074
Test: the new unit test
Change-Id: I9ed2d2b9aa79546c7175024a722c00924eba890d
Reviewed-on: https://chromium-review.googlesource.com/1195659Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587318}

The loaded module key is set the first time a dynamic module is loaded
and never cleared (i.e. it signifies, "has this ever been loaded"),
whereas the active module key is cleared when the dynamic module is
unloaded (i.e. it signifies, "is this currently in use").

Because these key values can change at runtime (in contrast to
BuildInfo information), add a CrashKeys class that can store the
information before the native library has been loaded (where the pure
Java exception reporter will log it manually) and forward it to the
native side afterwards, where Breakpad will automatically take care of
uploading them.

Bug: TBD
Change-Id: Ib67ce32e18dfc8b93be18ff87da06ceeaa450fef
Reviewed-on: https://chromium-review.googlesource.com/1193867Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587317}

https://pdfium.googlesource.com/pdfium.git/+log/5b346563297d..456e9703276d


git log 5b346563297d..456e9703276d --date=short --no-merges --format='%ad %ae %s'
2018-08-29 tsepez@chromium.org Remove FPDFDOC_ prefix from non-public functions
2018-08-29 tsepez@chromium.org Use pdfium::span<> in fpdf_parser_decode.h helper functions.
2018-08-29 thestig@chromium.org Stop using deprecated V8 APIs in CJS_GlobalArrays.
2018-08-29 tsepez@chromium.org Remove FPDFAPI_ prefix from internal cid/encoder functions
2018-08-29 thestig@chromium.org Reduce the number of CFXJSE_ResolveProcessor::GetNodeHelper() calls.
2018-08-29 thestig@chromium.org Move XFA_RESOLVENODE_TagName to xfa_resolvenode_rs.h.


Created with:
  gclient setdep -r src/third_party/pdfium@456e9703276d

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic95e6310a84ea6c58bf51981bc78ab678b1f9395
Reviewed-on: https://chromium-review.googlesource.com/1195863Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587316}

Bug: 853877
Change-Id: Ida1f8e9c1e88d91e6867d461f364e7f5fe298c63
Reviewed-on: https://chromium-review.googlesource.com/1194079
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587315}

Bug: 830892
Change-Id: Ia87628d081cd11f415c56cd067237c4d6536b432
Reviewed-on: https://chromium-review.googlesource.com/1172733Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587314}

Screenshot:
https://screenshot.googleplex.com/my3MWpB2rAv.png

Bug: 874194
Change-Id: Ifff7ae4f4e09c6a1c54c4c4215533ab0e1f78e4b
Reviewed-on: https://chromium-review.googlesource.com/1195811
Commit-Queue: Kristi Park <kristipark@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587313}

Bug: 833047
Change-Id: I72cba5196d54e3233608189df361e6c3790b6e7a
Reviewed-on: https://chromium-review.googlesource.com/1181932
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587312}

This is a continuation of a slow migration from BD to install_static for
brand-specific compile-time constants. There is no behavioral change.

BUG=none
R=nparker@chromium.org

Change-Id: I0a93a2887372b2e89288882a9fae303939673936
Reviewed-on: https://chromium-review.googlesource.com/1195816Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587311}

Bug: 806868
Change-Id: I401e37f930e5f729cd3e5f5977aca1472afa4eed
Reviewed-on: https://chromium-review.googlesource.com/1195431
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587310}

The flakiness for this test was due to https://codereview.chromium.org/1324913002/
on Linux.

BUG=129235

Change-Id: I8f68d3d8d1b781a0b51aa3a60877bb2aa577dea5
Reviewed-on: https://chromium-review.googlesource.com/1195793
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587309}

QuicAllowed and Http09OnNonDefaultPortsEnabled are not part of
android policies. See https://www.chromium.org/administrators/policy-list-3.
On desktop, they are retrieved from the policy service.
On Android, we are planning to run ServiceManager only without the browser
process. As a result, calling policy_service() doesn't work when that is
enabled.
This CL simply disables the code on Android, so we won't need
to worry about them when creating default network context without
browser process.
If later on these policies are enabled to Android, we can add them to a
persistent pref store, which can be loaded without browser process.

BUG=866028

Change-Id: Ie992d072ff26e085f236817e7a7f08c5bb8b3cba
Reviewed-on: https://chromium-review.googlesource.com/1195794Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587308}

Adding in product help for homepage tile pinned as the first Most
Visited Tiles when NTPButton is enabled.

Change-Id: I38d9a0bacccb892824b1a9adf22b46b1bd597797
Reviewed-on: https://chromium-review.googlesource.com/1188595
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587307}

Add AuthenticatorRequestClientDelegate::DidFailWithInterestingReason
that informs the embedder when the request being serviced by
AuthenticatorImpl fails because of either:
 -- timeout,
 -- the key already being registered for MakeCredential,
 -- the key not being registered for GetAssertion.

Bug: 866601
Change-Id: Id018033c0b306a14ebf33d307ab8c69f7d8ad96d
Reviewed-on: https://chromium-review.googlesource.com/1195490Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587306}

Add UMA to record the count of subresources whose loading is blocked
as well as their loading priority.

Change-Id: I2c6677060a9b46d75a5522bb277b39cb0f21f93b
Bug: 878129
Reviewed-on: https://chromium-review.googlesource.com/1195111Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587305}

AppListItemView got a new selection highlight, update the context menu
anchor bounds to match.

Also refactor slightly to prevent this error in the
future.

TEST=manual

Bug: 878161
Change-Id: I35649e9262925b45db8fcd801e8913d7111654b4
Reviewed-on: https://chromium-review.googlesource.com/1194995Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587304}

https://chromium.googlesource.com/catapult.git/+log/7dfd811ec106..8972cd776e13


git log 7dfd811ec106..8972cd776e13 --date=short --no-merges --format='%ad %ae %s'
2018-08-29 dtu@chromium.org [pinpoint] Add temporary mapping from Buildbot to LUCI builders.
2018-08-29 simonhatch@chromium.org Pinpoint - Escape names when creating test path
2018-08-29 simonhatch@chromium.org Reland "Pinpoint - Include doc link in bug comment."
2018-08-29 pasko@chromium.org dashboard: replace assert_called_once()
2018-08-29 zmo@chromium.org Remove node_runner from telemetry isolate
2018-08-29 dtu@chromium.org [pinpoint] d3-based heatmap and histogram.


Created with:
  gclient setdep -r src/third_party/catapult@8972cd776e13

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:790075,chromium:863861,chromium:878777,chromium:872521
TBR=sullivan@chromium.org

Change-Id: I17642df1db4953b723db72b7b52caaf3a97d8538
Reviewed-on: https://chromium-review.googlesource.com/1195862Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587303}

Bug: 877690
Change-Id: Ideeb349eed59c8b2106894b6d4f9971f3ea702f8
Reviewed-on: https://chromium-review.googlesource.com/1194872Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587302}

Per change in product requirement, toggling Assistant should have
different behavior depending on state.

Previously:
- When visible, toggling would close Assistant.
- When invisible, toggling would show Assistant.

Now:
- When invisible, toggling will show Assistant.
- When minimized, toggling will expand Assistant.
- Otherwise, toggling will close Assistant.

Bug: b:113279161
Change-Id: Id2e39f495711d6b12e938c3c76576603d2f2df3b
Reviewed-on: https://chromium-review.googlesource.com/1195817Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#587301}

VR Scrolling tests want to know about all page offset changes, whether
or not these impact browser UI. To allow for this in tests, we now call
WebContentsUtils.reportAllFrameSubmissions.

Change-Id: If3dd017b0709b1f0719e81129af7e2b94aa1d11a
Reviewed-on: https://chromium-review.googlesource.com/1194332Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587300}

tooltip_controller_unittest and window_reorder_unittest mostly just
work with mus. There are a couple of things that need to be disabled, but
for the most part they just work.

Also adds comment as to why some tests are not in views_mus_unittests.

BUG=NONE
TEST=this is a test only change

Change-Id: I198894fe7b8b7ca08d826ba2db2af1bde0e0a274
Reviewed-on: https://chromium-review.googlesource.com/1195815Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587299}

Prevents an issue once enabling SMB by default where the SmbService
ctor runs before the DBusThreadManager is properly initialized. This
only happens during tests.

Bug: chromium:757625
Change-Id: Id25265a7a9b763c5ea1ab59106df366dda4fd309
Reviewed-on: https://chromium-review.googlesource.com/1195644Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587298}

TBR=cbiesinger@chromium.org, kojii@chromium.org

Bug: 591099, 635619, 797591, 864156
Change-Id: Ibb3e27415a4b1e32055c9f2d156d3f36ca676085
Reviewed-on: https://chromium-review.googlesource.com/1194368Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587297}