- 10 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ff8b3f439723..f15fc26d5bf5 git log ff8b3f439723..f15fc26d5bf5 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@f15fc26d5bf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I74ba296e3592eee0d245d9af0fb3ac55436a05e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960487Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723421}
-
Michael Spang authored
../../chromecast/media/cma/backend/android/java/src/org/chromium/chromecast/cma/backend/android/VolumeMap.java:173: warning: [MultiVariableDeclaration] Variable declarations should declare only one variable float dbLeft = dbMin, dbRight = dbMin; ^ (see https://google.github.io/styleguide/javaguide.html#s4.8.2.1-variables-per-declaration) Did you mean 'float dbLeft = dbMin;float dbRight = dbMin;'? 1 warning Bug: b/145737017 Change-Id: I78ce6063a36e86a6959e013a480a863792bfdc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959797 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Michael Spang <spang@chromium.org> Reviewed-by:Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#723420}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=gogerald@chromium.org Bug: 1023677 Change-Id: I8ab6717f2361191bf63b2cf74d0e092bdcbf65f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957552 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#723419}
-
Michael Thiessen authored
It's easy enough to know and set the process type statically early on in startup, and not require callsites into the LibraryLoader to know which process they're running in if they otherwise don't care. Bug: 783819 Change-Id: I03e2a34a3e78cd06d5ceb1b958c4b2c15c802e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944313Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#723418}
-
Liquan (Max) Gu authored
Issue: in PageInfoController, holding mContext is dangerous, because WebContents' reparenting could cause mContext and mWindowAndroid to be mismatched. Change: Remove mContext as a member of PageInfoController. Instead, get context from mWindowAndroid when needed. Bug: 999196 Change-Id: I373a1babdcb321b7d135f9eb22544e0b61fa675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960485Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#723417}
-
Annie Sullivan authored
Change-Id: Ice42c58f9e23beefcf7ad11220844211d679f717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959801 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#723416}
-
danakj authored
The callback given to it is run once, with an id. R=avi@chromium.org TBR=servolk@chromium.org Bug: 1007763 Change-Id: I5ecac2ffc1cf72caf690f8540bcc40e3b9aac00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960546Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#723415}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab09a60e40ad..a58b81f6720d Created with: gclient setdep -r src-internal@a58b81f6720d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iafd31a716fa38a69cf287a97bca2451558622c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959543Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723414}
-
Marc Treib authored
Before this CL, when FCMInvalidationServiceBase triggered an InstanceID (aka client ID) deletion, it didn't actually clear its |client_id_| member, and it didn't propagate the deletion to its clients (via the InvalidatorRegistrar). This CL fixes these two things. This *probably* didn't really have consequences in practice: Only the SyncEngine actually used the InstanceID (for reflection blocking), and in this case it anyway gets shut down as well. Still, let's not keep obsolete IDs around. Bug: 1028761 Change-Id: I5c09aff83845bebab1b4fb6b7d8fd963ae91501f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954475 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#723413}
-
Piotr Bialecki authored
Fixes XRObjectSpace::MojoFromNative() returning incorrect (inverted) results. Fixes XRSession::CreateAnchor() incorrectly assuming that passed in initial pose is expressed relative to mojo, and creating resolver too early in the method. Other minor refactorings: - XRHitTestResult::getPose() - no functional changes, clarified naming - XRObjectSpace now assumes that T has MojoFromObject() method - Changed XRPlane and XRAnchor - renamed poseMatrix() to MojoFromObject() to match the changed expectations in XRObjectSpace. Fixed: 1032070, 1031684 Change-Id: I5aeefec31c2f501c56cff5b419af9bdff3eb1159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958428 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#723412}
-
Ian Kilpatrick authored
This builds on previous changes to (finally!) add the correct static-positions within the NGFlexLayoutAlgorithm. This takes into account the main-axis, and cross-axis alignment/justification - and converts it to the correct inline/block axis. As we may not know the final block-size when we encounter an OOF-positioned node, we "adjust" this within the fragment builder once known. This is important for block-end/block-center aligned OOF-positioned nodes. Bug: 845235 Change-Id: I45c89ae1f676ec06d742b86e4b744cfc3dbe6f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841245 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#723411}
-
Mark Cogan authored
To reduce usage of TabModelList, this CL removes all but two code paths in the new_tab_page_uma:: helpers that map a browserState to a single active WebState. new_tab_page_uma::RecordAction now takes a WebState by default. In cases where there isn't one to pass in, the deprecated (prior) version of the function uses TabModelList to find the active WebState of the TabModel associated with the current BrowserState. The two remaining code paths for RecordAction that don't pass a WebState are from ReadingListCoordinator (which doesn't yet have a Browser passed in) and HistoryTableViewController (likewise). Bug: 1032550 Change-Id: If0eee5c2fceed08357d806e973ce53e027d6ea2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960308 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#723410}
-
Carlos Knippschild authored
Update the articles suggestions' header to show a Google branded title when a non-default search engine is selected. This is to make it clear to users that even though the search engine is different, the suggested content is still being provided by Google. Bug: 1031288 Change-Id: I550176d03ef9d9eeff442157a780467e5b2bc6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959628 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
TBR=kojii@chromium.org Bug: 1025630 Change-Id: Iece505df711ba7d9c4b259df1bff81954781840d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959845Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#723408}
-
Tobias Sargeant authored
Creation of the Android SharedPreferences object causes disk I/O. Because there are execution paths that need that object on the UI thread it makes sense to prewarm it in parallel during initialization. Before creating a mechanism for off-UI-thread initialization work, just initialize the object directly (with StrictMode violations suppressed). Bug: 1029524 Change-Id: Ib2ea9e3ce9f4a84aceace95ce058dd0eeadf063f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959032Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#723407}
-
kylechar authored
Since the VizDisplayCompositor feature is always enabled now we no longer need tests for the path when it's disabled. Also don't enable the feature with ScopedFeatureList since it's already enabled. Bug: 844469 Change-Id: Id550e68dfc5aca25c265794a4557ad023cb41690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960391 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#723406}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=estark@chromium.org Bug: 1023677 Change-Id: I727b8a7caa8316441c9f496699db2312b8e988fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957551 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#723405}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f880a70cb757..d9b33e92da7f git log f880a70cb757..d9b33e92da7f --date=short --first-parent --format='%ad %ae %s' 2019-12-10 aerotwist@chromium.org Migrates emulation/ to esm Created with: gclient setdep -r src/third_party/devtools-frontend/src@d9b33e92da7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I65805d86f9a40ce9bce0112e9cd82c9d7640273a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959539Reviewed-by:
-
Henrique Nakashima authored
Also make a few minor changes to SharedPreferencesManager to avoid checking if a key is used twice in the same call. Change-Id: Ie25c5fa3ec21d99d18908ea7a9df3cde6a3051ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955909 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#723403}
-
Gauthier Ambard authored
The workaround was needed for iOS 11, it can be removed now. Fixed: 770914 Change-Id: Id55ab7f8093c3ba4b5c45fd30c12c1ffd2c15050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958995 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#723402}
-
danakj authored
Use OnceCallback where possible, otherwise rename to RepeatingCallback and BindRepeating. R=avi@chromium.org Bug: 1007763 Change-Id: I06c210dafc3066d4b26da90e484d3099dcf28b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958891 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Majid Valipour authored
Add a PRESUMIT check that ensures when the user has updated css_property_id.mojom they are also updating the enums.xml accordingly using the expected python script. The check is similar to the one in web_feature/PRESUMIT.py. Also removed a defunct PRESUMIT in core/frame that was trying to check the validity of max value. We no longer need user to manually enter max value so this is no longer needed. TEST = manually added a new entry in mojom file and not ran the script. presubmit check detected this with the following warning. Then running the script made the warning go away. ** Presubmit Warnings ** MappedCSSProperties enum has been updated and the UMA mapping needs to be regenerated. Please run update_use_counter_css.py in src/tools/metrics/histograms/ to update the mapping. third_party/blink/public/mojom/use_counter/css_property_id.mojom Change-Id: I357bad58682c8ac50d67f4929da5e9bca7c08554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755413 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#723400}
-
Kurt Horimoto authored
TBR=rohitrao@chromium.org Bug: none Change-Id: I547ed0d1a48fc2a330b570242b098d37969b3d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955601 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#723399}
-
Evan Stade authored
Bug: 268984 Change-Id: I20f24122630f106c66cf8af40cb373124678f1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955811Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#723398}
-
Luca Hunkeler authored
Bug: b/145898741 Change-Id: I2f80ce42d903b5c2df9a83f66fbd964127e41c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959971Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#723397}
-
Becca Hughes authored
This reverts commit 73087ef3. Reason for revert: Possible cause of deterministic build break https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/26024 Original change's description: > bind-gen: Implement [Reflect] and [ReflectOnly] family > > Bug: 839389 > Change-Id: I7dab0d16f191a89f955203c779bd4882a66594eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956971 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723357} TBR=peria@chromium.org,yukishiino@chromium.org Change-Id: Ia90b13f966854be9823d4b2d6cd12017ae9862cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960670Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#723396}
-
Peter Boström authored
This code is super-dead (no call sites) since r723360 and was effectively dead even before. Bug: None Change-Id: Ide433205873285a783efa4dc8a07185d66b6021b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959804 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#723395}
-
Gordon Guan authored
Bug: 1014513 Change-Id: I6ed9920decd9aa79267c7875edccca36ab03517a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956027Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Gordon Guan <gordonguan@google.com> Cr-Commit-Position: refs/heads/master@{#723394}
-
Mikel Astiz authored
Interface TrustedVaultClient is now implemented specifically for Android where the calls to fetch keys need to reach Java, where a embedder-specific logic should be integrated. The write path (i.e. TrustedVaultClient::StoreKeys()) is marked as unreachable because the codepath is unused on Android, and in fact the only real calling site (SyncEncryptionKeysTabHelper) is not even built. Bug: 1012659 Change-Id: I02e0b331f4cfd50cff0ff6f0af0e3dfe44601ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950993 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#723393}
-
Finnur Thorarinsson authored
This CL adds a circular background to the Zoom icons (on top of the navigation_bubble_shadow). The circular background supports Dark mode (is gray when Dark mode is enabled, and white when not). Bug: 656015 Change-Id: Ibf91c607add40be77807b88f66a7ed82f2955266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959031 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1dc90350c4e57acc99575912cc6f2e0c17a60687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959538Reviewed-by:
-
Abhijeet Kandalkar authored
The goal of this CL is to clean the element.h file and remove DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION to adopt new downcast helpers. This CL removes DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION for - HTMLFormControlElement, - HTMLFrameElementBase, - HTMLPlugInElement, - HTMLMediaElement Bug: 891908 Change-Id: Ia8d6ede04931b596fe347e59cca0dc15bfbee335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959912Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#723390}
-
Wez authored
Bug: 1025372 Change-Id: I0489b76bf859ab097f5c4e62a55938cbdd7064e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957174 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#723389}
-
Mark Cogan authored
There is no longer a cast service to initialize, so the cast service init can be removed from the provider. This also removes use of TabModel in the provider API. Change-Id: If618ff507104bfdd41d38b01cd9ec7087a7e66e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960450 Commit-Queue: Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723388}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jkarlin@chromium.org Bug: 1023677 Change-Id: I6584031bf0f103e6036009dfcac49b5541bce09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957550 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723387}
-
Philipp Hancke authored
adds webrtc-internals support for pc.onicecandidateerror so that it shows up in webrtc-internals dumps BUG=webrtc:3098 Change-Id: I671e59d8f7b634896f89445c90e274e7c18449bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959965Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#723386}
-
Abhijeet Kandalkar authored
The goal of this CL is to clean the element.h file and remove DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION to adopt new downcast helpers. This CL removes DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION for - SVGSMILElement, - SVGFELightElement, - SVGGeometryElement, - SVGGraphicsElement, - SVGPolyElement Bug: 891908 Change-Id: I8c9a76272baa2d8a911ea60d57f263b142301e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958425Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#723385}
-
Mihai Sardarescu authored
This CL removes the account mappings from the GCMStoreImpl during the migration of the CoreAccountId from email to a Gaia ID. This is required as the key of account mapping map stored on disk which was based on the email does not correspond to the account ID once the identity manager starts using Gaia IDs as the identifiers of an account. Bug: 1028505 Change-Id: Ie4470d4f36a1fc7e15d488daf1ca5919932fd02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954020Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#723384}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d1980c3a28d4..b2f0eb83d735 git log d1980c3a28d4..b2f0eb83d735 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 vapier@chromium.org portage_util_unittest: drop fileinput usage 2019-12-10 achuith@chromium.org chrome_chromeos_lkgm: Add abandon message. 2019-12-10 achuith@chromium.org chrome_committer: Refactor arg passing. 2019-12-10 achuith@chromium.org cros_flash: Allow cros flash to be run from simple chrome. 2019-12-10 ahassani@chromium.org common_util.py: return string from GetFileSha256 2019-12-10 matthewb@google.com licensing: Delete obsolete section of licenses.py module docstring. 2019-12-10 matthewb@google.com licensing: Update some URLs and wrapped lines. 2019-12-10 vapier@chromium.org cbuildbot: drop build_before_patching/do_not_apply_cq_patches 2019-12-10 sanikak@chromium.org auto_updater: Modifying FixPayloads() method for LabTransfer usecase 2019-12-10 andrewlamb@chromium.org Add function to get package root in source tree. 2019-12-10 achuith@chromium.org path_util: Default to os.getcwd() 2019-12-10 vapier@chromium.org trybot_patch_pool: delete unused FilterGitRemoteUrl 2019-12-10 saklein@chromium.org Sdk/Update example input: Remove second board. 2019-12-09 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-09 achuith@chromium.org flash_unittest: Use better mock for os.path.exists 2019-12-09 vapier@chromium.org cbuildbot: drop unused Chrome PFQ modules 2019-12-09 vapier@chromium.org run_tests: clear root owned cache files 2019-12-09 saklein@chromium.org Build API: Add synced directory mechanism. Created with: gclient setdep -r src/third_party/chromite@b2f0eb83d735 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I9ab4f3f96b5e304d4ce3baef65dc540c3b20a067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960396Reviewed-by:
-
jongdeok.kim authored
This CL enables to increase/decrease gfx::Size by gfx::Insets. Addition/subtraction(assignment) operators are added to gfx::Size. size() method is also added to gfx::Insets. Change-Id: I03f57ccf3447d6b06857ce358a3433dd61148180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913235 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#723382}
-
