GitLab

This CL creates a sandboxed service that hosts the Speech On-Device API
(SODA). It contains the components required to launch the service from
the renderer process, but the implementation of the service itself is
stubbed out. The design document for the feature is located at:
go/chrome-live-captions.

Bug: 1045043
Change-Id: I2411865457e1b7864f1b4a327d776932caf3132c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017563
Commit-Queue: Evan Liu <evliu@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747915}

Rotating the screen could cause UI issues with cookie controls card if
the screen is big enough for resizing. Set the width dynamically based
on this.

Bug: 1040091
Change-Id: Ieaf39b55662953db7dbeb05c954b8a32e148e1d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089904Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747914}

Bug: 1052460
Change-Id: Id3d82593c2cd0a54f6f5df5a9cea65838f14fd8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089981Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@google.com>
Cr-Commit-Position: refs/heads/master@{#747913}

Bug: 1054072
Change-Id: I0a22eb181959ad7df708119df282643c536f3098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082020Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747912}

https://skia.googlesource.com/skia.git/+log/7e46b14d8494..24a8e9e170f7

git log 7e46b14d8494..24a8e9e170f7 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 robertphillips@google.com Reland "Update skpbench's DDL timing"
2020-03-06 robertphillips@google.com Remove bot to record DDL creation time
2020-03-06 jvanverth@google.com Remove invalid assert
2020-03-06 robertphillips@google.com Allow a non-FBO0 surface to be matched with an FBO0 rendertarget proxy
2020-03-06 dmazzoni@chromium.org Add marked-content ID to PDF images
2020-03-06 martin@mainframe.co.uk set lib_switch to empty for the msvc toolchain
2020-03-06 robertphillips@google.com Revert "Update skpbench's DDL timing"
2020-03-06 borenet@google.com [recipes] Minor import cleanup
2020-03-06 reed@google.com Land a testable raster backend for per-vertex-data vertices.
2020-03-06 jvanverth@google.com Add GrD3DResource.
2020-03-06 mtklein@google.com disable command buffer on iOS g3 builds
2020-03-06 egdaniel@google.com Remove SkImage getTexture call.
2020-03-06 scroggo@google.com Split building encoding from decoding
2020-03-06 robertphillips@google.com Update skpbench's DDL timing
2020-03-06 martin@mainframe.co.uk fix print functions for python3 gn scripts

Created with:
  gclient setdep -r src/third_party/skia@24a8e9e170f7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:607777
Tbr: herb@google.com
Change-Id: Ice3918309707345d484612994ac488f59c1b128e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092081Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747911}

Feed and Zine share two prefs, but these pref strings are currently
duplicated. This CL makes the pref sharing explicit.
I'm making this change now because I want a feed/core test to use these
prefs.

Bug: 1044139
Change-Id: I9917863385cf0c521ad10e2d6d3913b94f107354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025638Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747910}

This can be useful if a bit of data serialized at the end is optional;
instead of having to encode an explicit boolean flag, the deserializer
can simply consult ReachedEnd().

Bug: 1055911
Change-Id: Id92bfa5ffbdd0c309367417ed12444eff2d94cb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091715
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747909}

https://chromium.googlesource.com/angle/angle.git/+log/e8883562ef57..1a5c7a16ba71

git log e8883562ef57..1a5c7a16ba71 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 tobine@google.com Reland "Vulkan:Include precision qualifier in GLSL"
2020-03-06 julien.isorce@chromium.org Instantiate rx::DisplayEGL when device type EGL is selected
2020-03-06 geofflang@google.com Fix GN warning about unused variable when angle_enable_commit_id=false
2020-03-06 ianelliott@google.com Generate new compiler errors for array-of-arrays

Created with:
  gclient setdep -r src/third_party/angle@1a5c7a16ba71

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: ianelliott@google.com
Change-Id: Ibc5d9905bceddc0ecac4b9439be58fa2e8470b6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091684Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747908}

Bug: 1044687
Change-Id: I1161682a841c05fd5854f77e4b0db127356ae037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087956Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747907}

They were to evaluate paint performance with the cost of
GraphicsContext or DisplayItem constructor excluded. They were
meaningful when we developed the early versions of display-item-based
painting (Slimming Paint V1), but seem to provide little value
nowadays.

Change-Id: I7b2ebf90364c51cf65ed1b65cd376e0eafdd7df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090760
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747906}

This CL adds a RemoteCommand field to HeartbeatResponse and make the
host restart with a REMOTE_RESTART_HOST offline reason when a RESTART
command is received.

Some refactoring has been done to make code more readable.

Bug: 1058988
Change-Id: I1dec66fd718176fb6cfe6257f86d8d2a3db1fe02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090876Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747905}

This change updates QuotaTemporaryStorageEvictor::time_of_end_of_last_round_
so that the above mentioned metric can be logged.

Bug: 994911
Change-Id: Ic191592615018381738c2e64709855828677e7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088640Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747904}

Launch bug: crbug/1011334

Bug: none
Change-Id: I764fea997d4296b228826df49c8773bcb7675988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089778Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#747903}

This adds support for giving flags a predetermined value. This won't
have any noticeable effect yet because the only flags with values are
finch-related, which are queried either:

- early in startup, before dev UI applis flags
  (https://crbug.com/1059131), or
- in the :webview_service process, which the flag UI doesn't currently
  support (https://crbug.com/1058189)

This does not support applying parameters to base::Features, since this
isn't supported through the basic base::Feature API (it's Finch-specific
functionality).

Bug: 1047493
Test: run_android_webview_junit_tests -f *FlagOverrideHelperTest#*
Change-Id: I773014bea72b4b7156d9e094b431f4fc1e7d0257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090882
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747902}

Latest spec: https://immersive-web.github.io/anchors/

- remove last changed time from anchor object
- anchor space is not nullable on anchor object now
- anchor objects are not created in zombie state anymore - when anchor
  creation promise resolves, it should receive a fully built object
- XRAnchor got simplified due to the above
- XRFrameProvider needs to make sure that JS promises can run between
  presentation frame update and rAF callbacks so that the app has a chance
  to see newly created anchors before they are delivered to it via
  XRFrame.trackedAnchors

Changes: 
Change-Id: If582552907274d472097f7d7b119bb7ee216736e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085701
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747901}

These csv files were prone to causing merge conflicts.
As the bug link shows, these have been replaced by a
Google Apps Scripts solution that writes the data
directly to Google Sheets.

See go/chrome-benchmarking-sheet to see the replacement.

Bug: 1054000
Change-Id: If43f4b9f38d17adca57d9ed4db7f1ec4aa59483e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092060
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747900}

What: Some callers to IsAdScriptInStack know the ExecutionContext that
triggered the event. Those callers should pass the context in to
IsAdScriptInStack as there is a small cost to looking it up.

Why: Some callers (such as core_probes) call frequently and looking up
the ExecutionContext when it's already known only slows things down.

Bug: 851531
Change-Id: Id8eadfc9855cdda0d18df34a4829dd47e31ac64f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090232
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747899}

Instead have a separate nataive_file_system_dialogs.h file for these methods.

Bug: none
Change-Id: I3c752c604cd29d4f7703503673b9b8530a04cd20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091724Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747898}

Add rule limits for regex rules. Initially we are going with a limit of
1000 rules applied separately to the extension's static and dynamic
ruleset.

BUG=974391

Change-Id: Ifdeca957ebf5fb85310fff64d96e545c1deb9e4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016201
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747897}

This is similar to crrev.com/c/2040060.

I still don't have a repro for this crash, but the stack trace indicates that it's receiving an index that is out of bounds.

Similar to in crrev.com/c/2040060, the change at line 2727 is to match previous behavior from before the crash: https://chromium-review.googlesource.com/c/chromium/src/+/1999088/10/chrome/browser/ui/views/tabs/tab_strip.cc#b1081

The addition at line 2742 is to catch any other possible -1s, since I don't have a repro.

Bug: 1049240
Change-Id: I86baec38039cfac7b4d96815ffbbe14f01efa555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091594Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747896}

https://quiche.googlesource.com/quiche.git/+log/c3316f30c075..a66f68433ddd

$ git log c3316f30c..a66f68433 --date=short --no-merges --format='%ad %ae %s'
2020-03-06 fayang gfe-relnote: In QUIC, let GetMinAckFrameSize use actual ack_frame instead of passed in largest_observed_length. Protected by gfe2_reloadable_flag_quic_use_ack_frame_to_get_min_size.
2020-03-05 danzh gfe-relnote: move stop/start accepting new connection feature from GfeQuicDispatcher to QuicDispatcher. Protected by --gfe2_restart_flag_quic_should_accept_new_connection.
2020-03-05 dschinazi Add --quic_versions to QuicToyServer and improve version parsing

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I8d3bf48892dcfb8e8ffce8c62f4d7f244bd7067f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091221
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747895}

This CL adds user Actions for closing or tapping "Restore". These
actions are helpful for Breadcrumbs feature that attaches steps to
reproduce to crash reports.

Bug: 1046231
Change-Id: I536c0de815a0bc0e4b14afe3c35ff06bc14474ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089860
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747894}

This plumbs the origin policy IDs from the net-side OriginPolicyContents
through to the renderer, where they get exposed on Window. This does not
yet tackle WorkerGlobalScope, but it does add idlharness tests for it,
which fail for now.

Bug: 1057123
Change-Id: Ie611f03bab99ccdaa6221733d9305cf2323a129e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089994
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747893}

Media History needs to support incognito
for Media Feeds. For an OTR profile we
allow reads from the original profile but
no writes.

BUG=1051239

Change-Id: I03d152d6701ef034d4ce05d9970c64c720b22011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091592Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747892}

Change-Id: Ia1da9ea77ada858a8d8e8b502e993257a2e2fda8
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092124Reviewed-by: David Maunder <davidjm@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747891}

Currently, the tab_strip_index is not set allowing the
tab_strip_model_order_controller.cc to decide on where to insert the tab
(which is currently based on the last active index). This can insert
a tab in the middle of a tab group breaking group continuity.

Bug: 1049195
Change-Id: I9a7f7cacdcb01845cd736818bc07d0efc9a594e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080079Reviewed-by: Charlene Yan <cyan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747890}

This relands 5c7bccda but with a
fix for the transitive Context reference in FragmentWindowAndroid.

Bug: 1057127,1056468
Change-Id: Iad9f0f3ba68319de160a9645f66c2972811104f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081254Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747889}

- Don't alias namespaces in header files as per
  https://google.github.io/styleguide/cppguide.html#Namespaces
- A few iwyu cleanups.
- Use AddAllocated to pass an element's memory to a repeated proto
  field.
- Move a pair of funcs in BrowserReportGenerator into an unnamed
  namespace.
- Avoid copies when iterating over plugins in
  BrowserReportGenerator::OnPluginsReady.

BUG=none

Change-Id: Ib47925de22d6a0872f40e068a246183888736046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091493
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747888}

When we are activated by viewport (auto case), we need to ensure that
we clear activation if we're switching to a non-activatable state
(hidden).

R=chrishtr@chromium.org

Fixed: 1059340
Change-Id: I0e9ef5a9f22c1cf479536d378e37fe60f70d47aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090035
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747887}

This CL adds the digest field to the metadata uploaded when deep
scanning a file. This allows for a very early return before any
processing of file contents has occurred at all, in cases where the
file is not unique.

Fixed: 1056929
Change-Id: I75e703a516cbb06b4f1aa480fd46c66ac20e37c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090607
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747886}

Add tests for the StartLookup method.

The original CL was reverted https://crrev.com/c/2089440.
The error is "Trying to register a previously registered pref"
Remove the double registered pref in this CL and reland.

Bug: 1050859
Change-Id: Ia5f88145f6c7fdbe98b7c1adf8e020602f341437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091593Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747885}

This reverts commit cf95a282.

TBR = gambard@chromium.org

Bug: 1038034, 1056613
Change-Id: Ib3cf8b9eb14d67a1a48dd757577604e82c7ea4c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090804Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747884}

TBR=mcnee@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1059322
Change-Id: I94b1216fdd9baf444d58a534a0a2bdf95579af3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092179Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747883}

These tests use GoogleTest assertions without using GoogleTest's testing
framework. Since UnitTest::Run() and friends (via RUN_ALL_TESTS) aren't
used to run the tests, Google Test's stack trace getter's
UponLeavingGTest method isn't called prior to running the actual test
code. Upon assertion failure, there is no basis on which to trim the
failure's stack trace.

This CL adds a single call to UponLeavingGTest in LLVMFuzzerTestOneInput
to provide such a basis. Better alternatives are to either run the tests
via RUN_ALL_TESTS (after calling testing::InitGoogleTest) or not use
GoogleTest assertions out of context.

BUG=1039559

Change-Id: I3aa5fa5a36361450548403babddb337af41d25d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089845Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747882}

NativeThemeDarkAura creates some complexity in other parts of the code
where we need to be aware of high/increased contrast colors and changes.
Removing it and replacing it with a version of the platform native
theme would allow us to remove all of the logic where we call
GetInstanceForNativeUi without losing any of the benefits that we get
from it. This streamlines the code as we move towards the Color Pipeline.

This adds an additional instance to the NativeThemes,
GetInstanceForDarkUI, which is a version of the platform native theme
that would be forced to use only dark mode. It also avoids setting up
any links to the webinstances in order to not pollute their state.

The IsForcedDarkMode behavior was not used or changed as that flag is
meant to override any other behavior. We would still want to be able to
apply high contrast where appropriate in incognito mode.

Additionally, this fixes an issue where the
IncreasedContrastThemeSupplier was not being removed correctly on
native theme changes.

See discussion in
https://chromium-review.googlesource.com/c/chromium/src/+/2068882 for
the additional context for this change.

Bug: 1003612, 953978
Change-Id: Ifaff1e755b69c8510a6e9f300443bb6bc8f39a27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079840
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747881}

See launch bug: crbug.com/1042127

Bug: 1042127
Change-Id: Icd5d4977f0700ed40c1e3f2fbfaed39b5ee866fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089708
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747880}

This patch ensures that we don't recurse into paint layers that have
display locked subtrees. We need to do this since the subtrees don't paint
and might not have up-to-date layout information, which is needed to
calculate their rects.

R=chrishtr@chromium.org

Fixed: 1059330
Change-Id: I832dfed1a47fba090c6e3ddd92de1846a47c3f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091599Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747879}

Change-Id: Ifdc5c616db4960a92a2df27a93700d894c263f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036405
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Bence Béky <bnc@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747878}

This change modifies BrowserInterfaceBrokerImpl::GetInterface() to
trigger a bad message error on its host's receiver.
Browser test added to verify the behaviour.
Empty binders added for interfaces requested by blink but
not bound by content (will mostly be called in tests).

Bug: 1047680
Change-Id: I242cb11fff56666b6b6bd29e49c2180954aa1227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062696Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747877}

Bug: 1052460
Change-Id: I28410d27a23d4491b13070f7377018249cc58a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087872
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747876}