GitLab

This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed
as argument to the RunLoop involved if any.
Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated).
For more details, see:
https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159

A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1635819

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=dcheng@chromium.org

Bug: 766678
Change-Id: I59de40f915421970b5da834ac2240c733581d8f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636057
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667325}

TBR=meacer@chromium.org

Change-Id: Ib442b6c9be98b8b2967a8517512d3fe972460ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649707Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667324}

https://pdfium.googlesource.com/pdfium.git/+log/1faba755ff77..1e364a244234


git log 1faba755ff77..1e364a244234 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 dhoss@chromium.org Adds test coverage for PSOP_ROUND and PSOP_TRUNCATE in CPDF_PSEngine
2019-06-07 thestig@chromium.org Change CPDF_TextRenderer methods to pass options by reference.
2019-06-07 asweintraub@google.com Fix bug-prone patterns found by ClangTidy
2019-06-07 thestig@chromium.org Clean up CQuartz2D.
2019-06-07 thestig@chromium.org Change DrawDeviceText() call stack to pass matrix by reference.
2019-06-07 asweintraub@google.com Fix ClangTidy - Performance findings in pdfium.
2019-06-07 thestig@chromium.org Replace empty span checks with ASSERTs in CCodec_JpegModule.
2019-06-07 tsepez@chromium.org Move CPDF_OCContext from fpdfapi/render to fpdfapi/page.


Created with:
  gclient setdep -r src/third_party/pdfium@1e364a244234

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Change-Id: Ie6e542d5cc3dd8cd1821dcd934cc0f09f38c78cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667323}

Wild pointer accesses that unintentionally access the GWP-ASan region
and cause a false-positive report are far more prevalent on 32-bit than
64-bit because the address space is smaller. One of the leading causes
of false positive reports on 64-bit is when the OS maps the GWP-ASan
region into the lower 32-bits. Provide a hint to mmap/VirtualAlloc to
map the GWP-ASan region above the first 32-bits of address space.

Bug: 969146
Change-Id: I04a436808290e4d8674af8e2cf2484d1ed8ee470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648694
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667322}

This patch moves the ref-qualified member functions section to the
whitelisted section, with advice to use it sparingly since it may be
poorly understood.

R=kylechar@chromium.org, danakj@chromium.org, pkasting@chromium.org

Change-Id: Ic9400af6a940d3f68c10cca617eb94ad161385ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649733Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Auto-Submit: vmpstr <vmpstr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667321}

Bug: 971323
Change-Id: Iabdccb8e835bae9b32a2435d6eb31e15ec2aa213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646552Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667320}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/96e0999f..05e98a6e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iee37d2a4d8b50bdabd0223ca1d3e493a4137b2cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649312Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667319}

If an acquire, update or commit resolver is not needed, then
there is no need to observe lifecycle updates, because the lock
is guaranteed to be quiescent (either unlocked or quiescent locked).

Bug: 968928

Change-Id: I68b1d233879f313fa83e7be0a244b52f10d44fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647617Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667318}

This CL adds the classes to support showing JS prompts via
OverlayPresenter, and adds the prompt coordinator to the
OverlayModality::kWebContentArea supported classes list.

Bug: 941745
Change-Id: I15743a8489d59cd3667812667f51abe2561af1af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639030
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667317}

Bug: 790202
Change-Id: Ic4151e8512cff6343961351b87e9b5266f5d96ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650223
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667316}

This CL:
- Adds in-product help feature and registers it in different places mentioned in
  https://chromium.googlesource.com/chromium/src/+/master/components/feature_engagement/
- Adjusts Toolbar related code to expose experimental button view
- Implements logic in IdentityDiscController to display a help bubble.

Screenshot: http://screen/TBTUGhdFo1J

BUG=958982
R=twellington@chromium.org

Change-Id: I0ce947df8d2f3aaab3179115da6ef5481d08672d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649135
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667315}

These histrograms are still needed, because these metrics are important
to measure video performance of WebRTC. They may not be actively used
right now but this is because we currently don't run any relevant
experiments. It's won't be the case in the future.

Bug: 970011,969980
Change-Id: Ib119ae50b6d1b4a2494121fed8226a38a1c44cf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645214Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667314}

https://skia.googlesource.com/skia.git/+log/28a5a4344adf..53ae936b8447


git log 28a5a4344adf..53ae936b8447 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 bungeman@google.com Make rasterallocator test a bit better.
2019-06-07 jlavrova@google.com Build fix
2019-06-07 brianosman@google.com Interpreter: Refactor interface and lifetime management
2019-06-07 mtklein@google.com fold through SKSL_USE_STD_STRING
2019-06-07 mtklein@google.com free skvx from its Skia shackles


Created with:
  gclient setdep -r src/third_party/skia@53ae936b8447

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Change-Id: I29a482b09008c18b28d07c43ce63277157fd8a4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649462Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667313}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 969798
Change-Id: I29817e2f28a6e6169a1286df33379c3b946df6c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641722Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667312}

The observer code was introduced in crrev.com/c/1139048 to detect rule
changes. However it seems that these observers were applicable only for
previous declarative APIs and not the declarative net request API,
where they remain unused.

Bug: 971455
Change-Id: Ie6a1c38d2ed11f9ce999f41c3b553fe0ad4e1a08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648819
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667311}

We never use hermetic xcode on iOS.

Change-Id: Id0a7655415e60453479caf5a9581ccf5077c2d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650321Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667310}

Previously, we used the PaintLayer's LayoutObject.

Xianzhu pointed out that there can be cases where a LayoutObject does
not have its own PaintLayer, and that we should instead use the
PropertyTreeState directly associated with the currently painting
object.

Change-Id: I4daf0d1f03507ca45f3e78bf2d3f93b4b6848efd
Bug: 971639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644939Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667309}

 Bug: 967931

Change-Id: I302a4eb12ff69c117c0254fdc86d1a2323231180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647454Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667308}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I626bf0e6850dac73c35b31536313958f72bd5734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650361Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667307}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=hansberry@chromium.org

Change-Id: I3659594870f528f8fa4523aeace161c246614ab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649372
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667306}

Change-Id: Iabcb3d7c34f20376d02df420ef0baa4649d94219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645676
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667305}

EasyUnlockServiceSignin assumes that it is called in a signin context,
but in this particular codepath, ExistingUserController was calling
it in a multi-signin context. In that multi-signin context, the
EasyUnlockServiceSignin object being grabbed was already shut down,
with deleted members -- its use caused a segfault. This CL makes that
assumption clear and only uses EasyUnlockServiceSignin in a signin
context.

Also add check in EasyUnlockServiceSignIn::IsEnabled() that
|pref_manager| is valid.

Bug: 971202
Fix: 971202

Change-Id: Iccc86faaef74ac882bda34fbdde5e5c26394ceea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648674
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667304}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c5c8ab626d5..452f5badf421


git log 4c5c8ab626d5..452f5badf421 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@452f5badf421

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I8febc0266c502bd7f60fa82df5757095d8132159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650042Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667303}

The thumbnails shown in the Grid Tab Switcher (GTS) were decoded from
the ETC1 format, downsampled, and then transferred through the JNI
boundary. This is not the most efficient way.

This CL introduces JPEG thumbnails, which would be saved at the same
time ETC1 thumbnails are saved, if GTS is enabled. The GTS would
directly read and decode the JPEG files from the Java side.

Bug: 971939
Change-Id: Iaf21ea2170afbb7b0385570459f4566715786ca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648963Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667302}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf4f55b6edc4..76904e283cfb


Created with:
  gclient setdep -r src-internal@76904e283cfb

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com

Change-Id: I577a60818594daf3f6aa75e18810567b15d80a8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649646Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667301}

Now that we don't hit crashes from 575245 anymore, remove the
DumpWithoutCrashing and update the CHECK to prevent regression.

Bug: 575245
Change-Id: I9c66c870b978bd7db0e80f79703dd1c7864cc438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650148Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667300}

While investigating youtube button, I've noticed that
window resize was always causing double relayouts.

What happens is that on window resize we do one layout,
notice size has changed, and always force another layout.

I think SetNeedsLayout call is not needed, as
MarkViewportConstrainedObjectsForLayout will already
mark ancestors for layout if needed.

https://chromium-review.googlesource.com/c/chromium/src/+/1649086

Bug: 970171
Change-Id: I4b65486557a798ab00ca939baea93af3706bdccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649066Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667299}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac6fd191f872..139ad7226949


git log ac6fd191f872..139ad7226949 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 dhanyaganesh@chromium.org cros_buildresult: Do not initialize CIDB client
2019-06-07 kinaba@google.com chromeos_config: Switch reef-pfq from NYC to PI.


Created with:
  gclient setdep -r src/third_party/chromite@139ad7226949

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I415affccf5b30f2d900a4a6024fc8adcc32a772b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649652Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667298}

https://chromium.googlesource.com/infra/luci/client-py.git/+log/9b1b0ed1f31d..96f125709acf

$ git log 9b1b0ed1f..96f125709 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 bpastene Revert "Fix logdog client library on windows."
2019-06-07 jbudorick subprocess42: allow configurable sleep duration in wait().
2019-06-04 maruel Revert "[client] Rename third_party/pyasn1-modules to third_party/pyasn1_modules"

Created with:
  roll-dep src/tools/swarming_client

Bug: 971224
Change-Id: Ic7049a0c3cdc5388453458b66ab17f3f31fa7af4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649307
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667297}

Currently breaking a veyron build, bug linked below, since SocketManager
is built regardless of libCUPS, but still technically depends on the
kHttpMaxBufferSize constant in cups_proxy/public/cpp/cups_util.

Though we could bring the constant to the SocketManager internals, there
is no clear reason for SocketManager to be built this way so this just brings it in line with the rest of the service internals..

TBR=rockot@chromium.org,skau@chromium.org

Bug: chromium:971906
Test: tests still pass && speculative build-breaking fix
Change-Id: Ic9b873093152c4bff01ed940551db2cdf36605c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648747
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667296}

Skia's API is fixed to take be compatible with a const
VkPhysicalDeviceFeatures.

Change-Id: I5a38c1aeeace1788b1b46914c2201e56013bf6f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650031
Auto-Submit: Saman Sami <samans@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667295}

Builds out support for CTAP2.1 §5.7.5, cancelling an ongoing
enrollment. The authenticator should always return success
whether there is an enrollment or not.

Change-Id: I1a99fb111c2f00d8fd016d2211e0fba9423dc1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636227
Commit-Queue: Matthew Webb <noviv@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667294}

Bug: none
Change-Id: I8e909c5f374198824ce843117b7cf9bed239c767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644152Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667293}

This section shows:
- URL configured for each of the 3 sitelists
- Time of last refresh
- Time of next refresh
- A "Download now" button, to immediately refresh

To make the "download now" button more usable, the entire page's
contents also automatically refresh when LBS prefs change, or after
XML sitelists are downloaded.

https://imgur.com/a/yhRZnpZ

Bug: 959379
Change-Id: I7517491d95bc9c570232d2080ee5aeead270b674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632001Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667292}

Replce the DCHECK in SkiaOutputSurfaceImpl::RemoveRenderPassResource()
with a test to see if the render pass has an entry in
|render_pass_image_cache_| before trying to remove it.

There isn't a known repro for this crash, but I suspect that using a
bypass to draw the quad in SkiaRenderer::DrawRenderPassQuad() can cause
the circumstances to arise. An entry for |render_pass_image_cache_| is
created in MakePromiseSkImageFromRenderPass(), but this is skipped if
a bypass quad is used, causing a difference between the render pass maps
in SkiaRenderer and SkiaOutputSurfaceImpl.

Bug: 959071
Change-Id: I4765f57eb30a7b4f14a559722e419ae526f79572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648326Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667291}

https://skia.googlesource.com/skia.git/+log/ac53c42b09f3..28a5a4344adf


git log ac53c42b09f3..28a5a4344adf --date=short --no-merges --format='%ad %ae %s'
2019-06-07 robertphillips@google.com Revise GrDataUtils to be more self-contained (take 3)
2019-06-07 egdaniel@google.com Reland "Reland "Remove support for copyAsDraw in gpu copySurface.""
2019-06-07 herb@google.com Remove advance only mode from SkGlyph.
2019-06-07 jlavrova@google.com SkParagraph
2019-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 386ae89d2b64..ed2c978cdeef (1 commits)
2019-06-07 jvanverth@google.com Another attempt at a shim to get sk_cf_obj landed.


Created with:
  gclient setdep -r src/third_party/skia@28a5a4344adf

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Change-Id: I0d156f2c4b62e8038d8f9f0b6762d213e38910eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649643Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667290}

When we encounter a preserved line break in relayout, we can't reuse its
items if:
- It was in a bidi context in a previous layout
- It's in a bidi context in the current (re)layout

We attempted to ensure that in crrev.com/c/1626498, but failed because
a <span dir=ltr> creates bidi contexts without necessarily setting the
NGInlineNodeData::is_bidi_enabled_ flag.

This patch fixes the issue by adding a flag to LayoutText to indicate if
the text has any bidi control items, so that when it's true and the text
contains newlines, we don't reuse its old inline items.

Bug: 966751
Change-Id: I63d95c9d1ddcffda62a5227d0d6166b2e9ce221a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649218
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667289}

https://webrtc.googlesource.com/src.git/+log/24cf2606e421..17031afe184c


git log 24cf2606e421..17031afe184c --date=short --no-merges --format='%ad %ae %s'
2019-06-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision add4dabf..25abf646 (667020:667125)


Created with:
  gclient setdep -r src/third_party/webrtc@17031afe184c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7b3d35169c7783a3628a6ec8513dbc6fb004fc18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649386Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667288}

Flag usage will be added in follow-up CL crrev.com/c/1616163

Bug: 964127
Change-Id: If68f27a302f78c3659b5bca31d042cf8a2062589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648600
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#667287}

Bug: None
Change-Id: Ia1b97402c52c2de4e25e6b3cd7fb7cab906da78d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646841
Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667286}