- 14 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/78d7b4b8250e..4faa62a0e9f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3d14beb01bce4ded4a62483f78b397b6c78672ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355006Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797970}
-
James Cook authored
Add mojo interface for communication between ash and lacros. For now, just add the fields needed for simple text notifications. Notifications are handled in a new class MessageCenterAsh. It lives in //chrome/browser/chromeos/crosapi instead of //c/b/notifications for consistency with other crosapi implementations. On mojo disconnect (e.g. lacros-chrome crash) all notifications created by lacros are removed. I'm working on tests now. They are not in this CL because this CL is getting too large. Test: Spawn basic notifications from test app Notifications Galore in chrome/test/data/extensions/api_test/notifications/galore/ Bug: 1113889 Change-Id: I6363b0e7568756b9087f089651a7fdc6d0901902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343849Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#797969}
-
Donn Denman authored
This reverts commit bc08f94f. Reason for revert: Not needed. There was an issue with the CLA not being accepted. Original change's description: > Add a chromium author that could not add himself > > BUG=1116202 > > Change-Id: I10738961da81ad153b770210e3d969210b0bcd0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354557 > Commit-Queue: Donn Denman <donnd@chromium.org> > Commit-Queue: Theresa <twellington@chromium.org> > Auto-Submit: Donn Denman <donnd@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797916} TBR=donnd@chromium.org,twellington@chromium.org Change-Id: Iaffe8f52f36455ba0c7746b0ed47fa2d9f5db209 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354562Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#797968}
-
Alexander Cooper authored
https://crrev.com/c/2352519 stopped attempting to load the GvrKeyboard, and the original bug that it fixed had the same error stack as seen in this bug. Re-enable the Permissions Tests that were failing with the same error. Fixed: 1091800 Change-Id: Icc2bf2d29ddd8ffbf0016df2be6e9e6d310a1ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354721 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797967}
-
Lan Wei authored
This reverts commit 261661bb. Reason for revert: BluetoothSocketTest.TestInputStream/TestOutputStream fails on Linux TSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/57982 Original change's description: > [Nearby] Create concrete BluetoothSocket and implement ConnectToService. > > Implement a concrete location::nearby::api::BluetoothSocket, created via > a bluetooth::mojom::Socket and Mojo DataPipes supplied by the newly > implemented BluetoothClassicMedium::ConnectToService(). > > Nearby Connections uses this BluetoothSocket to communicate with a > remote device. At a high-level, it first exchanges frames to encrypt > the connection, then delegates to its caller (e.g., Nearby Share) > to authenticate the connection, and finally expects its caller to > send and receive application-level messages. The following precautions > are taken to handle untrusted bytes received from remote devices: > * Nearby Connections (including the code being added in this CL) is > hosted in a Nearby utility process. > * Whenever Nearby Connections provides bytes received from a remote > device to its caller, even after it has been authenticated, the > caller must not trust those bytes, and is responsible for first > passing those bytes through the trusted NearbyDecoder interface > (see go/nearby-chrome-mojo). NearbyDecoder is hosted in the same > Nearby utility process. > > api::BluetoothSocket is a synchronous interface, so this > implementation consumes the synchronous signatures of > bluetooth::mojom::Socket methods. > > api::BluetoothSocket's subclasses are also synchronous interfaces, > but the Mojo DataPipes they consume only provide asynchronous > interfaces. This is reconciled by blocking on the caller thread when > waiting (via a mojo::SimpleWatcher) for the DataPipes to become > readable or writable (this is expected by the callers of > api::BluetoothSocket's subclasses). Mojo DataPipe operations are > handled on a separate task runner so that blocking on the calling > thread will not deadlock. > > Please see design doc go/nearby-chrome-bt for more details. > > Bug: b:154849033, b:158848873 > Change-Id: I2e945277aa1f75b4ca378d0b961f7682ff25d812 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322166 > Commit-Queue: Ryan Hansberry <hansberry@chromium.org> > Reviewed-by: Alex Chau <alexchau@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797758} TBR=reillyg@chromium.org,hansberry@chromium.org,alexchau@chromium.org,vecore@google.com Change-Id: Ia33d32ae93a8900032e81f77d298553c5de82874 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:154849033 Bug: b:158848873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355253Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797966}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fa7957ea438..4faa62a0e9f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I29bbbb11504a671706c05fa15577c8c24c3fb4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797965}
-
Avi Drissman authored
For CrOS, since the Task Manager is showing tasks for all of CrOS and not just “Chromium”, it's not appropriate to label it as such. Bug: 1109438 Change-Id: Iba02159483b124601a90123b0eed4a215f7851a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354415Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797964}
-
Kunihiko Sakamoto authored
This reverts commit 34bca2e3. Reason for revert: Suspected for TSan error (data race) in BluetoothSocketTest.TestOutputStream and BluetoothSocketTest.TestInputStream. https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/57982 Original change's description: > Implement key verification for incoming connection. > > Implements the key verification module that to verify remote device > before requesting introduction and beginning the transfer flow. > > Bug: 1085068 > Change-Id: I4bb75dce474042ef43ca86199db3456d63406874 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346325 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Alex Chau <alexchau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797868} TBR=alexchau@chromium.org,nohle@chromium.org,himanshujaju@chromium.org Change-Id: I04ef174610f0e3751299ea7aeccdd16c4bf8683f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352300Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797963}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5c8c6b4296e5..5559351c907d 2020-08-13 timvp@google.com Vulkan: Correctly determine mip level in resolveColorWithCommand() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: FramebufferTest_ES31::MultisampleResolveIntoMipMapWithBlit() Change-Id: I949ddd444d7586521289ffbd5cb458419d3eb9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797962}
-
Brian Malcolm authored
This is intended to replace the NativePrintersBulkAccessMode policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1113370 Change-Id: Iec6aeb20a1e0755e4985c849dc98280c4658659a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340513 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#797961}
-
Chris Blume authored
There are missing includes that are transitively included. But updating these files requires these missing includes be added. This CL adds those missing includes. Change-Id: I3bcf6d894d50cd57a3219e8b7a4ad0c5b83e76c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353486Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Auto-Submit: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#797960}
-
Yicheng Li authored
AuthDialogDebugView was used in in-session auth dialog in the early development stage. Now that it has the correct views and is close to the final contents view, rename it to AuthDialogContentsView. This change also removes the dev flag "show-auth-dialog-dev-overlay" so that: 1. developers (especially Chrome's WebAuthn team) can test the flow end to end without having to enter dev mode on ChromeOS. 2. UX reviewers can evaluate the user flow. Note that the feature is still behind a feature flag "base::Feature kWebAuthCrosPlatformAuthenticator". Developers can toggled that via chrome://flags. No functionality change. Bug: b:156258540 Change-Id: I7c8e0a94993cc6d483d5280cd91fa970846930f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355000 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797959}
-
Olivier Yiptong authored
Adds basic usage metrics to the main API methods. This will give us a basic quantitative view on how the API is used during Origin Trial. Fixed: 1116107 Change-Id: I79e2717f49b645eac5f065c7b5346ca10b3521ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354607 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#797958}
-
Kunihiko Sakamoto authored
This reverts commit b207aafb. Reason for revert: On android-marshmallow-arm64-rel bot, weblayer_instrumentation_test_apk flakily fails by assertion failure at BrowserControlsContainerView.java:206. Examples: https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/633073 https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/633096 Original change's description: > [WebLayer] Let the embedder animate top controls in/out. > > This CL adds an "animate" flag to Browser.setTopView that allows the > embedder to tell WebLayer to animate the top view off the screen when > setting it to null, or to animate it down from the top when setting it > to a non-null value. > > The animation off the screen is achieved by removing the View from the > view tree, but keeping the bitmap layer in place, hiding the top > controls, and then deleting the layer after the animation is complete. > > Bug: 1108956 > Change-Id: Idb9bce6c2633ef6d1d369ccb2741ae6fd1fe43a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335800 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797826} TBR=sky@chromium.org,bokan@chromium.org,boliu@chromium.org,khushalsagar@chromium.org,rmcelrath@chromium.org Change-Id: Idce18f8f22c3533a7124bb2688a60b0cb2cc28f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108956,1116246,1116247,1116248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354124Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797957}
-
Brandon Wylie authored
Bug: 1112563 Change-Id: Ic39af14db9a5771a63dec3a153e63aa21339379d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339403Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797956}
-
My Nguyen authored
Virtual keyboard can be enabled and not visible. When it's not visible, suggestions should still be shown normally. Bug: b/162293447 Change-Id: I3a9ef621abe4ab70031ea7ef0c1154ac61a7e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355152Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797955}
-
Rouslan Solomakhin authored
This patch adds a cross-platform way for Web Payment feature to query the IS_READY_TO_PAY intent of an Android app. As a first step, only the Android apps installed on the Android subsystem of Chrome OS are supported. Bug: 1061503 Change-Id: I3055874e96e046a233c5bb223c9e4422d7e8e966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248427 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#797954}
-
Peter Boström authored
The DialogModelField pointer is instead used to identify the field. Bug: 1106422 Change-Id: I2cd8ddd5bc4d79f4afa85bce47556fc31299155e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353408Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797953}
-
Thomas Guilbert authored
This CL adds basic tests, verifying VideoTrackReader construction, start and stop. Bug: 1094194 Change-Id: I945b49c83b30fb18e1b92f2263fbdb050a431d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353533Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#797952}
-
Scott Violet authored
This matches other parts of the code. BUG=1076463 TEST=none Change-Id: I995b0f3449d5a4e4c20fb504a723681e9c8c14d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354792 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#797951}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53090ac8..a6dff6f4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5fc979b7c9edf64af9b377110c06a01089e38510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353491Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797950}
-
Kyle Horimoto authored
This CL adds NotificationAccessManager::AttemptNotificationSetup(), which starts the flow for enabling notification access. Note that the real implementation for this flow has not yet been completed. However, the new code added to FakeNotificationAccessManager will unblock UI work which needs this code in place to write unit tests. A follow-up CL will actually implement the flow itself. Bug: 1106937 Change-Id: I2d0ccedbe758252857ec2238a294b8a2a1f31eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354657 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#797949}
-
William Lin authored
When enabling unbundled consent for GetAuthToken in the extensions API, the scopes returned by the server may not be the same as the requested scopes. In some cases, the returned scopes may also include multiple scope strings for the same requested scope. This CL addresses this mismatch between the requested and granted scopes by adding the ability for the access token cache to return tokens when only a subset of its scopes was requested. This change would prevent repeated cache misses when such mismatch occurs. Bug: 1100535 Change-Id: I4000dc6a6782504ffa1781ef4ab7916bb64a1aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330939 Commit-Queue: William Lin <williamlin@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797948}
-
My Nguyen authored
Bug: b/162293447 Change-Id: I04ea807ba7944a9fb216b367910254556c2440c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355229Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797947}
-
Kai Ninomiya authored
Updates the README in WPT to reflect this, and Chromium's roll script so that it doesn't roll into WPT. And, unrelatedly, removes JusSn from the suggested_reviewers as he is no longer actively working on WebGPU. Rationale: These tests test an unstable, constantly changing API. Because of this, it's not practical for browser implementations to try to sync on a single version of the test suite which is auto-imported/exported from WPT. Auto-imports in any browser will necessarily result in test failures just because the tests have changed to match some API change. Instead, for the moment, browsers should pin ("vendor") a particular version of the WebGPU CTS, and may include a built version of it in their equivalent of "wpt_internal" for automated testing. Discussion: https://github.com/web-platform-tests/wpt/issues/24699 Bug: None Change-Id: Iaabd81ef646404ab7f6e8cc19a884b15f5306bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353550Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797946}
-
Dan Sanders authored
This removes the VideoTrackWriter interface so that it will not become visible when the WebCodecs feature is enabled. The VideoTrackReader unittest depends on the VideoTrackWriter C++ code, so that has been left for now. Bug: 897297 Change-Id: I1c328d7ca995cf9019ca50c65f8cb7257fbb06ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353538 Commit-Queue: Dan Sanders <sandersd@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#797945}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c71a9c2930fa..1d054a1f6d99 2020-08-13 brgoddar@microsoft.com Source Order: add user action to histogram If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1094406 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3ba28ee403197e95c32aa05fea5bb5a474e262db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354583Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797944}
-
Justin Donnelly authored
This decouples ongoing work to refine the keyword button from our plans to experiment on button row and Pedals. Bug: 1046523 Change-Id: I3eddce8880f7473c837f393231e708bd5a07f56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343845Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#797943}
-
Wojciech Dzierżanowski authored
ExtenionUserScriptLoader was calling ChromeComponentExtensionResourceManager::IsComponentExtensionResource() on the extension file task runner. But ChromeComponentExtensionResourceManager should only be accessed on the main sequence, because LazyInitData needs BrowserProcessImpl, which must only be accessed on the main sequence (https://crbug.com/1033644). Besides, LazyInitData() was racy in the previous setup. Bug: 1113374 Change-Id: Ie1929a024213141a2ae431221e905c73134da65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343344 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797942}
-
Peter Kasting authored
Bug: 1104532 Change-Id: Iea05cc80dbcee0f2aa84c777cded4e07e7cb1311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354989 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#797941}
-
Shengfa Lin authored
Output specific browser version when version mismatch between ChromeDriver and Chrome. Also, output binary path for Desktop Chrome and package name for Android Chrome Bug: chromedriver:3559 Change-Id: Ic680d5363d0c860da6d2995a89500e887fbb63ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327792 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797940}
-
Arthur Eubanks authored
This increases the Linux Clang packaging time from ~1:10 to ~2:30, but is still comfortably faster than the Mac packaging. This improves the performance of Clang by ~3.5%. Bug: 1108051 Change-Id: I9cb323ae496df95fd9dd0d22dab4717ea774df88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327276 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797939}
-
Thanh Nguyen authored
We're moving from using png to vector icon for filetype in launcher search. This CL checks in the icons for different filetypes. Bug: 1067326 Change-Id: I78f852a7c3a1cbb359ddda4a29098c447cc9b4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352254 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#797938}
-
Takumi Fujimoto authored
Disabled for being flaky. TBR=altimin@chromium.org Bug: 1116190 Change-Id: Idf7b1015f25ee14c575a66a40e7c4181e2f847d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355094Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#797937}
-
Sebastien Marchand authored
Change-Id: I6625de68dcac33fd74f768d7fa7c60b899e2f200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354527 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#797936}
-
Joe Downing authored
This CL adds some logic to the It2MeHost to read this policy and update the network settings to reflect its value. The network settings are used to discard the entries in the ICE Config which are blocked by policy. With this change, the Me2MeHost and It2MeHost will now have the same behavior (previously the It2MeHost only read the NatTraversal policy). This should be a safe change as the AllowRelayedConnection policy defaults to true if not explicitly set and the description of the policy does not indicate that it only applies to Me2Me. Another interesting note is that we do not refer to it in our Enterprise config doc (only the firewall traversal policy is mentioned) so I would be surprised if it is broadly used. Once this lands, I'll update the website to use the new 'relayConnectionsAllowed' message value. Change-Id: Ide4009e5e7979f7bda6dc098e5968739ed50e97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353931 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#797935}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I10b59e128a24b4275f43e34939a761b75f14e931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355090Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797934}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/94ebd189a1d5..63c9de2bf41a $ git log 94ebd189a..63c9de2bf --date=short --no-merges --format='%ad %ae %s' 2020-08-07 omorsi system_api: Remove a finished TODO 2020-08-11 joelhockey vm_tools: cicerone: Add vsh host and container pid map 2020-08-12 sidereal system_api: Fix integer type in VmInfo 2020-08-11 kevinptt runtime_probe: update protobuf fields name for edid 2020-06-10 akhouderchah hermes: Introduce Euicc class 2020-06-29 puthik system_api: Add power_manager thermal.proto 2020-07-31 chenghaoyang system_api: Add DBus Method and Token to Bootstrap PowerManager's Mojo 2020-07-16 matthewmwang shill: remove WiFi.FTEnabled property 2020-07-31 vapier common-mk: check-owners: drop noparents settings 2020-07-21 chenghaoyang system_api: Add Iioservice DBus Constants Created with: roll-dep src/third_party/cros_system_api Change-Id: Ifd8f33c63b47d26af556531d0fc9702a7a841b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352968 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797933}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4faa62a0e9f8..241a4a92fb96 2020-08-13 lalitm@google.com Merge "tp: migrate sql metrics bazel script to use exec_tools" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6f36fe0d45cb95dbbadcc7f8a44272543edbf91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355072Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797932}
-
Regan Hsu authored
Adds another feature line item with icon that Better Together can mirror notifications from phone to Chromebook. Screenshot: https://screenshot.googleplex.com/L4rEXHdAeys Bug: 1106937 Change-Id: Ib3aa18fbe6c322244c87158b4dcb875e73cc3e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353020 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797931}
-