GitLab

Bug: 850068
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I8fdb2a09bb813492687ceb7c801571f1d2bd5c77
Reviewed-on: https://chromium-review.googlesource.com/1208362
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590288}

This reverts commit 03d7e3ce.

Reason for revert: Reverting on behalf of titovartem@. Breaks WebRTC since vp9_svc_layercontext doesn't compile: https://logs.chromium.org/logs/webrtc/buildbucket/cr-buildbucket.appspot.com/8935991820767406272/+/steps/compile/0/stdout

Original change's description:
> Roll src/third_party/libvpx/source/libvpx/ 753fd86e8..4ddfa331c (26 commits)
> 
> https://chromium.googlesource.com/webm/libvpx.git/+log/753fd86e86ac..4ddfa331c4f5
> 
> $ git log 753fd86e8..4ddfa331c --date=short --no-merges --format='%ad %ae %s'
> 2018-09-05 huisu Initialize the best partition before partition RDO
> 2018-08-29 marpan vp9-svc: Allow for setting framerate per spatial layer.
> 2018-08-31 jingning Adaptive ARF factor decision
> 2018-08-29 jingning Recursive rate allocation for multi-layer ARF coding
> 2018-08-28 jingning Enable adaptive rate allocation for multi-layer ARFs
> 2018-09-04 huisu Move partition search ML models to a seperate file
> 2018-09-04 marpan vp9-svc: Fix to first_spatial_to_encode for pattern constraint.
> 2018-08-28 jingning Increase encoder buffer for multi-layer ARFs
> 2018-08-28 jingning Structure the multi-layer ARF locations
> 2018-09-03 paulwilkins Fix short first kf bug.
> 2018-08-27 jingning Assign target bits for multi-layer ARF system
> 2018-09-03 marpan vp9-svc: Add bypass flag to constrain inter_layer.
> 2018-09-03 paulwilkins Revert "Revert "Prevent double application of min rate in two pass.""
> 2018-09-02 marpan vp9-svc: Fix condition for pattern constraints
> 2018-08-27 jingning Properly update the raw_src_frame for psnr calculation
> 2018-08-25 jingning Build arf index stack
> 2018-08-31 marpan vp9-svc: Add first_spatial_layer_to_encode per superframe
> 2018-07-16 huisu ML based rectangular partition search pruning
> 2018-08-24 jingning Fix arf_src_offset calculation
> 2018-08-23 jingning Set minimum frame size to be 1 byte
> (...)
> 
> Created with:
>   roll-dep src/third_party/libvpx/source/libvpx
> R=​johannkoenig@google.com
> 
> Change-Id: Iabdcddd52bc1b080b87155333614cb0f07b34627
> Reviewed-on: https://chromium-review.googlesource.com/1214362
> Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
> Commit-Queue: Jerome Jiang <jianj@google.com>
> Cr-Commit-Position: refs/heads/master@{#589741}

TBR=tomfinegan@chromium.org,johannkoenig@google.com,jianj@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ie1c41b10efa405e560d79a3755e4fbada743705c
Reviewed-on: https://chromium-review.googlesource.com/1219626Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590287}

(1) Add text allowing TBR with relands which previously appeared on the
    sites page.
(2) Add guidance that TBR'ed reverts should be clean and recent.
(3) Make "OWNERS file details" a subsection of "OWNERS files".

Discussed on chromium-dev at: goo.gl/kCw2HK

Change-Id: Ic0329574652926483f9cb33100635f89fa8b0107
Reviewed-on: https://chromium-review.googlesource.com/1217167Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590286}

Fix compile error with -Wshorten-64-to-32.

Bug: 881008
Change-Id: I52a1bab9cb7b4cb67ea4c275143390d42b192120
Reviewed-on: https://chromium-review.googlesource.com/1216524Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590285}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/656c1c9c270c..55c4417fbeca


Created with:
  gclient setdep -r src-internal@55c4417fbeca

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:882818
TBR=mmoss@chromium.org

Change-Id: I907b5d4a2dfd0e28fffe1ef78cb805762d08c998
Reviewed-on: https://chromium-review.googlesource.com/1219406Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590284}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a2ceb19a3a9a..eb5e205de2f3


git log a2ceb19a3a9a..eb5e205de2f3 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 sammc@chromium.org Add an option to list revisions when marking an ebuild as stable.


Created with:
  gclient setdep -r src/third_party/chromite@eb5e205de2f3

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If656e255fedc02247908655280f36294695fcc11
Reviewed-on: https://chromium-review.googlesource.com/1219409Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590283}

https://skia.googlesource.com/skia.git/+log/2bf7a7bcc67f..58aa824ddaea


git log 2bf7a7bcc67f..58aa824ddaea --date=short --no-merges --format='%ad %ae %s'
2018-09-11 caryclark@skia.org fix pathmeasure fuzz


Created with:
  gclient setdep -r src/third_party/skia@58aa824ddaea

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I1eb88fbc5f5925b14e65b21c238b3e8ac9d0a81f
Reviewed-on: https://chromium-review.googlesource.com/1219410Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590282}

https://webrtc.googlesource.com/src.git/+log/49b2c3c4c433..3d50a31aad31


git log 49b2c3c4c433..3d50a31aad31 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 sakal@webrtc.org Remove redundant initializers from WebRTC Java code.
2018-09-11 terelius@webrtc.org Allow printing graphs as protobuf in event_log_visualizer.
2018-09-11 mbonadei@webrtc.org Fix no_exit_time_destructors in pc.
2018-09-11 ivoc@webrtc.org Move code for setting field trials from NetEqTestFactory to the main function in neteq_rtpplay.
2018-09-11 ivoc@webrtc.org Remove the move constructor from NetEqState.
2018-09-11 magjed@webrtc.org Add receive stream id argument to CreateDecoder() method
2018-09-11 nisse@webrtc.org Delete deprecated simulcast and spatial index members
2018-09-11 ssilkin@webrtc.org Reland "Frame rate controller per spatial layer."
2018-09-11 mbonadei@webrtc.org Fix no_global_constructors/no_exit_time_destructors in Neteq.
2018-09-11 mbonadei@webrtc.org Fix no_global_constructors in audio_processing/agc2/rnn_vad.
2018-09-11 mbonadei@webrtc.org Remove double declaration of 2 conversion functions.


Created with:
  gclient setdep -r src/third_party/webrtc@3d50a31aad31

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia123dfdffbdb9d7fb228b92de7fa8ce11d6a7164
Reviewed-on: https://chromium-review.googlesource.com/1219408Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590281}

We currently push a SelectorFilterParentScope on the stack for each
element in the ancestor chain while matching style rules. In order to
support starting style recalc at a root element which is not the
document root, we need to be able to push a scope for an ancestor chain
instead of a single element. This CL introduces a subclass for doing
that. Also added some simple unit tests.

Bug: 868810
Change-Id: I23dd49ab1b9d02efe5f281ca2dbec773d699bc0e
Reviewed-on: https://chromium-review.googlesource.com/1219106Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590280}

This test applies the same property over and over, with a different
var()-reference each time. This is an unlucky case for Blink, because
we don't have a cascade structure internally, so we pay the full cost
of resolving the var()-reference every time.

It also has a button which makes it easy to compare the same situation
without var()-references.

Change-Id: I02cdcd691cbcad97374330b31e19834306ae8319
Reviewed-on: https://chromium-review.googlesource.com/1146906Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590279}

This CL enables the exclusive touch on the toolbar buttons. It won't
be possible to do two actions at the same time including a button.

Bug: 878348
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2a2e6f93cc42731ccd0d5730464cf0eb1ceca278
Reviewed-on: https://chromium-review.googlesource.com/1219487Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590278}

This reverts commit 95f627dc.

Reason for revert: The class will not be expanded anymore.

Original change's description:
> Rename BlacklistedDuplicatesCleaner class
> 
> This CL renames class with name BlacklistedDuplicatesCleaner to
> RedundantCredentialsCleaner. This is to reflect expanding this
> class to handle also non-blacklisted credentials, which will be
> done in coming CLs
> 
> Bug: 862930
> Change-Id: Ifba11a521775cbcd33c183aa685ae84a591d8457
> Reviewed-on: https://chromium-review.googlesource.com/1202664
> Commit-Queue: Narcis Gemene <gemene@google.com>
> Reviewed-by: Vaclav Brozek <vabr@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588473}

TBR=vabr@chromium.org,jdoerrie@chromium.org,gemene@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 862930
Change-Id: I7edb0dfaeed734109d928694be48667228edd54d
Reviewed-on: https://chromium-review.googlesource.com/1219606Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Narcis Gemene <gemene@google.com>
Cr-Commit-Position: refs/heads/master@{#590277}

This is a reland of 88924f03

Added a missing DCHECK_IS_ON() check.

Original change's description:
> blink/bindings: ASAN checks to ensure proper ParkableString accesses.
>
> A ParkableString underlying string memory should not be cached.
> Following a suggestion by pasko@, add ASAN instrumentation to make sure
> this is actually the case.
>
> Bug: 877044
> Change-Id: I463ad229b118f2e629b460f1a2beed41fc54b6a7
> Reviewed-on: https://chromium-review.googlesource.com/1216422
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590251}

Bug: 877044
Change-Id: I777d53528037015ff3d16cd8c5ce2b649788848b
Reviewed-on: https://chromium-review.googlesource.com/1219486Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590276}

Bug: 769756
Change-Id: Ifdcb0a5145ffad1d563562e2b2ea2390ff074cdc
Reviewed-on: https://chromium-review.googlesource.com/1213178Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590275}

FramebustBlockInfoBar#createContent crashes in case no scheme is specified in url.

Bug: 854733
Change-Id: I9603f4609dbf9b5882accd8f645f82a86452df27
Reviewed-on: https://chromium-review.googlesource.com/1217423
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590274}

Bug: 881364
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I99131d73c52118b1baa7dee460d91b0f9d7d8521
Reviewed-on: https://chromium-review.googlesource.com/1203997
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590273}

BUG=823254

Change-Id: Ibfa232b39e7003565ac68dba0e4e1aab9170c6fd
Reviewed-on: https://chromium-review.googlesource.com/1216845
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590272}

https://pdfium.googlesource.com/pdfium.git/+log/8550a2d1e037..9039169b64e1


git log 8550a2d1e037..9039169b64e1 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 thestig@chromium.org Do not copy data in DecodeAllScanlines().
2018-09-11 thestig@chromium.org Make flate decode functions' buffer out parameter unique_ptrs.
2018-09-11 thestig@chromium.org Make RunLengthDecode()'s buffer out parameter a unique_ptr.
2018-09-11 thestig@chromium.org Make HexDecode()'s buffer out parameter a unique_ptr.


Created with:
  gclient setdep -r src/third_party/pdfium@9039169b64e1

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I37b51823b66ded7a2c8c8f0d968c3ebdf5cbe0ab
Reviewed-on: https://chromium-review.googlesource.com/1218962Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590271}

This reverts commit 3ca917bd.

Reason for revert: The CL caused crashes on Chrome canary on Mac: crbug.com/882787

Original change's description:
> [OSCrypt] Add feature for preventing key overwrites in Keychain on Mac
>
> This Cl includes:
> - Add a feature flag which is disabled by default.
> - Include key creation utility to prevent key overwrites in KeychainPassword::GetPassword().
> - Add tests for the above changes.
> - Register the local state early from the main thread in os_crypt.
>
> Bug: 791541
> Change-Id: I2a664cd285fe73b32a15b2949977b940d95e7bbe
> Reviewed-on: https://chromium-review.googlesource.com/1188318
> Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589898}

TBR=battre@chromium.org,vasilii@chromium.org,rsesek@chromium.org,cfroussios@chromium.org,tsabolcec@google.com

Change-Id: I1be5c8294985e81115a8856f4105fbff8a3a28a9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 791541
Reviewed-on: https://chromium-review.googlesource.com/1219086Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Cr-Commit-Position: refs/heads/master@{#590270}

Turns out we'll need it afterall since some ios code
uses NonNestable tasks, e.g. indirectly via DeleteSoon.

Bug: 867421, 878356
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I77c0161b083c987f48b0f3270490e8feee241b18
Reviewed-on: https://chromium-review.googlesource.com/1216564Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590269}

This CL only handles a difficult case in //net. The easy cases were
tackled by mechanical CLs, such as https://crrev.com/c/1188959 for
//net. Parallel CLs will tackle other difficult cases.

ability to reason about instance ownership locally, creating instances
via base::MakeRefCounted makes it possible to use 1-based ref-counting
in the future (see base/memory/ref_counted.h).

net: :IOBuffer is (thread-safe) ref-counted. Asides from improving the
Change-Id: I9925444170fcb8ab3740c1a1223c10c5d4060775
Reviewed-on: https://chromium-review.googlesource.com/1215465Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590268}

This was added recently for testing purposes, but I wasn't aware of
FRIEND_TEST_ALL_PREFIXES at the time. PropertyRegistration instances must
never exist unless CSSVariables2 is enabled, and I've been worried this
might accidentally happen ever since ::Create was added.

Added bonus DCHECK for even more inner peace.

R=futhark@chromium.org

Bug: 641877
Change-Id: I61780ec25fb09673a0f3325775ce1b891b0867cb
Reviewed-on: https://chromium-review.googlesource.com/1218702Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590267}

In http://crbug.com/881384#c2 I saw some more evidence that the page cache is
not fully flushed when benchmarking. On Linux/Android calling sync(2) syscall
before evicting individual files should help because the later pagecache
dropping operations become a lot cheaper for the kernel. I could not find good
documentation about sync(2) guarantees on MacOS.

The page cache flushing for individual files is still asynchronous, with no
cheap way to check that it happened. The plan is to sleep for one second after
such operations. Since we would prefer to sleep only once per bulk of
operations, the sleeping will be done on higher levels.

The Windows story is not covered - the operation requires administrator
privileges.

Bug: 811244
Change-Id: Ib71f4f934a0eb4b438bfedbbb50462e07ff64308
Reviewed-on: https://chromium-review.googlesource.com/1211602
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590266}

Use the "META: global=" annotation to run the web-locks/ tests in
shared and service workers, as appropriate.

Change-Id: I1d6acd9b4e2932bf3a60b1e41285cbe74e3cb8ff
Reviewed-on: https://chromium-review.googlesource.com/1208447
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590265}

InfoBarContainer is now managed by Tab's UserDataHost,
and accessed through new static methods |from()| and |get()| defined
in the container class. Tab still a reference to a container.
It will be removed when all the callsites of |Tab.getInfoBatContainer|
are updated in a follow-up CL.

Bug: 877878
Change-Id: If59bf7e750bcaf7f0988925ab06f94eb8974cddc
Reviewed-on: https://chromium-review.googlesource.com/1212378
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590264}

https://skia.googlesource.com/skia.git/+log/82bf31003c66..2bf7a7bcc67f


git log 82bf31003c66..2bf7a7bcc67f --date=short --no-merges --format='%ad %ae %s'
2018-09-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 63aa0e5b7001..0d0fb43f34ee (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@2bf7a7bcc67f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I76ea9dc652739a0e176a7f9f82f74f913dd92811
Reviewed-on: https://chromium-review.googlesource.com/1218963Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590263}

This is a reland of 061ac2e7

Original change's description:
> Add method to rewrite a LevelDB instance
>
> Add the infrastructure to remove expired data by rewriting LevelDB
> instances.
> The integration with actual storage implementation will be added in
> followup Cls.
>
> Bug: 823071
> Change-Id: Iff1b93481468423d292266f16a45f6ef4ac6e7f2
> Reviewed-on: https://chromium-review.googlesource.com/1152917
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587980}

Tbr: pwnall@chromium.org
Bug: 823071
Change-Id: I9f01dd376166879b89650619692a33cef48d19ae
Reviewed-on: https://chromium-review.googlesource.com/1201856Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590262}

Remove obsolete commentary about media constraint name sources.
They don't matter any more.

Bug: chromium:543997
Change-Id: Ib37fd318c5a03f9cb94acb9f68bb443f7d0d06bd
Reviewed-on: https://chromium-review.googlesource.com/1218723Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590261}

This patch adds a new class called ServiceWorkerUpdateChecker and
makes ServiceWorkerRegisterJob use this class. The new class has a
method called Start(), which takes a callback as an argument and
triggers it only when the scripts had any changes to update. Currently
this method runs the callback unconditionally, but following patches
will implement script loading and comparison with the stored resources.

Bug: 648295
Change-Id: Iebbe85b6d5e5cdab27c23873b04811626b5abad0
Reviewed-on: https://chromium-review.googlesource.com/1215458
Commit-Queue: Momoko Hattori <momohatt@google.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590260}

The button catching the taps when the toolbar is collapsed doesn't catch
the taps on the status bar.
This CL makes sure the toolbar is expanded when the status bar is
tapped.

Bug: 878382
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: I71dd7af9ca7d2e47687887d69f11661c71e3d86c
Reviewed-on: https://chromium-review.googlesource.com/1199162Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590259}

The stack returned from _get_stack_from_dump can be None. This hardens
against this case, and hopefully another other unforseen issues around
the stack encoding, by transforming the stack to ascii inside a try
block.

Bug: 880246
Change-Id: I498b5929dab811a2ccc5e69bb51b930c8547179c
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1218842
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590258}

A commit just introduced two GetIdMap functions in ui/views/cocoa,
which broke jumbo builds because in jumbo builds they end up in
the same translation unit. This patch renames them
GetIdToWidgetImplMap and GetIdToWidgetHostImplMap

Bug: 859152

TBR=ccameron@chromium.org,ellyjones@chromium.org

Change-Id: I55b4a48d3d4f97c30450fd89bb8f52f46c2cedd7
Reviewed-on: https://chromium-review.googlesource.com/1219127Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#590257}

TBR=schenney@chromium.org

Bug: 880983, 882649
Change-Id: I5d75f448106ad20adf8e9e02ab33883b7eaa54a8
Reviewed-on: https://chromium-review.googlesource.com/1219247Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#590256}

Some crashes in CloseAndLockAndDisturb may be caused by early collection
of the stream referenced by BodyStreamBuffer. Keep an extra reference to
the stream on the stack as a speculative workaround.

BUG=882599

Change-Id: I798a175cbac6414a7a70cfcb1e924624232a0a19
Reviewed-on: https://chromium-review.googlesource.com/1218123Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590255}

This reverts commit 88924f03.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 590251 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg4OTI0ZjAzOWQwYjk2NjI2YzMzYzIxODNiZDE3Nzk1MmIwMGEyYTYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/16046

Sample Failed Step: compile

Original change's description:
> blink/bindings: ASAN checks to ensure proper ParkableString accesses.
> 
> A ParkableString underlying string memory should not be cached.
> Following a suggestion by pasko@, add ASAN instrumentation to make sure
> this is actually the case.
> 
> Bug: 877044
> Change-Id: I463ad229b118f2e629b460f1a2beed41fc54b6a7
> Reviewed-on: https://chromium-review.googlesource.com/1216422
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590251}

Change-Id: I3ce53830604e42a6bef13da80a420c44b9d5df11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 877044
Reviewed-on: https://chromium-review.googlesource.com/1218548
Cr-Commit-Position: refs/heads/master@{#590254}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1bfa8980a363..a2ceb19a3a9a


git log 1bfa8980a363..a2ceb19a3a9a --date=short --no-merges --format='%ad %ae %s'
2018-09-11 saklein@chromium.org Port cros_choose_profile to a chromite python script.


Created with:
  gclient setdep -r src/third_party/chromite@a2ceb19a3a9a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ifdcffd368a45120135306a15b3a364df55f97929
Reviewed-on: https://chromium-review.googlesource.com/1218545Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590253}

The benchmark cannot report metrics correctly for WebView. Also WebView
cares about different startup scenarios and has its own stories for
that.

Bug: 880091
Change-Id: I76bec3c24843a5429bfeec45a53439b19b3d7ef6
Reviewed-on: https://chromium-review.googlesource.com/1217103Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590252}

A ParkableString underlying string memory should not be cached.
Following a suggestion by pasko@, add ASAN instrumentation to make sure
this is actually the case.

Bug: 877044
Change-Id: I463ad229b118f2e629b460f1a2beed41fc54b6a7
Reviewed-on: https://chromium-review.googlesource.com/1216422Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590251}

The bottom toolbar tip doesn't use the isUserEngaged variable.
This allows us to display the tip multiple time during the isUserEngaged
period, for example during test.

Bug: 881829
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia4559353aaf831abeb34fd01bf4f4911d1a3267e
Reviewed-on: https://chromium-review.googlesource.com/1215208Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590250}

This reverts commit 87036e9b.

Reason for revert: Compile failure: https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/146603

Original change's description:
> [Android] Use a delegate for all keyboard visibility functions
> 
> This CL extends the use of the visibility delegate from affecting
> only the isKeyboardShown() function to all keyboard-related methods.
> 
> Using a delegate is also the first step to move towards binding
> the keyboard detection to WindowAndroid. This enables other
> components like the keyboard accessory to affect the visibility on
> an activity-specific level (instead of global and static).
> 
> These changes require more work and will follow in further CLs.
> 
> TBR=joedow@chromium.org
> TBR Reason: Renamed an interface which doesn't change any behavior.
> 
> Bug: 857460
> Change-Id: Ia878e84221d68c4a7c90a0dd2bbce9c8858d98bf
> Reviewed-on: https://chromium-review.googlesource.com/1190523
> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590243}

TBR=tedchoc@chromium.org,joedow@chromium.org,mdjones@chromium.org,fhorschig@chromium.org

Change-Id: I328fee1ed53a9e32a5ce3fb3092c5b3a6dd36887
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857460
Reviewed-on: https://chromium-review.googlesource.com/1219126Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590249}