GitLab

On platforms that don't support installing plug-ins, show a "plug-in
unsupported" message instead of a "missing plug-in" message.

BUG=158871

Review URL: https://codereview.chromium.org/11414010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171021 0039d316-1c4b-4281-b951-d872f2087c98

Finding the routing id requires LaunchSelLdr to run from the
main thread.  However, some sel_ldr instances host nexes that do
not actually need to use Pepper APIs (e.g., the PNaCl translator),
and should be run on a background thread.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=3176


Review URL: https://chromiumcodereview.appspot.com/11428063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171020 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/11299338

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171019 0039d316-1c4b-4281-b951-d872f2087c98

Whenever the active tab is an Instant search results page,
|instant_tab_| is used to talk the Instant API with it.

Also:
+ Replace uses of TabContents with WebContents as much as possible (in
  service of @avi's goal, http://crbug.com/107201).
+ Aggressively create the InstantLoader in many situations; update
  browser tests accordingly.
+ Don't send an initial resize on page load. This was only relevant for
  the erstwhile hidden Instant modes.
+ Delay delete the loader only when strictly necessary, such as when an
  InstantLoader method is on the call stack. At other times, prefer the
  much simpler loader_.reset().
+ Don't bother resetting state. Resetting state has no practical
  benefit, since we already only use state variables when they are
  valid. Instead, this avoids tricky situations where we should NOT
  reset state just because the |loader_| is deleted (since the
  |instant_tab_| may still be in use).
+ Given the above two, remove DeleteLoader() entirely.
+ Separate out the magic in Hide() into three pieces: Hide(),
  HideInternal() and a couple of places where we want to preserve
  |last_full_text_|. I think this makes things slightly clearer.

BUG=158942
R=jered@chromium.org,samarth@chromium.org,sky@chromium.org
TEST=Commit a query. Change mode to News. Type another query. You should
see results in News mode.

Review URL: https://chromiumcodereview.appspot.com/11421079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163104


Review URL: https://chromiumcodereview.appspot.com/11412302

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171017 0039d316-1c4b-4281-b951-d872f2087c98

The LabelButton hosts a Label to paints its text content. When the button
is disabled, that Label needs to be disabled as well so that it can paint
itself grayed out.

BUG=155363,162729


Review URL: https://chromiumcodereview.appspot.com/11411358

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171016 0039d316-1c4b-4281-b951-d872f2087c98

Now when using system protobuf the wrapper copies all relevant
.proto files to a temporary directory and removes parts not supported
by system protobuf.

No rewriting is done when using bundled protobuf (default).

BUG=157155

Review URL: https://codereview.chromium.org/11418310

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171015 0039d316-1c4b-4281-b951-d872f2087c98

Avoids a NULL deref when then image filter is NULL.

BUG=wkb.ug/103990
TBR=jamesr
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11308354

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171014 0039d316-1c4b-4281-b951-d872f2087c98

The tab drawing code had a spurious "+ 1". Move that into the
tab height, so that other places that look at this (such as the
tab drag-out code) get a consistent value.

The new height also matches the height of the corresponding bitmap:
chrome/app/theme/def_100/mac/tab_active_left.png ist 29px high and
has empty pixels at the top.

BUG=52468
TEST=drag out tab. tab in new window looks good.

Review URL: https://codereview.chromium.org/11419302

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171013 0039d316-1c4b-4281-b951-d872f2087c98

ProfileImplIOData::http_server_properties_manager_ is kept in sync and used to access the implementation.

This change moves ownership of HttpServerPropertiesImpl from OffTheRecordProfileIOData to ProfileIOData and
ensures http_server_properties_ outlives ChromeURLRequestContexts owned by ProfileIOData.

BUG=161832


Review URL: https://chromiumcodereview.appspot.com/11316320

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171012 0039d316-1c4b-4281-b951-d872f2087c98

This CL did the following:

1. Save/update manifest in chrome.storage.local when user successfully
requested latest manifest from server. If user failed to get manifest
from server(offline or server error), fallback to the manifest saved
in chrome.storage.local last time.

2. Lazily saves all requested thumbnails to thumbnails directory. And
load from that directory when user open wallpaper picker next time. Note
that thumbnails are shared across user session. So after one user saved
thumbnails, all other users will directly use the thumbnails that saved
in thumbnail directory.


BUG=158668


Review URL: https://chromiumcodereview.appspot.com/11348215

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171011 0039d316-1c4b-4281-b951-d872f2087c98

Enable skia's separable mask blur.  Remove the SK_DISABLE_SEPARABLE_MASK_BLUR flag from skia.gyp, and suppress the resulting failures until they are rebaselined.

Review URL: https://codereview.chromium.org/11411361

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171008 0039d316-1c4b-4281-b951-d872f2087c98

This is to make sure it is not to blame for the recent working size set memory regression. Will revert this change when we have more data.

BUG=163697
TEST=None.
Review URL: https://codereview.chromium.org/11419312

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171005 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171004 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r10361: (mseaborn) Performance tests: Print more digits for timing results
r10362: (mseaborn) Fix __nacl_tls_combined_size() to account for ARM header alignment properly
r10363: (mcgrathr) toolchain_build: Fix stripping of objects and archives so they remain usable
r10364: (bsy) Add testing scons option tsan_command to work the same way as memcheck_command, and memcheck_trusted_only to skip untrusted code valgrind memcheck tests
r10365: (kschimpf) Add uses to decoders in table miscellaneous_instructions
r10366: (mseaborn) IRT: Fix free() of invalid address in thread_exit()
r10367: (jfb) ARM validator: reject conditionalized memory accesses as a proper SFI mechanism.
r10368: (mseaborn) Cleanup: Combine two TLS initialisation functions into one function
r10369: (mseaborn) Fix Chrome's irt_variant_test_scons_files to be added to nacl_irt_test_env
r10370: (jfb) s/NaClCPUFeature_/NaClCPUFeatureX86_/g
r10371: (sbc) Add gcc arm toolchain support to gyp build.
r10372: (hamaji) Fix pnacl-clang -v with no inputs
r10373: (sbc) Remove unused --save-downloads-dir option download_toolchains.py.

BUG=none
TEST=nacl_integration

Review URL: https://codereview.chromium.org/11412317

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171003 0039d316-1c4b-4281-b951-d872f2087c98

This involved:
a) Removing methods that used PrefObserver from PrefChangeRegistrar and PrefMember.
b) Removing implementation of PrefObserver from a few remaining classes.
c) Removing NULL PrefObserver parameter for classes using PrefMember but not wishing for a callback.
d) Updating unit tests and test utility classes.

Also fixed what was most likely a bug (or at least an unintentional change in behavior) that I had introduced in CoreChromeOSOptionsHandler in a previous change.  Before my series of PrefObserver-related changes, there was polymorphism involved and the subclass was only handling pref changes for a couple of preferences (kProxy and kUseSharedProxy, only one of which it registers for itself) if the PrefService was the standard one, not the incognito one, otherwise delegating to the parent class.

TBR=ben@chromium.org
BUG=155525


Review URL: https://chromiumcodereview.appspot.com/11316163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171002 0039d316-1c4b-4281-b951-d872f2087c98

The Skia build depends on arm_neon_optional=1 being defined in GYP_DEFINES
to enable dynamic NEON support. It looks like this option was lost in
translation during the upstreaming of build/android/.

Note that this won't fix crbug.com/161834, i.e. on JB and higher, the
sandboxing currently prevents the CPU feature detection from working, but
it's a first step in the right direction (it fixes the code for ICS devices
though).

BUG=164002

R=joth@chromium.org,torne@chromium.org,djsollen@chromium.org,tomhudson@chromium.org,reed@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11419299

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81265
TEST=When setting up sync using the gaia-based web flow, the user should have
the option to configure sync before it starts.  The UX should be same as the
native ui flow.


Review URL: https://chromiumcodereview.appspot.com/11418200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170999 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170998 0039d316-1c4b-4281-b951-d872f2087c98

TBR=svenpanne@chromium.org

BUG=


Review URL: https://chromiumcodereview.appspot.com/11348379

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170997 0039d316-1c4b-4281-b951-d872f2087c98

- "total ..." lines can have values bigger than 32-bit
- some servers use "l" as a flag in permission listing
- some servers prepend garbage to the month column
- NetWare directory listings can have spaces in file names
- one additional variant of VMS error message

BUG=none

Review URL: https://codereview.chromium.org/11418296

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163755
TEST=EncryptedMediaTest.FrameChangeVideo in content_browsertests using externalclearkey.

Review URL: https://codereview.chromium.org/11414226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:152937
TEST=Manual, user policy still works.

Review URL: https://codereview.chromium.org/11434053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170991 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163209, 162733

Review URL: https://codereview.chromium.org/11414271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170990 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11428136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170989 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/162100
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11414304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170988 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11415264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164176,164178,164179
TBR=glider
Review URL: https://codereview.chromium.org/11411360

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107201
TEST=no visible change


Review URL: https://chromiumcodereview.appspot.com/11434091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170985 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157093

Review URL: https://codereview.chromium.org/11421209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170984 0039d316-1c4b-4281-b951-d872f2087c98

Completely unmodified resubmit of https://codereview.chromium.org/11361265/

Actual bug causing previous submission to fail is fixed in https://codereview.chromium.org/11413054/

TBR=rlp@chromium.org,sky@chromium.org
BUG=154918

Review URL: https://codereview.chromium.org/11316090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170983 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67957,125928
TBR=glider
Review URL: https://codereview.chromium.org/11308352

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163728
TBR=robertshield

Review URL: https://codereview.chromium.org/11411359

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161880
TBR=nkostylev

Review URL: https://codereview.chromium.org/11428124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170977 0039d316-1c4b-4281-b951-d872f2087c98

This code was accessing preferences and it was asserting
in Debug mode because it was being run on another thread.

BUG=99504,164000

Review URL: https://codereview.chromium.org/11299312

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170976 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for refreshing public account policy, which
doesn't have a PrefService at its disposal. CloudPolicyManager now takes
care of extracting the pref value and passing it on to
CloudPolicyRefreshScheduler.

BUG=chromium:152937
TEST=unit tests


Review URL: https://chromiumcodereview.appspot.com/11299305

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161233

Review URL: https://codereview.chromium.org/11428083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170973 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/11316240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170969 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11364068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170968 0039d316-1c4b-4281-b951-d872f2087c98