- 31 Jul, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b8cc1cc..15016c7f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id4c0b59e6a43ce82a7bdcf6374ba3d4ed9dc8f4d Reviewed-on: https://chromium-review.googlesource.com/1157130Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579585}
-
Fabrice de Gans-Riberi authored
This reverts commit de31a634. Reason for revert: This has made the Mac10.12 Tests content_unittests fail on the following tests: WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess180 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationGreater360 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess90 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess360 WebInputEventBuilderMacTest.BuildWebTouchEvents See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14711 Original change's description: > Make pen inputs behave like touch inputs on MacOS > > Currently on MacOS the pen behaves like a mouse input, because we > generate mouse events for the pen input. We agreed that the pen input > should behave like a touch input, so we now send touch events instead. > > Bug: 854354 > Change-Id: Iac7910e250020a8125a57fb6055fb282db3faf0e > Reviewed-on: https://chromium-review.googlesource.com/1136721 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579482} TBR=meacer@chromium.org,tdresser@chromium.org,lanwei@chromium.org,nzolghadr@chromium.org Change-Id: I51b85daec63d39ef9aebb9dd727def7dfd7ca432 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854354 Reviewed-on: https://chromium-review.googlesource.com/1157304Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579584}
-
Ben Pastene authored
They were accidentally re added in https://chromium-review.googlesource.com/c/chromium/src/+/1145768 Bug: 869456 Change-Id: Ifb991ccc82980e2f51d38ad29ae1b3b7f206d5ad Reviewed-on: https://chromium-review.googlesource.com/1157188Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#579583}
-
Lu Chen authored
Finch is used to control the scales of each feature when calculating navigation scores. This CL is blocked on 1132680. Bug: 850624 Change-Id: I422f1e7f9f9db17530694d7445ab1233976f5930 Reviewed-on: https://chromium-review.googlesource.com/1152037 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#579582}
-
Mao Huang authored
dump. Original CLs: - http://codereview.chromium.org/6532051 Fix heap profiler to always append the process id to the heap dump. To run Chrome: HEAP_PROFILE_ALLOCATION_INTERVAL=1000000 HEAPPROFILE=heapprof out/Debug/chrome To analyze: pprof --text out/Debug/chrome heapprof.21026.0039.heap pprof --gv out/Debug/chrome heapprof.21026.0039.heap (pprof is slooow) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86273 - https://codereview.chromium.org/8957007 Change the heap file names to be Cleanup'ed in third_party/tcmalloc/chromium. In spite of Chromium's changing heap file names dumped in heap-profiler.cc:DumpProfileLocked(), the file names cleaned-up in heap-profile-table.cc:HeapProfileTable::CleanupOldProfiles are not modified. (See the difference between third_party/tcmalloc/chromium/src/heap-profiler.cc and .../vendor/src/heap-profiler.cc) This patch is originally from http://codereview.chromium.org/7865021/. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114777 BUG=724399,b:70905156 Change-Id: Iab590a6a34f3e3922b0958460169e517accef7df Reviewed-on: https://chromium-review.googlesource.com/1130782 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#579581}
-
Hector Carmona authored
Bug: 832938 Change-Id: Ie3cec973be983a74aff44a3e77e99a3789044fec Reviewed-on: https://chromium-review.googlesource.com/1145596 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579580}
-
Reid Kleckner authored
The temporary base::Optional<PersistentWindowInfo> object is destroyed at the end of the full expression in this statement: const auto& persistent_window_info = *window_state->persistent_window_info(); Avoid the lifetime issue by making a copy of the small struct. This bug was found by ASan after a clang change to more accurately track the lifetime of temporaries like these. TBR=afakhry@chromium.org Bug: 869067 Change-Id: Ibb4cd6761ec29fc09cd42c75b8d7bb13844f5352 Reviewed-on: https://chromium-review.googlesource.com/1157256Reviewed-by:Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579579}
-
Yao Xiao authored
Bug: 863889 Change-Id: Ib1c68ca3053f3dfea5e06e40127a74634e45f6da Reviewed-on: https://chromium-review.googlesource.com/1140204Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#579578}
-
sczs authored
Changes the title and subtitle contentCompressionResistancePriority to prevent them from being compressed by the stackView. Bug: 862744 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0587b639cb76215c7f1c5b3bc26fdf87a21ab7c3 Reviewed-on: https://chromium-review.googlesource.com/1157197 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#579577}
-
Wei-Yin Chen (陳威尹) authored
Parameters |white_list| and |black_list| in FilterSourceFile() take iterables of strings, and they don't have to be tuples. Single-entry tuples are harder to read. The trailing comma could be confusing, especially in a list of arguments. They are converted to lists in this CL. Bug: None Change-Id: Iec5ed2f1e2d25bacf444165b734f76eaa3375aff Reviewed-on: https://chromium-review.googlesource.com/1155708 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#579576}
-
Sarah Hu authored
Also added strings and image for fingerprint unlock UI. Bug: 835357 Change-Id: I8b7f1de78121cdef8b831f1fe2373674705cee7b Reviewed-on: https://chromium-review.googlesource.com/1157064 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#579575}
-
Sam Maier authored
maybeMergeTabs is called on cold starts. It's an expenisve operation, and doesn't appear to do anything except in the case when there is a process restarted, as in https://bugs.chromium.org/p/chromium/issues/detail?id=657418 Testing: followed the Testing Multi-Instance Merging testing doc. https://docs.google.com/document/d/1KDykYo9M63O0zFeDdrV9BUYtomQl4dVnbVgssCyydng Bug: 867596 Change-Id: I1a0a42fe75d2487dfc71382d7fb55bbc0636e5a7 Reviewed-on: https://chromium-review.googlesource.com/1153438Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579574}
-
Michael Spang authored
This test is broken - it's trying to verify that non-matching modifiers will cause screen manager to reject the current buffer for modesetting, but currently we do accept the buffer. The only reason the test passes is because the EXPECT_NE() checks that the framebuffer id doesn't match the current framebuffer, when it should check the opaque framebuffer id. Bug: 868010 Change-Id: I1f2312e6bc698f68f3806afd79ac07c19c3027cb Reviewed-on: https://chromium-review.googlesource.com/1155914 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579573}
-
Stephen Martinis authored
Uses the bit.ly/chromium-build-naming naming scheme. Re-land which shouldn't break builders. Depends on https://crrev.com/c/1155263 Bug: 867725 Change-Id: I230121d1e531de5aeaeb34f09e2b1b6432008eff Reviewed-on: https://chromium-review.googlesource.com/1153616Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579572}
-
Sam Maier authored
Currently, the AsyncTask that creates the Calendars is on the SERIAL_EXECUTOR - this is causing a lot of ANRs. Since it doesn't appear to require any synchronus guarantees with anything else in the SERIAL_EXECUTOR, we can move this to the THREAD_POOL_EXECUTOR. This means when we block on calendar creation using get(), we don't have to wait on all tasks currently in the SERIAL_EXECUTOR finishing. Bug: 866998 Change-Id: I3eb3a9c3b59771f4696fa1e17856e6fcb192388a Reviewed-on: https://chromium-review.googlesource.com/1157195Reviewed-by:
-
Kurt Horimoto authored
This prevents voice over from scrolling to these screens when they aren't visible. Bug: 865938 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b27176c59a496fc0bb38468cfe11670c79529bd Reviewed-on: https://chromium-review.googlesource.com/1152366 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579570}
-
Michael Spang authored
ScanoutBuffer is used to wrap a framebuffer, so call it that. Bug: 869206 Change-Id: Idf748e60b4bbaed774cd91e9c3d35cb3778bae26 Reviewed-on: https://chromium-review.googlesource.com/1155912 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2a99c0bf6765..45a4c41eda90 git log 2a99c0bf6765..45a4c41eda90 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 mbonadei@webrtc.org Never invoke rtc::LogMessage::SetLogToStderr outside of main. Created with: gclient setdep -r src/third_party/webrtc@45a4c41eda90 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I31947d2e4aa6ee452ffb9b836522635cc5bd16bd Reviewed-on: https://chromium-review.googlesource.com/1156910Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579568}
-
Dirk Pranke authored
At one point we were capacity-constrained on the Mac CQ, and so in order to switch running the tests from 10.9 to something newer, I was forced to split the tests between 10.12 and 10.13. Really, they should all be on 10.13 since the CQ is configured to mirror the 'Mac 10.13 Tests' bot. This CL starts to fix that by configuring traffic splitting using the multi-dimension trigger script; this should start shifting the layout tests to 10.13. Eventually we'll rebalance the pools and run them exclusively on 10.13 when we have enough capacity. R=jbudorick@chromium.org, kbr@chromium.org BUG=853356 NOTRY=true Change-Id: I549c5e5b9e149d78606e692679d03e055be14ab7 Reviewed-on: https://chromium-review.googlesource.com/1111030 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Sky Malice authored
Bug: 831648 Change-Id: I3a9525384ca17c05f38748fc3592af3f46f742db Reviewed-on: https://chromium-review.googlesource.com/1089930 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#579566}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c2ace4e71f59..a52306a4a7f2 git log c2ace4e71f59..a52306a4a7f2 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 michaschwab@google.com Overview Brush Timeline Created with: gclient setdep -r src/third_party/perfetto@a52306a4a7f2 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I18d7f9dcd8969be782638e64667a1669e36c2ecb Reviewed-on: https://chromium-review.googlesource.com/1156913 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579565}
-
Trent Apted authored
Doing so requires it to detached and re-attached as a child window of the browser. Even though the status bubble has NSWindowCollectionBehaviorTransient, this triggers a space switch due to rdar://9037452 . Note the status bubble can still be hidden implicitly in other ways. E.g. Cmd+h, or miniaturizing the browser window. Bug: 866760, 31821 Change-Id: Iaf6220bf39bb62cb6002ebd372b96abb10db4f38 Reviewed-on: https://chromium-review.googlesource.com/1155274Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#579564}
-
Trent Apted authored
Normally drags initiated via views::View::ProcessMouseDragged() complete in views::View::DoDrag() once exceeding their drag distance threshold. However, DownloadItemView doesn't set a views::DragController or override View::GetDragOperations(). Instead, it runs its own drag in an override of View::OnMouseDragged(). This drag code path isn't aware of the Widget::SetCapture() call done in Widget::OnMouseEvent(), which needs to be released before an OS-level drag can take place. Usually this is done by views::DragDropClientMac, which gets skipped. To fix, ensure the custom OS-level drag codepath in download_item_drag_mac.mm releases capture instead. Bug: 863377 Change-Id: Ib2f7c80a00dd3b38fe5a98475bddb4e595f3f83c Reviewed-on: https://chromium-review.googlesource.com/1156192Reviewed-by:
-
Yuwei Huang authored
We have received quite a few feedback reports complaining about the confusion in the host setup process. Some users set up an IT2ME host instead of ME2ME host while others don't realize they need to refresh the page after the host has been set up. This CL improves the setup instruction by pointing the user to the new ME2ME setup page, replacing confusing phrase, and telling people to refresh the page. Bug: 869511 Change-Id: I6a91e5bd6e6b3e82999bc1a55c84a0bb0ab9b028 Reviewed-on: https://chromium-review.googlesource.com/1156045Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#579562}
-
Sebastien Marchand authored
This makes TabManager aware of the navigation events happening on a frozen tab (e.g. by right-clicking + choosing reload on a frozen tab). Bug: 775644, 867647 Change-Id: I3877a40884f4c365390202bd5a1d696b17c69b54 Reviewed-on: https://chromium-review.googlesource.com/1133958Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#579561}
-
Quinten Yearsley authored
This would make it work correctly if anyone else runs into the issue with some other message in the output before the issue number, although this is still just a hack. Bug: 868469 Change-Id: Ib0a66a4374ae4db9807d11feb3d150d261ce0dd6 Reviewed-on: https://chromium-review.googlesource.com/1156994Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#579560}
-
Michael Giuffrida authored
Adds a third option for stylusStatus: - "seen" if supported and stylus has been used at least once or the device comes with an internal stylus. Follow-up to https://crrev.com/c/1123320. eve: "supported", then "seen"; caroline: "seen") Bug: 632814 Test: browser_tests, manually (banjo: "unsupported"; Change-Id: I155dd3e98e5d68990aef304be5ac6c1d8d4f5edc Reviewed-on: https://chromium-review.googlesource.com/1123397 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#579559}
-
Bence Béky authored
Bug: 807724 Change-Id: I5972e59d700236f845c2eb2cc578d6781c602b85 Reviewed-on: https://chromium-review.googlesource.com/1154693 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#579558}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 017b6770. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22175 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I7d6746395e597dfa397ef2d91028ff23305918d3 Reviewed-on: https://chromium-review.googlesource.com/1157117 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#579557}
-
Dirk Pranke authored
This re-lands r569466 (reverting 569703) with the needed fixes. This brings the test results more into compliance with the current test result standard in bit.ly/chromium-json-test-results-format. Notable changes: - If a test is run multiple times, we explicitly return every `actual` result. Previously, if the test produced the same result every time, we'd only return a single value for `actual` - If a test is skipped unexpectedly, that will be considered a regression and an unexpected result. - The test results will contain `is_unexpected`, `is_flaky`, and `is_regression` fields for the matching conditions. Bug: 837047, 822078 Change-Id: I98a80deb2e7e095fe471507a04e80b8b583ed5cc Reviewed-on: https://chromium-review.googlesource.com/1154107 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Kyle Milka authored
Bug: 850309 Change-Id: I84e20a2895cd1af8e01c86b33f64d787b0055ce2 Reviewed-on: https://chromium-review.googlesource.com/1147215Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#579555}
-
James Cook authored
We used to fall back to the old non-app version, but the app works fine with the focus highlight feature. Switch access is still under development. dmazzoni said not to worry about it. Bug: 841020 Test: manual, turn on "Highlight object with keyboard focus" and use shortcut viewer app Change-Id: If45a9e67add82287e39d20633e98c2e992e71119 Reviewed-on: https://chromium-review.googlesource.com/1153350 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Mathieu Perreault authored
To load the NTP faster, we include config.js data in the local ntp page's initial resources instead of later added by local_ntp.js To achieve this, we refactor into the SearchConfigProvider and cache the config data. It will be recomputed on Search provider change. We also now declare the CSP as part of a <meta> tag instead of headers, since in URLDataSource the headers are created on the IO thread and the response on the UI thread. Doing everything in the local_ntp.html response avoids races nicely. Bug: 868432 Change-Id: Iab38ca2b2e032a58c2d404938065a612b08cc69a Reviewed-on: https://chromium-review.googlesource.com/1154687Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579553}
-
Shimi Zhang authored
We want to set icon to null when shouldShowIcon() returns false for primary action. Bug: 869500, b/111806618 Change-Id: I44203568fb167899ab25fd5d2d3dff13f6723c46 Reviewed-on: https://chromium-review.googlesource.com/1157120Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#579552}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b303a427c03d..e782f8472f61 git log b303a427c03d..e782f8472f61 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 bsalomon@google.com Remove GrResourceIOProcessor. 2018-07-31 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 2925dc93401c..f80f027f8ac9 (1 commits) Created with: gclient setdep -r src/third_party/skia@e782f8472f61 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I76cd03a32ebdc9f58633e185af5b040e68bd6093 Reviewed-on: https://chromium-review.googlesource.com/1156911Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579551}
-
tzik authored
The first reference to a TrackedPreferencesMigrator instance used to be made in its constructor implicitly. Though this case is safe as the reference keeps alive until the other reference is made, it's error prone to make the first reference in the ctor, and an upcoming change to base::Bind rejects to make the first reference. This CL moves the implicit ref count manipulation through base::Bind() out of the constructor, so that we can avoid making the implicit first reference creation. Bug: 866456 Change-Id: I3563296c0f972d57ad8cc0c2f6e32658b9d6293d Reviewed-on: https://chromium-review.googlesource.com/1156706Reviewed-by:
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: Iaff688980eaf782b8fb1c5923da0125f4b3755e9 Reviewed-on: https://chromium-review.googlesource.com/1152555Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#579549}
-
Boris Sazonov authored
Recently added ConsentBumpFragment actually implements the consent bump screen with advanced options, so this CL renames this fragment to ConsentBumpMoreOptionsFragment. Bug: 869426 Change-Id: Id002d77e12420308efb94af9c9f192ab5becd3e1 Reviewed-on: https://chromium-review.googlesource.com/1157008Reviewed-by:
-
Bence Béky authored
Remove some dead code from HttpAuthHandlerMock: SetResolveExpectation(), NeedsCanonicalName(), ResolveCanonicalName(), OnResolveCanonicalName() methods, Resolve enum, resolve_ member. Change-Id: I87a7904f41433eb5e649ddc039e6d12ceb211edd Reviewed-on: https://chromium-review.googlesource.com/1154347Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579547}
-
Tessa Nijssen authored
According to the description for Replace() in input_handler.mojom, Replace() will replace the current selection, and if there is none, it will select the word around the caret and replace that word. However, in FrameInputHandlerImpl::Replace(), the word around the caret is only selected if there is a selection (and not just a caret). This is not in line with the description given above. To fix this, the check that the WebLocalFrame has a selection is negated. If the WebLocalFrame does not have a selection, the word around the caret should be selected. Otherwise, the selection should be left as is. Bug: 869512 Change-Id: I288ab40fcfa10e0c04ad442e25f2404e0c700a14 Reviewed-on: https://chromium-review.googlesource.com/1157035Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#579546}
-
