- 03 Nov, 2018 37 commits
-
-
file://.../*.svgzChris Mumford authored
Chrome supports loading gzipped SVG files from the file scheme which was unsupported with the network service implementation. Note: The non-network service implementation of *.svgz loading is currently broken on Linux, but works on Windows and macOS. This change works on both platforms. Bug: 857117 Change-Id: Id90deba4761ea67d4ac7bef681051ea9326e113b Reviewed-on: https://chromium-review.googlesource.com/c/1268960 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605136}
-
Xi Cheng authored
Change-Id: I837334681a63e4d174e6bc2a9da67ef8db139db3 Reviewed-on: https://chromium-review.googlesource.com/c/1316099Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#605135}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c9e75f29605..535c96c5642a Created with: gclient setdep -r src-internal@535c96c5642a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2bab0946388f183eecf34741cfdb3905c9bc38cd Reviewed-on: https://chromium-review.googlesource.com/c/1316848Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605134}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/19502fd6..3ad9cf63 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibed999ac4b342fde632a86bf09d13cc6c06992d5 Reviewed-on: https://chromium-review.googlesource.com/c/1316829Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605133}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fec80c41355c..a98da076b9e5 git log fec80c41355c..a98da076b9e5 --date=short --no-merges --format='%ad %ae %s' 2018-11-03 mbinette@google.com Add CELab gclient config Created with: gclient setdep -r src/third_party/depot_tools@a98da076b9e5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1da4f7cc06f1f3b3c7eb543a44823e80fac3b101 Reviewed-on: https://chromium-review.googlesource.com/c/1316847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605132}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d6db27cfd2f7..1edff303fddb git log d6db27cfd2f7..1edff303fddb --date=short --no-merges --format='%ad %ae %s' 2018-11-02 reed@google.com SkPaint::Align is dead 2018-11-02 herb@google.com Remove one field of unique data from SkGlyphCacheBuilder 2018-11-02 brianosman@google.com Remove one more unused macro 2018-11-02 benjaminwagner@google.com [Infra] Switch to latest Win10 in Skolo. 2018-11-02 herb@google.com Make special SkRunFont ctor in SkPaint private again 2018-11-02 brianosman@google.com Simplify bitmappremul GM a bit, remove more SkColorData 4444 macros 2018-11-02 herb@google.com Make glyph runs const in the glyph run list. 2018-11-02 jvanverth@google.com Add SK_API to SkYUVASizeInfo def 2018-11-02 mtklein@google.com remove SkUnpremultiplyRow() 2018-11-02 mtklein@google.com DeMorgan's blend-on-black logic 2018-11-02 brianosman@google.com Leverage readPixels to simplify PDF bitmap output 2018-11-02 herb@google.com Remove mutablePaint from glyphRuns 2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 caeb1e895d7b..6ba22ee13768 (3 commits) 2018-11-02 mtklein@google.com implement most SkImageEncoderFns with skcms 2018-11-02 brianosman@google.com Remove colorType switches in SkBitmap and SkBitmapDevice 2018-11-02 mtklein@google.com make big-endian very opt-in 2018-11-02 brianosman@google.com Remove SkUnPreMultiply::UnPreMultiplyPreservingByteOrder 2018-11-02 mtklein@google.com transform_scanline_888x is transform_scanline_RGBX Created with: gclient setdep -r src/third_party/skia@1edff303fddb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I195f1a9f5e006f510c77be502066692da84b2376 Reviewed-on: https://chromium-review.googlesource.com/c/1316348Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605131}
-
Vikas Soni authored
Remove VulkanContextProvider from viz common build target and create a new target. This is required so that the files which needs to only use VulkanContextProvider can depend on this new target rather than depending on whole viz common. Bug: 891060 Change-Id: Iddff176837a43f029b6466c4b31fedb508d1fb79 Reviewed-on: https://chromium-review.googlesource.com/c/1313114Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#605130}
-
Dale Curtis authored
libaom has fixed all the framebuffer issues, so we should now be able to use these. All tests pass and YouTube videos look good. Seems only a minor memory savings ~2mb on a 480p clip. This also resolves an issue with clipping of 64-bit timestamps passed in as a void* (which might be 32-bit on some platforms). BUG=867613,900302 TEST=existing tests all still pass. Change-Id: I83af8ecd867e13741f27f5225316b62f31981562 Reviewed-on: https://chromium-review.googlesource.com/c/1316408 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#605129}
-
Andreas Butler authored
Fixing minor nits with IndexedDBFactory databases() WPTs as suggested by jsbell@ over email -assert_object_equals is deprecated and shouldn't be used. Prefer to test the results explicitly, even though it's more code. -all of the test cases use 1 for the version - we should have tests for databases at other versions. -the assertion messages should have the form ".... should be ...", describing what is being asserted, rather than attempting to diagnose the problem (it's easier to verify that the assertions match the spec that way) -there are a handful of lines missing semicolons -the trailing done() should not be needed for .any.js tests Bug: 899085 Change-Id: Ie8831c26fabe0e043ccba8238925ac7f520d1d69 Reviewed-on: https://chromium-review.googlesource.com/c/1313275Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Andreas Butler <andreasbutler@google.com> Cr-Commit-Position: refs/heads/master@{#605128}
-
Antoine Labour authored
Calling code (CommandBufferStub via GpuChannel) doesn't check that the GMB handle type corresponds to the correct platform-specific handle (indeed it doesn't have a way to). So check in the GpuMemoryBufferFactory* classes and fail if the handle type is invalid. Bug: 870116 Change-Id: I78b574439350bee3dccda569e53eae7f74c7d0a7 Reviewed-on: https://chromium-review.googlesource.com/c/1316168Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605127}
-
Asanka Herath authored
Bug: None Change-Id: I881f20202ff1efaa2655173366f4f9ae5b86cdad Reviewed-on: https://chromium-review.googlesource.com/c/1300777Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#605126}
-
Sergey Ulanov authored
Now renderer will try to use FuchsiaVideoDecoder on Fuchsia before falling back to SW decoders. Also moved FuchsiaVideoDecoder implementation from //media/gpu to //media/filters since it will be used in the renderer process. Bug: 876519 Change-Id: Iad682c2dbcf4b100406891d722e818435d04bfda Reviewed-on: https://chromium-review.googlesource.com/c/1300686Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605125}
-
Ted Meyer authored
Newer hardware supports, and encrypted media requires D3D11VideoContext1 usage, while older hardware might only have support for D3D11VideoContext. We should support both of these seamlessly. There are also other levels of video context, and this should make it easy to add support should we ever require that. This should hopefully help mitigate some crashes we are seeing on older hardware. Bug: 897785 Change-Id: I46c913ba64036c2bc6ef655026f1cd90d0ab4684 Reviewed-on: https://chromium-review.googlesource.com/c/1298636 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#605124}
-
Erik Luo authored
Focused Objects in Console will now have tabIndex -1 instead of 0. Bug: 865674 Change-Id: I382576e1b5ec5ca0bc1c62b8ff0d998c73b18474 Reviewed-on: https://chromium-review.googlesource.com/c/1275266 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#605123}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0367d1a1fb0a..2039ee7dced5 git log 0367d1a1fb0a..2039ee7dced5 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 qingsi@webrtc.org Revert "Delete rtc::Pathname" 2018-11-02 mellem@webrtc.org Implement data channel methods in LoopbackMediaTransport. Created with: gclient setdep -r src/third_party/webrtc@2039ee7dced5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic5554c169351a5515d258d12f129a5c7f9e81d20 Reviewed-on: https://chromium-review.googlesource.com/c/1315811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605122}
-
Siddhartha authored
1. Gets the register context from signal handler and sets all registers correctly before using libunwind. This avoids crashes if registers are used for unwinding frames. 2. Removes the need for unwinding signal handler function since we get the context of the stopped function directly. BUG=859260,888434 Change-Id: Ib337f20c19e25e2f82e61b08f8e9ed4ac1195fde Reviewed-on: https://chromium-review.googlesource.com/c/1307055 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605121}
-
Daniel Rubery authored
This unit test currently waits for the timeout on network requests to occur before it verifies the proper request was sent. This CL adds a fake response so that the test runs quickly. Bug: 899898 Change-Id: I9e35086647cc80344488abb3319a538e90785eb9 Reviewed-on: https://chromium-review.googlesource.com/c/1316411Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605120}
-
Mitsuru Oshima authored
Updating to the same value can cause shelf state update. Check the value before setting. This is to merge 71. I'll change the impl side for 72. Bug: 895744 Test: manual. see bug for repro step. Change-Id: I9aad35098fc120dbfae365ddb79faf6af0069881 Reviewed-on: https://chromium-review.googlesource.com/c/1316590Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#605119}
-
Gyuyoung Kim authored
This CL introduces the following command-line switches: - max-appcache-disk-cache-size-mb - limits the size of the HTTP disk cache used by AppCache for all origins - max-appcache-origin-cache-size-mb - limits the per-origin AppCache quota when no QuotaManager is present The CL is heavily based on the following reverted commits: 1. https://crrev.com/c/974804 - Set the maximum cache size per an origin in the command line for application cache 2. https://crrev.com/c/979877 - Pass the maximium disk cache size of appcache in the command line to appcache thread Bug: 824619, 895825 Change-Id: I4fb424fa740ef9875d0584def4e9390aef366916 Reviewed-on: https://chromium-review.googlesource.com/c/1282685Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#605118}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/468ff3e5a030..c02ed04700f7 git log 468ff3e5a030..c02ed04700f7 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 dpranke@chromium.org Reformat typ expectation parser code to match the surrounding style. 2018-11-02 dpranke@chromium.org Copy existing expectations parser into typ. Created with: gclient setdep -r src/third_party/catapult@c02ed04700f7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:835690,chromium:835690 TBR=sullivan@chromium.org Change-Id: Ica23fbe593b0950a5e061374af37497b7bc9e782 Reviewed-on: https://chromium-review.googlesource.com/c/1316548Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605117}
-
Morten Stenshorne authored
At least when using mock scrollbars from web tests (and maybe there are real use cases too?), NeedsScrollbarReconstruction() will return true after layout, which will make us remove the current scrollbars. Legacy layout will re-lay out and eventually end up with updating the scrollbar rectangles. NG cannot re-lay out from PaintLayerScrollableArea::UpdateAfterLayout() like legacy does, but we do need to update the scrollbar rectangles anyway. NG has its own scrollbar size change detection mechanism, but in this particular case, the scrollbars would have the exact same size with the default skin and with the mock scrollbars, so no change would be detected, and there'd be no re-layout, and no call to UpdateScrollDimensions(). Without this fix, scrollbars/rtl/overflow-scroll-rtl.html would fail with https://chromium-review.googlesource.com/c/chromium/src/+/1297367 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I15e159e0c26ab9fe8469ae8ad2c0af0dabe7417b Reviewed-on: https://chromium-review.googlesource.com/c/1309741Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#605116}
-
Roberto Carrillo authored
R=liaoyuke,stgao,jbudorick Change-Id: I1b9568f37d7ab6813095c1078fc8380fce231723 Reviewed-on: https://chromium-review.googlesource.com/c/1316654Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#605115}
-
Mitsuru Oshima authored
This is 2nd attempt to land: crrev.com/c/1304973 [2] are the difference from above CL. *[2] Added null check in OnStartingAnimationComplete. * Pause occusion tracker during overview animation [2] wait 5000ms when exiting overview before resume because a user may re-enter overview [2] wait 50ms when entering overview before resume because it can take 2 frame to finish draing the frame after animation observer is called. * Activate the text filter after animation * [2]Animate shelf after overview animation. * [2] Improve blur animation: Use Compositor's AnimationObesrver to drive animation Progress only by 2 to reduce the frequency. * Don't animate backdrop window during overview animation. * Fix the bounds change issue in WindowGrid. It shouldn't change the parent window's bounds. in both clamshell and tabletmode. The web contents should load after animations without backdrop animation. No gap at the bottom of the screen after exiting overview mode. Bug: 898077, 897387 Test: no functional change. Manually tested visual change by entering/exiting overview mode Change-Id: I0e606af2ad2f8871108e17e6147e51d0b68b5ee6 Reviewed-on: https://chromium-review.googlesource.com/c/1316828Reviewed-by:Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#605114}
-
Sorin Jianu authored
The buggy code serializes the <disabled> tag before closing the <app> tag, like this: <app appid=...version="0.9" brand="TEST" enabled="0"<disabled reason="0"/> Bug: 901497 Change-Id: I2106ee35e99dd9c7fa66baab0c0efdc4942cab05 Reviewed-on: https://chromium-review.googlesource.com/c/1316441Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605113}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5af3a96bfa9f..ecb0098989c1 git log 5af3a96bfa9f..ecb0098989c1 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 lalitm@google.com Merge "trace_processor: remove order by on columns with equality filter" Created with: gclient setdep -r src/third_party/perfetto@ecb0098989c1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I98034715c87d5d67c89cf2d9c0d98ec567d6b5e5 Reviewed-on: https://chromium-review.googlesource.com/c/1315812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605112}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48a5c18d49ce..4c9e75f29605 Created with: gclient setdep -r src-internal@4c9e75f29605 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie8990e3c066b53b5f5731708039e834faf468347 Reviewed-on: https://chromium-review.googlesource.com/c/1315733Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605111}
-
James Cook authored
For lock screen app windows the window manager needs to specify the initial show state of the window. Ensure the client (chrome) does not overwrite the aura window show-state property in ash if the client window has ui::SHOW_STATE_DEFAULT. Fixes LockScreenNoteTakingTest.Launch pass under SingleProcessMash The reland changes FirstAppRunToastManager to use a WidgetObserver to watch for app window bounds changes. Mash tears down aura::Windows similarly to aura on MS Windows and Linux. The aura::Window for the app window can be destroyed before AppWindowRegistry notifies StateController and FirstAppRunToastManager that the app has been closed, so it's not safe for FirstAppRunToastManager::Reset() to manipulate the aura::Window to remove the ScopedObserver. See bug. TBR=sky@chromium.org TBR=tsepez@chromium.org Bug: 899055 Test: added to views_mus_unittests Change-Id: I886dbe45fe53708beb4441c1d9da2587a2352997 Reviewed-on: https://chromium-review.googlesource.com/c/1312972Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#605110}
-
Ken Rockot authored
Updates the mojo_core shared library so that it is actually suitable for production IPC use. Namely: - MojoInitialize now spins up a background thread for I/O and gives it to the core impl. - A flag is added to Initialize(), allowing shared library consumers to initialize themselves as a broker process. - The thunks helper correctly loads the mojo_core library with RTLD_DEEPBIND set, avoiding heap crossover within the core impl due to e.g. malloc and free lazy-binding to different heaps - Fixes the thunks header to compile as C once again, as it was missing some struct keywords. - Adds MojoShutdown to the core ABI as a necessary call for shared library consumers who want clean shutdown. This also adds a new multiprocess test consuming the shared library to tie together and validate all of the above changes. Bug: 809320 Change-Id: Ic1c56d99c86fd4a2dc7f812ee152994ced35ece6 Reviewed-on: https://chromium-review.googlesource.com/c/1306347 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605109}
-
Sophie Chang authored
Bug: 898982 Change-Id: I37d2006abe68282d9d068f7a19d7d501bd4ee5bd Reviewed-on: https://chromium-review.googlesource.com/c/1299919 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#605108}
-
Hao Zhang authored
[Autofill] create editableExpirationDate flag and determine when to request expiration date correctly Change-Id: I231263dece7fbb2a1a0eefdebb30a29c48e27d6b Bug: 899057 Reviewed-on: https://chromium-review.googlesource.com/c/1297696Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Hao Zhang <hozhng@google.com> Cr-Commit-Position: refs/heads/master@{#605107}
-
Regan Hsu authored
Add metrics for when DeviceSync succeeds or fails upon retrieving supported devices. Bug: 870138 Change-Id: I270d35effa7de2161544ead77929e2913d2b2108 Reviewed-on: https://chromium-review.googlesource.com/c/1313565 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#605106}
-
Elly Fong-Jones authored
This change has ViewTreeValidator account for the changed interior structure of NSButton on 10.14. This fixes FirstRunDialogControllerTest's LayoutWithLongStrings. Bug: 892176 Change-Id: Icc9e977034a98fbb587719770c326d082adb3743 Reviewed-on: https://chromium-review.googlesource.com/c/1316113 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605105}
-
Will Harris authored
This changes the default version of tcmalloc used by Chrome on Linux from a modified tcmalloc 2.0 to a modified tcmalloc 2.7. See discussion at http://shortn/_db7vovHkbm for benchmarks and analysis. BUG=724399 Change-Id: I75b89fcb0e22c2ca627634a6581c937608f4ce6f Reviewed-on: https://chromium-review.googlesource.com/c/1278949 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605104}
-
Jesse McKenna authored
Bug: 889029 Change-Id: I189f7a33aec070d882712f7360223cdc804b0fbf Reviewed-on: https://chromium-review.googlesource.com/c/1312929 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#605103}
-
Lukasz Anforowicz authored
Why remove DoesSiteRequireDedicatedProcess ========================================== This CL removes ShellContentBrowserClient::DoesSiteRequireDedicatedProcess. We plan to remove 2 other overrides of this ContentBrowserClient method in other CLs. We want to remove this ContentBrowserClient method altogether, because 1) it is currently the only reason SiteInstanceImpl::DetermineProcessLockURL needs to take BrowserContext* as an argument (and therefore is problematic on threads other than UI thread) 2) the method was initially introduced to support --isolate-extensions which has been obsolete since shipping --site-per-process in M67. Removal mechanics ================= agl@ (original author of the test) suggested to simply remove WebAuthJavascriptClientBrowserTest.RegisterDuringUnload for now. Change-Id: I5aeb3b113de642ef96d7a9abc35d0e9c42c45f86 Bug: 898281 Reviewed-on: https://chromium-review.googlesource.com/c/1308256 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#605102}
-
Regan Hsu authored
Add metrics for: (1) MultiDevice.DeviceSyncService.ForceEnrollmentNow.Result, and (2) MultiDevice.DeviceSyncService.ForceSyncNow.Result. Both currently are enumerated histograms with 2 buckets: (1) Success (2) Service not ready. Bug: 870138 Change-Id: I78acaea600885c1e44be249d37237a49f8b81e9f Reviewed-on: https://chromium-review.googlesource.com/c/1312569Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605101}
-
Ryan Hansberry authored
Bug: 899100 Change-Id: I96193d431fc13ea80068e0b44b7826a31a8e6003 Reviewed-on: https://chromium-review.googlesource.com/c/1316650Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605100}
-
- 02 Nov, 2018 3 commits
-
-
Mike Wittman authored
TBR=nhiroki@chromium.org Bug: 901317 Change-Id: I9f510e73e29d11e52e830b1ef63326e10ba257dc Reviewed-on: https://chromium-review.googlesource.com/c/1315936 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605099}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6ba22ee13768..1590fcc4d3ee git log 6ba22ee13768..1590fcc4d3ee --date=short --no-merges --format='%ad %ae %s' 2018-11-02 geofflang@chromium.org Add a spec and tests for GL_ANGLE_memory_size. 2018-11-02 syoussefi@chromium.org Implement missing posix utils Created with: gclient setdep -r src/third_party/angle@1590fcc4d3ee The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:892288 TBR=ynovikov@chromium.org Change-Id: I16ef2d3941c7b7fcbac1020513e265aaa2b06197 Reviewed-on: https://chromium-review.googlesource.com/c/1315814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605098}
-
Devlin Cronin authored
Flip the RuntimeHostPermissions feature to be enabled by default on ToT. Remove the entry in the testing config. Bug: 869996 Change-Id: Ic76c4a018c6bc0140069bd2730ff5591cd293bda Reviewed-on: https://chromium-review.googlesource.com/c/1294010Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605097}
-