- 29 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/28e801ad3afb..08a3cc4cfbaa 2020-07-29 amaiorano@google.com Add doc for testing with SWANGLE 2020-07-29 amaiorano@google.com Add doc on using ANGLE instead of SwiftShader GL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibbbc837e5e148b81923ce98ebe51cd742bcdbb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792924}
-
Sinan Sahin authored
Bug: 1110145 Change-Id: Ie0299b0564a5f6bd7cccb1358e113397dccd96e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327142Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#792923}
-
Scott Little authored
This CL updates almost all of the methods in components/translate/core/browser/translate_prefs.cc and components/language/core/browser/language_prefs.cc that previously took std::string as arguments to take base::StringPiece arguments. This CL does not change any functionality, and is only clean up. Bug: 1109032 Change-Id: I83a3a985cac6b947ee9e642f1b2e3f87d748112a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325104 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#792922}
-
Xinghui Lu authored
Add extended reporting and password leak detection toggles under the standard protection page. They are clickable only if Chrome is currently under standard protection mode. If Chrome is under enhanced protection mode, they are forced enabled; If Chrome is under no protection mode, they are forced disabled. If leak detection should be enabled but there is currently no account signed in, the toggle will be shown as disabled with an additional explanation under the toggle: http://screen/ROmpLDkUNAP before: http://screen/KdwYdsgcUf5 after: http://screen/4BXF3e8ZRSg Bug: 1097310 Change-Id: I25b60626f4c8b3622e87fe5c98baff22f0c3eea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311030 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#792921}
-
Peter Boström authored
Bug: 1002162 Change-Id: Ie8d88ebf7ade6f749bcc3adab913c501d9501d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327832 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#792920}
-
Sonny Sasaka authored
This adds the logic in BluetoothAdapterBluez, that whenever there is an event about a Battery object (addition, change, and removal) it updates the corresponding device's battery_percentage value. Bug: b:160905767 Change-Id: Iade2942f5638f8e6af1afbb8789afed56155fb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298325Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#792919}
-
Maxime Charland authored
All empty states of the Other Devices section will use the new TableViewIllustratedItem and its corresponding cell. Empty states that require a Signin promo will still contain a Signin promo of which only the button(s) will be visible. The TableView cell will always have the same image and the same title. However, the subtitle will be different for each empty state, to better explain to the user what to do in order to be able to use the Other Devices section. (Googlers only links) Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I0709219d617950db8057eee830aef9228d4b563b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308875 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#792918}
-
Dana Fried authored
Tablet mode has no restore functionality since all windows are effectively "maximized" even in split-screen mode. Bug: 1111019 Change-Id: I397c6a66cc9c337d0bb8e04e33bf8e4a44153d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327645Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#792917}
-
Dale Curtis authored
When we get bad device info, we don't setup the NullAudioSink for the suspend muted audio feature (we're already on a NullAudioSink). R=tmathmeyer Fixed: 1110780 Test: New unittest. Change-Id: I258db545723c0cdf4ab6a8a4ca319c4c88da8e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327250 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792916}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I5dd4f605e1a8ab160f0b6d5949bf40c61abbe7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327453Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792915}
-
Vikash Sharma authored
Keyboard shortcut(Shift + F10) triggers event with non-located context menu. In codepath where hit testing is done for the receiving element of event, calculation of center of focused element is not clipped to visual viewport bounds. This calculation of center can be incorrect and fall outside viewport area if element dimensions are much larger than visual viewport. In this case root html element is returned as result of hit testing, hence incorrect context menu shows up. This CL replaces BoundsInViewport() with VisibleBoundsInVisualViewport() to clip rect within viewport bounds. This calculates center of element area in viewport and eventually hit test for correct element to show up its context menu. Bug: 1101653 Change-Id: I6a6ff4bf5ba2d70eb3221449cad609b77370e6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299663 Commit-Queue: Vikash Sharma <vikash@microsoft.com> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792914}
-
zhaoyangli authored
Changed builder config in sdk builders. Changed tester configs in both sdk & beta builders. Ignore-CQ-Freeze: true Bug: 1109044 Change-Id: If12f3ea03c4ff985fed7fff14a90828b2a7f6f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316699Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#792913}
-
Kalvin Lee authored
This reverts commit e258c3f4. Reason for revert: user-reported regression Original change's description: > printing: don't construct StringPiece from nullptr > > This change modifies several call sites in printing code to avoid > constructing base::StringPiece instances from nullptr. > > Bug: 1102941 > Fixes: 1102941 > Test: autoninja ... chrome printing_unittests > Test: ./printing_unittests > Change-Id: If5797f6d41a03c9cfdf9eb5d40f063159a9193e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313978 > Commit-Queue: Kalvin Lee <kdlee@chromium.org> > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791622} TBR=skau@chromium.org,baileyberro@chromium.org,kdlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1102941 Change-Id: Ic26a6c2378578e12ae8af34ac498e3d8a57350f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324210Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#792912}
-
Jan Wilken Dörrie authored
This change fixes a bug in zcxvbn-cpp triggered when the number of computed guesses exceed DBL_MAX. Fixed: 1110991 Change-Id: I2751feea4c806049eef5faef9196d3f3dee00f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326633 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792911}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ab04da48f45d..03cf7c3eaeaf 2020-07-29 bryan.bernhart@intel.com Enable GBV by default for correctness tests. 2020-07-29 tommek@google.com Optimizing memcpy inside Queue::WriteTexture 2020-07-29 cwallez@chromium.org dawn_wire: Implement CreateBufferMapped on top of mappedAtCreation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I46ea28a9f726e09036e79cb0decd6f96381ab3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792910}
-
Yuwei Huang authored
This CL migrates a few remaining remaining gRPC requests (i.e. log to server, ICE config, register support host) initiated by the host to execute via Protobuf over HTTP. Bug: 1103416 Change-Id: I507914ce8c443adab5fea047df804e1815b94141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325231Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#792909}
-
Dave Tapuska authored
SetDisplayMode was only overridden by frame widgets, move the implementation into WebFrameWidgetBase. BUG=1097816 Change-Id: I1a097cdd20bbabb589adbfcbc51f3516bb0c79e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314978 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792908}
-
Jeffrey Cohen authored
This changes the ModalDialogManagerObserver calls to better reflect an accurate state of the ModalDialogs in chrome for android. The notifications previously did not properly handle the suspended states of the dialog queue properly. Bug: 1109694 Change-Id: Ic347ce07a563ccdc58fe4c5f989d8985c487fae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319343Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792907}
-
Robert Ogden authored
Adds DNS probing to Isolated Prerender which can be enabled by an experiment. Also adds a canary check, similar to the now removed data reduction proxy canary check, which removes the need to do probing before each prefetched navigation. Canary checks vary by network and are cached in the browser prefs, which is all done through the AvailabilityProber. Bug: 1109992 Change-Id: If1c00e692a7ba8e214a4ce4a7360a63d5835bcc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324106 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792906}
-
Kramer Ge authored
AcceleratedWidget used to have 1-1 relation with a wl_surface because a platform window was 1-1 with wl_surface. This is no longer the case with overlay forwarding where a platform window can consist of multiple wl_surfaces. With this CL ui::WaylandSurface* identifies a WaylandSurface, gfx::AcceleratedWidget identifies a WaylandWindow. This is 1/? CL for overlay forwarding using wl_subsurface. Bug: 1063865 Change-Id: I0636817dbc5533fd8f4e5f6890bf4deac365ab2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314138 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#792905}
-
Edward Lesmes authored
Change-Id: I56259bca22bf1726ef06c9002426ab080b219a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316690Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#792904}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96d6c6f04dcb..a40e7b77fbb1 2020-07-29 brianosman@google.com Add Skia.natvis to platform_tools/debugging 2020-07-29 senorblanco@chromium.org Fix MSVC build. 2020-07-29 reed@google.com Can't share encoded data if we have any modifiers 2020-07-29 mtklein@google.com don't let shaders know the destination is unpremul 2020-07-29 csmartdalton@google.com Make tessellation join type values negative 2020-07-29 mtklein@google.com skvm sprite blitter 2020-07-29 rmistry@google.com Use storage.ErrObjectNotExist in Canary-G3 2020-07-29 bungeman@google.com SkUNREACHABLE should fail, not be UB. 2020-07-29 robertphillips@google.com Re-org image-cacherator-from-* GMs 2020-07-29 johnstiles@google.com Add LLDB debugging extensions for SkAutoTArray. 2020-07-29 johnstiles@google.com Add LLDB debugging extensions for SkTArray and SkString. 2020-07-29 nifong@google.com A puppeteer test that runs karma-like tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I562311e76a90a753e2d6da48cd9223513c921b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792903}
-
Mustafa Emre Acer authored
Bug: 1077426 Change-Id: I4fe56e3b9c21a734628a5d82c6d53ca4a466b901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327634Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792902}
-
Nick Burris authored
PaymentAppProviderImpl was recently changed[1] to use WebContents* instead of BrowserContext*, in preparation for making the object owned by WebContents. However, the service worker logic still needs to use a BrowserContext* to register callbacks in case it outlives the WebContents, which is possible in the current state where it's a singleton. This patch makes it so all service worker logic uses a BrowserContext*. Bug: 1110207 Change-Id: Iee16d9cdfc81e2f186226e11be379890d6d66eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324041Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#792901}
-
James Vecore authored
This is a reland of https://crrev.com/c/2317166 which fixes an issue with the post CQ builder: linux-blink-cors-rel. Fixed by adding 'network::features::kOutOfBlinkCors' to the enabled list in featureList. This also fixes an issue in the WATCHLISTS. Revert is here: https://crrev.com/c/2325433 Original message: > [Nearby] Add NearbyShareSettings mojo for use in settings and webui > |NearbyShareSettings| provides a strongly typed wrapper over the raw > user prefs and allows clients to observe individual changes. This class > also implements a mojo interface to allow multiple WebUIs to access > settings (OSSettingsUI, NearbyShareDialog, and eventually SettingsUI). > > This CL achieves sharing of mojos and the components that depend on them > outside of chrome://resources by having the shared resources hosted in > chrome://nearby and re-registering them in chrome://os-settings. This > gets around having to include explicit references to the mojo generated > resources in //content which required a DEPS exception that was not > acceptable to //content/OWNERS. > > Many other options were considered to solve this shared resource > problem. Please see the dicussion thread for more context: > http://g/chrome-webui/Q8WGiGO7h-E > > Change-Id: I831044176ed71b15fb7df0be8f1c393e574254f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317166 > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Josh Nohle <nohle@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792503} Change-Id: I433a4a6292525d50eb7df12d20a8abe81d2949db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327010Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#792900}
-
Francois Beaufort authored
This CL makes sure sendReport(), sendFeatureReport() and receiveFeatureReport() will throw an error if an invalid reportId is provided by simply using EnforceRange. Spec: https://github.com/WICG/webhid/pull/25 Bug: 890096 Change-Id: I4d6eee9a7460cfe1d707d87702f58c9fe43d39d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317788 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#792899}
-
Maksim Ivanov authored
Delete the TestCertificateProviderExtensionLoginScreenMixin mixin class and migrate the existing tests to ExtensionForceInstallMixin. The motivation is unifying the implementation in tests that need to force-install extensions: the new ExtensionForceInstallMixin is a more universal and flexible tool. The old TestCertificateProviderExtensionLoginScreenMixin was very-narrow focused on simulating a specific use case. Bug: 1090941 Change-Id: I3965abe807d0d41250a3b138383e5a6dfe460876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316359 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#792898}
-
Dmitry Shachnev authored
To fix warnings/errors from binutils 2.35 branch about relocation in read-only section `.text', when building Chromium as a shared library (as in Qt WebEngine). See the following binutils bugs: - https://sourceware.org/bugzilla/show_bug.cgi?id=20824 - https://sourceware.org/bugzilla/show_bug.cgi?id=22909 And this Debian bug: https://bugs.debian.org/965328. TBR=ssilkin Change-Id: Ie3342eb433d30eb1073b7553687d23acaa38625b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309438 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#792897}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I3078305bd106abc310bdb8eb4af855cbb09f0dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324176 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#792896}
-
David Black authored
This is being done to provide ash::ClipboardHistory the ability to access and restore ClipboardData directly from ClipboardNonBacked without having to otherwise read/write the clipboard buffer. Manually reading/writing the buffer would likely be prone to missing some aspects of ClipboardData if changes were to get out of sync. Bug: 1104352 Change-Id: I80c800f1ebde26ad3bb8196bc0f438394bed2067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316802 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792895}
-
Matt Menke authored
Because they're for startup logging, they have to open files while blocking the UI thread. In chrome/, we instantiate the NetworkService before we start blocking file I/O on the UI thread, so things work fine, but in content_shell, NetworkService is only created after I/O blocking is configured, so opening the files DCHECKs. This CL adds a ScopedAllowBlocking around opening these files to resolve the issue. Fixed: 1048822 Change-Id: I264a54e7dfb6da0040c74f6fcf1fb5aba51ae18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324169 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#792894}
-
Scott Violet authored
No actual code change, just updates the docs. BUG=1076463 TEST=none Change-Id: Ic02eb8adc562fb6eace70500c7c2fb00fb6ed8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326690 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792893}
-
Matt Jones authored
All users of the old widget have been converted to use the ScrimCoordinator component. This patch removes the old widget and any lingering references. Bug: 1062099 Change-Id: Ib7673611e02bae32258ab1d945f22adf52dfe3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312916Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#792892}
-
Olivia Flynn authored
This CL adds: - A CDP method to act as an entry point for new a tool that shows the source order of child elements within a given node - A CDP object to hold information about how to draw the outlines - An inspector tool to draw outlines of the nodes Screenshot: https://imgur.com/a/LIKYJEJ This CL is part of creating a Source Order Viewer, which was identified as a customer ask on The Web We Want The Web We Want submission: https://webwewant.fyi/wants/64 Explainer: https://docs.google.com/document/d/1t33UTIpW46MGor70W8mdBJVRio8eo3p76w3FH8MjV7A/edit?usp=sharing Back-end CL to label child elements w/ source order: https://chromium-review.googlesource.com/c/chromium/src/+/2250883 Front-end CLs: Drawing labels: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2250404 UI: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2251080/9 Bug: 1094406 Change-Id: I226f1ae5a2a2263d592e66c56a8a56d3f1fd1ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250504 Commit-Queue: Olivia Flynn <t-olfly@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792891}
-
Xiaohui Chen authored
Token refresh unitest has a delay that's too long. It causes many screen refreshes and makes the unittest run very slow. R=wutao@chromium.org Bug: None Change-Id: Ic93fdc6a97a4125dff42be077d99ca197cc94b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327273Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#792890}
-
Tao Bai authored
Directly use the result of FormFieldData.IsVisible(), since it is hard to detect if a field visible to the end user or not, the result could be false positive, but once it is set to INVISIBLE, it isn't visible to the user. Bug: 1110041 Change-Id: Ie745ababf98ce0e195c7cd603fa16665656d5918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324996Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#792889}
-
Kevin Babbitt authored
Open up early-adopter testing to look for site compatibility issues. Bug: 1081945 Change-Id: I677f1008436b6b738f519d7f50cab995320b4f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293575Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792888}
-
Philipp Hancke authored
use LOG(ERROR) instead of DLOG(ERROR) in the log message for hitting the maximum number of audio input/output streams. BUG=chromium:1110171 Change-Id: Ic49ba74ffc7d43d00460aadce211cc6e806d0e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325610Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#792887}
-
Brandon Wylie authored
Bug: 1111001 Change-Id: I7b5278e7ec80feca1ba71700cab9e25c07c1e2da TBR=andypaicu@chromium.org Change-Id: I7b5278e7ec80feca1ba71700cab9e25c07c1e2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327139Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792886}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ieef7e6fa8ad4b0eb5713cf6bb5e0dbe5fb2eabf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792885}
-