- 21 Nov, 2019 40 commits
-
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1023677 Change-Id: Id20e94399700bb14d990b625f7703636035f2a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925460 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717696}
-
Olivier Li authored
Bug: 546640 Change-Id: I524066ce81a422938eca2c80523b60c4f9f670c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929094Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#717695}
-
Matt Jones authored
Since text selection is no longer the responsibility of the BottomSheet, the dependency on tab and tab provider have been removed as well. Bug: 986310 Change-Id: I827607ee610bf994a1205ad5b89c81b7bbff1813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927222Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#717694}
-
Wanchang Ryu authored
With --disable-in-process-stack-traces command-line flag, service process doesn't set signal handler for SIGPIPE. This causes crash when write() failed. This patch set SIGPIPE to SIG_IGN regardless --disable-in-process-stack-traces to get return value of write() Bug: 1026188 Change-Id: I11fcde7b38b7e6fa522cf17a50ebee6e62673177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924094Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#717693}
-
Jonathan Ross authored
MediaSourceTest.Playback_VideoOnly_WebM has begun flaking, up to 10% now. I'm disabling it on vulkan_content_browsertests until the root cause can be addressed. Also updating the bug id in the filter file to the unified bug covering this form of failure. TBR=ynovikov@chromium.org TEST=MediaSourceTest.Playback_VideoOnly_WebM vulkan_content_browsertests Bug: 985387 Change-Id: Ibac1705e890aeeccac01fbf671346567d562483b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928058Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#717692}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b184e9654d26..2dad99092c8c git log b184e9654d26..2dad99092c8c --date=short --no-merges --format='%ad %ae %s' 2019-11-21 halcanary@google.com Replace third_party/gif: Preflight changes 2019-11-21 ethannicholas@google.com Revert "Fixed some GrSkSLFP limitations." Created with: gclient setdep -r src/third_party/skia@2dad99092c8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: Ie7990d5000a6f992c9ec8e5c8bf55c0ff74acc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717691}
-
Michael Ershov authored
The test failed because sometimes RemoteCommandsService generated an additional request that was not expected by a mock object. Fixed by reordering AllowUninterestingRemoteCommandFetches function calls and EXPECT_CALL(..., StartJob(_)) calls. It looks like the latter one overrode the former one. Bug: 1014318 Test: DeviceCloudPolicyManagerChromeOSEnrollmentTest.Success Change-Id: I9cd8f13c9346623faaabb3c850b292ec10bdd5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924431Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#717690}
-
Michael Thiessen authored
This reverts commit 1c0ecd5d. Reason for revert: Increases crash rate due to large bundles. Original change's description: > Save WebappActivity tab state to bundle, remove old stale file deletion > > Simplifies tab restore by copying from NoTouchActivity, which has the > same persistence model (currently) as WebappActivity. > > This also simplifies the stale directory cleanup to only clean up more > recent sources of stale directories. This could lead stale directories > to stick around when updating from very old versions of Chrome, but > these directories should be small regardless. > > Also deletes some unused webApk UMA constants, and deletes the unused > histogram generation code in NoTouchActivity for tab restore. > > Bug: 525785 > Change-Id: I615542e2f28a147ecd5403b04b61b749f3e737ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769313 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690834} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 525785 Change-Id: I47afd77f54e7c11574a5814fbdec50a1a3cf3d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926573 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#717689}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kcwu@chromium.org Bug: 1023677 Change-Id: I32c8ed6a484a6eafb0aa0e67cb393b9cae6c6275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926796 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717688}
-
bttk authored
This dependency breaks the refactoring of java metrics. The refactoring is a work in progress: https://chromium-review.googlesource.com/c/chromium/src/+/1915193 Change-Id: I3ae2cacb86d49611a4e1f4311fe227c462c965d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926509Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#717687}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/235c2525d2c0..3692dd5f3f67 git log 235c2525d2c0..3692dd5f3f67 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 lalitm@google.com Merge "gn: ensure that highest proto visibility is preserved when merging" 2019-11-21 hjd@google.com Merge "perfetto-cmd: Remove 10mb upload limit on user" 2019-11-21 treehugger-gerrit@google.com Merge "ui: Link to public version of extension page" 2019-11-21 lalitm@google.com trace_processor: fix userspace Android slice tracking Created with: gclient setdep -r src/third_party/perfetto@3692dd5f3f67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:144598382 Change-Id: Icc4404d52103c3e8c5c70ab075c048f2e606edd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928147Reviewed-by:
-
Friedrich Horschig authored
With this CL, the PasswordPendingView shows an additional checkbox in test and debug builds. When the checkbox is selected/unselected, it changes the store inside the pending_form_ of the ManagePasswordsBubbleModel. So far, this field is unused (since pending_form_ is a copy and only username and password are passed to the delegate). To see the checkbox: * Build with is_debug=true or check_always_on=true * set the flag \#passwords-account-storage-saving-ui (or check out the screenshots in the linked bug) Bug: 1018701 Change-Id: Ie26931fb375677cffb5de3c0b5dff3b0a1544375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926587Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#717685}
-
Anastasiia Nikolaienko authored
The stub account on ChromeOS is treated specially for test purposes. Remove this special-casing since we have unified the interface for setting the primary account on ChromeOS with that on other platforms. Update tests: remove expectations that "the stub user is signed in by default on browsertests". Bug: 1014074 Change-Id: I37a812e060631c101d1b2d7d897c785c4c200f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872066 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#717684}
-
Wei-Yin Chen (陳威尹) authored
The first meaningful paint of Grid Tab Switcher (GTS) is defined as having all the thumbnails shown. When the tab switcher is shown due to feature "TabSwitcherOnReturn", this CL records the elapsed time from Activity OnCreate to the event as a performance metric. Bug: 1016952 Change-Id: I7c018823d19461a2cacf4496aa628beaefcbc7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892557Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717683}
-
Xianzhu Wang authored
These flags were used just for a few tests for checking internal data of composited layers. We should check them with unit tests. Removed tests: - compositing/layer-tree.html: just tested LAYER_TREE_INCLUDES_ROOT_LAYER which is not important. - compositing/overflow/composited-scrolling-paint-phases and compositing/update-paint-phases.html: The tested functionality is already tested by unit test CompositedLayerMappingTest.ScrollingContentsAndForegroundLayerPaintingPhase - compositing/animation/hidden-composited.html: now tested with unit test CompositedLayerMappingTest.CompositedHiddenAnimatingLayer. Change-Id: I148b4480020b41f241cd7ab854c31f96528cf89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927187Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#717682}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ae8320dd326..8adc98765133 Created with: gclient setdep -r src-internal@8adc98765133 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I746b61247f8d00334e723231dc066924e8805e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928142Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717681}
-
Anatoliy Potapchuk authored
Bug: 1006230 Change-Id: I1658e2ff0f2b7e91a74719e8eeeb26920273f54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926491 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Chris Lu authored
This change adds InfobarTranslateMediator to handle most InfobarDelegate model information retrieval. The InfobarTranslateTableViewController will use a data source protocol to retrieve it from the mediator. Bug: 1014959 Change-Id: I793f4bf5b3cb009b4a965aafb20e8ad045809af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921339 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#717679}
-
Richard Knoll authored
Removes these flags as they are enabled by default on stable already and we won't disable them anymore: - ClickToCallContextMenuForSelectedText - SharingDeviceRegistration - ClickToCallOpenDialerDirectly The ClickToCallReceiver feature is kept as a kill switch but the chrome flags entry for it is removed. Bug: None Change-Id: I05a5f10325176c56ecaaf6419d3c876675eced3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926627 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#717678}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e835fc01b1a9..b86a1770ee64 git log e835fc01b1a9..b86a1770ee64 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 sakal@webrtc.org Expose ABGRToI420 in YuvHelper. Created with: gclient setdep -r src/third_party/webrtc@b86a1770ee64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iaec7ae149c60bae4dd8ef2ab76a7c484cb35a718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928137Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f2c9ce1e08ed..72e68083f914 git log f2c9ce1e08ed..72e68083f914 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 kadam@inf.u-szeged.hu Add new relocation types. Created with: gclient setdep -r src/third_party/swiftshader@72e68083f914 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:893460 Change-Id: I8f539e41ae0aaba518e060dd87f905194c538185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928144Reviewed-by:
-
Joe Downing authored
This is the first step in removing the CRD Webapp code. First we need to make sure it's disappearance won't cause a problem for the official builders. After that we can continue cleaning up the various bits and bobs which build it and our pNaCl plugin. BUG= Change-Id: I7b30bc90e768505518046124ed887b23c09ddd4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925353Reviewed-by:
Jason Kersey <kerz@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#717675}
-
Sebastien Marchand authored
The L41r GraphObserver has been added in https://crrev.com/c/1579363 but it has never been created, this fix this by calling LocalSiteCharacteristicsWebContentsObserver::MaybeCreateGraphObserver(); when starting TabManager. This CL also removes notifications from the list of features that are ignored during the first seconds after a tab has been backgrounded. This list is meant to be for features that needs to "stabilize" (e.g. the tab title can change while a tab is in background after a same-document navigation), but notifications are an explicit form of communication with the user. This also enable the corresponding test to avoid any regression on this. Change-Id: I34c1efb88e101337b9f9913b9796a4442a876487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925137Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#717674}
-
Sadrul Habib Chowdhury authored
The display compositor sends a list of LatencyInfo objects to the renderers during swap. This is used to report some of the latency metrics. In order to be able to report additional metrics, it is necessary to send additional information about the frame being swapped. So introduce a SwapFrameData to capture such information. BUG=1027129 Change-Id: Ide1773e7b7a2ce3aca1f942d8e2c6f7f1d097795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928040 Commit-Queue: Saman Sami <samans@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#717673}
-
Mohamed Heikal authored
This reverts commit 8a4e1e84. Bug: 1027068 Reason for revert: https://www.androidpolice.com/2019/11/21/chrome-canary-gets-mysteriously-renamed-to-clankium-with-funky-dino-icon-apk-download/ Original change's description: > Allow android_resources targets to specify files rather than dirs > > Specifying directories in android_resources targets leads to subtle > failures such as the target not being rebuilt after adding new files to > it. > > Change-Id: I5f5cb1d50b5d7d6a8d7184b891182658aa690afa > Bug: 1026378 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919602 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717177} TBR=agrieve@chromium.org,mheikal@chromium.org Change-Id: I7107e14539fded7a4ec67ec374ea1c91a23da0cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928558Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#717672}
-
David Roger authored
Change-Id: I55ddd99da9115affc449f4f2f9fb5a0539c1171a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924477 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#717671}
-
Yves Gerey authored
Reason for revert: Breaks iOS WebRTC bots. Change-Id: Ib85d9865dee9fb70637fa0e48e52a5ce3d45e649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929219Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#717670}
-
Sam Maier authored
We no longer need the callGraphCycleEliminatorMaxDepthThreshold, since R8 fixed this issue (see b/143685705). Change-Id: Ibd9ad9c3ca3d7c7365c7475ff9435cc39fc9774c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928047 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Antonio Gomes authored
BUG=78725 R=guidou@chromium.org Change-Id: I2bd17004fd4635330e761980bc6a1304e0475f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924887 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#717668}
-
Doug Arnett authored
Back-forward navigations can trigger the ClientRedirectCycle.RedirectToReferrer logic (which is applicable for DeferAllScript previews). We have a better approach now (RedirectLoopDetectedUsingCache) so we can revert this initial approach and allow these false positive cases to be eligible for the DeferAllScript preview. Bug: 1026089 Change-Id: Id415aa2a0e7e33742b942976b428b27dd1231a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925884Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#717667}
-
David Roger authored
This CL removes the non-forced dice migration. There code to perform the forced migration is not removed. Bug: 777774 Change-Id: Icdcb6cbaa1eeaa2ff174bc4c73d3a93e919665ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917177 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Monica Basta authored
Bug: 305720 Change-Id: I283ada9ff6b7d55c1055bfbdfb301854d372b651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926473 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#717665}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c36744bff1ae..4da3b30c3879 git log c36744bff1ae..4da3b30c3879 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 aerotwist@chromium.org Migrates css_overview/ to esm Created with: gclient setdep -r src/third_party/devtools-frontend/src@4da3b30c3879 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib42dd6434e4f078178a6025be24f7cc981495f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928138Reviewed-by:
-
Alex Ilin authored
This reverts commit 8c36510c. Reason for revert: Added missing include on ChromeOS. Original change's description: > Revert "[base] Remove base::SharedMemory and base::SharedMemoryHandle" > > This reverts commit fa7e8cc7. > > Reason for revert: It looks like there was at least one missed instance of transitively including file_util. Sample build log: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-google-rel/4373 > > Original change's description: > > [base] Remove base::SharedMemory and base::SharedMemoryHandle > > > > There are no users of the deprecated shared memory left, so its code > > can safely removed. > > > > To use shared memory in Chrome, please refer to > > base::WritableSharedMemoryRegion and base::ReadOnlySharedMemoryRegion > > classes. > > > > This CL removes all remaining #includes of > > "base/memory/shared_memory.h" and > > "base/memory/shared_memory_handle.h". They are replaced by new shared > > memory includes when needed. > > > > It also appears that "base/files/file_util.h" and > > "base/posix/eintr_wrapper.h" were transitively included in many places > > through the removed files. This CL includes them explicitly in all > > those files. > > > > TBR: wfh@chromium.org > > Bug: 795291 > > Change-Id: I97ecac4b529c0ad6498b6e5ccf01515f750448ad > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919152 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#717588} > > TBR=dcheng@chromium.org,jochen@chromium.org,alexilin@chromium.org > > Change-Id: I16c6e4c2ada01240d577706478cf739ce1061ee5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 795291 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929252 > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Commit-Queue: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717644} TBR=dcheng@chromium.org,tmartino@chromium.org,jochen@chromium.org,alexilin@chromium.org Change-Id: I437cf7f93965858840170eb49b2d611b37e79b25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 795291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929221Reviewed-by:
-
Eric Seckler authored
This reverts commit 5d686312. Reason for revert: turns out this was caused by a different patch afterall. Original change's description: > Revert "Disable failing tests on android-go_webview-perf" > > This reverts commit 7a502f46. > > Reason for revert: patch that caused the failures was reverted > > Original change's description: > > Disable failing tests on android-go_webview-perf > > > > Disabling the following tests on android-go_webview-perf: > > * system_health.common_mobile/browse:media:youtube:2019 > > * system_health.common_mobile/browse:news:nytimes:2019 > > * system_health.common_mobile/browse:news:cnn:2018 > > > > TBR=crouleau@chromium.org > > NOTRY=true > > > > Bug: 1026822 > > Change-Id: I2581e3c21158edff2563de628bfa41de7349271d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927216 > > Reviewed-by: John Chen <johnchen@chromium.org> > > Commit-Queue: John Chen <johnchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#717272} > > TBR=crouleau@chromium.org,johnchen@chromium.org > > Change-Id: I0cf407e4ec8f3a44afa229c9fae82c064d9bb9a0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1026822 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928322 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717618} TBR=crouleau@chromium.org,eseckler@chromium.org,johnchen@chromium.org Change-Id: I0c6f3f761c335df3463564ba84946735b552c713 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928557Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#717662}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf492e4910bb..1898c08274eb git log bf492e4910bb..1898c08274eb --date=short --no-merges --format='%ad %ae %s' 2019-11-21 jmadill@chromium.org Roll third_party/android_ndk/ 89e8db0cd..27c0a8d09 (1 commit) Created with: gclient setdep -r src/third_party/angle@1898c08274eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: None Change-Id: I9732fd4cc1eeb8af13ec755b3ce0b558bcff8bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928134Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4f854080375..b184e9654d26 git log b4f854080375..b184e9654d26 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 egdaniel@google.com Update failure calls in GrVkMemory and shader creation. Created with: gclient setdep -r src/third_party/skia@b184e9654d26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: I22328bc7f04f65073f39c0fe40028c5377017898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928139Reviewed-by:
-
Tobias Sargeant authored
This allows us to support starting code loading earlier, as well as supporting APIs that may not need or want to fully initialize WebLayer, but just make use of Java code from the WebLayer provider. Also clean up calls to getApplicationContext to ensure that they happen at the public API surface rather than internally. Bug: 1027076 Change-Id: I16d7ce196c680722981883ed7d2be463d482b801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928779Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#717659}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/26c7fb61a9db..10146cfca138 git log 26c7fb61a9db..10146cfca138 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 mmortensen@google.com BuildAPI: Add unit tests and mocks for Image Service. Created with: gclient setdep -r src/third_party/chromite@10146cfca138 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I5b6b2987393ff50989a8835279d7ed9acccd6014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928133Reviewed-by:
-
Ella Ge authored
Currently, when recording in devtool performance tab, it will draw all events even though some GestureScrollUpdate are coalesced into others. In that case, coalesced GSUs are terminated earlier, and the slice are smaller than what it should be and meaningless (as it's not really been handled) This CL adds a is_coalesced bit to latencyInfo trace event data, it will be used for filtering out unnecessary GSUs in devtool performance panel(crrev.com/c/1928916). Bug: 956681 Change-Id: I9d999dd86e54f2b75d0a2527a4ba0e39f0e6ce9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924311Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#717657}
-
