GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283784 0039d316-1c4b-4281-b951-d872f2087c98

283418: [MIPS] Make srtp_driver compile for MIPS

BUG=

Review URL: https://codereview.chromium.org/396803006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283783 0039d316-1c4b-4281-b951-d872f2087c98

For example: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%281%29/builds/2843/steps/content_browsertests/logs/SingleProcess

BUG=394775
TBR=groby@chromium.org, gab@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/402613007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283782 0039d316-1c4b-4281-b951-d872f2087c98

> Fix silly mistakes
>  * The original CL was totally broken. sorry about that.
>   *add missing ui_resources.
> 
> BUG=None
> TBR=sadrul@chromium.org
> 
> Review URL: https://codereview.chromium.org/401613004

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/404533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283781 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283780 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178335:178351&mode=html
TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/400523006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283779 0039d316-1c4b-4281-b951-d872f2087c98

It has been failing since it was added.

BUG=394756
TBR=wiltzius@chromium.org
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/399613011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283775 0039d316-1c4b-4281-b951-d872f2087c98

 * The original CL was totally broken. sorry about that.
  *add missing ui_resources.

BUG=None
TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/401613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283774 0039d316-1c4b-4281-b951-d872f2087c98

SPEC: http://www.whatwg.org/specs/web-apps/current-work/#document.title

According to spec, set title without head element should be aborted in steps.
So to continue test as well as follow spec, NoCallbackAtLoad test case
should create head element before setting title.

Review URL: https://codereview.chromium.org/400523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283773 0039d316-1c4b-4281-b951-d872f2087c98

Also add mentioning that some constants have been copied to Chromium OS.

BUG=none

Review URL: https://codereview.chromium.org/397543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283772 0039d316-1c4b-4281-b951-d872f2087c98

switches::kNaClLoaderProcess is referenced by chrome_main_delegate.cc
but isn't found by the linker.

BUG=None

Review URL: https://codereview.chromium.org/398323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283771 0039d316-1c4b-4281-b951-d872f2087c98

Change AndroidHistoryProviderService::MoveStatement to use
base::CancelableTaskTracker instead of CancelableRequestConsumer.

BUG=371818

Review URL: https://codereview.chromium.org/366133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283770 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283769 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/9d7321c9d0412779a29c4b09962e7ce12936bbc4..3f376a55002c205aacacc4cb16ed745e3afbad31

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=halcanary@google.com
BUG=

Review URL: https://codereview.chromium.org/400533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283768 0039d316-1c4b-4281-b951-d872f2087c98

This also introduce the notion of message header to allow routing.

R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/371603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283767 0039d316-1c4b-4281-b951-d872f2087c98

These functions are defined but not used on ASan-enabled build.
That causes build failure on ASan-enabled build without -w flag.

BUG=162783

Review URL: https://codereview.chromium.org/388263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283766 0039d316-1c4b-4281-b951-d872f2087c98

This uploads key files before changing the unit test, as the Commit-Queue has problems with binary files.

Main CL will be committed afterwards: https://codereview.chromium.org/394013005/

BUG=210525, 329735, 315285
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/399103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283765 0039d316-1c4b-4281-b951-d872f2087c98

The native viewport service on android must run on the main thread
of the application. Because it is expected at the moment to run on
its own thread, this CL move the shell thread on android to a
secondary background thread and use the main thread of the
application for the native viewport service.

Review URL: https://codereview.chromium.org/399663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283764 0039d316-1c4b-4281-b951-d872f2087c98

Display the name of the domain for which enrollment is recovered and
restart the browser after enrollment recovery to avoid login screen
breakage.

BUG=389481

Review URL: https://codereview.chromium.org/387403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283763 0039d316-1c4b-4281-b951-d872f2087c98

With gcc, ObserverList expands to 6-700 bytes every time it is 
iterated. By not trying to force OberservListBase to be inline
that shrinks some. clang already ignores the hints to inline 
the code and actually doesn't change a single bit in the generated
program with this change.

raw data:
Total change: -90875 bytes
==========================
  262 added, totalling +39188 bytes across 2 sources
  49 removed, totalling -27573 bytes across 16 sources
  23 grown, for a net change of +3600 bytes (34968 bytes before, 38568 bytes after) across 8 sources
  228 shrunk, for a net change of -106090 bytes (239819 bytes before, 133729 bytes after) across 53 sources

The additions is about 2-300 different flavours of ObserverListBase, 100-300 bytes each.

The savings are 200-600 bytes each every time an observer list is used. For example:

-870: content::RenderFrameImpl::didFailLoad(blink::WebLocalFrame*, blink::WebURLError const&) type=t, (was 1635 bytes, 
now 765 bytes)
-895: content::RenderFrameImpl::didFinishLoad(blink::WebLocalFrame*) type=t, (was 1646 bytes, now 751 bytes)
-583: content::WebContentsImpl::DidFailProvisionalLoadWithError(content::RenderFrameHostImpl*, FrameHostMsg_DidFailProvisionalLoadWithError_Params const&) type=t, (was 768 bytes, now 185 bytes)
-611: content::WebContentsImpl::DidStartProvisionalLoad(content::RenderFrameHostImpl*, GURL const&, bool, bool) type=t, (was 895 bytes, now 284 bytes)

BUG=394311

Review URL: https://codereview.chromium.org/396473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283762 0039d316-1c4b-4281-b951-d872f2087c98

When setting the navigationStart recorded on the browser side for
browser-initiated navigations, we need to ensure the time is lower than
the time of starting the load on the renderer side. Otherwise with heavy
clock differences between processes and particularly fast navigation
start-ups we could end up pushing the navigationStart *forward* and
hitting an assert that is being deployed in
https://codereview.chromium.org/379873002/ .

BUG=376004

Review URL: https://codereview.chromium.org/384503009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394390

Review URL: https://codereview.chromium.org/391393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283760 0039d316-1c4b-4281-b951-d872f2087c98

It is assumed that no indexes exist before.

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOnDiskTest.*"

Review URL: https://codereview.chromium.org/391623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283759 0039d316-1c4b-4281-b951-d872f2087c98

This mirrors a similar change to WindowTreeHostOzone.

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran with egltest

Review URL: https://codereview.chromium.org/390493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283758 0039d316-1c4b-4281-b951-d872f2087c98

The media browser tests (content and chrome) load data from media/test/data.

BUG=379314

Review URL: https://codereview.chromium.org/399693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283757 0039d316-1c4b-4281-b951-d872f2087c98

This CL should fix a memory corruption in a unit_tests which is recently introduced.
That is caused by sync task invocation after SyncFileSystemService::Shutdown.

BUG=394460
TEST=unit_tests --gtest_filter='SyncFileSystemServiceTest.*'

Review URL: https://codereview.chromium.org/395333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283756 0039d316-1c4b-4281-b951-d872f2087c98

Checks whether background is defined in IME extension manifest. And also move KeyEventDone logic from InputMethodEngine to input_ime_api.cc.

BUG=394682, 394420
TEST=Verified on linux_chromeos and Pixel device.

Review URL: https://codereview.chromium.org/400523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283755 0039d316-1c4b-4281-b951-d872f2087c98

This change fixes the SourceBufferStream unit tests so that they always
provide valid durations for buffers that it passes to SourceBufferStream.
I've also added code to SoureBufferStream to verify that it always gets
buffers with valid durations.

Minor tweaks to test expectations were needed to compensate for the
SourceBufferStream behaving differently when it got actual durations instead
of using the durations it made up. In most cases I just used the duration
the SourceBufferStream was ultimately using. In a few cases the duration
the SourceBufferStream was generating didn't make any sense so I simply
changed the expectations to match the new behavior.

This is an attempt to reland https://codereview.chromium.org/379693002/ with
appropriate crash fixes.

Review URL: https://codereview.chromium.org/393403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283754 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393815
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/393903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382301
TEST=Panel interactive_ui_tests pass

Review URL: https://codereview.chromium.org/368163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283752 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283751 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72612,370496

Review URL: https://codereview.chromium.org/397183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283750 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff titzer@chromium.org in case of problems.

TBR=titzer@chromium.org

Review URL: https://codereview.chromium.org/399043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283749 0039d316-1c4b-4281-b951-d872f2087c98

When the InterceptDownloadResourceThrottle intercepts the download request, the response might not have been received yet.
As a result, we are not sure about the mime type and and other file informations.
Using android Download Manager at this stage is premature and risky.
This change bypasses android download manager in this case.

BUG=394092

Review URL: https://codereview.chromium.org/394993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283748 0039d316-1c4b-4281-b951-d872f2087c98

chrome_template_url_service_client.cc should include
chrome/browser/history/history_notifications.h as it's using
history::URLVisitedDetails declared there.

Review URL: https://codereview.chromium.org/396313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283747 0039d316-1c4b-4281-b951-d872f2087c98

There is no direct way to copy image url through context menu by
which user can copy image url. Added an option in context menu
for image to copy image url.

BUG=394314

Review URL: https://codereview.chromium.org/398803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283746 0039d316-1c4b-4281-b951-d872f2087c98

This would be essentially harmless, but setting 'nacl arch'
in StartPageHandler means allowing embed of the hotword plugin,
which consumes memory and CPU. Because it communicates with
the hotword extension directly, this plugin is unused at all.

BUG=393321
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/395963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283745 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283744 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/3944a1d2374d2de8622b0192aa080dba6fb92c76..9d7321c9d0412779a29c4b09962e7ce12936bbc4

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=halcanary@google.com
BUG=

Review URL: https://codereview.chromium.org/392423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283743 0039d316-1c4b-4281-b951-d872f2087c98

Adds Java version of DomDistillerService and 
DistilledPagePrefs with support for setting and retrieving
the current Theme.

The DomDistillerService can be retrieved by using the
DomDistillerServiceFactory, which maps a profile to an
instance of the service.

BUG=383630

Review URL: https://codereview.chromium.org/340403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283742 0039d316-1c4b-4281-b951-d872f2087c98