- 10 Oct, 2019 16 commits
-
-
David Benjamin authored
The logic was picking up the default argument in the GroupId constructor and, as a result, when double-keyed socket pools were enabled, client certs didn't quite behave right. It was possible to get double-prompted as a consequence of preconnects. Bug: 1011190 Change-Id: If8a3ffebbc0246b3d3dcf35bc90c08c53ba12120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849985 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#704432}
-
yilkal authored
This cl updates IsMainFrameWhitelisted to include domains which the parents have manually whitelisted. This can happen when a child asks for permission and the parent manually approves it. Bug: 850328 Change-Id: I056ccf9f5bc1385013eb0f41cf0014c2c859a45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837409 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704431}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7951a0da32d5..0a9ec07ff393 git log 7951a0da32d5..0a9ec07ff393 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-09 jvanverth@google.com Draw perspective text as paths. Created with: gclient setdep -r src/third_party/skia@0a9ec07ff393 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Id0511ad6649ec7ce3fbe4d672f283399fcfd67dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850778Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704430}
-
Jack Lynch authored
This CL adds an axe accessibility test for the call stack pane. It was previously reviewed in [1] but was split out because the CL was unwieldy and it isn't dependent on those changes. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1690089/ Bug: 963183 Change-Id: I247a5e6dfc6a5331c67944e6b95a34f7b06b2e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716213 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#704429}
-
Jinsuk Kim authored
Moves |createHistoricalTab| to TabState as a static helper method. TabState already provides a method creating a historical Tab from WebContentsState, so could be a good fit for hosting another creating Tab from WebContents. Bug: 995903 Change-Id: Ied744eb3292a9b0793f0baf93abdaf84ac8aac0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846613Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#704428}
-
Ahmed Mehfooz authored
Temporarily disabling color for all notification types. This will be enabled once ARC notifications provide accent color in Chrome OS. Bug: 1002714 Change-Id: I2fb6b6f33ee27dd2d2ecd865f7b5a6c360d00c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838166Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704427}
-
Bence Béky authored
Change-Id: I048554ee726f17b5a0b14d487728f0ad90085ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835159 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#704426}
-
cjamcl@google.com authored
Related: https://github.com/GoogleChrome/lighthouse/pull/9783 Bug: 1011228 Change-Id: I8c232c8f440df72d3780dc66a03166cddc9f5287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838310 Commit-Queue: Connor Clark <cjamcl@google.com> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#704425}
-
Piotr Pawliczek authored
Since the CL:1838051, each BulkPrintersCalculator is created by the first object that asks for it. BulkPrinterCalculator for User Policy is deleted in NativePrintersExternalDataHandler or in the first called destructor of corresponding EnterprisePrintersProvider or CalculatorsPoliciesBinder objects. BulkPrinterCalculator for Device Policy is deleted in DeviceNativePrintersExternalDataHandler. All instances of BulkPrintersCalculator are accesses in the UI thread and by using WeakPtr. BUG=chromium:1009062 TEST=on nautilus Change-Id: I09d4b9b4deea4f0cc06847abbd18f4800a7c5e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836660Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#704424}
-
Findit authored
This reverts commit 9b161472. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 704421 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzliMTYxNDcyODQ4ZGE1YmE1ZDI0MGExZDE1YWIyYmUwNjFlNGQ3NDcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-archive-rel/5897 Sample Failed Step: compile Original change's description: > Remove change_password_handler code. > > The change password card in the settings is not triggered > from password protection so it should be removed completely. > This is part 2 of the removal of the change password handler. > First part was crrev.com/c/1834950. > > Bug: 991764 > Change-Id: I2d877366f67bb7e30763b232211df62458554084 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834906 > Commit-Queue: Bettina Dea <bdea@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704421} Change-Id: I43b87004899419781cb8021b7f2946158c679411 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 991764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851233 Cr-Commit-Position: refs/heads/master@{#704423}
-
John Budorick authored
This reverts commit bc1f6367. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/1130 Original change's description: > [fuchsia] Add wildcard support for hosts filtering. > > Add wildcard-based filtering for hosts in UrlRequestRewriteRules. > > Bug: 1011156 > > Change-Id: I982b2241e622194dbf39ccd8519af8f92ee593c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838706 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704406} TBR=wez@chromium.org,fdegans@chromium.org Change-Id: I362ac64fee5d00e4ca75ecfb61e5a976139c78b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851124Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#704422}
-
Bettina authored
The change password card in the settings is not triggered from password protection so it should be removed completely. This is part 2 of the removal of the change password handler. First part was crrev.com/c/1834950. Bug: 991764 Change-Id: I2d877366f67bb7e30763b232211df62458554084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834906 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#704421}
-
W. James MacLean authored
The DCHECK(!internal_id_.empty()) in CreateFrameContainer() appears to be invalid in the clusterfuzz test case in the associated bug. This CL revises the code to tell it to not self-delete via a bool in the remove functions. Bug: 1012696 Change-Id: Ib5f39beb649299b8baa24450958e1cfb8d617005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849194 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704420}
-
Tim Song authored
BUG=1012052 Change-Id: I8cbfbf4bd5808fececc3c331c5a0cd32a9e84e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846026 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#704419}
-
Matt Menke authored
This makes ReportingUploader take a NetworkIsolationKey, which it applies to the URLRequests it creates. Currently it's only passed empty keys, so this doesn't observably affect behavior yet. Bug: 993805 Change-Id: I7ab627be3fc934651ae7ee425c58b741e05d2629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848355 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#704418}
-
Yuwei Huang authored
Renaming a few dont_show_again stuff to silence to make them less clumsy. Bug: 1001291 Change-Id: I90985ccba46f119f3caebd3a961702a3a9f5c7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849436 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#704417}
-
- 09 Oct, 2019 24 commits
-
-
danakj authored
The only user is RenderWidget and it can do that itself. R=avi@chromium.org Bug: 419087 Change-Id: I079e0ca7c61cdf6eb6cf5aee31605d447044ec45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850110Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#704416}
-
yilkal authored
Bug: 850328 Change-Id: I0e6a26fddd77fc8115755c058d36ebe00efd9d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845826 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#704415}
-
Tricia Crichton authored
Alerts that fire during the takeScreenshot command can result is freezing ChromeDriver. This cl checks for the UnexpectedAlertOpen status and cancels the screenshot retry. The status returned to ExecuteWindowCommand enables the latter to preserve and return the UnexpectedAlertOpen status. Bug: chromedriver:2117 Change-Id: I0b55a3144ed9e7482f0a15533381521e5205f636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849433Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#704414}
-
yilkal authored
This CL updates SupervisedUserNavigationObserver and SupervisedUserInterstitial to be able to handle multiple interstitial error pages inside a particular web contents. This is required because we are enabling iframe filtering for SupervisedUserNavigationThrottle. The CL also adds WebContents::ReloadFrame(RenderFrameHost* rfh, bool bypass_cache) interface and implementation. The CL also adds test in SupervisedUserNavigationThrottle for iframe filters. Bug: 850328 Change-Id: I6feea8f39a947011d91d1abfb27621a54281353c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816580 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9642dadd. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline ksakamoto@chromium.org: external/wpt/resource-timing panicker@chromium.org: external/wpt/page-visibility external/wpt/user-timing tdresser@chromium.org: external/wpt/hr-time external/wpt/navigation-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I64016c572d7bac1cc40eeb203858b7900312903b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850173Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704412}
-
David Benjamin authored
This makes several related changes. First, we add an admin policy, TLS13HardeningForLocalAnchorsEnabled, to toggle the TLS 1.3 downgrade check for local anchor. Next we add a base::Feature to control it, currently defaulted to off. Finally, we route this base::Feature up to chrome://flags and unwind the old base::Feature. The old base::Feature + parameters didn't quite work so it turns out the multi-value chrome://flags entry was just broken. Bug: 996894 Change-Id: Icb6a2eee1c5beb0098959c5aefff79956370d918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830115 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#704411}
-
Yuwei Huang authored
This CL removes a few flags that are no longer relevant after the tachyon migration. XmppLogToServer and XmppRegisterSupportHostRequest still use the directory bot JID for IT2ME scenario, but that will be intercepted and handled by the website, so I just localize the bot JID into It2meNativeMessagingHost for now. SignalingAddress still needs the bot JID to handle LCS addresses, which isn't used any more; I'll clean that up in a separate CL. Bug: 983282 Change-Id: Ic1b8c2fe190db40fde625aa9d7af88f2dfd29430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850777Reviewed-by:
-
James Hollyer authored
We plan to add a feature policy and secure context requirement to gamepad for privacy reasons. We are trying to gather data to see what will break and make a plan for how we can roll this out. Bug: 1011006 Change-Id: I30f045f2d05ec45ff983528cbb4bf1d6759db8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838111 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#704409}
-
Jazz Xu authored
This CL makes source icon background rounded. Bug: 1012937 Change-Id: I2d3c2f0f7ad509ba5c5e65cd632e60eb0ec1f8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849360Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704408}
-
Darwin Huang authored
- Adds UMA metrics for failures of RegisterClipboardFormat and XInternAtom. - Updates some comments, particularly function comments regarding invalid values. - Updates X11AtomCache to use a std::map, as it may hold many values. Bug: 897289, 1000919 Change-Id: Ie5793399387957f44259d32683ee4f4598f3cc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763247Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704407}
-
Fabrice de Gans-Riberi authored
Add wildcard-based filtering for hosts in UrlRequestRewriteRules. Bug: 1011156 Change-Id: I982b2241e622194dbf39ccd8519af8f92ee593c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838706 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#704406}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/16d4c4d4fbb8..066c2ab92f80 git log 16d4c4d4fbb8..066c2ab92f80 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8e1616e4..d9b4f45e (704145:704251) Created with: gclient setdep -r src/third_party/webrtc@066c2ab92f80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I6811981f8e3d29c4fae4f237ecf7f825f85a9034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850205Reviewed-by:
-
Xiaohan Wang authored
Making it easier to find instructions to add fuzz tests. Change-Id: I3c9a285300022a0ddf11ff9003f82ee2b2377d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850593Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704404}
-
Miyoung Shin authored
This CL converts IsolatedXRRuntimeProviderPtr that that is left only in IsolatedVRDeviceProvider class in chrome to the new Mojo type. Bug: 955171 Change-Id: I1b43e1576d423c9ab73bcacca2474dc97bc4863a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847467Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#704403}
-
Peter Boström authored
Prevents unnecessary string copies for simpler operations like GetText().empty(). Bug: None Change-Id: I25bf5ac9652d1799c42dc7ab282c4e4757e6a916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850715 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#704402}
-
Kurt Horimoto authored
Bug: 987646 Change-Id: I08dab761f2443cadf49acf60acdbc3e4df9fbb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847679 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#704401}
-
sczs authored
There was a change on iOS13.1 where the were multiple buttons matching the Close label. This CL adds an extra matcher to differentiate between the two. Bug: 1012341 Change-Id: Ia4d20bcf0797d8ba32551ce5da2944aad0d06882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850780Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#704400}
-
Miyoung Shin authored
This CL converts AudioFocusObserverPtr that is left only in audio_focus_manager.cc to the new Mojo type. Bug: 955171 Change-Id: Ifc2f73129f7b4f414f2a978affe316da49db04dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849738Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Dana Fried authored
Medium weight was causing text to shift, which was distracting. Bug: 1011307 Fixes: 1011307 Change-Id: I4e879b34d9cf51a5f29fc96943569356ad207f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850633Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#704398}
-
Alexander Timin authored
Bug: 1001087 Change-Id: Ie0f88867cf6a267d851c6b083aba778b4b5b703f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821907 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704397}
-
Rob Paveza authored
When a JS source file refers to a sourcemap, which then refers to a file that is not found on the file system (file://), the underlying request handler doesn't return any headers. With no headers, the DevTools UI bindings component presumes that the response is equivalent to a 200 OK and returns a blank file. Instead, we're going to return a 404, which will then prevent DevTools from surfacing the not-found file altogether. Bug: 941035 Change-Id: Icf92bdcfb415f0381217547dac9037d53915e3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847833Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704396}
-
danakj authored
This pointer holds the same value as the RenderWidget's WebWidget now so we don't need both. We stop passing a WebFrameWidget to InitForMainFrame() since it is sometimes null and thus we always have to pass it the RenderWidget through RenderViewImpl anyways. This way the presence of WebFrameWidget is consistent for main frames. R=avi@chromium.org Bug: 419087 Change-Id: I3b5a419619c9089c09ae1d46c01bd111dde9e3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825582 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Vladislav Kaznacheev authored
Currently excessively large menus are only displayed correctly with kBubbleAbove alignment. This CL adds checks and adjustments that ensure the correct menu size and position when alignment is kBubbleLeft or kBubbleRight. Bug: 1002879 Test: manual, added MenuControllerTest.TestMenuFitsOnSmallScreen/* Change-Id: I2dd36432465d4df39f47296d7675f9c65e7ec25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807565Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1deec71ea11d..5ee5b8853db6 git log 1deec71ea11d..5ee5b8853db6 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 seanabraham@chromium.org chromeos_test_config: use bvt-sync quota for synchronous release tests Created with: gclient setdep -r src/third_party/chromite@5ee5b8853db6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ide3cf88386eea8b49ece601907d934a3a476010f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850600Reviewed-by:
-
