- 06 Mar, 2019 40 commits
-
-
Aleks Totic authored
NGBlockNode::PrepareForLayout calls ToLayoutNGListItem(box_)->UpdateMarkerTextIfNeeded ComputeMinMax also needs to call it to compute correct MixMax sizes. Bug: 938224 Change-Id: Iebf3183c9e7447857ebc092a29a65cbd90a720bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504155 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#637958}
-
Sammie Quon authored
These are also failing on the informational trybots. Test: none Bug: 938575 Change-Id: I3d59cccf5546b5512e837a27b9829c48402d603f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504704Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#637957}
-
Weiliang Chen authored
SkImageFilter need filter origin and scale passed in and fix the bug where it wasn't passed in before. Bug: 922570 Change-Id: I24fcac2d80cc4de76eb2b72f4a24dfeec9f936b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503341Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#637956}
-
Dale Curtis authored
These are not template based, so compiling them twice just ends up with duplicate symbols that will cause linker errors. BUG=938190 TEST=local android build links. Change-Id: I0fe171e45fb24329611d09a328e38fe951cd53ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504702 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#637955}
-
Wez authored
Change-Id: Ia7e7399d266530754895ec14ec6e5a3876d5a157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496324Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#637954}
-
dstockwell authored
* Add missing labels for undo/redo/expand * Don't prevent Escape from closing popups if focus is on a radio button Bug: 902646 Change-Id: I33a73f9f1a971dddc19fb0d7708aeb997ee494e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501775Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637953}
-
Ayman Almadhoun authored
This change contains the following: 1) Adds TabStripToolbarCoordinator/Mediator component. 2) Updates existing BottomTabGridCoordinator. 3) Replaces BottomTabGridSheetToolbarView with a generic BottomToolbarView. Change-Id: I7687eb7cb69ca89656a7f85e2dc993ed23b9f508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500876 Commit-Queue: Ayman Almadhoun <ayman@chromium.org> Auto-Submit: Ayman Almadhoun <ayman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#637952}
-
Donn Denman authored
When Smart Text Selection appears to be active TTS currently does not trigger on long-press. This is problematic for many reasons, not the least being that long-press is a reliable way to trigger a UX. We have supported an override switch for this suppression. This CL removes the disabling and the override switch. Now long-press will trigger TTS regardless of whether Smart Text Selection appears to be active or not. Also rename some methods used to prevent a race-condition with Smart Selection gathering the surrounding text. See issue 773330 for background on this race condition. BUG=868108 Change-Id: I3831ffc26973f019257787d3df499d7684d3c1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490737Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#637951}
-
John Rummell authored
Update MediaDrmOriginIdManager so that when a profile is loaded it will check if any more origin IDs need to be pre-provisioned, and if so attempt to pre-provision them. This is enabled by a new base::Feature "MediaDrmPreprovisioningAtStartup". BUG=917527 TEST=new unit_tests pass Change-Id: If0e51516bd0f4d348792230c5309e89bd2b3388d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481111Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637950}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/30c1365e30b1..ad22645bad55 git log 30c1365e30b1..ad22645bad55 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 primiano@google.com Merge "traceconv: Add --version" Created with: gclient setdep -r src/third_party/perfetto@ad22645bad55 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7e6366528cf6ef5ffe894bf00aef554806008d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503564Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637949}
-
Eric Orth authored
Previously, HttpAuthHandlerFactory (which is global) assumed HostResolver is also global. It was given a single HostResolver pointer at creation in NetworkService and used it for all HttpAuth. Now, the factory doesn't keep its own HostResolver pointer. CreateAuthHandler() takes a pointer that gets passed in from the context. This is a prereq for making HostResolver per-context rather than global. TBR=torne@chromium.org,halliwell@chromium.org,dimich@chromium.org,eugenebut@chromium.org,rohitrao@chromium.org Bug: 934402 Change-Id: Ieb62a72f807e6a4445eee99ff9fb81abfc1eda0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491765 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#637948}
-
Tsuyoshi Horo authored
In crrev.com/c/1468855, I reused the existing histogram of NEL for Signed Exchange Reporting. But I think we should have a specific histogram. This CL also introduces RequestOutcome::DISCARDED_IP_ADDRESS_MISMATCH which is only used for signed exchange reporting. This value is recorded if the server has set the NEL policy previously, but doesn't set the NEL policy for the signed exchange response, and the IP address has changed due to DNS round robin. Bug: 910516 Change-Id: Ic231f33b1de8d09e0d06eb06485012d5bf9e3012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482096 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#637947}
-
Dan Sanders authored
VTVDA binds IOSurfaces to textures, and therefore it is possible for a GL operation on the IOSurface to still be queued (at the platform level) after all references to the IOSurface have been dropped. This CL enables VDAs to request the READ_LOCK_FENCES_ENABLED flag on their VideoFrames, which ensures that platform operations have completed before references are dropped. Bug: 934578 Change-Id: Ia369c66d06100f58f991494b354d00dc628b38c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487698Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#637946}
-
Ryan Hamilton authored
Change-Id: I3b76a2332b7a39ccb2c521d72ea908112fea2955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504005 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637945}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd98a9a1520a..a272d1148d5b Created with: gclient setdep -r src-internal@a272d1148d5b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: Ieba1b20dc99a490b75cc75261524a57119937938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503563Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637944}
-
Toni Barzic authored
Also, removes the code that supports them. Affected exit codes: * USER_IMAGE_SELECTED * user image screen has been removed from (in session) OOBE, and will be added to discover screen, which means, wizard controller does not have to handle the screen exit code any longer * ENCRYPTION_MIGRATION_FINISHED ENCRYPTION_MIGRATION_SKIPPED * Encryption migration screen is not reporting result to wizard controller (instead it provides interface to add callbacks to be called upon completion) * CONNECTION_FAILED * Not used anywhere While here, remove HIDDetectionScreen::Delegate, as HIDDetectionScreen is not callign into the delegate anymore. BUG=930267 Change-Id: I03d3b28270967032fa66db29e4a4ac9e2d64655f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501092 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#637943}
-
Yiming Zhou authored
Bug: 847905 Change-Id: Ibfa4d74affd7bd5823dd2d2036706f06734866e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497762 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#637942}
-
David Jacobo authored
Adding forward declarations when needed so we can remove duplicated includes. Removing unnecessary prefix for code already declared inside the chromeos namespace. Bug: None Change-Id: If9e7d04fbb282ce9badbc08908490d7e8d634627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504392 Commit-Queue: David Jacobo <djacobo@chromium.org> Auto-Submit: David Jacobo <djacobo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#637941}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e57f10e4041d..4c84dbdce271 git log e57f10e4041d..4c84dbdce271 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 bclayton@google.com Kokoro: Don't use verbose logging for make Created with: gclient setdep -r src/third_party/swiftshader@4c84dbdce271 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I5a13cc96ea7059610fbfe4e65bcfa2e9ce93eeea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637940}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6ce450029683..3a9f8f45de46 git log 6ce450029683..3a9f8f45de46 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 evanhernandez@chromium.org cros branch: Log notice instead of info. 2019-03-05 dgarrett@google.com chromeos_config: Change packages for old factorybranches. Created with: gclient setdep -r src/third_party/chromite@3a9f8f45de46 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ieeb57d4b5f417f54792995066d2d286ede901407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637939}
-
Yun Liu authored
Bug: 728297 Change-Id: I563b49e1c6d37b3c3e2a408be46920ab3f7f87e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504306Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#637938}
-
Tomasz Wiszkowski authored
This change removes outstanding references to file removed under crrev.com/c/1503344 Bug: 472729 Change-Id: I1d84279a316d8ccd9ebc99c93a466d0dbb57bc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504338 Auto-Submit: Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#637937}
-
Lambros Lambrou authored
This is a simple change to allow VP9 to work reasonably well without crashing, when connecting via the website with VP9 experiment enabled. Future work will optimize VP9 encoding, and remove large-picture detection in the frame scheduler (as it's not needed for VP9). Change-Id: Id80297dd9a0abf420ccf0e22251fca23200c32e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489711Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#637936}
-
Patrick Noland authored
When a site is suspended, SuspendedTab is shown in place of the actual contents of the page. Showing a SuspendedTab stops loading on the associated tab. Logic for showing a SuspendedTab flows through PageViewObserver, which already has the knowledge of which domains are being navigated to and shown. The SuspendedTab will eagerly remove itself on a new page load, which means every page load on a suspended site will create a new SuspendedTab. The alternative ended up being much more complex to code. We don't actively reload a page when a site is un-suspended, although this would be fairly easy to add in a follow-up. Bug: 902568 Change-Id: Ibc7099eafbab65f583d5989436c8831366a9b040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1435623 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#637935}
-
Lei Zhang authored
- Use range-based for loops. - Add a GetPrintPreviewUIForDialog() helper function. Change-Id: Ib571f575d53f8f8b6ad857e61f2b1111cf2ab5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497857 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637934}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6752606a395..624cec68e43a git log e6752606a395..624cec68e43a --date=short --no-merges --format='%ad %ae %s' 2019-03-05 khushalsagar@chromium.org remote fonts: Ensure consistent gamma usage with remote and gpu fonts. 2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8e3cddfd..2f034a6e (426 commits) 2019-03-05 michaelludwig@google.com Support per-entry transforms in image-set API 2019-03-05 csmartdalton@google.com Make mixed samples detection automatic 2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e57f10e4041d..4c84dbdce271 (1 commits) 2019-03-05 herb@google.com Pointer to GrStrikeCache on GrTextBlob Created with: gclient setdep -r src/third_party/skia@624cec68e43a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I337f2e33667e5beefca194028b755e0909f0ae94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637933}
-
Sam McNally authored
It's been disabled for a few years without any action and passes locally so try on the bots again. Bug: 577332 Change-Id: If5b9cd5857e9940f891ce104e9bb2694698b25aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481174 Auto-Submit: Sam McNally <sammc@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637932}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8fdf9af7..3e8a733a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5451f69c939d64b3ecabb8a730751b6cd1d7759b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504292Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637931}
-
Becky Zhou authored
+ Add override configuration for Tab themed application context so that the UIs inflated from it don't get night mode from application UI mode + Change color resources access to use activity/view context instead of application context Bug: 936983 Change-Id: I08135f7bd2c54540d1516bd3dd68dfa11a3fd264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503902Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#637930}
-
Jamie Walch authored
This fixes our top crasher for M74 Chrome Remote Desktop. It is probably not the right long-term fix, but it is suitable for merging in the short term. Bug: 938648 Change-Id: Iad763e8b17f7355105f74bdd89e9d32a37a532f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504147Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#637929}
-
Darren Shen authored
This reverts commit 9deda679. Reason for revert: Seems to be causing failures in ASAN due to dangling pointer (crbug.com/938699). Original change's description: > Delay querying for printers list until the policy file is parsed > > A list of enterpise printers is not ready immediately after creation of > CupsPrintersManager. It caused a problem for testing procedure since from the > level of autotest_private_api we do not know if the final list is ready or > there are still some ongoing calculations. A new method called > OnEnterprisePrintersInitialized() was added to the observer of > CupsPrintersManager to solve this issue. Also whole code related to > enterprise printers were refactored, large part of functionality was moved > from SyncedPrintersManager to new class EnterprisePrintersProvider. Classes > ExternalPrintersPrefBridge and DeviceExternalPrintersSettingsBridge have been > merged into one class called CalculatorsPoliciesBinder. > This is reland of CL:1220547, it fixes the problem detected by the test > AutotestPrivateApiTest.AutotestPrivate (method execution after destruction > of CupsPrintersManager object). > > BUG=chromium:816996 > TEST=Tested on cave with the use of CL:1451591 > TBR=achuith@chromium.org > > Change-Id: I70958421aadd9fab9a2401555bef0dbb28ad5a6a > Reviewed-on: https://chromium-review.googlesource.com/c/1491909 > Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636618} TBR=achuith@chromium.org,emaxx@chromium.org,skau@chromium.org,pawliczek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:816996 Change-Id: I22e41f42fe812f6d1f080585ee8cc40e51a2dd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504652Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#637928}
-
Lei Zhang authored
Add new owners and remove inactive owners. Change-Id: I4dc7dc5317ea7b261ef7794072f85c58db1b33a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504305 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637927}
-
kdillon authored
This cl upstreams the tests that were translated in this cl: https://chromium-review.googlesource.com/c/chromium/src/+/1475004 It also deletes some of the redundant tests in wpt/workers as a result of the move. Bug: 795636 Change-Id: Ic5678837dd9314c064f9e8a25bdb62468bfcb49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500938Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#637926}
-
Robbie McElrath authored
These recently started failing. See the bug. Bug: 938672 Change-Id: I259afc8c760f4153b095f1041a68109666a24cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504454Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#637925}
-
Steven Bennetts authored
The constants subdirectories were inadvertently defined as source sets, even though they are included by mulitiple libraries. This causes ODR violations in asan component builds. Sinces these are just constants it should not affect any runtime behavior. This CL also adds a BUILD.gn file to each subdir and cleans up a few unnecessary dependencies. For mechanical BUILD.gn changes: TBR=sky@chromium.org Bug: 933063 Change-Id: I05195779ddd606c4ad33ae7c1c713044a8cb089e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495862Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#637924}
-
Tao Bai authored
This patch Instantiates the ContentCapture in ChromeAndroid and WebView if the feature is enabled. Bug: 924681 Change-Id: Id4da70b57d66e60680c3f605a9a76548457a2caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495436Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637923}
-
Khushal authored
Enable AImageReader and VizDisplayCompositor if SurfaceControl is enabled. Bug: 889328 Change-Id: Ief585c25563c9224cb9c8f77dccb4c6eb1548135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504225 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#637922}
-
Lei Zhang authored
Bug: 61248 Change-Id: Ib3a23abaa3ad6772c2af7cba6b333c33f901eb71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503905 Commit-Queue: dstockwell <dstockwell@chromium.org> Auto-Submit: Lei Zhang <thestig@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637921}
-
Reid Kleckner authored
I wrote many words. Please skim them. We can put more things here as time passes. R=hans@chromium.org, inglorion@chromium.org, thakis@chromium.org Change-Id: I1e248446bad423bcb537373bf6c08994fd8e2c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496321 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#637920}
-
Stefan Zager authored
For the javascript IntersectionObserver class, when new notifications are generated, a task is posted to deliver the notifications (i.e., run the javascript callback). Because the task is put in the regular task queue, there's no guarantee when it will run. For blink-internal users of IntersectionObserver, it doesn't make sense to post a task to deliver the observations -- and this may even lead to correctness issues or other bugs. The bug link on this CL refers to an old bug of this kind which was previously fixed using a gross but necessary hack. This patch changes IntersectionObserver so that non-javascript observers will deliver notifications synchronously as they are generated. R=chrishtr@chromium.org,mlamouri@chromium.org Bug: 590856 Change-Id: I2f91f23a01288214209f901bc582717678312dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501655 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#637919}
-