- 16 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e364dd820b29..f82b08b1e252 2020-06-16 liviurau@chromium.org Revert "Support formatting python3 scripts" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ifdd4448742794e41abf4ad045956f866956dabff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248035Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778887}
-
Jérôme Lebel authored
Fixing: +[URLOpener openURL:applicationActive:tabOpener:startupInformation:] This method needs to check if Chrome is presenting the FRE. With FRE URL should be dropped. This can be reproduced with multi-windows enabled, or when Chrome is active when receiving the URL (this can be done with split-view). Fixed: 1092492 Change-Id: Id9313e5eea484b262574d19c9ce30ceec1fab469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243132 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#778886}
-
Stephen Chenney authored
Extend these expiring histograms and try to bring them into alignment with the other Blink.*.UpdateTime histograms. This will be a gradual process as histograms expire. Bug: 1095031, 1095030 Change-Id: I01ea65da538b5bd4c3f6e24892865c9fc6d03eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246555 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#778885}
-
Brandon Wylie authored
Bug: 1091191 Change-Id: I02f4b3c8f4e34928d53c70772fe8ab50a271de7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246992 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#778884}
-
Chris Lu authored
SaveCard's acceptance action involves passing the card credentials to be saved. Thus, it can't use the InfobarBannerMainActionResponse like other InfoBars. Thus, the banner's response to bannerInfobarButtonWasPressed: will use SaveCardMainAction to accept the banner InfoBar action. Bug: 1071914 Change-Id: I9e5495f422cd43ea315a8b6096466e9ea2fb829f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246951 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#778883}
-
Scott Violet authored
BUG=1042771 TEST=AwOriginMatcherTest* Change-Id: I5ee9eb34a36d21de91694ad996cfdc51907ee672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242748 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#778882}
-
Alex Chau authored
- Should always instantiate service in factory, otherwise the service will stay nullptr until Chrome restart. Pref should be checked inside - Shutdown NearbyConnections if Nearby Sharing is disabled - Introduced FakeNearbyConnectionsManager as the basis for testing further NearbySharingServiceImpl methods Bug: 1084283 Change-Id: Ia3e01cf257757b023d38c2832c2ce482dedf6441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247879 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778881}
-
Alice Wang authored
Change-Id: I819a7368990de4e0242cbcc90e250ff9e5c9acde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247779Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#778880}
-
Yuzu Saijo authored
This CL implements BackForwardCache Timeout and Ack. When we cannot put a page into bfcache in a certain time period, we give up putting the page into cache. Ack function allows us to know whether the page is before/during/after the process of caching, instead of whether it is in/out of cache. Change-Id: I921076636afeddcd172889a8dd5f68687c8e0ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192793 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778879}
-
Eric Seckler authored
With the addition of per-thread UMAs, the collection became a little bit more expensive. This patch moves it to a background thread and reduces the collection interval for the browser and GPU processes, which (i) are persistent processes (so data loss at termination is less of an issue) and (ii) tend to execute many small main thread tasks. Bug: 1081760,1094434 Change-Id: I847179ae78c024bb506772c1c42804e9d896f762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245906 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#778878}
-
Patrick Noland authored
This change has MenuButton control its tab switcher animation drawing internally so that ToolbarPhone doesn't need to keep track of which Drawable to use. It also adds some regression tests. Bug: 1082771 Change-Id: I792712106ec7660f1a717e031514e17695d5062a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238368Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#778877}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/324cc4b94f7a..ea290a9b84bc 2020-06-16 fmayer@google.com Merge "Separate client management from hooks." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I05a78f29f7dcd6b795daad11c2a68daa34ad5a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248027Reviewed-by:
-
Jun Mukai authored
Historically ArcCustomTab code is in Ash, since it needed to be there for supporting Mustash. Now mustash is gone, and arc_custom_tab has no dependencies on ash anymore. Bug: 1090616 Test: build passes Change-Id: I4e379ab4d174598db93f5591e19f5c0ff481ecee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246819Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#778875}
-
Ahmed Fakhry authored
R=chromium-metrics-reviews@google.com Fixed: 1052909 Change-Id: I6430e68818a6fe1ce9be5969c3165f4dfbce134f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247062Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#778874}
-
Maggie Chen authored
There are a lot of crashes with the old Vulkan drivers. Bug: 863086,850881 Change-Id: I07eb6b08313a14d78614f371d2fbceb82852bbc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203478 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#778873}
-
Stephen McGruer authored
This was an oversight that only ever worked because the system python happened to have most packages anyway. Then we introduced atomicwrite, which the system python didn't have, and the importer broke. Bug: 1095643 Change-Id: Ie5733edb7b25fc93b417e7725c9452c0e8c86f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248121 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#778872}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4928d556e6b5..051c6fed884b 2020-06-16 cepheus@frii.com Build: use better MSVC subfolder names for the previous build changes. 2020-06-16 johnkslang@users.noreply.github.com Merge pull request #2275 from ben-clayton/mv-hlsl 2020-06-16 cepheus@frii.com Bump version numbers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ib1e59d88a2b3a570b5706a4fbd39f7136a813027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248022Reviewed-by:
-
Jonathan Ross authored
Split off from master: https://chromium-review.googlesource.com/c/chromium/src/+/2187203 We have previously added new traces for the ablation experiment under a new category "gpu.memory". This was done to avoid trying to record and parse all of "gpu". This patch adds the new category to the loading and rendering stories. The catapult patch to parse the results is: https://chromium-review.googlesource.com/c/catapult/+/2187206 Bug: 908462 Change-Id: I548bd2a10a859f706342a438906bbee35f396970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246931Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#778870}
-
Martin Kreichgauer authored
Setting the GattSession.MaintainConnection property causes the system to automatically establish a GATT connection for us, which supposedly improves connection reliability. Also change the implementation of GattConnected() to reflect the GattSession.SessionStatus property, rather than relying on BluetoothLEDevice.ConnectionStatus. The new session handling behavior requires at least Windows 10 1709 (RS2). Clients on 1703 (RS2) continue to use the old behavior. The new behavior can also be switched off via the "NewBLEGattSessionHandling" feature flag. Change-Id: I0536dae8748f720aa7e0c5533e4d5e1ac35a9599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212668Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#778869}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e30ca7f4..8e0b4634 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I53c666a1a3203cce6cca7582992cf11e01292a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248218Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778868}
-
Eric Roman authored
NOTRY=true Change-Id: Iace3fcfe0a2830397f6d530beb2a7f20f2b2434c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246697 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#778867}
-
Evan Stade authored
Bug: 1007823 Change-Id: I679665e614b41c6671b9d8755ffb75903098e24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241867 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#778866}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2755b192accb..9d178021d3b7 2020-06-16 khokhlov@google.com [tracing] Add Ampere-hour unit to histogram proto format 2020-06-16 khokhlov@google.com [Telemetry] Add sched details to experimental data sources 2020-06-16 fancl@chromium.org sheriff-config: Remove legacy patterns If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055685,chromium:839068 Tbr: eseckler@google.com Change-Id: I1c90e66c155d1ac2159a268dfe4de9ba113bc3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248032Reviewed-by:
-
Maciek Slusarczyk authored
Deprecated ToInternalValue() and FromInternvalValue() are being removed from pref::kSAMLLastGAIASignInTime. This CL is submitted in preparation for online sync on the lock screen feature. Bug: 634507 Change-Id: If9afee3be3773b9a929940a82c361d635da988d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245136 Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#778864}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I80cf79d117ffb1d19e6a629324cc00ad8ac302d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247554Reviewed-by:
-
Jérôme Lebel authored
Adding user action: + Settings.MyAccount, when the MyAccount item is tapped in the settings view. + Signin_Signout_FromAccountSettings, when the user wants to sign-out. + Signin_SignoutClearData_FromAccountsSettings, when the user wants to sign-out and remove their user data. Fixed: 1082910 Change-Id: I2f3bd6da6512984d11be58be5a22db373f56add8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231106 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#778862}
-
Bailey Berro authored
This did not currently cause any issues because internally we stored input and output level prefs in the same dictionary. Fix this bug now because a subsequent CL will introduce a separate structure for node gain. Change-Id: I61cb83bdd1a88c658302aea6c2ff46de3bc3fe92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246840 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#778861}
-
Archana Simha authored
Bug: 1092712 Change-Id: I36084e63b4ee103ac066d51c3fb8d6e3c85a3e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243580 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
-
ckitagawa authored
This CL parallelizes compositing to improve performance in zoom when multiple tiles need to be re-rastered at once. Bug: 1020702 Change-Id: Ic4ec4ce058d08794eff197e7f7ee22eacc24575e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235976Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#778859}
-
Adrienne Walker authored
OnAppCacheInfoFetchComplete in appcache_helper.cc assumes that any vector of infos for an origin is non-empty, and the origin trial early outs in AppCacheStorageImpl broke this assumption. This is just a minor DCHECK and would result only spurious zero-size origins in the appcache internals page, but it's good to fix anyway. Bug: 1094811 Change-Id: I101f9da0f1036afa1691e6db7f94c2ebfb5f655b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246957Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Mohamed Heikal authored
We cannot check if android specific pydeps files are stale in a non-android checkout because some imported libraries will be missing. However, we can output a warning letting the developer know so as to reduce the chances of CLs landing that make android pydeps stale. Change-Id: Icd1047d4350f6d3cb439d09ea2ba958b51afe61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240260 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#778857}
-
Rushan Suleymanov authored
When the feature SyncDoNotCommitBookmarksWithoutFavicon is enabled, it is possible that local change will not be sent to the server immediately. This feature toggle disables commits of bookmarks if favicon is still loading. Additional nudge for commit is needed in this case if there are still unsynced changes. Bug: 1061411 Change-Id: Ie379e90c22df778cb08711f32f11a3a87b4e55c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236473 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#778856}
-
Joshua Pawlicki authored
This is a mechanical refactoring to lump the server behavior in with the apps in preparation for factoring out a common server app class. Bug: 1092936 Change-Id: Ic8319c222eb4c9fb89f1c50969af60275fe4d840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238015 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778855}
-
John Budorick authored
This is a reland of 98846b50 Original change's description: > Update asan_device_setup.sh to r351636. > > Improves support for running 32-bit binaries on the N5Xs, at least. > > Bug: 790202 > Change-Id: I2a870d3b5a1e88992d8908358e21f159d1740fce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648665 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667692} Bug: 790202 Change-Id: Iea5c8eddfb3e104a9c3a8375dc57ae68b31e35b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209238Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
The default state of the PasswordCheckBehavior creates an IDLE state even before the backend is first queried. This causes a brief flicker of the check button when reloading the page. With this CL, the button is only made visible once the sync data has arrived. Without the sync data, it is assumed that a check can not be started. Bug: 1094855 Change-Id: I9a762ae4ef95339e4ed27841571caeae49409599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246174Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#778853}
-
Robert Ma authored
Clarify that you should invoke the script (or the .bat file on Windows) directly instead of calling it using `python`. Bug: 1095643 Change-Id: Ie8d5079bf4618f8d2b7f162d879f50da49c0260c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248120Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#778852}
-
Ioana Pandele authored
TBR=szager@chromium.org Bug: 1094562 Change-Id: I4517855a78c8c35641e81be137815089b820ffa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247825Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#778851}
-
Gauthier Ambard authored
This can be useful for breadcrumbs or other metrics purpose. Added on crrev.com/i/3115706. Bug: 1082908 Change-Id: Ide69472a86d42276bcee9049eb90ef3bdf2a1bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241129 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#778850}
-
Vladimir Levin authored
This patch adds new counter-set property to css.proto and a corresponding entry to the converter. R=andruud@chromium.org Change-Id: I24899e6dd88f373383b9db11d82019eae5bab983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248161Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778849}
-
edchin authored
This CL adds a new NSUserActivity type for moving a tab to a new window. This CL is one in a series to add drag and drop functionality in a multi-window world. Dragging a tab (which will come in a later CL) to the edge of the screen in an iPad is a gesture to create a new window with that tab. A custom NSUserActivity is required to enable this gesture. Bug: 1087844 Change-Id: I0462f3074825f682ccc4c1e8345f22e310abdcc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236896Reviewed-by:
-
