GitLab

This is used to fetch a previously downloaded favicon. For
consistency this returns the same image as that returned
from FaviconFetcher.

BUG=1076463
TEST=none

Change-Id: Icdd01286d1d564c7cb5b62847ffb1d888d9d70fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340796Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795685}

This prevents triggering a NOTREACHED() for internal projects that have
a very large number of variations.

Bug: b:162438420
Change-Id: I171062c0d462e56f70cc6eb7ebeb279169279333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332571Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795684}

There is a bunch more work to be done here, but this makes the
code match that of the names in history.

BUG=1104873
TEST=none

Change-Id: Ib11d1a2335e1c8ee6643b1f5e58d5807dd66a788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340547Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795683}

Inbound and outbound depths must be >= 0. Previously, users could select
values less than 0, this is no longer the case.

Bug: 1102546
Change-Id: I479984448987a30d0b699bcae55336de840aff8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340364
Commit-Queue: James Long <yjlong@google.com>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795682}

After we finish the scroll unification, the scrolls happens mainly on
the compositor thread, and the scroll code in the main thread will be
removed. eventSender sends the scroll events to main thread, so it
would not work after the scroll unification. We should replace
eventSender.continuousMouseScrollBy with
gpuBenchmarking.smoothScrollByXY in
fast/events/mouse-wheel-main-frame-event.html.

Bug: 1047176
Change-Id: I5746dc6504e15984862957c670c458979afe5b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332327Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795681}

Last attempt just moved the flake to the next line that times out while
waiting for fullscreen state. Now make the whole rest of the test into a
retry loop and see if things improve.

Bug: 1107954
Change-Id: I1a358a28a4b22904db23e0b4ee0400b90292c59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340672
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795680}

The current caBLEv2 handshake has the desktop speak first. We expect the
network-based design to have the phone speak first, thus this change
turns the handshake “around” to accommodate that. Also, the current v2
handshake includes pairing information in the response but, if the phone
speaks first, the response is coming from the wrong place to include
pairing information and the first message has insufficient protection to
include it. Thus that is removed. Instead, a getInfo message can be
included in the phone's first message because it'll be needed anyway and
it's generic and thus doesn't require forward security.

BUG=1002262

Change-Id: If2fb27b2a56ef21c0b21a454ff498f65ce62e81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340062
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#795679}

We'll soon be adding another Finch group that indicates to the client
that we should defer to the BlinkOptimizationGuide (being implemented in
[1]) for the delay async script execution milestone, as opposed to
relying on the field trial param value being set by Finch.

This CL adds the kOptimizationGuide value as an option for the
kDelayAsyncScriptExecutionDelayParam field trial parameter. When the
BlinkOptimizationGuide is implemented [1], there will be a follow-up to
this CL that actually uses the OptimizationGuide hint once it is
plumbed to Blink.

[1]: https://crrev.com/c/2337050

R=falken@chromium.org, kinuko@chromium.org, nhiroki@chromium.org

Bug: 1086227
Change-Id: I8b8419b03b2a52399971cd32262ba003f2750ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337767Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795678}

The problem with xor is it's a commutative operator, so the relative
ordering of operations won't be captured in the digest calculated.

This is problematic, as drawing an oval and then a rectangle can produce
visually-different results than drawing the rectangle and then the oval.

Instead, we can use the IdentifiableTokenBuilder library, which was
designed to preserve such ordering.

Bug: 973801
Change-Id: I45baf54418263a1984bc3446233fd5a7d0a6ebc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311059
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795677}

Since only Android versions P and above are supported, settings page
toggle should not be visible if O or lower.

Bug: 949269
Change-Id: Idefda09cd2210843578abc58ae4a11b79b711eac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338726Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#795676}

The spec does not permit undefined values to be resolved:

https://w3c.github.io/ServiceWorker/#cache-storage-open

Since this only triggers for rare error conditions that are difficult
to trigger there is no test for this change.

Bug: 1113829
Change-Id: I7e015fdb51e42e7560510fac37ea0071624f95c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341395Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795675}

TBR=govind@chromium.org

Change-Id: I5ac6cd8c3f011ea5c75df1749c0d4c94a86432d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340671
Commit-Queue: Ben Mason <benmason@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795674}

This is intended to replace the UsbDetachableWhitelist policy.
The old policy will still be used in the absence of the new one for at
least a few releases of Chrome.

BUG=chromium:1103813

Change-Id: Ibc22d67893984f2644d3ce50cb281d5eeff9981c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333038
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795673}

This test appears to flaky on Chrome OS.

TBR=sammiequon@chromium.org

Bug: 1113901
Change-Id: Ia6e4b0954ec47549e4f69796a096545a9051c332
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341174Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795672}

(And to measure the entropy if so).

Or rather, to measure if it could be used for it, since we can't actually tell if the page observes the side effects.

Bug: 1103288
Change-Id: Ia94184d373d84ca9d4ce00d41dd5e67136a6936f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330002
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795671}

Tests marked as experimental in the lacros bot (crrev.com/c/2341931),
so we they don't need to be disabled.

TBR=svenzheng@chromium.org

Bug: 1113695
Change-Id: Idaf81bf6b03fbd45a509b7d51588f2cbf0f6e244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341159
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795670}

https://android.googlesource.com/platform/external/perfetto.git/+log/dc68e3248ed9..e69d5b2de943

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I49b9bf2effd3391579871679863a12058baedb8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340554Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795669}

Bug: 1113695
Change-Id: I498b1a6a10a7dfa0f34c36df1dda45417698a13c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341931Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795668}

Bug: 1100991
Change-Id: I4051534404e0160a6b4415c137c2537849b047e5
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339207
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795667}

Change-Id: I14c30dd135dc2f4fe813c4cee927ba911d33f28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305672Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795666}

As part of a larger effort to migrate fields in Tab to UserData objects
so Tab doesn't become large and unwieldy.

Bug: 1112364
Change-Id: I838e0542a43d4f8a87685eaa679745cff77ebb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337576Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795665}

Default ACL on the password item only allows the owner application to
read the content. We analyze the ACL and recreate the item in case it
won't allow Lean Native Helper or Chrome to access it. Access is limited
to application sharing same team id which is taken from the signing
certificate.

This CL matches secure connector native host behavior. Original CL id:
300399914.

Bug: 1062382

Change-Id: Ica4d8852b544318b06692ecfb02f62628f0b5bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144195Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795664}

This is UI review request to replace the previous open display settings
on context menu. This adds a notification that disappears after 6s
(notifications API default). The notification is shown when a display is
added, all other display related notifications remain hidden if the flag
is off.

Test: manual
Bug: 1111479
Change-Id: Ib3cf08f5a3a6a129a3457605e0b5aefc21063dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340265
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795663}

Bug: 1106950
Change-Id: I401a4dc9d47daa3feee3baf30860e6e42510b8e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341348
Commit-Queue: Gary Tong <gatong@chromium.org>
Auto-Submit: Gary Tong <gatong@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795662}

This is done near the start of wWinMain instead of in InitializeOSUtils
to ensure that it happens before any ScopedHandle's are used.

R=vakh

Bug: 1113819
Change-Id: Ie2a9362da04defdc727637858031e69d8195d8dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341155
Auto-Submit: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795661}

I believe the problem is we are not synchronizing the
delete and save operations - we try to verify one
is done without waiting for the operation to complete.
I solved this by adding in some callbacks

Bug: 1101760
Change-Id: I851e9488df971728738b47292de96710d00a4bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300811Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795660}

In immersive mode, the toolbar floats on top of the tab content. Their
bounds intersect.

The WebUI tab strip would autoclose whenever an event occured inside the
tab content's bounds. However, this didn't consider if the event would
ultimately be delivered to browser UI instead.

This CL lets events whose locations are in the toolbar pass through. It
also adds test coverage for these behaviors.

A more robust solution would consider the event's target window rather
than just its location, but this is more complex. For now these bounds
checks should be sufficient.

Bug: 1112028
Change-Id: Id290bacb973bad1db535c7f69122c1d4019571e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339591
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795659}

This change adds a button to the chrome://network to send a feedback
report populated with the results of the Network diagnostic tests.

content

Bug: chromium:1098405
Test: Click Send Feedback Report button and inspect EXTRA_DIAGNOSTICS
Change-Id: I3707d62878bd49a80ecf76ec235619a6662b34dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334000
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795658}

TBR=robertogden@chromium.org

Bug: 1105908
Change-Id: Iaa8be308734a24879c43687c197f600d64a062ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341814Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795657}

Since GridTabSwitcher has an instance of TabGridDialog, having instant
start on means that TabGridDialog can also be constructed before native.
Similar to http://crrev.com/c/2328038, this CL moves things in
TabGridDialog that should happen after native is ready to appropriate
places.

Bug: 1111391
Change-Id: I7c4e96a715b5867aa62fdd30d9e7dc2a8436d306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329154
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795656}

A file picker control (<input type=file>) is exposed as
a button in the accessibility tree. Previously the
filename chosen was only exposed in the accessible value,
like with other input elements - but most screen readers
were not reading the value, since it's not normal to
read the value of a button. So users couldn't tell what
file was chosen, or whether a file was chosen at all.

Fix this by making the accessible name include both the
filename (as already exposed in the value) and the
text of the "Choose File" button.

Add a test to confirm this is working correctly when a
file is selected.

Bug: 903655

Change-Id: Iaa22ee66e21079014999e8af3d762ee481c85c54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340163
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795655}

We no longer support PDFEngine implementations other than PDFiumEngine,
so there's no need for a PDFEngine::Create() factory that abstracts
which PDFEngine implementation is created.

This also allows OutOfProcessInstance to use PDFiumEngine directly,
rather than having to add methods to PDFEngine first.

Bug: 1076554
Change-Id: I8808038ff5ed0db58719905c2aa8157fbd4bb092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340280Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795654}

This converts the last usages of base::Bind in media/blink to pass the
types expected by the media::ChunkDemuxer ctor.

Bug: 1102651
Change-Id: Id5af750df306168d2307d43bef363ef19ced81ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341385Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795653}

This test flaked on me locally with:
height expected 100 but got 0

Which is consistent with calling checkLayout before the image has
loaded, but not a guarantee that's what's happening. I haven't been able
to reproduce it.

In any case, this change can't hurt.

Change-Id: I1bf8ccb935845c6e5e4529694c2d77e3f4a529a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340735Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795652}

Bug: 1113862
Change-Id: I0ec30cbaeab8ace6de40661548e239860672e2bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341391Reviewed-by: S. Ganesh <ganesh@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795651}

The HandleVerifier is currently enabled on Canary and Dev channel.
It is currently not running for a chrome developers local build.

This CL enables the HandleVerifier for builds with DCHECK_ON. It will
run on Canary builds for a reduced set of the population under the
albatross build instead of on all Canary/Dev. This helps isolate the
performance impact to builds with that intent in my mind and avoids
polluting performance diagnosis tools.

The developers can reproduce issues locally. A build with
dcheck_always_on and supporting the IAT/EAT patching will run the
HandleVerifier.

R=wfh@chromium.org
Bug: 1104342, 1103801

Change-Id: Ie565dcc99c8c2faa27f61bcc4533bb48494c0492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294562Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795650}

This CL adds a dummy ntp-grid into the dummy module. This works as a
proof of concept that NTP-provided custom elements can be used in
modules.

Bug: 1110062
Change-Id: Ib106888c99680f14ed8b0a1282f9660a46f4ffab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339338
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795649}

Bug: 1046523
Change-Id: Ifa9950ffb2495775b567239d931e8a39dbe69e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339998
Commit-Queue: Angela Yoeurng <yoangela@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795648}

Lookalike interstitials require committed interstitials to be
enabled, so add a check in tab_helper_util.

Change-Id: Ia991dcb4630b576cc7d59fd0ec2ce5a78c3d4de2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341040Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795647}

This addresses a few issues I noticed with the IME (AKA "soft keyboard")
with the new search bar:

 * Switches to "adjustPan" mode, which overlays the IME on top of our
   layout rather than resizing our layout to sit above the IME (avoids
   an issue where the bottom nav bar sits above the keyboard)
 * Hide the IME when the user clicks the "done" button
 * Hide the IME when the user taps away from the EditText

Bug: 1052345
Test: Manual - verify IME works as expected
Change-Id: I1275299ffa562a48bd2f99586c8c10974b376927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340931Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795646}