GitLab

Revert of Refactor ScrollableArea::setScrollPosition. (patchset #6 id:100001 of https://codereview.chromium.org/2383113003/ )

Reason for revert:
Blocks revert of another patch: https://codereview.chromium.org/2395683002/

Original issue's description:
> Refactor ScrollableArea::setScrollPosition.
>
> - Eliminate some redundant PaintLayerScrollableArea methods and
> indirection.
>
> - ScrollableArea::setScrollPosition now always clamps its argument.
> Code inspection revealed that nearly all callers were clamping
> the position argument anyway.
>
> - ScrollableArea::setScrollPosition returns immediately if the scroll
> position did not change.  This avoids a bunch of unnecessary
> work.
>
> - For the rare instances where the scroll position should not be
> clamped, or the scroll position update code should run even if the
> scroll position didn't change, add the method
> setScrollPositionUnconditionally.
>
> - When modifying the scroll position due to a change in effective
> zoom, preserve the offset from beginning of flow, rather than the
> distance from top-left of overflow area.
>
> BUG=417782
> R=skobes@chromium.org,bokan@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/cddc823c56d453758003a831fd5a2475e94c0387
> Cr-Commit-Position: refs/heads/master@{#423033}

TBR=bokan@chromium.org,skobes@chromium.org,pdr@chromium.org,szager@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=417782

Review-Url: https://codereview.chromium.org/2387393003
Cr-Commit-Position: refs/heads/master@{#423041}

This makes crash dumping optional for RPH::ShutdownForBadMessage,
and changes the thread-safe bad_message::ReceivedBadMessage to
generate its own crash dump immediately, before potentially posting
a UI thread task.

All other call sites have been updated to opt into crash dumping,
preserving previous behavior.

This ensures that bad message reports from the IO thread have a
useful crash stack.

BUG=652755
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2387113004
Cr-Commit-Position: refs/heads/master@{#423040}

This patch is to increase perceived performance of network panel
by using requestAnimationFrame instead of setTimeout for scheduled
refreshes.

R=lushnikov
BUG=None

Review-Url: https://codereview.chromium.org/2392123002
Cr-Commit-Position: refs/heads/master@{#423039}

Changed EListStylePosition to an enum class and gave it an unsigned underlying
type so it can be stored in a bitfield in the future. Also renamed its
members to match its keywords from CSSValueKeywords.in. This is pre-work
to move EListStylePosition to be generated in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2380233002
Cr-Commit-Position: refs/heads/master@{#423038}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d561772ce644..f68d5268f877

$ git log d561772ce..f68d5268f --date=short --no-merges --format='%ad %ae %s'
2016-10-04 benjhayden Add a test_data trace containing LayoutTrees.
2016-10-04 aiolos Remove dev build platforms that aren't used in Catapult tests.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2396703002
Cr-Commit-Position: refs/heads/master@{#423037}

This patch prunes createVisibleSelectionDeprecated from DragController
by either having an explicit layout update before each call site, or
confirming that the layout is already clean.

Note: Layout is clean at the call site in |dispatchTextInputEventFor()|
because it's called directly after a hit test, which is performed in
|elementUnderMouse()|.

BUG=651373

Review-Url: https://codereview.chromium.org/2386083002
Cr-Commit-Position: refs/heads/master@{#423036}

Also adding some missing validation for MapBufferRange.

BUG=429053,651843
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2221173002
Cr-Commit-Position: refs/heads/master@{#423035}

We don't plan to fix the bug, because the FileSystem API is in
maintenance mode. We document the bug as a heads-up to anyone (most
likely us in the future) who might want to reuse the code.

BUG=171284

Review-Url: https://codereview.chromium.org/2390323003
Cr-Commit-Position: refs/heads/master@{#423034}

- Eliminate some redundant PaintLayerScrollableArea methods and
indirection.

- ScrollableArea::setScrollPosition now always clamps its argument.
Code inspection revealed that nearly all callers were clamping
the position argument anyway.

- ScrollableArea::setScrollPosition returns immediately if the scroll
position did not change.  This avoids a bunch of unnecessary
work.

- For the rare instances where the scroll position should not be
clamped, or the scroll position update code should run even if the
scroll position didn't change, add the method
setScrollPositionUnconditionally.

- When modifying the scroll position due to a change in effective
zoom, preserve the offset from beginning of flow, rather than the
distance from top-left of overflow area.

BUG=417782
R=skobes@chromium.org,bokan@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2383113003
Cr-Commit-Position: refs/heads/master@{#423033}

BUG=angleproject:1354

Review-Url: https://codereview.chromium.org/2385323003
Cr-Commit-Position: refs/heads/master@{#423032}

This also makes some minor modifications (rewrite for clarity, etc.).

BUG=563793
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2385123003
Cr-Commit-Position: refs/heads/master@{#423031}

In https://codereview.chromium.org/1894333002/ I made the OnRequestMoveAck
method reset the view_screen_rect_ variable to the pending rect. This was a
mistake because the move request is on the *window* rect, not the view rect.
Additionally, it's unnecessary since it's the browser's job to send an
UpdateScreenRects message to the renderer with the new view and window bounds.
This only happens for non-popup windows so popups will now store the view/window
rects immediately. This patch removes the reset in the Ack method.

In addition, the windowRect method confusingly returns the view_screen_rect or
pending_window_rect if there's a pending move. I've changed this to return the
window_screen_rect_ and added a viewRect method for callers that actually
expect the view. I also did some cleanup and replaced the redundant
RootWindowRect with windowRect.

BUG=638671

Review-Url: https://codereview.chromium.org/2333353002
Cr-Commit-Position: refs/heads/master@{#423030}

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for to make
our ECDSA client certs logic for TLS 1.3. (Having certificates with the
keys will be convenient)

Also check in client_root_ca.pem so the inputs are all available.

BUG=630150

Review-Url: https://codereview.chromium.org/2390493002
Cr-Commit-Position: refs/heads/master@{#423029}

BUG=652908
TEST=none

Review-Url: https://codereview.chromium.org/2394663004
Cr-Commit-Position: refs/heads/master@{#423028}

Chrome context menu items use "Sentence case" on Chrome OS.
Fix the Files app's "Get Info" string. Also add a few
missing descriptions for other strings.

BUG=none

Review-Url: https://codereview.chromium.org/2389353002
Cr-Commit-Position: refs/heads/master@{#423027}

BUG=563793
TBR=haraken

Review-Url: https://codereview.chromium.org/2392443007
Cr-Commit-Position: refs/heads/master@{#423026}

BUG=647872
TEST=new test added

Review-Url: https://codereview.chromium.org/2353813002
Cr-Commit-Position: refs/heads/master@{#423025}

This causes the Feedback screenshot to be captured after the drawer is
closed.

BUG=651527

Review-Url: https://codereview.chromium.org/2389153003
Cr-Commit-Position: refs/heads/master@{#423024}

Revert of Fix task manager's default sizing. (patchset #6 id:100001 of https://codereview.chromium.org/2344703002/ )

Reason for revert:
On Linux, the task manager window self expands and gets wider and wiser.

Original issue's description:
> Fix task manager's default sizing.
>
> Set default width based on contents rather than hardcoding a value (which happened to be too small once we adjusted outer padding for the dialog).
>
> BUG=614317
>
> Committed: https://crrev.com/6678470d3169979d811eec56e7cdea668ab751c1
> Cr-Commit-Position: refs/heads/master@{#422893}

TBR=sky@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=614317

Review-Url: https://codereview.chromium.org/2389803006
Cr-Commit-Position: refs/heads/master@{#423023}

https://chromium.googlesource.com/skia.git/+log/511f2d79bf6e..121563eb4a02

$ git log 511f2d79b..121563eb4 --date=short --no-merges --format='%ad %ae %s'
2016-10-04 mtklein Fold extra_*_flags into GN as a config.
2016-10-04 mtklein Revert "Debug Mac test failure."
2016-10-04 reed Revert[5] "replace SkXfermode obj with SkBlendMode enum in paints"
2016-10-04 benjaminwagner Remove SK_SUPPORT_LEGACY_TEXTBLOB_BUILDER from public.bzl
2016-10-04 csmartdalton Use uint64_t for PlatformFence
2016-10-04 borenet Make the housekeeper upload doxygen to a newer bucket

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=stephana@google.com

Review-Url: https://codereview.chromium.org/2390783004
Cr-Commit-Position: refs/heads/master@{#423022}

* Initialize ui::NetworkConnect during mash startup
* Provide a stub NetworkConnect::Delegate implementation

It still won't actually switch networks on the device (there are issues
talking to shill in lower-level code) but it's a step in the right direction.

BUG=644355
TEST=manual, click on network in system tray, no crash

Review-Url: https://codereview.chromium.org/2394503003
Cr-Commit-Position: refs/heads/master@{#423021}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/a1ec1d60129d55b93340a46b2bb389b86ea2fb95 Add gen/ui to generated bindings paths (rockot@chromium.org)
  https://crrev.com/6b5d14dc03df1b90ff9794d0887a491b2c7bad6c [android] Support not passing --adb-path. (jbudorick@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=652250,652761

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2396713002
Cr-Commit-Position: refs/heads/master@{#423020}

ModelTypeController simply takes a model thread into its constructor and
treats the UI thread the same as any other.

This CL contains significant cleanup of the test file as well, which contains
all the test cases from NonUiModelTypeControllerTest and
NonBlockingDataTypeControllerTest:

- It no longer uses the real SharedModelTypeProcessor implementation.
- It no longer pretends to have a sync thread that's really just the UI thread.
- There's a private section to make it clear which pieces are internal.
- A better TestBackendDataTypeConfigurer with no MockSyncBackend.

Note that ModelTypeProcessorProxy was promoted to its own file in order
to implement TestModelTypeProcessor elegantly.

BUG=652398

Review-Url: https://codereview.chromium.org/2384153004
Cr-Commit-Position: refs/heads/master@{#423019}

BUG=

Review-Url: https://codereview.chromium.org/2379993006
Cr-Commit-Position: refs/heads/master@{#423018}

I believe that after http://crrev.com/2276713002, invoking webkit-patch
with --help rather than help was broken.

When `webkit-patch help` is invoked, the codepath that's used goes through
the execute method of HelpCommand, and the _tool attribute is set, so it
worked.

But when --help is passed, a different codepath is used, that goes through
optparse which directly uses HelpCommand.help_epilog and the _tool attribute
was never set.

This CL fixes this case by setting the _tool attribute in the constructor
of HelpCommand.

Review-Url: https://codereview.chromium.org/2385373003
Cr-Commit-Position: refs/heads/master@{#423017}

BUG=none

Review-Url: https://codereview.chromium.org/2390933003
Cr-Commit-Position: refs/heads/master@{#423016}

BUG=563793

Review-Url: https://codereview.chromium.org/2390773004
Cr-Commit-Position: refs/heads/master@{#423015}

BUG=563793

Review-Url: https://codereview.chromium.org/2391893006
Cr-Commit-Position: refs/heads/master@{#423014}

BUG=652907
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2393703003
Cr-Commit-Position: refs/heads/master@{#423013}

BUG=651984

Review-Url: https://codereview.chromium.org/2385673005
Cr-Commit-Position: refs/heads/master@{#423012}

BUG=603396

Review-Url: https://codereview.chromium.org/2390983002
Cr-Commit-Position: refs/heads/master@{#423011}

Added yuweih@.

Review-Url: https://codereview.chromium.org/2391003003
Cr-Commit-Position: refs/heads/master@{#423010}

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2384273005
Cr-Commit-Position: refs/heads/master@{#423009}

BUG=603928
R=skobes@chromium.org, cbiesinger@chromium.org

Review-Url: https://codereview.chromium.org/2373963002
Cr-Commit-Position: refs/heads/master@{#423008}

BUG=555865

Review-Url: https://codereview.chromium.org/2389583002
Cr-Commit-Position: refs/heads/master@{#423007}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ea00e6ba38cf..d561772ce644

$ git log ea00e6ba3..d561772ce --date=short --no-merges --format='%ad %ae %s'
2016-10-04 aiolos Update desktop stable Chrome reference builds.
2016-10-04 robertocn Missing import for compare_samples executable script.
2016-10-04 aiolos Update the used canary/dev Chrome reference builds.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2396683002
Cr-Commit-Position: refs/heads/master@{#423006}

The original CL is here: https://codereview.chromium.org/2367673002/
It was reverted because of compile failure with gn flags:
is_debug=false
is_component_build=true
target_os="android"
The reason is gvr uses API that only available in Android N SDK. For
release build, proguard detected the dependancy and results a compile
error. N SDK is in the process of rolling to chromium
https://codereview.chromium.org/2350013004/
In this CL, I restricted WebVr to debug build only. This could unblock
us. And I will remove the is_debug restriction once N is in Chromium

BUG=389343
TBR=dtrainor@

Review-Url: https://codereview.chromium.org/2396663002
Cr-Commit-Position: refs/heads/master@{#423005}

This change adds the ability to scroll the desktop canvas out from under
any visible System UI.

When System UI is displayed (for Kitkat and higher) the
TouchInputHandler instance is called with the state/sizes of the System
UI per edge of the screen.  These values are passed to the DesktopCanvas
instance which uses them for determining whether the System UI overlaps
with the remote image content.  If there is overlap then it adjusts
the region of valid cursor and viewport positions which then allows
the user to pan the content out from 'under' the System UI which is
obscuring it.allowable position of the viewport.

When the System UI disappears (or changes size), the current amount of
padding, if any, is used as the new boundary.  This prevents a jarring
translation from occuring when the System UI changes size.

BUG=621633

Review-Url: https://codereview.chromium.org/2375113003
Cr-Commit-Position: refs/heads/master@{#423004}

BUG=639530

Review-Url: https://codereview.chromium.org/2394623003
Cr-Commit-Position: refs/heads/master@{#423003}

BUG=563793
TBR=pilgrim@chromium.org

Review-Url: https://codereview.chromium.org/2392153002
Cr-Commit-Position: refs/heads/master@{#423002}