- 23 Oct, 2020 27 commits
-
-
Liquan (Max) Gu authored
Before the CL, //components' JourneyLogger depends on //chrome's journey_logger_android. This disallows WebLayer from depending on JourneyLogger. So this CL moves journey_logger_android into //components. After the CL, WebLayer can depend on //components' JourneyLogger. Bug: 1140637 Change-Id: I881fc8dd65071907e424f1184ea221f5bca0d147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491606Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820086}
-
Darren Shen authored
Add Mojo and protobuf messages for Chrome to send on blur to the IME service. Bug: 1019541 Change-Id: If01c8e2dceaa13c7218ee13913f32a26ddcfe52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483944Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#820085}
-
Pavel Yatsuk authored
Initializing messages after native initialization is needed to make sure the same flag value for MESSAGES_FOR_ANDROID_INFRASTRUCTURE is available both in RootUiCoordinator and native feature code. BUG=1123947 R=lazzzis@chromium.org Change-Id: I18e488caba8dae94b3b1117fc16c406c277f1f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476616Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#820084}
-
Chris Palmer authored
When zapping on free. Bug: None Change-Id: Idc47cb00c9017b9bb305bf2b1c7fc6279fb0b224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493320Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#820083}
-
Lei Zhang authored
Instead of passing in std::unique_ptr<base::Value>, mechanically convert many callers from OneArgument(std::make_unique<base::Value>(...)) to OneArgument(base::Value(...)). Also drop base::Value::ToUniquePtrValue() in a few case. Bug: 1139221 Change-Id: I75eab4b239fc0ec33b37bb021b4be989d204b96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487878Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820082}
-
Reilly Grant authored
In the Camera v1 API the camera must be opened to read parameters including whether or not it supports zoom. Opening the camera to read these parameters can cause a conflict in some hardware drivers which prevents the call to android.hardware.Camera.open() in allocate() to fail. It is most important that the camera be openable at all than to detect whether zoom is supported. Bug: 1138608 Change-Id: If22ec843cab964f70a656eb73f9c9d325e018bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493421Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820081}
-
Eric Lawrence authored
I recently added code to use the chrome://net-export tab's icon as an indicator that a netlog is being captured. This icon incorrectly shows as a white dot when the browser is in Dark mode, because Chrome tries to "theme" the icon for chrome:// pages. This CL exempts the chrome://net-export icon from theming. Bug: 1141181 Change-Id: Ia48271a09b3200e715b3527d934226cf2663477c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490763Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820080}
-
Alfonso Garza authored
Crash happens because the cell item is no longer in the collection when reconfigureCellsForItems is called, which triggers a NOTREACHED() line. Bug: crbug/2380145 Change-Id: I379fe21debd73a3950282eb9a8436b2d305a94ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493263 Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#820079}
-
George Steel authored
vector-effect: non-scaling-stroke blocks composited transform animations since it means that paint changes when transform does. In the current implementation of svg:use, instances clone their computed styles from the original element and are effected by its animations, meaning that there is no 1:1 correspondence between element and transform node, as required by compositor animations. Bug: 1139109, 1137884 Change-Id: I5844db7e7c920e0796d71326e66651bbc2808e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482002Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#820078}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7c00632bb5ade9946c077688cb71976ee57fdcc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820077}
-
Lei Zhang authored
Instead of taking std::unique_ptr<base::Value>. Mechanically convert many callers from OneArgument(std::make_unique<base::Value>(...)) to OneArgument(base::Value(...)). Bug: 1139221 Change-Id: Ib5cd0b2f54f87b620662ccde23c241566e50bde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473352Reviewed-by:
-
Nate Chapin authored
Change-Id: Iefa5a511d95b711458409170d908f1907f24cf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493095 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Kinuko Yasuda authored
This reverts commit ad03192d. Reason for revert: VulkanWebEngineIntegrationTest.HardwareVideoDecoderFlag_Provided consistently failing on Fuchsia https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64/59108 https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64/59109 Original change's description: > Roll ANGLE from 5641e3c185a8 to 9c8da02650bc (4 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/5641e3c185a8..9c8da02650bc > > 2020-10-22 cnorthrop@google.com Revert "Tests: Add FIFA Mobile trace" > 2020-10-22 syoussefi@chromium.org Vulkan: Validate SPIR-V transformer at link time > 2020-10-22 xiaoxuan.liu@arm.com Fix end2end tests VertexAttribute* failure > 2020-10-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 970c132746b1 to 91ce213a1d88 (3 revisions) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC jonahr@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: jonahr@google.com > Change-Id: Ibcd63dae3ab0e3cbf06da55b97e6e34d6635372d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492566 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#820011} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,jonahr@google.com Change-Id: I1e549590c11e64de1c8425ae10e89008ac33b8b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493960Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#820074}
-
Regan Hsu authored
Adoption * State upon login (using feature status enum values) Connectivity * Connection latency * Connection success rate * Connection duration Usage * Counters for each command sent Bug: 1106938 Change-Id: I457360ff1f805b56d48e7be0ccd36429ee07d6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485445 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#820073}
-
Nate Chapin authored
Change-Id: Ifcea842ded0a9337be297e2a1a928f65d244353c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493424 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Gordon Seto authored
Update default search engine preference to be a dialog, remove tooltip. Screenshots: Before: https://screenshot.googleplex.com/8AwiZ9VfMSDVvHe.png After: https://screenshot.googleplex.com/3ZYYuwHJQ73kVmG.png https://screenshot.googleplex.com/4wn9i9DbgbW22NG.png Fixed: 1032121 Change-Id: I9c3e62ac7ee2ae94fdbe919cebad6b4c992a0277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489955 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820071}
-
Yuchen Liu authored
For Q+ devices, SurfaceControl and AImageReader may cause some video playback stall. Temporarily disable them. Bug: internal b/162803423 Test: Bug is not repro Change-Id: I4ce7e42fd87433464dfe4a6b29b816cb41ce7138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493091Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820070}
-
Wei Li authored
Allows Checkbox class to use builder pattern, and converts the Checkbox example to use the builder. Also add callback property into Button class so Button class and its subclasses can use callback in their metadata and builders. Bug: 1130078 Change-Id: Ifd2e7cebd172d8fc91cbce50c0dacafd6b5ecf9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490339 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#820069}
-
Vladimir Levin authored
This patch ensures that when we delay the load because the plugins need to be loaded and we're under a content-visibility lock, then we add the object to be updated into frame view's list immediately This is typically done during layout, but if layout is prevented then we run into a possibility of delaying load event forever. Adding the object to the update set immediately avoids the problem. R=masonfreed@chromium.org Bug: 1138128 Change-Id: I4d918c6bbdcd80aa6f01bf3b068acb64a93b0196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485671 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#820068}
-
Jeffrey Kardatzke authored
This adds parsing of SPS from the H265 bitstream. To keep the size down a little, it doesn't handle VUI and the other extension data yet. That'll be in the next CL. The design follows the existing H264Parser. BUG=chrome:1141237,b:153111783 TEST=media_unittests pass Change-Id: If489ddb5a31fcdb323773a3f530719f51878a897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491925 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#820067}
-
Donn Denman authored
Adds or updates file-level comments for most of the key classes used by Contextual Search. There are no functionality changes. This CL consists only of file-level comment updates. Change-Id: I44a1ab287bea16cf383dfb2c1769f09171144eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487835Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#820066}
-
Darren Shen authored
Add Mojo and protobuf messages for Chrome to send surrounding text changes to the IME service. Change-Id: I0ff2fdb302c884be2ff9640d7990bdfcba8d87ca Bug: b/161490915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422021Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#820065}
-
Hiroki Nakagawa authored
This CL adds basic browser tests for <link rel=prerender> using Prerender2. Bug: 1132746 Change-Id: I260fb9652839ee30327f5bfd44096ea570aceb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489061Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#820064}
-
Lan Wei authored
The pointerevent' spec has properties e.g. width, height, pressure..., so we are working on adding the pointerevent's properties to Webdriver Action API to simulate the inputs from devices such as touchscreen and stylus, which have these additional properties. This CL adds these properties to ChromeDriver's ExecutePerformActions. This CL adds these properties to Devtool Input protocol's DispatchMouseEvent and TouchPoint. Bug: 1139172 Change-Id: I75f3d08491ffb9719340f327268d952bedf1ad80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477049Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#820063}
-
Shakti Sahu authored
This CL changes the radio button in language picker from using a linear layout to use RadioButtonWithDescription. Also disable the watch button initially when no radio button is checked. Bug: 1117182 Change-Id: I836947d6484c57760c6e6fd9b0d2450d8ce8d6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492906Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820062}
-
Ricky Liang authored
When the render thread encounters GPU context lost, we need to re-create the SharedImage resources to recover the video capture stream. Bug: 1131998, b:169429427 Test: Manually with chrome://gpuclean on soraka Change-Id: Ie6306653e779885fbf131c9964ae8ed90493ac76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455328Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820061}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4af5cd3397d..2e5b59565826 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I49be8bd157187a309d54e7e45fbda2ba21233917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493361Reviewed-by:
-
- 22 Oct, 2020 13 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65674e4c2e56..53281c712159 2020-10-22 tdenniston@google.com [svg] Add current node to render context 2020-10-22 ethannicholas@google.com moved SkSL Switch data into IRNode 2020-10-22 johnstiles@google.com Use SkMutex in SkSL. 2020-10-22 ethannicholas@google.com added SkSL OptimizationContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Ie6c1dff6f8085ab99e719673f1f3f86116758060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492892Reviewed-by:
-
Nina Satragno authored
This change implements the webauthn:extension:largeBlob extension capability, adding large blob support for virtual authenticators. The webauthn:extension:largeBlob capability: * Adds an option on authenticator creation to enable large blob support. * Allows setting and retrieving the large blob through AddCredentials and GetCredentials. https://w3c.github.io/webauthn/#sctn-authenticator-extension-capabilities This is part of the WebAuthn Testing API https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ Bug: chromedriver:3631 Change-Id: Ie8be5a36f78068c1f7f168987e8aa531fef6077a Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488183Reviewed-by:
Shengfa Lin <shengfa@google.com> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#820058}
-
Richard Townsend authored
Enums can be unsigned or signed. This change corrects an unsigned/signed comparison error by making sure this enum is always unsigned. Bug: 1141421 Change-Id: Ic3576497c77fd6e3391e6d42a4653c699f337a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493201Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#820057}
-
David Munro authored
In some cases (e.g. the linked bug) source can be null. SetSelection is already a no-op for nullptr source (and invalid for nullptr data_device) so there's no change in behaviour for the case where event_type != nullopt, and it fixes a nullptr dereference when event_type == nullopt. Bug: 1138761 Test: Deploy, launch evolution, Chrome doesn't crash Change-Id: I23da80e418834f5c1e38eecd2f0b140638b63a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487022Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#820056}
-
David Tseng authored
This reverts commit 743f4e9d. In extended usage, this doesn't work well for long text blocks. Stopping speech, ChromeVox is immediately brought to the end of that entire block. We need timepointing from tts to help here. TBR=dtseng@chromium.org Change-Id: I6fe2503618fefe35d9043453c56edfa4c05e9653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493121Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820055}
-
Richard Chui authored
This CL ensures that when dragging the selected region by an edge affordance, that the capture region is resized only in the expected direction. Test: manual, updated test Change-Id: Icd2691592deb180db55b84f8e394b2e8935a3858 Fixed: 1140778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490866 Commit-Queue: Richard Chui <richui@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#820054}
-
Sorin Jianu authored
The *ServiceClass names are intended for per-machine coclass names. This CLSID is used by the per-user code but it has been named using the per-machine naming convention by mistake. This is a step toward spplitting updater idls goal. Bug: 1140562 Change-Id: I12b0d2f7d15d0f58de062e6e9f0dbec0eff5420e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493720Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820053}
-
Joshua Peraza authored
865ba27672fe Remove unnecessary macro from CaptureContext code e6b525a4be28 Update config adjustments for moved build config in mini_chromium f3aad4921621 Roll mini_chromium to 71a7fdb 74b38694fa86 Roll mini_chromium to 2b6cfa3 0b240a5347e7 Update mini_chromium to 1dbeb82e0452 0e03f8e7fa3f Remove now-no-op set_sources_assignment_filter calls 79d43b8ac37b Add noexcept to no_cfi_icall templates c4c71b80c6a2 linux: Fix tests with UBSan 71e8ec79870b Initialize logging This change also updates base/logging.cc to conditionally access CommandLine because crashpad doesn't initialize one. Bug: chromium:711159 Change-Id: I0056d71ae2281329d21fb6f58eba3ebb34beaf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490880Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#820052}
-
Peter Boström authored
Removes overrides in all child classes of PasswordBubbleViewBase. Also replaces ShouldShowCloseButton() overrides. Bug: 1128500 Change-Id: I7f875679888beeb4f138a6bb62abf78c0d2b1542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493126 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#820051}
-
Matt Menke authored
Make HttpNetworkTransaction pass in appropriate NetworkIsolationKey to Reporting and Network Error Logging APIs. Bug: 993805 Change-Id: I0c5f4f7c1672df661ca2c7bb3d6f9e1a83a8c9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485512Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#820050}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id18eb0cacd214c36b134b5eac485e03fd7001e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493085Reviewed-by:
-
Hoch Hochkeppel authored
Adding a #include to FakeIAsyncOperation that should have been included originally but was missed. Bug: 1141584 Change-Id: I0da3062a08b103d535c947f56c326f33db54179d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493062 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#820048}
-
Michael Hansen authored
This cleans up the pattern in which we were storing callbacks as instance variables in FastInitiationManager. This is no longer required because BluetoothAdapter now accepts OnceCallbacks, so we can just carry them through the flow as bound input parameters. Fixed: 1119970 Change-Id: Iee6bc637dc847b6810694bd63b6b008e1738c62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468786 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#820047}
-
