- 16 Nov, 2018 40 commits
-
-
Rune Lillesveen authored
There is no point in marking an element style dirty while we are recalculating style for it. For SVG elements which are referenced through <use> elements we even mark the instances style-dirty which caused a problem in issue 904381 because the <use> instance was outside of the sub-tree rooted at the recalc root, causing the tree to be still style-dirty after UpdateStyle. Bug: 904381 Change-Id: If5e487783668e9d411ff721fd60e80fa7f1a8313 Reviewed-on: https://chromium-review.googlesource.com/c/1335602Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#608712}
-
Jun Choi authored
This reverts commit 73564b6c. Reason for revert: <Fails build Google Chrome Win Build #40337 on "chrome/browser/conflicts/module_blacklist_cache_util_win.cc(242,61)"> Original change's description: > [base] Remove base::span's comparison operators > > At the recent ISO C++ Committee meeting in San Diego it was decided [1] > to make std::span SemiRegular and drop its comparison operators [2]. For > further info see also this blog post [3]. > > This change updates the base::span implemention appropriately and > replaces prior usages of the comparison operators with their STL > algorithm equivalent. > > [1] http://redd.it/9vwvbz > [2] https://wg21.link/p1085 > [3] https://abseil.io/blog/20180531-regular-types#evaluating-span > > Bug: 828324 > Change-Id: I94e94450df5f233b6de81da81f309386e0dcf4a7 > Reviewed-on: https://chromium-review.googlesource.com/c/1337628 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Jun Choi <hongjunchoi@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608702} TBR=rsleevi@chromium.org,dcheng@chromium.org,rockot@google.com,jrummell@chromium.org,mek@chromium.org,haraken@chromium.org,jdoerrie@chromium.org,hongjunchoi@chromium.org Change-Id: Id39b32be29dd80b6d299fc99a2efade8c2246fe6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828324 Reviewed-on: https://chromium-review.googlesource.com/c/1339999Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608711}
-
Veranika Liaukevich authored
The code hasn't been used by the cleaner or the reporter for a long time. Change-Id: I46e95300ac11d5c6d601bccafe1853b555de54f7 Reviewed-on: https://chromium-review.googlesource.com/c/1316170Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Cr-Commit-Position: refs/heads/master@{#608710}
-
Yutaka Hirano authored
It's no longer crashy. Bug: 902632 Change-Id: I2446b569e116e6a9f62b1bedf2c1eb0338184461 Reviewed-on: https://chromium-review.googlesource.com/c/1338822Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#608709}
-
Amos Lim authored
If a 2d translation is specified, the property must serialize with only one or two values (per usual, if the second value is 0px, the default, it must be omitted when serializing)[1]. [1]: https://drafts.csswg.org/css-transforms-2/#individual-transform-serialization Bug: 904804 Change-Id: I34c4f47b5413348c7526b9050c89ec35212c3093 Reviewed-on: https://chromium-review.googlesource.com/c/1337670Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#608708}
-
Corentin Wallez authored
BUG=chromium:chromium:901830 Change-Id: Idf9d60a7ca58d65ca8632fef1a729691d99207a5 Reviewed-on: https://chromium-review.googlesource.com/c/1337499Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#608707}
-
Ernest Galbrun authored
Bug: 806868 Change-Id: Iacfc5e5100a27f1bec98d7f794bd624eef4c9f82 Reviewed-on: https://chromium-review.googlesource.com/c/1335573 Commit-Queue: Ernest Galbrun <galbrun@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#608706}
-
Jun Choi authored
MacOS use system native UI for Bluetooth pairing process. Thus, instead of showing BLE PIN UI, directly attempt to establish connection with the device user selected during BLE device selection UI. Bug: 877344 Change-Id: I47bcd31e7d679beba65337dcc6d9b3b555bdf739 Reviewed-on: https://chromium-review.googlesource.com/c/1331474Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608705}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0111ee0e733..39d528d074c9 Created with: gclient setdep -r src-internal@39d528d074c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic9b2fb974e834b590b82eef6ce17add4763b6967 Reviewed-on: https://chromium-review.googlesource.com/c/1339480Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608704}
-
Amos Lim authored
Align WorkerLocation IDL with HTML spec by getting rid of URLUtilsReadOnly and flattening it into WorkerLocation. Spec: https://html.spec.whatwg.org/multipage/workers.html#worker-locations Bug: 699873 Change-Id: I525a47c01e7ef31457958dd76a811134737597b4 Reviewed-on: https://chromium-review.googlesource.com/c/1339680 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#608703}
-
jdoerrie authored
At the recent ISO C++ Committee meeting in San Diego it was decided [1] to make std::span SemiRegular and drop its comparison operators [2]. For further info see also this blog post [3]. This change updates the base::span implemention appropriately and replaces prior usages of the comparison operators with their STL algorithm equivalent. [1] http://redd.it/9vwvbz [2] https://wg21.link/p1085 [3] https://abseil.io/blog/20180531-regular-types#evaluating-span Bug: 828324 Change-Id: I94e94450df5f233b6de81da81f309386e0dcf4a7 Reviewed-on: https://chromium-review.googlesource.com/c/1337628Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Kent Tamura authored
CustomElementDefinition::disable_internals_ is initialized with the content of 'disabledFeatures'. This code is behind 'ElementInternals' runtime flag, and this CL doesn't have user-visible behavior changes yet. Bug: 905922 Change-Id: I9755835079cb71f34317a74a76cf4ac9486df60d Reviewed-on: https://chromium-review.googlesource.com/c/1339500Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#608701}
-
Kent Tamura authored
'formdata' event handlers can get entries created with form-associated elements. Bug: 825684 Change-Id: I55169bf1491073dc52f310d1165c882ed2a98101 Reviewed-on: https://chromium-review.googlesource.com/c/1338825Reviewed-by:
-
Hitoshi Yoshida authored
This is a reland of 6a1db25d with fixing the build error. Original change's description: > document: Use ElementCreationOptions in Document.createElement() > > We used (DOMString or Dictionary) type for |option| parameter, > but this CL replaces it with (DOMString or ElementCreationOpitons) > as the spec defined. > > > Bug: 904241 > Change-Id: I9416af83168e7c1f7456ffdbd3141fa97b510706 > Reviewed-on: https://chromium-review.googlesource.com/c/1333094 > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608668} Bug: 904241 Change-Id: I2ea645814ea80f9989dab93574e70e473b72a10a Reviewed-on: https://chromium-review.googlesource.com/c/1339499Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Oystein Eftevaag authored
Specifically memory.long_running_idle_gmail_background_tbmv2 will OOM on Nexus5 devices with this buffer size. R=eseckler@chromium.org Bug: 902064 Change-Id: If8e5529f3000b9a2f3b86abaecb1f219df356575 Reviewed-on: https://chromium-review.googlesource.com/c/1338889 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#608698}
-
Oystein Eftevaag authored
R=eseckler@chromium.org Bug: 902064 Change-Id: I4b113c69df1192b4d0d05c0a5b9107b84b9cae2e Reviewed-on: https://chromium-review.googlesource.com/c/1338879 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 97597a97. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I8d94faa710dfebfa36100ca26344b5ceadc51f86 Reviewed-on: https://chromium-review.googlesource.com/c/1339459 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608696}
-
David Jean authored
Bug: 845472 Change-Id: I1eb716c293492ada3476d356fcdfcfe23597fa59 Reviewed-on: https://chromium-review.googlesource.com/c/1335596 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#608695}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0abe42b5a5e..c0111ee0e733 Created with: gclient setdep -r src-internal@c0111ee0e733 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I65206ebce722da6459a6a51dcb4aff30cc0f20ec Reviewed-on: https://chromium-review.googlesource.com/c/1339479Reviewed-by:
-
Asami Doi authored
This CL adds t.add_cleanup() that calls service_worker_unregister() in WPT tests to ensure registrations are removed on test completion. Bug: 824647 Change-Id: Ieb790d4d7f63fc4810f6062d7e288aad1e88f45d Reviewed-on: https://chromium-review.googlesource.com/c/1328545 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#608693}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dcdb6042002f..c735b4f9dc50 git log dcdb6042002f..c735b4f9dc50 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@c735b4f9dc50 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I5de6419295141af9532bcb7f7cda9aa11572882d Reviewed-on: https://chromium-review.googlesource.com/c/1339323Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608692}
-
Matt Falkenhagen authored
Some https requests trigger TLS client certificate selection. This is a dialog displayed to the user in the tab containing the frame making the request. Service workers broke this when they intercepted the request from a frame, and reissued the request via fetch(). The service worker doesn't have a frame and there is no information on the request that tracks back to the frame. This CL addreses that via the following mechanism. ServiceWorkerProviderHost has a |fetch_request_window_id| which is similar to |client_uuid|, except it is not a web-exposed GUID and is reset on redirects during navigations. This token is added to requests that go through service workers, and identifies the originating frame. This corresponds to the Fetch specification's concept of a request's associated |window|. Now when the service worker reissues the request, and the browser wants to display the UI, it can get the WebContents of the originating frame. Limitations: * Doesn't work for requests from workers that are intercepted by service workers. Workers aren't fully supported as service worker clients yet (they don't have their own ServiceWorkerProviderHost). * The Fetch API's feature of disassociating a request via setting |init.window| to null in the constructor is not yet implemented. Bug: 894484 Change-Id: I377f2103f62bee81bdee2c971b4359ee8a8b3049 Reviewed-on: https://chromium-review.googlesource.com/c/1290435 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#608691}
-
Christopher Cameron authored
Add the NSAccessibilityRemoteUIElement interface along with helper functions to use the interface with stl structures. Make the previously-dummy GetNativeViewAccessible implementation of perform a sync call to BridgedNativeWidgetHost to set up the required accessibility tree structures. - Send to the browser process the accessibility tokens for the NSWindow and its content NSView. - Retrieve the accessibility token for the root AXPlatformNodeCocoa, along with the browser process id. This is not sufficient for accessibility to work. The remaining parts are to - Update the AXPlatformNodeCocoa class to return the object created from the accessibility tokens. - Add TODOs where this needs to be hooked up, but defer the actual change to a separate patch. - Splice together the accessibility trees for content and views. Create a ScopedAccessibilityFocus class to override the value returned by -[NSApplication accessibilityFocusedUIElement]. This is required for cross-process accessibility methods to find the appropriate focused element. Bug: 900846 Change-Id: I09df0bfddd82b7904131b195ece55dc803c56aa9 Reviewed-on: https://chromium-review.googlesource.com/c/1337377 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#608690}
-
Oleh Prypin authored
This seems to be the only way to pass this property to runtest.py if we're not on Buildbot: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/api.py?rcl=0547a2d019f638868abffa0bd525d9e0ea9631d1&l=709 https://cs.chromium.org/chromium/build/scripts/slave/runtest.py?l=367&rcl=ccdd71cae2e6bce819a6d8f8b1dcaa27a9e31141 TBR: jbudorick@chromium.org Bug: 877018 Change-Id: Icadb0abfd036a90735a6b194a0de1958e49107f3 Reviewed-on: https://chromium-review.googlesource.com/c/1338185 Commit-Queue: Oleh Prypin <oprypin@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#608689}
-
Keiichi Watanabe authored
Load vivid before running capture_unittests on chromeos-amd64-generic-rel. This makes it possible to run test cases that require a webcam. Bug: 852302, 904730 Change-Id: I5d4f5a1dd7a8ea27ef7eabd438fd766621573096 Signed-off-by:
Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1282424Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#608688}
-
Christopher Lam authored
This CL moves the non-extensions-specific concepts of External Web Apps, System Web Apps and Policy Web Apps into the generic web_applications/ level, rather than being in web_applications/bookmark_apps/ which was extensions specific. The tests remain in bookmark_apps/ because they have some dependencies on extensions e.g installing and explicitly checking the existence of an app through the extensions system. Tests without extensions dependencies will be moved in a follow-up patch. Bug: None Change-Id: I9d9bca55e73a46ef5ad2781f6eca29416059d6b6 Reviewed-on: https://chromium-review.googlesource.com/c/1333012Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#608687}
-
Reilly Grant authored
This change adds support for tracking device name changes in the WinRT Bluetooth Low Energy backend. This is done in two ways: * When advertisement packets are received for a known device the "local name" is updated if previous advertisements did not provide one. * BluetoothDeviceWinrt subscribes to the NameChanged event on the IBluetoothLEDevice. This tracks name changes once a connection is established. Bug: 902241 Change-Id: I489fc1b7fb86da3c28fde1ec4459d0c736f27326 Reviewed-on: https://chromium-review.googlesource.com/c/1328222Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608686}
-
Risan authored
source_path like drivefs:// should be ignored in Chrome instead of being published to Android. BUG=b:119122689 TEST=Manual. See that drivefs mount doesn't flown through ARC++ container. Change-Id: I0ff1c8af00ad83c7c968f6d9616353942290dc5d Reviewed-on: https://chromium-review.googlesource.com/c/1333268Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608685}
-
Antonio Gomes authored
This CL is a follow up of [1], where production code was migrated away from using SigninManager APIs directly, in favor of IdentityManager (//services/identity). This is done as part of the servicification effort. After this CL, the last remaining step will be converting DiceResponseHandler (production code) away from using ProfileOAuth2TokenService directly, blocked of crbug.com/887870. [1] https://crrev.com/c/1318550 BUG=890790 Change-Id: Ifc54410bd7112c1e2fae01d6770ab6afa002481d Reviewed-on: https://chromium-review.googlesource.com/c/1316927 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#608684}
-
David Staessens authored
When decoding a jpeg the generated surface is reused when the video frame size doesn't change. When encoding a jpeg a new surface is created every time. This change enables reusing of surfaces for jpeg encoding. This also fixes a bug that causes the jpeg_encode_accelerator_unittest to always fail in debug, because surfaces are not properly destroyed before creating new ones. TEST=JPEG encode tests on nocturne BUG=905502 Change-Id: I9a6b0b5703813e518a3e82687b289e94745e1c62 Reviewed-on: https://chromium-review.googlesource.com/c/1337130 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608683}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d9ee8bf96207..c30f45d3f9c1 git log d9ee8bf96207..c30f45d3f9c1 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 syoussefi@chromium.org Vulkan: Rename PipelineDesc/Cache to Graphics& Created with: gclient setdep -r src/third_party/angle@c30f45d3f9c1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I3d8a04fb2eecc0d8f36cad29ea67017474d34d83 Reviewed-on: https://chromium-review.googlesource.com/c/1339321Reviewed-by:
-
Mike Frysinger authored
Unlike the other grit tools, these three weren't really checking the command line options that closely. Formalize it a bit so we reject all unknown options and too few/many arguments. Change-Id: Ifdd58be1b723ca8b09d5add0c3dcde7243a07ecc Reviewed-on: https://chromium-review.googlesource.com/c/1338469 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
|fileManagerPrivateNatives.GetEntryURL| fails if it receives a non-native entry, such as VolumeEntry. Previously I've worked around this by unwrapping VolumeEntry on |changeDirectoryEntry| however MyFiles changes is expanding the use of FilesAppEntry types, so this CL refactors the unwrapping to be performed on our custom bindings. Refactor |VolumeEntry.rootEntry| to be more generic to any FilesAppEntry renamed to |getNativeEntry| and added as part of FilesAppEntry interface. Add methods |getDirectory| and |getFile| to VolumeEntry, because after renaming this method is also called and was raising an error. Add a utility that unwraps an entry if necessary. The test below fails without unwrapping the entry before sending to fileManagerPrivate. MyFiles/FilesAppBrowserTest.Test/myFilesFolderRename: *FileManagerJsTest.FilesAppEntryTypes' Test: gtest_filter=' Bug: 873539 Change-Id: I0673ed7a8aaeefcec84ed2fc09fe3555c453ef4d Reviewed-on: https://chromium-review.googlesource.com/c/1338820 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#608680}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f1482716167..d6eacbfadd07 git log 1f1482716167..d6eacbfadd07 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 saklein@chromium.org archive_hwqual: move to crostestutils Created with: gclient setdep -r src/third_party/chromite@d6eacbfadd07 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1745cb0ecaf5cfffb2d84c187c5db44e400e8b11 Reviewed-on: https://chromium-review.googlesource.com/c/1338871Reviewed-by:
-
Hayato Ito authored
This is a quick fix for tools/gdb/gdbinit so it can be used in Python 3 environment too. I don't think we need to support Python 3 in chromium development environment, however, this is a very small fix so it could be okay. The issue what this CL fixes is: If user's `gdb` embeds Python 3, instead of Python 2, tools/gdb/gdbinit fails as follows: Traceback (most recent call last): File "<string>", line 61, in newobj_handler File "<string>", line 35, in load_libcxx_pretty_printers File "/usr/lib/python3.5/posixpath.py", line 89, in join genericpath._check_arg_types('join', a, *p) File "/usr/lib/python3.5/genericpath.py", line 145, in _check_arg_types raise TypeError("Can't mix strings and bytes in path components") from None TypeError: Can't mix strings and bytes in path components The reason of the failure is that stdout of subprocess is |byte|, instead of |string|, and Python 3 doesn't allow mixing strings and bytes in the following |os.path.join|. We have to convert |byte| to |str| explicitly in Python 3, which is harmless in Python 2. Change-Id: I5e66be86b61f8e715dc0c2165eb7c427b56d648b Reviewed-on: https://chromium-review.googlesource.com/c/1338593Reviewed-by: -
Makoto Shimazu authored
Previously these tests finish before the worker is started, and TearDownOnMainThread could be called during loading the script. After this CL, each tests waits until the worker is ready to ensure that no task is running on TearDownOnMainThread. Bug: 872742 Change-Id: I5fc33048f852f6c7088f5a971a4a7d4a4ffa410b Reviewed-on: https://chromium-review.googlesource.com/c/1337146Reviewed-by:
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=dominickn@chromium.org Bug: 903957 Change-Id: Ib6f8a8c38d1de1673f2a465478c8f3aebb920a8a Reviewed-on: https://chromium-review.googlesource.com/c/1338491Reviewed-by: -
Shawn Gallea authored
Move zcr_remote_shell interface out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I4ed019e376e5c374315c6bd5c0dab330588376f5 Reviewed-on: https://chromium-review.googlesource.com/c/1324092 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608675}
-
Fergus Dall authored
This should have been done during https://chromium-review.googlesource.com/c/chromium/src/+/1331094, but better late then never. Bug: 703927 Change-Id: I851619d196968b3697ec56c97b3e24fcb15fb58e Reviewed-on: https://chromium-review.googlesource.com/c/1338819Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#608674}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e195c5ac007..e0abe42b5a5e Created with: gclient setdep -r src-internal@e0abe42b5a5e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I28b56057d55ad4f88350b39084bef3df0e94b954 Reviewed-on: https://chromium-review.googlesource.com/c/1339320Reviewed-by:
-
