GitLab

This is a temporary CL to try to locate the reason why some Android
installs are collecting a large number of metrics files without
uploading them.

Bug: 760317
Change-Id: I174f502d2a3a9b59c95d62e85565da81c688d7ec
Reviewed-on: https://chromium-review.googlesource.com/682836Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504241}

Add select to speak and switch access to services that enable all ARc++ apps for native accessibility.

Test: enable Select to Speak. Run with any app and verify it works.


Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3b19ed8c28f252254def2462679103c559a93696
Reviewed-on: https://chromium-review.googlesource.com/675837Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504240}

The underlying issue has been fixed.

Bug: 762745
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9899e66b3ed149aeec086ee0ce41ad4f07f1cadc
Reviewed-on: https://chromium-review.googlesource.com/683244Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504239}

This reverts commit d94db169.

Reason for revert: Seeing lots of layout failures. Suspecting this CL.
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak

Original change's description:
> Media Controls: Replace painter with CSS.
> 
> Replace MediaControlPainter with CSS. Add some classes to some
> elements to allow styling by state. This is a resubmit of the
> button code only from crrev.com/c/584771.
> 
> BUG=746872
> 
> TBR=pfeldman@chromium.org
> 
> Change-Id: If79ce339a10f6671ddd02a223468bb3d7bbcd1df
> Reviewed-on: https://chromium-review.googlesource.com/657024
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504095}

TBR=mlamouri@chromium.org,pfeldman@chromium.org,beccahughes@chromium.org

Change-Id: I698bec05d24045896e664e287415cba5f19d9f60
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 746872
Reviewed-on: https://chromium-review.googlesource.com/683434Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504238}

Implemented ClearStorageTask, which is responsible for clearing expired
temporary pages from metadata store, and their associated archive files.
This is replacing the functionality of the OfflinePageStorageManager.

Bug: 753595
Change-Id: I037923a1293950998446e9992e247155063d0b5a
Reviewed-on: https://chromium-review.googlesource.com/674057
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504237}

The requests do file system access, which shouldn't run on the thread
Catalog runs on (IO thread).

BUG=763529
TEST=none

Change-Id: Ie5324370fde6ed8ad8206de40190b4a1c3bf5676
Reviewed-on: https://chromium-review.googlesource.com/682648
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504236}

At some point, some of the tests under fast/canvas were re-written to
use testharness.js. However, some of the tests are not correctly written.
For example, assert_throws(null, ...) will generate an -expected.txt
file saying: Test bug: need to pass exception to assert_throws()

This CL corrects those test by checking the right exception type in
the assert_throws. This change will get rid of those expected.txt files.

Bug: 725651
Change-Id: If72032e4f89fd2ae9432900456cb610abe7664b9
Reviewed-on: https://chromium-review.googlesource.com/677648Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504235}

Change-Id: I559c15c3c19b6d72032b4949c9a5489ad4065bbd
Reviewed-on: https://chromium-review.googlesource.com/682766
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Charlie Reis (catching up) <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504234}

BUG=768020
R=thestig@chromium.org

Change-Id: I8ec5c4b4b4be5910f3571d7770e910f5e74ae0f4
Reviewed-on: https://chromium-review.googlesource.com/683155
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504233}

The Request class in deterministic_dispatcher.h was made moveable to support
its inclusion in a circular_deque. There was some minor cleanup of this
class.

Typedefs around changed code were converted to using statements.

Some unnecessary <deque> includes were removed. An unnecessary <list>
include is removed from remoting/protocol/message_decoder.h, and a
<list> include was addedto remoting/protocol/message_decoder_unittest.cc
which was depending on this.

TBR=stevenjb (chromeos/network owners)

Bug: 757232
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I654daa3f575b21fbfd6db225d0c321bc5781f96f
Reviewed-on: https://chromium-review.googlesource.com/676201
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504232}

This also includes some layout fixes.

Bug: 380937
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9cffb4e7e1f1a736ea2a65a74c1be5923245b4c4
Reviewed-on: https://chromium-review.googlesource.com/677486
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504231}

This CL makes it so that hiding or showing the URL bar continually fires
visualViewport resize events. Previously, the resize event would be
fired only once the user lifts their finger.

Bug: 762518
Change-Id: I09470b980d09b16d5cd7b60e98e7ec3653fdaa40
Reviewed-on: https://chromium-review.googlesource.com/666600
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504230}

It now saves them in its own pref file, rather than using a shared one.
Since these aren't meant to be directly modified by the embedder, but
rather just used as a key-value store, there's minimal benefit from
sharing a pref store with Chrome. This approach is a little simpler,
and also lets us flush to it on clean shutdown (not currently
implemented).

Also moves ClearNetworkingHistorySince over to NetworkContext, as it
relies on the HttpServerPropertiesManager API (rather than just the
HttpServerPropertiesAPI).

Bug: 715695
Change-Id: Icca19030ac95d9c9d5bc7b78b24357458ec50adc
Reviewed-on: https://chromium-review.googlesource.com/679396
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504229}

Bug: 649000
Change-Id: Iad772c39ccd86c9bcc8bf9c9f87b2f1ef12bde57
Reviewed-on: https://chromium-review.googlesource.com/682757
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504228}

Bug: 646711
Change-Id: I407f425a8acb2eb55108403b83c93000e9edceea
Reviewed-on: https://chromium-review.googlesource.com/679598Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504227}

* Place app list widget in the ash app list window container, instead of
  in the container for browser windows.
* Perform widget bounds computations in local coordinates. This avoids
  problems with screen-to-local computations under mash where the native
  window's parent is the desktop widget, not the window container as in
  classic ash.
* Use side shelf mode in mash, which skips some problematic opening
  animations. See issue 768437.
* Introduce AppListView::InitParams so we don't have 2 ints and 2 bools
  as adjacent parameters.
* Eliminate some unused Init() method params.

Bug: 763961, 768437
Test: app_list_unittests, manual testing of fullscreen app list with multiple monitors (stacked vertically) and/or side shelf mode.

Change-Id: I933f5130feab3d8b4edfc2b573f52748e9c82539
Reviewed-on: https://chromium-review.googlesource.com/682343
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504226}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/89e89852..67e0f781

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ia2716ee85143b58f0d3d30914fce7fcca8c74ec7
Reviewed-on: https://chromium-review.googlesource.com/682935Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504225}

ukm.old.xml is generated after running 'git cl format'. This CL adds .gitignore
file to ignore this file, so that it will not be accidentally checked in.

Change-Id: I19f9d0e4150b051da6a349ccbf80e388c9fcf992
Reviewed-on: https://chromium-review.googlesource.com/680794Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504224}

Bug: 649000
Change-Id: Iafa20e38efb6a83082c186d56902589ca310cb10
Reviewed-on: https://chromium-review.googlesource.com/680002
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504223}

Fixes the diff phase appending an argument to the base phase's args
list.

Bug: 759087
Change-Id: I951b5ae961604caf3ce8510a993b6363488d8e7f
Reviewed-on: https://chromium-review.googlesource.com/682994Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504222}

This proto will be removed in a followup (requires a server change first).

Bug: 739505
Change-Id: I979ff8037b81e983c18f5abe1b964fba4dbb4753
Reviewed-on: https://chromium-review.googlesource.com/683243Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504221}

This CL prepares the DevTools frontend to specially format objects with
these internal properties:
- [[PrimitiveValue]] > shows this value in preview alone
- [[PromiseStatus]] + [[PromiseValue]] > shows '<resolved>: "foo"'
- [[GeneratorStatus]] > shows '<suspended>'

Screenshot: http://imgur.com/a/r3rXE

Bug: 567265
Change-Id: Ic14f361e6c2402340a4f3d30bcf255ed362663c6
Reviewed-on: https://chromium-review.googlesource.com/604938
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504220}

I'm removing all use of NetLog except through URLRequestContext, as part
of servicification. Eventually URLRequestContexts, will be out of
process, too, but that's quite a ways off.

Bug: 767450
Change-Id: If905f1cf7f5737ecb55f5b1ac9433ed4f14a85c8
Reviewed-on: https://chromium-review.googlesource.com/677232Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504219}

https://skia.googlesource.com/skia.git/+log/f40ae1a4b536..712fe73cafb8

$ git log f40ae1a4b..712fe73ca --date=short --no-merges --format='%ad %ae %s'
2017-09-25 jvanverth Add animated cowboy sample from WebKit tests, and fix.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I9424d18497cbd74d5c14963bbf7082aa7b976b32
Reviewed-on: https://chromium-review.googlesource.com/683223Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504218}

DevTools: Move devtools-node-modules checkout from //third_party/WebKit/Source/devtools/ to //third_party/

Checkout inside WebKit/Source is troublesome on the Great Blink mv.

Bug: 768274
Change-Id: Ia57f3df4fad83dae56dd7d4cd9bef1841dae1a8c
Reviewed-on: https://chromium-review.googlesource.com/680180Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504217}

R=amineer@chromium.org

TBR=amineer@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3c6363adc957bd3df15d011c59138d05130c0d23
Reviewed-on: https://chromium-review.googlesource.com/683222Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504216}

If we have Arabic text in one line and English text in the second line
and select both lines then both touch handles will be right handles
(for RTL reasons). A previous CL (crrev.com/c/658599) assumed that
each handle had to have a different direction. This CL removes that
assumption.

Bug: 766466
Change-Id: Icdb725cc2cf21f593e90d5d90acbd2a489dbca1d
Reviewed-on: https://chromium-review.googlesource.com/678036Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504215}

There is a Bluetooth issue which can result in a
BluetoothDiscoverySession returning IsActive() == false without a Stop()
call ever completing successfully. If this occurs, it is possible to
repro a stack overflow resulting in a crash.

This patch works around that issue to
ensure that it is not possible to get stuck out of sync.

Bug: 768521, 672263
Change-Id: I7574241db2be21f63aef371f567cf1d88aed0537
Reviewed-on: https://chromium-review.googlesource.com/683034
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504214}

Use device::mojom::HidDeviceInfo instead, make the device::HidDeviceInfo
internal of the //device/hid. So we can move the //device/hid into
//services in next step.

BUG=728223

Change-Id: I5d5cbd365f1debc7a963d54b9ccffc41fddda54a
Reviewed-on: https://chromium-review.googlesource.com/676946Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#504213}

This should be glProduceTextureCHROMIUM.
BUG=None

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1961ced54de08b00f0b68ecfb560681568ee3436
Reviewed-on: https://chromium-review.googlesource.com/677024
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504212}

ServiceWorkerScriptURLLoader should check the HTTP response code of fetched
scripts and abort the subsequent sequence if it's not 2XX. This CL adds the
check and a unit test.

This also adds MockHTTPServer that is a handy utility to provide mocked
responses for ServiceWorkerScriptURLLoader and adds a test case for an empty
response body.

Bug: 748415
Change-Id: I3512d20650809ffca593197c200ce8dc871d435d
Reviewed-on: https://chromium-review.googlesource.com/672224
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504211}

These 3 methods in each of SBRByPts and SBRByDts are not used by
anything, and are deleted by this change. I found these during
refactoring SBRByPts for PTS/DTS compliance, and split their deletion
into this CL to make compliance CL(s) smaller.

BUG=718641

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a50a6e618e6d3bcc2a799bec398ebe752dba690
Reviewed-on: https://chromium-review.googlesource.com/683154Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504210}

This patch changes the horizontal textfield insets in Harmony to be 8pt,
and changes the height to be 28pt by default. The height pre-Harmony
is changed by 2pt because its preferred height was taking into account
the border height as well, which is now fixed.

Bug: 764019
Change-Id: Icce4cc6a0a0038ccb23077299475aca1415ff9b6
Reviewed-on: https://chromium-review.googlesource.com/676474
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504209}

https://crrev.com/c/634847 started migration of view size storage
to ViewAndroid but it is not in effect yet, therefore the previous
size adjustment mechanism should be preserved. This CL restores
the resize flow accidentally removed and caused the reported regression.

Bug: 767658
Change-Id: I63b19043d404280b336663c46c17a646fcb7074e
Reviewed-on: https://chromium-review.googlesource.com/680156Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504208}

The crash occurs in AppsGridView::GetHeightOnTopOfAllAppsTiles. After
clicking the app icon, app list is dismissed. |folder_delegate_| becomes
nullptr, AppsGridView::GetHeightOnTopOfAllAppsTiles use
|suggestions_container_| without checking whether it is nullptr.

Changes:
Check nullptr for all usage of |suggestions_container_|,
|expand_arrow_view_| and |all_apps_indicator_| which are possibily
nullptr.

BUG=768287

Change-Id: I73832fdf0da95d431fb0c628bf0c8ba45c3b3a0a
Reviewed-on: https://chromium-review.googlesource.com/683227Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504207}

This adds a learn more link to the TPM firmware update option on the device
reset aka powerwash OOBE screen.

BUG=chromium:767900
TEST=Manual

Change-Id: Iaaeb7c63f877b0b0d6e8e5fb3073a04eec3bd3e8
Reviewed-on: https://chromium-review.googlesource.com/682694Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504206}

Changes:
Remove javascript/html code of Google Now, corresponding handlers, test
and strings.

BUG=731991,459827

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I834d707eb3dee799e63348a3e717023b116a434d
Reviewed-on: https://chromium-review.googlesource.com/679739Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504205}

Bug: 758467
Change-Id: I29102a65235a027da03abdec8b9e1d3e98b81115
Reviewed-on: https://chromium-review.googlesource.com/682554Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504204}

https://pdfium.googlesource.com/pdfium.git/+log/92627618a937..ba14c0a5f12b

$ git log 92627618a..ba14c0a5f --date=short --no-merges --format='%ad %ae %s'
2017-09-22 thestig Update comments regarding dictionary keys in public APIS.
2017-09-25 dsinclair Hide CFX_UniqueKeyGen

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I71ad62bc4a9e01ede71eeec5514979d35e9ffa81
Reviewed-on: https://chromium-review.googlesource.com/682998
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504203}

AppListControllerSearchResultsBrowserTest.UninstallSearchResult is
broken by the Answer Card feature randomly. It happens when the
AnswerCardSearchProvider object is GCed before DidFinishNavigation
is called. Then the navigation context becomes nullptr and will
break the equal check with the content source.

This commit skips those late DidFinishNavigation calls by unsetting
the delegates when AnswerCardWebContents objects get recycled.

Crash logs:
[ RUN      ] AppListControllerSearchResultsBrowserTest.UninstallSearchResult
[10573:10573:0922/200830.460519:FATAL:answer_card_search_provider.cc(131)] Check failed: source == context_for_loading.contents.get() (0x15fd7b449f30 vs. (nil))
#0 0x00000387062c base::debug::StackTrace::StackTrace()
#1 0x00000388999c logging::LogMessage::~LogMessage()
#2 0x0000067d8611 app_list::AnswerCardSearchProvider::DidFinishNavigation()
#3 0x0000067d9a85 app_list::AnswerCardWebContents::DidFinishNavigation()
#4 0x00000267cb07 content::WebContentsImpl::DidFinishNavigation()
#5 0x000002375fb9 content::NavigationHandleImpl::~NavigationHandleImpl()
#6 0x00000237663e content::NavigationHandleImpl::~NavigationHandleImpl()
#7 0x00000266ad3c content::WebContentsImpl::~WebContentsImpl()
#8 0x00000266bade content::WebContentsImpl::~WebContentsImpl()
#9 0x0000067d91e3 app_list::AnswerCardWebContents::~AnswerCardWebContents()
#10 0x0000067d7ecd app_list::AnswerCardSearchProvider::~AnswerCardSearchProvider()
#11 0x0000067d7f2e app_list::AnswerCardSearchProvider::~AnswerCardSearchProvider()
#12 0x000008b3e28b app_list::SearchController::~SearchController()
...

Bug: 766784
Change-Id: Iaa5da44696c567815626d24d8bad5436cb971f27
Reviewed-on: https://chromium-review.googlesource.com/682756Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#504202}