- 01 Apr, 2020 40 commits
-
-
David Van Cleve authored
The experimental Trust Token API (https://github.com/wicg/trust-token-api) takes in parameters specifying a Trust Tokens protocol operation, annotates outgoing requests with request headers corresponding to protocol state, and processes corresponding response headers. For the MVP of the API, we're making the functionality available via Fetch, iframe, and XHR. To implement the iframe surface, this CL adds a new iframe attribute, "trusttoken," that accepts as input a syntactically identical struct to the corresponding Fetch parameter This CL passes Trust Tokens parameters parsed from the attribute's value to the network service via the navigation stack. Test: Add integration tests to ensure the parameters propagate. Bug: 1062396 Change-Id: I1144e5b5699a90c88219e4490b62da072ea55b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079309Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#755224}
-
Danan S authored
Bug: 1066183 Change-Id: I6d72cd59f93691e0ce38f6681aa46fda4b21a97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128570Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755223}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1668abdd..0169ff39 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id3cbbe32095e7af7c5815ca6330f6bed759d1842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130713Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755222}
-
tby authored
This header appears never to have been listed in chrome/test/BUILD.gn, and deleting some files that referenced it caused compile failures. Let's add it to the build file in case this causes further issues. Bug: 1065406 Change-Id: If550192a6f8601560f176b23dc8832d843cab2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124341 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755221}
-
Alexandre Courbot authored
This reverts commit 1343d831. Reason for revert: video_decode_accelerator_tests fails on Hana. Original change's description: > media/gpu/V4L2IP: Reconfigure V4L2 queues on the first Process() > > The client of ImageProcessor feeds ImageProcessor VideoFrame in > import mode. The underlying buffer of the fed VideoFrame can have > a different stride and size from the expectation of > ImageProcessor. The difference is critical in V4L2ImageProcessor. > It is necessary to reconfigure the v4l2 image processor driver by > VIDIOC_S_FMT with the stride and height of the fed VideoFrame. > > Bug: 1033799 > Test: ip_test --gtest_filter=NV12* on kukui > Change-Id: I73050718f6a95a1eaa3d9c7a60eeea1bc791f04e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097857 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754835} TBR=hiroh@chromium.org,acourbot@chromium.org Change-Id: I9d4232292efd26cfe9f07a5157bdf767f2c0a33c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131546Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#755220}
-
Kevin Marshall authored
* Implements the FIDL ConfigureInputTypes() API, for embedder control over whether input events should be routed to web content or ignored. * Transitions CastRunner to use ConfigureInputTypes(). * Removes the deprecated SetInputEnabled() method. Bug: 1031776 Change-Id: I54e0b5c3b5a92935e6860e037edc6bc5a92eaa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956154 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755219}
-
Trevor Perrier authored
This CL adds empty xtb files for sr-Latn and adds sr-Latn to the translation_expectations.pyl file. On the next TC import the Latin script for Serbian should be imported into all xtb files. Bug: 1053811 Change-Id: I271e2e8ae042f085d962eb62ae3d4ad03ecf9190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121076Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#755218}
-
Rakib M. Hasan authored
This CL will also move the addition of these command line arguments into the browser specific WPTAdapter subclass. Bug: 1050754 Change-Id: I658ae5741229ad5a6eae740ab73008c99eae8d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119761 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#755217}
-
Karandeep Bhatia authored
Remove reference to IO thread in URLRequestMonitor and RulesetCountWaiter. RulesetManager now lives on the UI thread, hence a lock shouldn't be necessary. Use a SequenceChecker to assert the same. Also delete ScopedRulesetManagerTestObserver. BUG=754526 Change-Id: I540207ee0eeeab73dc6b9b9e98e42e050fe920e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128927Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#755216}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I44a0620cbeb24554e89c5bb9307deda3974244b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755215}
-
Daniel Hosseinian authored
Meanwhile, do some cleanup (like alphabetical ordering of platform specific build instructions) to make printing/BUILD.gn easier to read. Also, move EMF test data into its own directory to make platform specific splitting easier. Bug: 1018739 Change-Id: I8bd18fe31b5b5ca97d6de4a4f53563156f494f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130783Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#755214}
-
Kevin Marshall authored
Ensures that the view stays black until webpage style data is loaded and parsed, by setting up a black background layer and making content output surfaces initially transparent. Some IWYU fixes. Bug: 1051241 Change-Id: I22552863c1ae7cb2b7df280a4936a65445614215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123307 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755213}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/beec66070ea7..43d002a2caf2 git log beec66070ea7..43d002a2caf2 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 ehmaldonado@chromium.org Revert "git-cl: Execute clang-format-diff.py using vpython." 2020-03-31 ehmaldonado@google.com depot_tools: Don't use carets when checking if a revision exists. Created with: gclient setdep -r src/third_party/depot_tools@43d002a2caf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065307,chromium:1066187 Tbr: agable@chromium.org Change-Id: Ic8e404e43e00978aa51c7f55176caa56f8459613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131389Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755212}
-
Julian Watson authored
Bug: 1049453 Change-Id: I29218026e149fd382224b4cb12b507e16b7dd003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094581 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#755211}
-
Gyuyoung Kim authored
This CL moves flex-shorthand-flex-basis-middle.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Bug: 1063749 Change-Id: I3985eeb6fa7add1b8e530e7cf83efce9e0f4fa51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123582 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#755210}
-
Orin Jaworski authored
This CL restores two other previously reverted commits, with a fix: * 30750caa [omnibox] Refactor ViewViews to not directly set PopupModel state * 80f05db7 [omnibox] Add unit test for popup model StepSelection The fix resolves the unit test that was failing around keyword mode. Instead of having the view manage both popup_model and edit_model with complex logic, all the model changes are moved into StepSelection. Change-Id: Ia1ff449d780e5beddf4208b8bc1c58f98c1dc7fe Bug: 1046523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131021Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#755209}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4b425aeef9cd..65674d83e1f5 git log 4b425aeef9cd..65674d83e1f5 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 marinaciocea@webrtc.org Transform encoded frames in ChannelSend. 2020-03-31 deadbeef@webrtc.org Expose enableDscp in Obj-C API. 2020-03-31 deadbeef@webrtc.org Regression test for SCTP transport. 2020-03-31 sprang@webrtc.org Fixes TaskQueuePacedSender padding while only sending non-paced audio. 2020-03-31 guidou@webrtc.org [InsertableStreams] Set video frame transformer if RTP stream already started. Created with: gclient setdep -r src/third_party/webrtc@65674d83e1f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065836 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3c2c5b4fa61e223462f58b5e1d9f90001a5f4d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755208}
-
rajendrant authored
Fixed: 1037039 Change-Id: Ib8deb39d9b1d0206e4dc3b5acabed8797d456b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130967 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#755207}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7800453ed2e5..7a3358c80b6e git log 7800453ed2e5..7a3358c80b6e --date=short --first-parent --format='%ad %ae %s' 2020-03-31 brianosman@google.com Really fix SkVerticesPriv on MSVC 2017 Created with: gclient setdep -r src/third_party/skia@7a3358c80b6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I21c92b1ab7edae64c18eb977c821ee61cb720280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755206}
-
Clark DuVall authored
This allows embedders to listen for cookie changes on a URL. Bug: 1054160 Change-Id: I030a4b2f2f05863763a7f352d6ffd376af0b4f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124094Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#755205}
-
chrome://flagsAhmed Mehfooz authored
Bug: 1065079 Change-Id: I22dfe74700313bf3d5b1755a8fbcdcdebdbec8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130969Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#755204}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/06f4f3e13c49..4b94d7bb4fbe git log 06f4f3e13c49..4b94d7bb4fbe --date=short --first-parent --format='%ad %ae %s' 2020-03-31 jonahr@google.com Split EGL_CHROMIUM_sync_control into EGL_ANGLE_sync_control_rate 2020-03-31 kbr@chromium.org Apply limitMaxMSAASamplesTo4 workaround to macOS. Created with: gclient setdep -r src/third_party/angle@4b94d7bb4fbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064078 Tbr: cwallez@google.com Change-Id: I7a8964875bea0a7976be111a203ea3718427b029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755203}
-
Jinsuk Kim authored
void (Ar|Vr)ContentDialog.show(ChromeActivity -> WindowAndroid) The classes were passed ChromeActivity to get ModalDialogManager. This can be obtained from WindowAndroid too. Replaces TabImpl.getActivity with (ChromeActivity) TabUtils.getActivity. in ArCoreJavaUtils. Its native uses renderer process/frame id to find WebContents, Tab, and then ChromeActivity. Ended up casting the activity for now. Bug: 952703 Change-Id: Ic219cb01e896e8e322a8804be0b78ef497ba078d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129366Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#755202}
-
rbpotter authored
Bug: 1064664 Change-Id: I9d3136de342504081a2feba77068da2bc14a8f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130891Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#755201}
-
Daniel Rubery authored
"Proection" should be "Protection" Change-Id: Ic4017eb37663bd7b9789f41f8ca79e9f0cb91720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131042 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#755200}
-
Jon Mann authored
This also updates existing logs to go to the same buffer and removes PII. Bug: 966270 Change-Id: Ib0469c7d0e625fde1e556f82a9d2b296752057ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128026 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#755199}
-
Eric Foo authored
Bug: 1034648 Change-Id: Ib846a51312469cfe2b8ab0fdd0c005f504aa4680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129243 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#755198}
-
Kyle Horimoto authored
(1) Change internal implementation to be synchronous, now that LocalSearchService exposes a synchronous API. (2) Add a synchronous public API for SearchHandler in anticipation for use by in-process clients (e.g., upcoming Launcher usage). Bug: 1063505, 1059099 Change-Id: If1110a4f43158ca17b387d766dac58cc87ba08f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130681 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#755197}
-
Jeremy Apthorp authored
This allows passing arguments with move-only semantics. Change-Id: I852eb343398e6f763abfe2a44e623f28353d79a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129029 Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#755196}
-
Adam Langley authored
Saves a little code. Change-Id: I823f31d998e7ae6d8b0c22e42773df74b847bff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131044 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#755195}
-
Hwanseung Lee authored
Use enum class instead of enum for views::SliderChangeReason. enum class is more type safety. Bug: 940736 Change-Id: I396a74e79cdf6da52163d875fcceffa20920968f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128033Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#755194}
-
edchin authored
This reverts commit 194955c6. Reason for revert: Mistakenly relanded last CL without change. Original change's description: > Reland "[ios] Remove dead code in first_run_util" > > This reverts commit 4edeedc6. > > Reason for revert: > > Will fix the error in this reland. > welcome_to_chrome_view_controller.mm should not have been edited. > > Original change's description: > > Revert "[ios] Remove dead code in first_run_util" > > > > This reverts commit 721f0aa1. > > > > Reason for revert: > > suspect this is breaking compilation on ios-simulator > > > > Original change's description: > > > [ios] Remove dead code in first_run_util > > > > > > Removed dead codepaths and marked unused histograms obsolete. > > > > > > Change-Id: Ie4f5485ebd9c915dcb36c8ac7d14d2d688b200e7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129507 > > > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > > > Reviewed-by: Ilya Sherman <isherman@chromium.org> > > > Commit-Queue: edchin <edchin@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#755163} > > > > TBR=isherman@chromium.org,kkhorimoto@chromium.org,mrefaat@chromium.org,edchin@chromium.org > > > > Change-Id: I1d3d94ce35b28df80626a1838b3c110957b8757d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131354 > > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755166} > > TBR=isherman@chromium.org,kkhorimoto@chromium.org,mrefaat@chromium.org,edchin@chromium.org,rbpotter@chromium.org > > Change-Id: Ia325e65092b1d7b4cc66e6f2be7d52e93e50f39f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131357 > Reviewed-by: edchin <edchin@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755191} TBR=isherman@chromium.org,kkhorimoto@chromium.org,mrefaat@chromium.org,edchin@chromium.org,rbpotter@chromium.org Change-Id: Ide9f88a5222c1a44cff70af1c4518b4904ecc703 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131149Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755193}
-
Tal Pressman authored
Change-Id: Ib0995aa8c7c5714edaf400d0f46188cd3be1e536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129406Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#755192}
-
edchin authored
This reverts commit 4edeedc6. Reason for revert: Will fix the error in this reland. welcome_to_chrome_view_controller.mm should not have been edited. Original change's description: > Revert "[ios] Remove dead code in first_run_util" > > This reverts commit 721f0aa1. > > Reason for revert: > suspect this is breaking compilation on ios-simulator > > Original change's description: > > [ios] Remove dead code in first_run_util > > > > Removed dead codepaths and marked unused histograms obsolete. > > > > Change-Id: Ie4f5485ebd9c915dcb36c8ac7d14d2d688b200e7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129507 > > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > > Reviewed-by: Ilya Sherman <isherman@chromium.org> > > Commit-Queue: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755163} > > TBR=isherman@chromium.org,kkhorimoto@chromium.org,mrefaat@chromium.org,edchin@chromium.org > > Change-Id: I1d3d94ce35b28df80626a1838b3c110957b8757d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131354 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755166} TBR=isherman@chromium.org,kkhorimoto@chromium.org,mrefaat@chromium.org,edchin@chromium.org,rbpotter@chromium.org Change-Id: Ia325e65092b1d7b4cc66e6f2be7d52e93e50f39f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131357Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755191}
-
Mei Liang authored
Change-Id: I7e7ccdadc486458764190c5f8f3fb7becb766c39 Bug: 1005929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112174 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755190}
-
Sam Bowen authored
Generate code for types inheriting from Enumeration and use this code in the extractor and the validator. The extractor will accept any strings that start with "http[s]://schema.org", while the validator will ensure the strings match one of the enum options for one of the enum types in the property config. Previously these were treated as a nested entity type, but we will only ever find enum as string values. Bug: 1065511 Change-Id: I53b7d3cf290c94f44ede7776eb2cb287c21e513c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128527 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#755189}
-
Lei Zhang authored
It lives in docs/, not build/. Change-Id: If616e3f51a838b1f5e19d2f64e11187785174c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131023Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#755188}
-
Daniel Cheng authored
Code should just use the //base abstractions directly. Update the API to just expose a way to install the Mojo hooks. Fixed: 876525 Change-Id: Ic90adb8eae9ee065977e81c7ec7ccf330a12c93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102635 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#755187}
-
David Van Cleve authored
This is one of a series of CLs updating Trust Tokens key commitment state to use a singleton in-memory store owned by NetworkContext and updated via Mojo from the component updater. This involves 1. Remove key commitment-related state from the on-disk trust token store 2. Mojoify TrustTokenKeyCommitmentResult and remove commitment fetching and parsing code [3, this CL] Add a centralized issuers-to-commitments store in the network service: - Define the new store class (TrustTokenKeyCommitments) and make it accessible via a NetworkService accessor method - Expand NetworkService's Mojo interface to include a setter 4. Add component updater logic to populate this store. Bug: 1063510 Change-Id: I69bda37a0373281c420919630b29f4aa3e127f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117295Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#755186}
-
Erik Jensen authored
Specifically, document that an empty list is handled similarly to the policy not being set. Bug: 807264 Change-Id: Ibfd80e91c86ffe341a9a9b753fe2ba58d962e43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783730Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#755185}
-