- 16 Oct, 2019 40 commits
-
-
Paul Lewis authored
If a user right clicks on an element in the console and chooses to reveal it in the elements panel, and the element is not in the document, the operation fails but it is not communicated to the user. This patch adds a warning if the node appears to be detached from the document; it is done through checking the parentNode property, which is the most suitable means in lieu of having the isConnected property available in the Node object. Bug: 967156 Change-Id: I58228facb54e9afc87215d68176f473121121db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681891 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#706474}
-
Thomas Tangl authored
Bug: 995720 Change-Id: Ib8863788082efb13f38831813e86dff5289d810b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865247 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#706473}
-
Peter Boström authored
This reverts commit 5bb16cdd. Reason for revert: Relanding without CreateInkDropMask removal. Original change's description: > Revert "Add HighlightPathGenerator to TabCloseButton" > > This reverts commit b25e7445. > > Reason for revert: The ink drop path here was not the same as the highlight path; in particular, the ink drop path is manually mirrored, while the highlight path is auto-mirrored. Reverting since this results in the wrong appearance in RTL. > > Original change's description: > > Add HighlightPathGenerator to TabCloseButton > > > > Replaces OnBoundsChanged override which resulted in a lot of path > > generation (per-tab + frame) while opening new tabs or resizing the > > window. > > > > Also removes a ::GetInkDropMask() override which just generated the same > > path. > > > > Bug: chromium:1007546 > > Change-Id: I0131f9a589c1525e2c0eacd61c9fcd9f6ac05948 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861016 > > Auto-Submit: Peter Boström <pbos@chromium.org> > > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#705972} > > TBR=ellyjones@chromium.org,pbos@chromium.org > > Change-Id: Ic7bd1312d452c828877669db89af45ac59160455 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1007546 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864393 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706348} TBR=ellyjones@chromium.org,pkasting@chromium.org,pbos@chromium.org Change-Id: I219552ebc8ec2dfe0504f5d1234d01fdc7e1232d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1007546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864376 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706472}
-
Jinsong Fan authored
In code path of ShowNonLocatedContextMenu, if can show the context menu at the selection, here always use the first rect of the selection range to compute the position for hittest. So if there is a lot of selected text in the contenteditable box, the begin of the selection is likely to be invisible, and the value of the first rect will be negative and invalid. The CL uses one of corner point or center of the selection rect fully between the handles. Bug: 1002344 Change-Id: Iba5110cad4d8d7d2dd36ece2454c415d7dcdd419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792426Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#706471}
-
Juan Antonio Navarro Perez authored
This new class makes it easier to write tests for LegacyPageTest implementations, and is compatible with the add hoc measurements that they normally write. Depends on catapult CL: https://chromium-review.googlesource.com/c/catapult/+/1862517 Bug: 999484 Change-Id: I13c64fdf7cb7181ac34306a124868d408bc99742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863292Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#706470}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2f6e525099a0..64444bc865d2 git log 2f6e525099a0..64444bc865d2 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fbf280c2..08af4873 (706299:706400) 2019-10-16 saza@webrtc.org Remove the noise_suppression() pointer to submodule interface 2019-10-16 perkj@webrtc.org Removed unused RTCP methods SendFeedbackPacket and SendNetworkStateEstimate 2019-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bdc89d87..fbf280c2 (706176:706299) Created with: gclient setdep -r src/third_party/webrtc@64444bc865d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: I461324d0657be3dbd9cd31c4534fa85323a173ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706469}
-
Peter Boström authored
Apparently use_titlecase was only used for IDS_TOOLTIP_NEW_TAB and IDS_TOOLTIP_SAVE_CREDIT_CARD. This removes titlecasing for those two. It's very possible that there are titlecase tooltips that don't have TOOLTIP in their IDS_name but auditing TOOLTIP strings in grd/grdp files seemed like the only tractable thing. Bug: chromium:999574 Change-Id: Ica864612ab85a2708bd93d213d2782f5ae3eee1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860880 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706468}
-
Evan Stade authored
OnProfileMarkedForPermanentDeletion should move from ProfileManagerObserver to ProfileObserver, which would also fix this bug. However, changing the order of members is the quickest and most cherry-pick-able way to avoid the crash. Bug: 1005244 Change-Id: If2db68c846dd418cd02864b57b9b543687fa1e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863518 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
-
Mohamed Abdelhalim authored
To clear the in-memory cache, the test was relying on a cross-process navigation. This is not enough, because the old page can be kept in the back-forward cache. This patch disables the back-forward cache for the old page. Bug: 999849 Change-Id: I7f2587d0bc25a349c74c8a68599e74db4eb8e318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863296 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706466}
-
Lily Chen authored
This adds analogues of the Cookie.SameSiteAttributeValue and Cookie.SameSiteNoneIsSecure histograms in //net to the Android WebView CookieManager API, to collect SameSite metrics specifically from the AW CookieManager Java API. Bug: 986319 Change-Id: Ifd9822a2c560cb30844652cbd1ceccfafc0bf2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860529Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#706465}
-
François Beaufort authored
This CL declares a NFC intent filter so that Android can directly start WebAPK activity if in the scope of the WebAPK. Change-Id: Ia9c716bc37f4534d6cf6cd387e53a6152d9d0f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863190Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#706464}
-
Olga Gerchikov authored
This change removes opacity, transform and filters members of cc:AnimationEvent that are not used anymore. Bug: 1013715 Change-Id: Ide6889a26ae39ac86d904fd5e2135350af3f0b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863731Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706463}
-
Nektarios Paisios authored
Similar to what Safari exposes, we expose three new parameterized attributes on Mac, which will be used for dumping text markers, text marker ranges and their anchor nodes. A followup patch will wire these attributes through to dump tree tests as follows: The @MAC-ALLOW directive will be extended to take parameterized attributes and an argument for each one. For example, if we want to dump the current selection, we could write: @MAC-ALLOW:AXTextMarkerRangeDebugDescription(AXSelectedTextMarkerRange) R=dmazzoni@chromium.org Change-Id: Ife020ad4ebc5d7d0002126a53d7d150555d31d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857049 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706462}
-
Aaron Krajeski authored
This function was being overridden twice, but was never called anywhere. Bug: 1005911 Change-Id: Ia17aaf20ed47ccad80571438578d0b62911cc7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856918Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#706461}
-
Sammie Quon authored
Overview now has a clipping animation which will clip out the frame, so we can dont have to change how paint works for overview. Caption buttons on the regular browser still need a repaint on overview state changed. Test: manual Bug: 1014520 Change-Id: Ie2b1d2a28e11f50e52c1ebe50f0ce6a8a2f85412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863756Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#706460}
-
behdad authored
TBR=sadrul@chromium.org Bug: chromium:1011969 Change-Id: Ida53ba86a2d673a834ff3afb501e66d49b42c7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863359 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
-
Li, Hao authored
Overrides Dawn's Vulkan validation layers path to reuse the one in ANGLE. TBR=dpranke@chromium.org BUG=dawn:150 Change-Id: Ibf4e513db2c2cb1a89613f1e3ab679f56bcf1c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864394Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#706458}
-
Nektarios Paisios authored
This patch adds tests that exercise the use of extra Mac nodes in AXTableInfo and OneshotAccessibilityTreeSearch. Extra Mac nodes are fake nodes that are added in the accessibility tree on Mac, representing the table header and columns. R=dmazzoni@chromium.org Bug: 1006842 Change-Id: Ia1d648be0cc52e949c5177d5d7df2bc2cb7d6d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854682 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic, only docs. This fixes several mistakes in the java_cpp_strings docs: * Do not need GENERATED_JAVA_PACKAGE * {NATIVE_STRINGS}, not {NATIVE_SWITCHES} * Do not need "This file is autogenerated..." boilerplate in the template * Consistent package name between template and generated file * Consistent class name between template and generated file * Change {YEAR} to $YEAR, as this must not be left templated, but should be filled in by the author This also adds some more opinionated changes: * Mark the class as "public final" not "public abstract" and mark the constructor private, as this is a more robust way to mark the class as non-instantiable * Include the boilerplate "This following string constants..." [sic] message in the generated file, as that's what the script inserts. * Use more realistic file names (foo_switches.cc and FooSwitches.java). * Add javadoc for the template file, as a suggestion for others to document the generated class. Bug: 1011991 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia1aa96cf50842bf226f35440fd2cafe8a186f8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863866Reviewed-by:Ian Vollick <vollick@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706456}
-
delima02 authored
Bug: 139488757 Change-Id: If51b977f7b9b3bc50a83a6328cebfdb6e0138aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808715 Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Auto-Submit: Juan Pablo De Lima <jpdelima@chromium.org> Cr-Commit-Position: refs/heads/master@{#706455}
-
Andreas Haas authored
It seems to me that the additional step of first creating a DataHandle was used to handle the case where allocation fails. However, this is also possible by creating an ArrayBufferContents directly. Bug: chromium:1008840 Change-Id: If2dde91b411157721dacc8257f9ab2a08bf48048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865159Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#706454}
-
Parastoo Geranmayeh authored
This reverts commit 83b71438. Reason for revert: SitePerProcessSSLBrowserTest.UnloadHandlersArePowerful* failing on Android. Please see bug. Bug: 1014956 Original change's description: > Adjust tests for upcoming cross-site cookie requirements > > They will need to be marked explicitly and secure, so adjust some tests to > be over SSL and mark those cookies appropriately > > Bug: 1006816 > Change-Id: I6da53ea64a7c03530335913fadb9099992e8ca33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863389 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Maksim Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706108} TBR=avi@chromium.org,morlovich@chromium.org Change-Id: I982bc1590171f92883000c8315d3be77f7b35b9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865249Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706453}
-
Mikel Astiz authored
The newly introduced mechanism around PendingLocalNigoriCommit allows implementing NigoriSyncBridgeImpl::SetEncryptionPassphrase(), responsible for setting up a custom passphrase, in a way that: a) Success is only reported when the sync server acks the commit. b) Conflict-resolution becomes simple. c) Logic is factored out from NigoriSyncBridgeImpl. There is a risk that the round trip to the sync server introduces noticeable UX latency when setting up a custom passphrase. However, manual tests suggests that it's actually not noticeable. Bug: 922900 Change-Id: I76f6644ed313d05aca8fe1d7cdf1d3205c7282cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856968 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#706452}
-
Primiano Tucci authored
This rolls the following in third_party/perfetto: 2019-10-15 primiano@google.com Remove checked-in generated files and use build-time gen ones 2019-10-15 primiano@google.com Make proto_to_cpp a build-time generator Turns out that the proto_to_cpp binary is overly generous in terms of aliasing enums and this lead a wrong use of some enum scopes in chromium. I found this problem when pre-rolling and testing [1] which is turning proto_to_cpp as a compile-time tool and getting rid of auto-generated checked-in code (ultimately to get rid of dependencies on libprotobuf). I checked that the new scoping matches the behavior of the code generated by the official protobuf library. [1] https://android-review.googlesource.com/c/platform/external/perfetto/+/1106801 Bug: 1006776 Bug: b/132880619 Change-Id: I85b519ad3e18c6be6674a8a27abe700ef73759e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863792 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#706451}
-
Sylvain Defresne authored
The tests ProgrammaticTabModelTest/TabModelTest.* tried to clean up the session file using NSFileManager but this step was flaky due to a race condition (it sometimes fails with a permission error). TestChromeBrowserState already delete the state directory if no explicit path is passed to the builder, thus the step to clean up was unnecessary and can be removed. Bug: none Change-Id: If0ece62ee5cee726e4135952f3d50efae35dabb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865211 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#706450}
-
Etienne Pierre-doray authored
By default, the NetworkService bootstraps a leaking SystemDnsConfigChangeNotifier singleton object in NetworkChangeNotifier::NetworkChangeNotifier(). This SystemDnsConfigChangeNotifier observes the DNS configuration (via FilePathWatchers on /etc/resolv.conf and /etc/hosts on POSIX and via ObjectWatchers on the registry on Windows). These watchers outlive the BrowserTaskEnvironment of the RenderViewHostTestHarness, including it's message queues. If the trybots experience network changes (e.g. due to expiring DHCP leases or other problems), it is possible that the watchers post messages to a message queue that has been destroyed already, see crbug.com/1011275#c3. This CL cause NetworkService to use a mock NetworkChangeNotifier which does not observe network changes. Bug: 1011275 Change-Id: I426999899cadf4732a93d4040871f56332422d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856803Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#706449}
-
Nicolás Peña Moreno authored
We do not intend to ship this feature, so remove the flag and some of the associated code. A followup CL will remove SubTaskAttributions and code used to compute them. Bug: 738493 Change-Id: I6b036e5d308bf8e555f5d5c76874e12458a028c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853124Reviewed-by:
Tom McKee <tommckee@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#706448}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/083a75d6762c..59e72b71b5cf git log 083a75d6762c..59e72b71b5cf --date=short --no-merges --format='%ad %ae %s' 2019-10-16 fmalita@chromium.org [skottie] Luma matte support Created with: gclient setdep -r src/third_party/skia@59e72b71b5cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: Iaa5b859db39d7f55e92dd7b4c4387dd32880748e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865101Reviewed-by:
-
Javier Ernesto Flores Robles authored
Change-Id: Ifc0899f198c9dad30c55e17efa6cf24bb2444b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864680 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Andy Paicu authored
Bug: 1014026 Change-Id: I5fe93b9bc7b39873900d9e15dcba66dfddd7c4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860015 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706445}
-
danakj authored
The UpdateVisualProperties IPC is going to a RenderWidget to set state on it, so move it back to RenderWidget. We are no longer attempting to build some global state in the Renderer, as each local root is an atomic unit of state, even including the "global" properties such as screen info, so that each RenderWidget sees the updates to itself as a single change. VisualPropertiesManager is no longer needed in the browser as each RenderWidgetHostImpl will just Send() the IPC to its RenderWidget directly. Tests updated to look for the IPCs again. R=avi@chromium.org TBR=dcheng Bug: 419087 Change-Id: I656864ea7f1a379c06b013b4aa6d88698838a4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857182 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#706444}
-
ckitagawa authored
Renderer side paint preview implementation. This CL creates a mojo service on a RenderFrameObserver that facilitates most of the paint preview capture management. Flow: - Browser calls this service to request paint preview capture of current frame (future CL 1) - PaintPreviewServiceImpl sets up for capture in Blink (this CL) - Blink handles the capture via a flow similar to printing (future CL 2) - This will include invoking a request to the browser to forward requests to OOP subframes. - PaintPreviewServiceImpl does post-processing and marshals a response (this CL) - Two artifacts are produced: - A SkPicture is written to the file handle provided by the browser - A proto containing metadata for the frame is sent via shared memory to the browser. - Browser does some minor modifications to the proto then either stores the proto to disk or forwards the proto and SkPicture files to a utility process for playback. The browser will retain the links from the proto for hit testing. (future CLs) Part of landing: https://chromium-review.googlesource.com/c/chromium/src/+/1786583 Internal Doc: go/fdt-design Bug: 994833 Change-Id: I88ffb89d92dfcb78b61a91a21df2b842c713f8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824669Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Roman Sorokin authored
This is a first step to implement new Help App dialog specs (see the bug for details) Bug: 1008073 Test: run on a device with a long content Change-Id: Id1abdb069ecc52aa35590f10cb5d21ab2e7eff70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864674Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706442}
-
Dominique Fauteux-Chapleau authored
Bug: 944625 Change-Id: Ifa032c85938406b87d24edf4c06ec738905a7978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783400 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706441}
-
Parastoo Geranmayeh authored
This reverts commit ba4c901f. Reason for revert: suspect for test failure. Please see bug. Bug: 1014930 Original change's description: > Fix for flaky test (scrollbar-button-gesture-target.html). > > The test fails because it tries to dereference a raw pointer which > points to layer that was destroyed. The fix is to set the pointer > to null and add checks in scrollbar_controller.cc > > Bug: 1002828, 987115 > Change-Id: I46efc7e35ee62bb36020a42aafbd75998728017c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854534 > Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706170} TBR=bokan@chromium.org,arakeri@microsoft.com Change-Id: I83735cb53a08929a532a917748278cfdabb98d64 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002828, 987115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864711Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the viz::mojom::FrameSinkManager interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I8a7ea0d64ec447de26e52a2b65f7620009be44ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860028Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#706439}
-
Laís Minchillo authored
This CL fixes a crash when a null VisualStateCallback is passed to postVisualStateCallback. Since there is no action to do if the callback is null, just return early. Bug: 1014924 Change-Id: I891eda56bd884af5b2d7e1cb909895cb5fdd6a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865155Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706438}
-
Jonah Ryan-Davis authored
These tests were all caused by bugs in Mesa which were fixed, but the tests were still suppressed until the bots were updated to a later Mesa version. All the bots are now updated and the tests pass. Bug: 666384 Bug: 680675 Bug: 844349 Bug: 905011 Change-Id: Ic371d2fdaf36a6ebd184ee36b78b90dacd6dfcd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863375Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#706437}
-
Roman Aleksandrov authored
Change ResolveLanguageListInThreadPool so that it uses AppLocale instead of default locale if exists. Bug: 955397 Change-Id: I6947dd89e297adea3fd019e38d083e45419ea282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704098Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#706436}
-
Sergio Villar Senin authored
In order to remove the dependency, the web_sudden_termination_disabler_type.h file was moved to third_party/blink/public/common. Since the file is no longer in the public/platform/ directory we are also renaming it sudden_termination_disabler_type.h (and the type defined in that file to SuddenTerminationDisablerType). Bug: 1008303 Change-Id: Ia97a4bbc329b222b4bdc7ee92ff73c507963aa5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845002Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
