GitLab

Bug: 1107466
Change-Id: If904c34d51be80412b3a1d077216f3dffeb1a406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309797
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795573}

Bug: 1111388
Change-Id: I9170271535bc110c92994440dbc92cbe3ba0e084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329738Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795572}

When a node's children have changed, accessibility code enqueues
information about that in order to examine the accessibility tree
after layout is clean. However, under some circumstances that led
to enqueuing the same node over and over again.

Fix that by adding a set to keep track of nodes already in the queue.

This patch also adds tracing for
AXObjectCacheImpl::ProcessDeferredAccessibilityEvents and adds a new
perf test to track this optimization. I'm seeing a ~20x speedup.

Bug: 1107988
Change-Id: I1263c5139991287a35b89c9c0e6e021f07628c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340384
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795571}

The rounding APIs on a Range are not used anymore.

We fixed the use cases where the call to Round was incorrect.
Typically, the code was looking for an "enclosing-range" or
and "enclosed-range".

It is preferable to remove the API since it's misleading the devs.

R=rsesek@chromium.org

Bug: 1111044
Change-Id: I7f11c9c28c2a5c93d3fe8cfcbd38a6b077e90105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339713Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795570}

CompositorAnimations::ConvertTimingForCompositor does not take the play
direction into account when adjusting the time offset for the start
delay.

Note that a similar trick might work for end delays; however, deferring
to a separate CL given the comment:

  // FIXME: Compositor does not know anything about endDelay.

which suggests that other CC changes may be required to accommodate
end delays properly.

Difference between composited and main thread animation can be observed
in the following CodePen without the patch.

https://codepen.io/kevers-google/pen/NWNPGRg


Bug: 1095813
Change-Id: I3d5d09618f6e58795bc527c18bc6deabe9abed13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339712Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795569}

This test appears to time out flakily.

TBR=ftirelo@chromium.org

Bug: 1113802
Change-Id: Id6280cac06c7deed2b8c2c7ae7c1a524e6246ded
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340277Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795568}

The default upstream was recently set to ON, which broke the
linux_upload_clang bot because its binutils is older than 2.26.

Bug: 1113475
Change-Id: Ifcce2f9ab6181e45fe89182dca45dac3b5b10c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341369Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Amy Huang <akhuang@google.com>
Cr-Commit-Position: refs/heads/master@{#795567}

Also make the constructor interface of MenuButton consistent
with LabelButton.

This CL is part of the effort to make Views default
constructible, allowing UI to be built in a declarative fashion.

Bug: 1108460
Change-Id: Ib46d0491d85bbd068c1a82a4d4dc3aaf47e63972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339586Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795566}

Creates a skeletal blink::WebPlugin counterpart to the Pepper-based
OutOfProcessInstance. This will support migrating the PDF viewer from a
Pepper plugin to a plain Blink plugin.

Note that the ultimate intent is _not_ to run the PDF viewer as a plain
Blink plugin, without other changes to isolate it. This is just a
starting point for the final implementation.

Bug: 1085334
Change-Id: I6bea3ddd7fc1b27879af5cd5614071cb02491d77
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328030Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795565}

This CL sets the ax::mojom::NameFrom property for static text nodes and
inline text nodes in PdfAccessibilityTree. This property is used by
AXNode::GetInnerText() to compute the inner text of the nodes.

This CL also includes the relevant tests to validate the change.

Bug: 1112890
Change-Id: I782ceb4d93a07146a81b1d23ff9696af3267d7f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337195
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795564}

This reverts commit 1f9a9579.

Reason for revert: Can't generate build files on mac-arm64-rel

Bug: 1113849

Original change's description:
> Infra: Rename mac-arm64 builder to mac-arm64-rel
> 
> Bug: 1106950
> Change-Id: Ie1c1fac0955afe6908335d2360a07954c718c25f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337103
> Commit-Queue: Gary Tong <gatong@chromium.org>
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#795517}

TBR=gbeaty@chromium.org,gatong@chromium.org

Change-Id: I4c0fca2e541852704f57c843bfb14f874ddffcc5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1106950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341810Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795563}

This is similar to what we do in local_frame_view.cc when traversing
GraphicsLayers. The null paint state may be caused by throttling or
display lock.

Will follow up with a more complete solution.

Bug: 1110232
Change-Id: Idce2c3e2ff80932dd6d0b68db52fa33e2fb8973c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341251
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795562}

R=dmazzoni@chromium.org

Fixed: 1113751
Change-Id: Ie7c04ab7b23b18ed6d980ed4b78fb6a756c59774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341402Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795561}

The previous change was reverted because the newly introduced focus_resulted_in_navigation_ member
caused MSAN failures as in some test scenarios the value would end up being uninitialized.

The value is now default-initialized in constructor.

This is a reland of 2ce4939f

Original change's description:
> Log abandoned omnibox interactions.
> 
> Introduces new metric recording outcome of every Omnibox focus event.
> Logged result will allow us to monitor for increase in abandoned
> interactions as we introduce new suggestion types.
> 
> Bug: 1105156
> Change-Id: I0b12e8cfa748e6a33f1d44e96ade77bf0b39cdd5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329878
> Commit-Queue: Ender 💬 = 🕐 (ping me for faster reviews) <ender@google.com>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#795155}

Bug: 1105156
Change-Id: I67231a7c653617f3f197b66bf9c25a0183710fc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340411Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#795560}

https://skia.googlesource.com/skia.git/+log/1362c1eac458..70df33d24eb1

2020-08-06 herb@google.com use a single point as DirectMaskSubRun's vertex data
2020-08-06 robertphillips@google.com Begin wrapping GrSmallPathRenderer atlas accesses
2020-08-06 jvanverth@google.com Reland "Switch GN defs on Mac and iOS to use frameworks, take 2."
2020-08-06 mtklein@google.com add SkGraphics::AllowJIT()
2020-08-06 adlai@google.com Migrate SkImage::MakeFromTexture to GrRecordingContext
2020-08-06 adlai@google.com Migrate MakeCrossContextFromPixmap to GrDirectContext
2020-08-06 mtklein@google.com iwyu fixes for VS 16.7's STL
2020-08-06 robertphillips@google.com Pull ShapeData into its own header file and rename to GrSmallPathShapeData
2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6c873cfde957 to bedac4f06b5c (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1104516
Tbr: herb@google.com
Test: Test: Test: CQ
Change-Id: If7f3b0c43f46a4f10331a2c490debe9d4f8749a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341364Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795559}

setproctitle sets argv[0] to space delimited string which causes
program_invocation_short_name to include all the switches until NULL
delimiter. This prevents such breakage by making
program_invocation_short_name point to a copy of the program name.

BUG=chromium:1110865
TEST=content_unittests

Change-Id: Iece5fa626e027a0145e7321cdbbda915f73b6c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326511
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Yuta Hijikata <ythjkt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795558}

TBR=tkent@chromium.org

Bug: 1113791
Change-Id: I4adf0f4a0411cbba1ce414337b3c71340fd5039a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339231Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795557}

Similar to http://crrev.com/c/2328038, this CL moves more things that
should happen after native is ready to appropriate places. This CL
fixes the drag-and-drop misbehavior when instant start is on.

Bug: 1111122
Change-Id: I84cfc6d7dc04d392f3af6d115e3b2a79fb6c3f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326858
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795556}

These traces events are causing issue with tracing.
  1) The initial version of trace events were crashing chrome on Shutdown
     since tracing is using a TLS boolean to check re-entrancy. The TLS
     was not longer there and can't be re-created during shutdown.

  2) The current version of trace events are causing a Locking issue and
     can deadlock.

Let revert these events until we figure out what is happening.

Bug: 1112636, 1111492
Change-Id: I5bd058f37203fdbb7fd4a8aa1e3424278397026d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341165
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795555}

The infobar currently show a time when download is scheduled on the
same day. It needs another string since many languages need different
translations between date and time.

Bug: b/160265853
Change-Id: I1572c1be5065a983a5ba0534c1414d78d5e6ddde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327750Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795554}

From the monitoring data, the pool is capable for higher traffic.

Bug: 997376
Change-Id: I557a7de4b7eed461b31941661c56265004263cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340187
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795553}

Partially implement a concrete location::nearby::api::BluetoothAdapter,
using the shared bluetooth::mojom::Adapter reference in Chrome's Nearby
Connections.

Only implement the methods on BluetoothAdapter which are required to
act as a 'Sender' device (discovery and connection initiation), and
basic methods like GetName().

A subsequent CL will finish this implementation; more methods need to
be made available on bluetooth::mojom::Adapter first.

api::BluetoothAdapter is a synchronous interface, so this CL converts
the bluetooth::mojom::Adapter::GetInfo() method it consumes to [Sync].

Please see design doc go/nearby-chrome-bt for more details.

Bug: b:154849033, b:158848873
Change-Id: Ia787f2890c42629a78c5d6e5caac6a73f9784a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313998
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#795552}

This is slightly more efficient (it doesn't require us to deduce at
runtime that this always erases to the container end and thus no
relocation after remove_if is necessary), but more to the point it's the
standard idiom for using std::remove_if with a WTF::Vector seen
elsewhere, so it's a little quicker to scan.

Change-Id: Icb6957d32923f334a5fda5b6d7e017fa8e9ac5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340662
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795551}

This CL removes credentials from the IncidentReportingService, and starts
using the Browser-wide URLLoaderFactory, since we don't attach cookies.
This allows for the SafeBrowsing URLLoader to become profile-keyed in
the future.

Bug: 1049833
Change-Id: I59d097d80aaf90c22b80928d7f9c8fce1209478b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337292Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795550}

Followup to crrev.com/c/2326632 and some comments there.

For the Tab Groups Extensions API, it's useful to be able to query all browsers for the one containing a TabGroupId, without needing to know the profile up-front. There are separate checks for ensuring that a group doesn't move across profiles. This is still assuming it's unlikely for group IDs to clash across profiles.

If there's a better way to approach this I'm happy to adjust!

Bug: 1098439
Change-Id: I71bd07f5d00fad74ee5aa02d1a62feb4883e3819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339341
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795549}

Following the comments from crrev.com/c/2310800.

Bug: 1085115
Change-Id: I2985b8a8f912009524edbcbb4286687ec6a5c0aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339668Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795548}

Bug: 866790
Change-Id: I8f9f3c567717f36e91f8a8f12b42124f4114ed03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340913
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795547}

Bug: 1111856
Change-Id: I3b201ae3900980f52849d0dafc4632c5c16bce5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337513Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795546}

We want to simplify error handling and use CLOUD_PROVISION_FLOW_ERROR with message code everywhere instead of CLOUD_PROVISION_FLOW_FAILED for few special cases.

BUG=b:62613791
BUG=b:146435695
TEST=deploy to dut, disable playstore, re-enable playstore, successfully
finish the authorization flow

Change-Id: Idb4dfeed9fa60d427703170488a3d581f66a9041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340111Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795545}

Break-before, break-after, and break-inside don't apply to absolute
positioned elements, so we don't need to add any special handling for
these when fragmenting OOF positioned elements. This change adds tests
to ensure that these forced breaks don't apply to abspos elements, as
expected, but do still apply to the children of abspos elements.

Bug: 1079031
Change-Id: Iaee4dfa67244e1999f659978c7cb3bbfce55ad8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327818
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795544}

This cl renames the SigninButton and ChooseAccountButton to Primary and
Secondary button respectively.

Bug: 1095628
Change-Id: I6c502c8f6509a4e45395204f986ccb554fad1f91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273238
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795543}

This change fixes IdleWakeups' SystemInformationSampler failing to
handle processes for which ::NtQuerySystemInformation() returns a
thread count of zero. With this change, processes with "zero" threads
are simply skipped.

Currently, the "Secure System" process reports a thread count of 0
(as it prohibits other processes from accessing it in any way), and
SystemInformationSampler subtracts 1 from this (logically assuming
that every process has at least one thread), which overflows to a
large number. SystemInformationSampler, noting that thread
information for <large number> threads would not fit in its buffer,
triggers an early return.

In practice, this results in IdleWakeups showing 0 processes when
a process with "zero" threads exists before its targeted process in
the process list, because it hits the early return described above
before reaching the process of interest.

Change-Id: I63b9a36bb139aba0b18539e65312bdc5d836cc69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335799
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795542}

R=chrisha

Change-Id: If77da5ebdff20e663f1fe9e216a2b1a46dda56bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341345Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795541}

Bug: skia:104662
Change-Id: I6f7f4ba8f77a19174b50d8485b3a0c2a5e9a46f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340704
Commit-Queue: Adlai Holler <adlai@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Adlai Holler <adlai@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#795540}

TBR=kinuko@chromium.org

Bug: 1113696, 1113692
Change-Id: I2e949d45670d0155dc45c125904d35386ecbd38e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340184
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795539}

TBR=sky@chromium.org

Bug: 1113694
Change-Id: I299d834ec9369d6314a25956f0b00e56cae308e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341242Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795538}

The implementation of the legacy TLS interstitial on iOS relies on
committed interstitials being enabled, so we should gate triggering
the interstitial on the committed interstitials feature being enabled.

Bug: 1100647
Change-Id: I0901deb007b34c14916a3f2daf4f2054f254e06d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340588Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795537}

Bug: 1109965
Change-Id: I619729473928759c478dbb64e215eff29dbb09c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335905Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#795536}

QuicSession::OnGoaway() is only for transport layer GOAWAY in Google
QUIC.  IETF QUIC uses HTTP/3 layer GOAWAY instead, and in order to
handle it, QuicChromiumClientSession should override
QuicSpdySession::OnHttp3Goaway() as well.

Bug: 1113661
Change-Id: I4ffa2edea730f823af22af232ecd2cc97856ba56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340856Reviewed-by: Renjie Tang <renjietang@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795535}

This change disconnects caBLEv2 on the desktop and mobile so that
further changes can be made incrementally. Otherwise, in order to
keep everything working, large changes cannot be broken up.

BUG=1002262

Change-Id: If2e4c5c561fd2b57cd8f70dbe33c769109ca9c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332375
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795534}