GitLab

We will limit the enhanced bookmark image store database size
to ensure that the db file size is reasonable. So add a function
to query the actual file size.

BUG=378853

Review URL: https://codereview.chromium.org/305963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274297 0039d316-1c4b-4281-b951-d872f2087c98

Reverting as we think it caused checkdeps failure on Linux:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/24742/steps/checkdeps/logs/stdio

ERROR in /b/build/slave/Linux_Builder__dbg__32_/build/src/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
  Illegal include: "out/Debug/java_mojo/mojo_public_test_interfaces/src/org/chromium/mojo/bindings/test/sample/SampleServiceConstants.java"
    Because of no rule applying.


> Generate java bindings for constants.
> 
> This CL is the first CL introducing java bindings. It only generates constants.
> 
> This is a reland of https://codereview.chromium.org/291903003
> 
> TBR=viettrungluu@chromium.org,rmcilroy@chromium.org
> 
> Review URL: https://codereview.chromium.org/305963009

TBR=qsr@chromium.org

Review URL: https://codereview.chromium.org/311643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274296 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/309053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379065

Review URL: https://codereview.chromium.org/307103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274287 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/304993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274285 0039d316-1c4b-4281-b951-d872f2087c98

- MostVisitedSites keeps track of which source the sites come from
- Blacklist requests are sent to the source corresponding to the current
suggestions
- SuggestionsService now handles blacklist requests

BUG=None
TEST=SuggestionsService

Review URL: https://codereview.chromium.org/298703009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379399
TEST=none
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/307963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274283 0039d316-1c4b-4281-b951-d872f2087c98

TEST=chrome --ozone-platform=gbm
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/302093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274281 0039d316-1c4b-4281-b951-d872f2087c98

Whenever a resource load is aborted, two events fire: loadabort and
loadstop. This change explicitly mentions two-event behaviour in our
documentation of loadabort and loadstop events.

Review URL: https://codereview.chromium.org/309673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274280 0039d316-1c4b-4281-b951-d872f2087c98

This CL is the first CL introducing java bindings. It only generates constants.

This is a reland of https://codereview.chromium.org/291903003

TBR=viettrungluu@chromium.org,rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/305963009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274278 0039d316-1c4b-4281-b951-d872f2087c98

This is the final cleanup before the unified gesture recognizer is turned on.

Tests are passing with the unified GR flag on and with the flag off.

BUG=332418
Test=GestureRecognizerTest.*, GestureProviderTest.*

Review URL: https://codereview.chromium.org/306483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274277 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/309573007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274276 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274275 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TESTED=try bots built unittests
R=wjia@chromium.org

Review URL: https://codereview.chromium.org/294343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274274 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the lint warns at:
Error: Field requires API level 16 (current min is 14):
    android.view.View#SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION [InlinedApi]
Error: Field requires API level 16 (current min is 14):
    android.view.View#SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN [InlinedApi]
Error: Field requires API level 16 (current min is 14):
    android.view.View#SYSTEM_UI_FLAG_FULLSCREEN [InlinedApi]

So we need to add @SuppressLint("InlinedApi") to suppress these lint errors.

BUG=327768

Review URL: https://codereview.chromium.org/305333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274273 0039d316-1c4b-4281-b951-d872f2087c98

As of May 14, 2014, this benchmark is no longer maintained.
https://github.com/facebookarchive/jsgamebench/commit/3938f9893d8713c47032d8d98bac41c32f4545ec

I think it is time we thank it for all the fish (e.g. http://crbug.com/161828)
and turn our eyes towards new benchmarks.

My motivation for pursuing this is that it has a long cycle time and is flaky in many places.

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/307263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=mark@chromium.org

Review URL: https://codereview.chromium.org/308123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274271 0039d316-1c4b-4281-b951-d872f2087c98

Also slightly modify a comment, as linebreak only changes make
Rietveld sad.

BUG=NONE
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/311623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274270 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for the delegated software renderer. For the GL delegated
render, the texture state is maintained by the driver.

BUG=314190

Review URL: https://codereview.chromium.org/303063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274269 0039d316-1c4b-4281-b951-d872f2087c98

This is a spinoff of https://codereview.chromium.org/266373006/, Patchset 11.

BUG=304290

Review URL: https://codereview.chromium.org/280393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274268 0039d316-1c4b-4281-b951-d872f2087c98

It somehow causes unresolved symbol errors when building other packages.
Let's see if we can skip instrumenting it without breaking MSan builds.

BUG=313751
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/308683010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/311563007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274264 0039d316-1c4b-4281-b951-d872f2087c98

Also ShellDesktopController has its own logic to initialize the
window manager, and its subclass (like Athena) can initialize
its own window management logic.

R=jamescook@chromium.org, oshima@chromium.org
TEST=no logic changes, confirmed athena_main running
BUG=

Review URL: https://codereview.chromium.org/308783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274263 0039d316-1c4b-4281-b951-d872f2087c98

Reason: the tests still fail.

> Tentatively enable StartupBrowserCreatorFirstRunTest.* on official Mac builder.
> 
> I recently fixed some places which passed empty URLs around (r272182), and these
> tests might have been failing because of the empty URL behavior (empty URLs were
> treated as the home page, and maybe the home page is something different on the
> official Mac builder than other builders).
> 
> Feel free to revert this commit if the tests fail.
> 
> R=bartfab@chromium.org
> TBR=sky@chromium.org
> BUG=314819
> 
> Review URL: https://codereview.chromium.org/308083004

TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/305963012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274262 0039d316-1c4b-4281-b951-d872f2087c98

Remove 2 outdated entries. Add an entry for an issue caused by an MSan bug.

BUG=363487,378909
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/310653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274261 0039d316-1c4b-4281-b951-d872f2087c98

And run the new Python-driven test_mini_installer on win_rel trybot.

BUG=277655

Review URL: https://codereview.chromium.org/301223007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274260 0039d316-1c4b-4281-b951-d872f2087c98

This patch disables a flaky test on mac.

TBR=dharcourt@chromium.org

Review URL: https://codereview.chromium.org/305963011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274259 0039d316-1c4b-4281-b951-d872f2087c98

> Remove passwords from the keychain if profile is destroyed.
> 
> BUG=343891
> 
> Review URL: https://codereview.chromium.org/307673002

TBR=vasilii@chromium.org

Review URL: https://codereview.chromium.org/306343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274257 0039d316-1c4b-4281-b951-d872f2087c98

Fixes the memory leak in the unit tests

BUG=116119

TBR=koz,jochen

Review URL: https://codereview.chromium.org/310483008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274256 0039d316-1c4b-4281-b951-d872f2087c98

The purpose of this change is to move ProfileOAuth2TokenServiceRequest
into google_apis/gaia and drop any browser dependencies.

ProfileOAuth2TokenServiceRequest becomes OAuth2TokenServiceRequest.

Add support for invalidating tokens.

Review URL: https://codereview.chromium.org/299943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274255 0039d316-1c4b-4281-b951-d872f2087c98

The eventual goal is to allow it to simulate flaky network connections.

Docs:
https://docs.google.com/a/google.com/document/d/1SkuWqLYIUpMDI05n7vgx8zdkunyUsxGs9tvUPDOqEJY/edit
https://docs.google.com/a/google.com/document/d/19O_UeUfCFZg5cEnH5jkkZ6_tqsfaLQLYUEIGyXw3oTo/edit

BUG=245436

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273584

Review URL: https://codereview.chromium.org/182993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274253 0039d316-1c4b-4281-b951-d872f2087c98

To solve the dependency on chrome_command_ids, this CL removes the
IDC_OPTIONS_TRANSLATE_* constants and instead defines the command IDs
locally in the file, which is an approach already used at several other places in
the code.

To solve the dependency on themes, the icon ID for the translate infobar is no
longer hardcoded, but fetched from the translate client instead.

BUG=371845
TBR=estade, joaodasilva

Review URL: https://codereview.chromium.org/284313008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274252 0039d316-1c4b-4281-b951-d872f2087c98

The (future) relocation packing tool requires a host build of gtest for
its unit tests.

BUG=

Review URL: https://codereview.chromium.org/308913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274251 0039d316-1c4b-4281-b951-d872f2087c98

Blink in Chromium now has this define, so it can be removed from Chromium.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274250 0039d316-1c4b-4281-b951-d872f2087c98

Support dumping coverage data generated by AsanCoverage from sandboxed processes. For the GPU process, we simply pre-open a file before engaging the sandbox. For the renderers, we use a helper process which we fork from the zygote. The helper process collects coverage data from renderers over a socket and writes it to a file. This allows an arbitrary number of renderers to share one output file.

With this change, GPU and renderers will write coverage data to .sancov.packed files which may contain data from multiple modules/processes. Previously, we created one .sancov file per process per module (and still do so for other processes).

Note that the new behavior takes effect regardless of whether the sandbox is actually enabled.

BUG=336212
R=jln@chromium.org
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/280303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178409
R=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/304353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274247 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60973
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/303393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274238 0039d316-1c4b-4281-b951-d872f2087c98

Disabling ExtensionToolbarModelTest.SizeAfterPrefChange due to the following
flake
../../chrome/browser/extensions/extension_toolbar_model_browsertest.cc:601: Failure
Value of: model_->GetVisibleIconCount()
  Actual: 1
  Expected: -1

BUG=379170
TBR=finnur@chromium.org,kihong.kwon@samsung.com

Review URL: https://codereview.chromium.org/308003017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274237 0039d316-1c4b-4281-b951-d872f2087c98

OutOfProcessPPAPITest.TrueTypeFont

TBR=jam@chromium.org
BUG=379774

Review URL: https://codereview.chromium.org/308003016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274236 0039d316-1c4b-4281-b951-d872f2087c98