- 14 Aug, 2020 40 commits
-
-
Lei Zhang authored
Various KerberosCredentialsManagerTest test cases are flaky. Bug: 1116500 Change-Id: I31984b06d49d58f2f4994bf1b0053bd97e82ea9c Tbr: emaxx@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357409Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798244}
-
Robbie McElrath authored
This reverts commit 0f654bd2. Reason for revert: The CL that caused the flakiness was reverted. Original change's description: > Disable flaky test ErrorPageCallbackTest.testOverrideErrorPage > > org.chromium.weblayer.test.ErrorPageCallbackTest.testOverrideErrorPage > is flaky on Android, > https://analysis.chromium.org/p/chromium/flake-portal/flakes/ > occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfAsSBUZsYWtlInFjaHJvbWl1bUB3ZWJs > YXllcl9pbnN0cnVtZW50YXRpb25fdGVzdF9hcGtAb3JnLmNocm9taXVtLndlYmxheWVyLnRl > c3QuRXJyb3JQYWdlQ2FsbGJhY2tUZXN0I3Rlc3RPdmVycmlkZUVycm9yUGFnZQw, > disable it for now until it is fixed. > > TBR=estade@chromium.org > > Bug: 1116277 > Change-Id: Id9eaa577587cb64136cd36364dc7e882f1c34876 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355399 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798021} TBR=estade@chromium.org,lanwei@chromium.org Change-Id: I53f4ab75620ae834b2969cf6042c201f381e443a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357595Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#798243}
-
Dylan Cutler authored
HTMLVideoElement.webkitDroppedFrameCount for identifiability study. Bug: 973801 Change-Id: I1d7efabe6e44764a447b9b47adc1bd343aa6e80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354306Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#798242}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c9c4e2e9efac..8b07b9f55a73 2020-08-14 mtklein@google.com Revert "move conditions for JIT into SkVM.h" 2020-08-14 johnstiles@google.com Improve unit tests for switch-case and enum error handling. 2020-08-14 nifong@google.com missed minification bug 2020-08-14 mtklein@google.com byte code instructions can fit in a byte 2020-08-14 mtklein@google.com clean up stray #undef 2020-08-14 egdaniel@google.com Remove ability to add waitOp to GrOpsTask. 2020-08-14 jvanverth@google.com Fix MetalWindowContext::swapBuffers. 2020-08-14 brianosman@google.com Make switch case handling safer 2020-08-14 johnstiles@google.com Enable ClangTidy check modernize-use-nullptr. 2020-08-14 adlai@google.com Remove SK_IMAGE_MAKE_COLOR_TYPE_AND_SPACE_USE_SOURCE_CONTEXT 2020-08-14 herb@google.com benchmark for text vertex fill 2020-08-14 brianosman@google.com Move init code from pipeline stage generator to GrSkSLFP 2020-08-14 mtklein@google.com move conditions for JIT into SkVM.h 2020-08-14 nifong@google.com Check SKP file version, return error string to JS caller 2020-08-14 robertphillips@google.com Require a direct context to precompile a DDL's programs 2020-08-14 johnstiles@google.com Describe the Skia 'onMethodName' pattern. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I0f46f94b17577a86659c60fd5a3cfc9075532dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354504Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798241}
-
Karandeep Bhatia authored
https://chromium-review.googlesource.com/c/chromium/src/+/2354566 plumbed DOMWrapperWorld for all resource requests. Hence we no longer need to look at the current world to see if the main world CSP should be bypassed in CSP checks in fetch context. Instead we can rely on the CSP associated with the plumbed DOMWrapperWorld. This is more accurate as it prevents incorrectly bypassing or not bypassing the CSP when BaseFetchContext::ShouldBypassMainWorldCSP is called asynchronously from the point the request is initiated. BUG=1099975 Change-Id: I6cb782dab25e3b418f5b9be79578b3b7d0e50b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317030Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#798240}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I8205c0d2bf2c771687689ebf5f7714dd0669dc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356567Reviewed-by:
-
Rouslan Solomakhin authored
This patch adds a C++ payment app object that communicates to Android payment apps. At this time, only Chrome OS has concrete implementation that connects to a Trusted Web Activity in the Android subsystem. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1061503 Change-Id: Ice5918967493e34cfa5ad4a4ccc25ce2602d204a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255112 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798238}
-
Guillaume Jenkins authored
One of the prefs related to Enterprise reporting for iOS CBCM wasn't being registered, and that caused a crash when CBCM was enabled. This change correctly registers the missing pref to the local state pref registry. Bug: 1066495 Change-Id: I2ccc81ea8f4290cc00238618853b0c03b16de483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357133Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#798237}
-
Eugene But authored
Chrome for iOS restores 75 navigation items per Tab, which is the maximum supported by slim navigation manager. There is evidence that navigation session uses a lot of memory and this CL adds a metric to understand how many navigation items Chrome actually need. If users rarely go 75 items back, then Chrome could restore fewer items and safe on memory usage. Bug: 1115279 Change-Id: Iab54a577473ace598f7eb171785b2e1eefa92784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352214 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#798236}
-
Yuki Shiino authored
This is a reland of e1dce34f Original change's description: > bind-gen: Switch to the new IDL interface implementation > > Blink-V8 bindings team has been developing the new improved > Web IDL bindings system, and this patch enables the new > bindings implementation of Web IDL interfaces at build time. > > Note that other IDL definitions (buffer source types, > dictionaries, callback functions, etc.) are not affected and > the old bindings are still used for them. > > The new IDL interface implementation is not 100% compatible > with the old one, and we see the following changes/improvement > that are visible from author script. > > Behavioral changes: > - Cross origin attributes become accessor properties. > - Indexed/named properties' behaviors change. > - Legacy platform objects with indexed properties support > @@iterator property. > - Maplike supports size() operation. > - [NoInterfaceObject] removes 'constructor' property. > - Some of error messages change. > For these changes, new behaviors are better conforming to > Web IDL specification. > > Non-behavioral changes: > - Keep-alive-GC optimization is removed. > > For performance, there is no major difference in speed perf > and -17KB improvement in APK binary size. > > Pinpoint results > https://pinpoint-dot-chromeperf.appspot.com/job/1230bdd8920000 > https://pinpoint-dot-chromeperf.appspot.com/job/14b5b5d0920000 > https://pinpoint-dot-chromeperf.appspot.com/job/12ca6424920000 > https://pinpoint-dot-chromeperf.appspot.com/job/14e3aa48920000 > > Bug: 839389 > Change-Id: I9de8de3cc9e37b4ee46333c9270fe49bbdd69534 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081633 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793165} About perf: APK size +7KB https://pinpoint-dot-chromeperf.appspot.com/job/143264c6920000 https://pinpoint-dot-chromeperf.appspot.com/job/174ee7a9920000 https://pinpoint-dot-chromeperf.appspot.com/job/175f8f66920000 Bug: 839389 Change-Id: Ib5a486eba6627d3dcb40efc3a617c90511645b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335713 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#798235}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/241a4a92fb96..4c3752c7f677 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I30da7939ceeccf1716a189d8449721ff47ac179f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356829Reviewed-by:
-
Ben Pastene authored
A small attempt at reducing overall traffic to various pools. Bug: 1116532 Change-Id: I9c36e08a9babfa4a69d62bb246950ae48890e94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357412Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#798233}
-
Lei Zhang authored
The test is crashing in a flaky manner. Bug: 1116543 Change-Id: I9c0d020aa8a936be1ffce98f207a892f2a0516bf Tbr: erikchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357253Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798232}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/292d9a8341d3..69d93258d753 2020-08-14 omerkatz@chromium.org heap: Add epoch based metric for blink gc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986235 Tbr: eseckler@google.com Change-Id: I211fc1cf765e79915ecdb13e1aa9f261a27d5eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356588Reviewed-by:
-
Emily Stark authored
This CL ignores private registries when computing the simplified domain, i.e. registrable domain. For example, "foo.example.com" will be simplified to "example.com", and "foo.blogspot.com" will be simplified to "blogspot.com". (Note that as of https://chromium-review.googlesource.com/c/chromium/src/+/2337761, the simplified domain logic only applies in unusual cases; most of the time, we show the full hostname). The reason for ignoring private registries is that we don't want to create negative incentives for malicious websites to add themselves as private registries to the Public Suffix List. This policy isn't perfect, but we think it best balances the security benefit of eliding malicious subdomains while minimally impacting benign websites that use subdomains. Bug: 1106962 Change-Id: Ifb75a510707c1dcac0825f899625069656838932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356936Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#798230}
-
Filip Gorski authored
Prevents exceptions when setting URL in clipboard. Bug: 1115825 Change-Id: If64623659d042f1949f22ad759fbf26aaf55531c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355012 Commit-Queue: Filip Gorski <fgorski@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798229}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.57-1597053344-benchmark-86.0.4231.0-r1 to 86-4183.57-1597053344-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7ec183d4c0ca2c55bdcecd0603a6cd03c22ab694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357489Reviewed-by:
-
Lei Zhang authored
FindIt says the test recently started being is flaky. Bug: 1096976 Change-Id: I7c60c47a365533325748818f27bf0fd5e4eaaeb5 Tbr: mahmadi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357131Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798227}
-
Kyle Ju authored
Bug: 1116264 Change-Id: Ie91b0b6298c9ad3d1284157291a0dd90e03ca985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354302Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798226}
-
K. Moon authored
Adds a "PdfIncrementalLoading" feature to control whether or not the PDF viewer tries to use incremental loading. The default state is enabled, as this feature has shipped already, but we would like to experiment with disabling it to address certain problems related to incremental loading. crrev.com/c/2349429 added a similar control for "partial" loading. The two features are orthogonal: Incremental loading tries to load a PDF before all the bytes have arrived, while partial loading tries to fetch the bytes out of order. (Partial loading currently is not useful without incremental loading, however.) The linearized.pdf file was derived from the equivalent file in third_party/pdfium/testing/resources. For the purposes of this test, the file has been relinearized and decompressed using qpdf. Bug: 1115149 Change-Id: Ib9f9d3d66b9c5d051528a6d49b4662b70d236649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352217 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#798225}
-
David Van Cleve authored
This change updates net_log_test_util's methods that retrieve strings from NetLogEvent dictionaries to allow fetching a string from a nested dictionary using the base::Value::GetStringPath syntax (for instance, "inner.item" will fetch { "inner": { "item": "value" } }). (This allows writing some slightly more concise test code in the child CL crrev.com/c/2315641.) R=eroman Bug: None Change-Id: Ie8552b9347e9bb147f12e1a57ca98a43b9216f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354293 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:Eric Roman <eroman@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798224}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597405958-c5a8fe7086bb1f6a4ff7abcf1204e717b88da2c5.profdata to chrome-mac-master-1597426673-550b761d47e655299dbb3d5b54525f083ab2d05d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia56486fb547441131e12c282dfe029a17a20a84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357094Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.57-1597055597-benchmark-86.0.4231.0-r1 to 86-4183.57-1597055597-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iedac652f41c5b9f9b05fad000bd0f29eff0c28a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357429Reviewed-by:
-
Nate Fischer authored
All of TrustedWebActivityLocationDelegationTest.* are flaking on the official tester. This just disables the entire test file. Tbr: peconn@chromium.org Bug: 1116518 Test: run_chrome_public_test_apk -f TrustedWebActivityLocationDelegationTest.* (verify nothing runs) Change-Id: I168bbb668493fcc95578be67e7c1abbb3716b52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356989Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798221}
-
Brian Malcolm authored
BUG=chromium:1113362 Change-Id: I1a3fd4448c706991e25bba434273bd783bdcfea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355053 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798220}
-
Steven Bennetts authored
The NetworkHealthService class owns both a NetworkHealth instance and a NetworkDiagnostics{Impl} instance. This CL cleans these classes up a bit to make them more consistant and to make the relationships a bit more clear. No functionatlity is changed. TBR=tbegin@, khegde@ Bug: None Change-Id: I6d07f0e6f7fc0b24ba51e4c999672ff0865c36ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356268Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#798219}
-
Adam Goode authored
The work to implement this as a proper option in the UI is still pending. Until then, this flag is the only mechanism available for this accessibility option. Bug: 817814 Change-Id: I18d1d2d62071e85b1be5f6b017cb2b05271795df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356190Reviewed-by:
-
Keishi Hattori authored
LayoutObject::Destroy() should not be called inside a finalizer. This becomes dangerous when we migrate LayoutObje ct to Oilpan as finalizers are not allowed to access other on-heap objects. This CL adds AllowDestroyingLayoutObjectInFinalizerScope to mark certain SVGImage() as exempt from this CHECK. This is OK as SVGImage is retaining the LayoutObject via a Persistent and so it is guaranteed to survive the current GC cycle. Bug: 1030176 Change-Id: Ibdd0a29e7630747ea118d92d442776cf1bac8537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352294Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Kenneth Russell authored
This reverts commit d69e7bfd. Reason for revert: assertion failures in BrowserControlsOffsetManager::SetupAnimation per Issue 1116552 and related bugs. Original change's description: > Reland "[Offline indicator v2] Add field trial testing entry" > > This reverts commit 52b501ca. > > The reason for the revert has been fixed with crrev.com/c/2248931. This > reland also includes changes in tools/perf/benchmarks. We basically add > a command-line switch to force the offline indicator an online state. > This is because these benchmarks are run on offline devices and this > causes the offline indicator to show and affects the stories being run. > Showing the offline indicator isn't realistic when the test is simulating > navigating webpages that would normally require the device to be online. > Also, showing the offline indicator might cause flakiness in the results > or dilute real regressions. We've investigated the reported regressions > and confirmed that they're WAI when the indicator is showing. > > Original change's description: > > Revert "[Offline indicator v2] Add field trial testing entry" > > > > This reverts commit ceaac935. > > > > Reason for revert: continued assertion failures on some phones; see http://crbug.com/1084740#c17 . > > > > Original change's description: > > > [Offline indicator v2] Add field trial testing entry > > > > > > Enabling the feature causes some test failures since the bots are > > > offline and the offline indicator is always visible. For the short term, > > > we are adding a command-line switch to disable the offline indicator. > > > > > > The longer-term plan is to enable the feature for most tests, and only > > > disable where we have to. > > > > > > Bug: 989148, 1091491, 1093085 > > > Change-Id: I89e7ef93233b4c4cc2bd395ce1309bc14d5dea09 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228367 > > > Reviewed-by: Steven Holte <holte@chromium.org> > > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > > Reviewed-by: Avi Drissman <avi@chromium.org> > > > Reviewed-by: Theresa <twellington@chromium.org> > > > Commit-Queue: Sinan Sahin <sinansahin@google.com> > > > Cr-Commit-Position: refs/heads/master@{#777216} > > > > TBR=avi@chromium.org,twellington@chromium.org,holte@chromium.org,bsheedy@chromium.org,sinansahin@google.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 989148, 1091491, 1093085 > > Change-Id: I6c22120bbb27ff430f73a40ea28f1bf1a9a7da31 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244195 > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: Kenneth Russell <kbr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#778024} > > Bug: 1091491 > Change-Id: I3fd5e9d92f61c980a664ad6b5c311fe6b68cd57c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246834 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/master@{#798016} TBR=avi@chromium.org,bcwhite@chromium.org,twellington@chromium.org,bsheedy@chromium.org,sinansahin@google.com Change-Id: Ic31ee74957d7803d3c8fa6669ac9adb9c9c43479 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1091491, 1116552, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357672Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798216}
-
Karandeep Bhatia authored
This is part of the work to enforce isolated world CSP for resource requests when the feature IsolatedWorldCSP is enabled and to correctly bypass the main world CSP otherwise. Note that it's possible that the plumbed DOMWrapperWorld might not always be completely correct (for example if it is plumbed asynchronously from the point which caused the resource request). However this is still better than the status quo where the CSP checks for isolated worlds are bypassed based on calling FrameFetchContext::ShouldBypassMainWorldCSP() which is often incorrect especially for redirects since we might be in a different different world by then. Next CL will remove FetchContext::ShouldBypassMainWorldCSP. BUG=1099975 Change-Id: I727513d0fa8e9e16aa05a0fdd7c86d987f983890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354566Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0e97afad480e..02b64b9591b9 2020-08-14 brgoddar@microsoft.com Elements: Remove Event Listener Pane focus override If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1114604 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6e84984651a0c504757af0ad5d246d0f0f879788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356591Reviewed-by:
-
Evan Stade authored
This fixes run_weblayer_shell crashing on startup when no URL is passed (broken in 8c5d422b) Bug: none Change-Id: I1b4a82853686f14f6a244eac226db21cecc69dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354611 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#798213}
-
Eric Roman authored
Change-Id: I4687a02904771284055b902ce3431b4cc549bdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356931 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#798212}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/241a4a92fb96..4c3752c7f677 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1882c62b34b6d312a530df8e2a6f021298ff14c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356266Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I9a87473492cf182ade2b279d0e2246678f0f8126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355522Reviewed-by:
-
Scott Violet authored
To FaviconDatabase. I'm going to use this in weblayer code to expire favicons. WebLayer doesn't use history, but needs a way to prune the database. BUG=1076463 TEST=covered by tests Change-Id: If74a389a947eb465447009c620e0988f9545ab91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354998 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#798209}
-
Lijin Shen authored
Bug: NONE Change-Id: Ie3b5b44531c8e870fd0961ce4746313f6e5e4de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351720 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#798208}
-
sczs authored
Comparison image: https://drive.google.com/file/d/1YqxC7U2VQ_X318GDHVmu6tOJnEblOQFs/view?usp=sharing (Left:New Right:Old) Bug: 1085419 Change-Id: I0ba685cf36db42e41daf11d7735600cffb5408a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355310 Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#798207}
-
Lei Zhang authored
The newly added ShouldPasteHistoryAsPlainText test case is flaky. Bug: 1116530 Change-Id: I75897352152844220ffbc3fbc0e27007d650ca29 Tbr: dmblack@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357050Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798206}
-
Mike Dougherty authored
This DCHECK occasionally triggers, but for unknown reasons. Update the DCHECK to exclude re-registering the same main web frame. This will separate the issue from the same frame being re-registered which will be caught by the next, already existing DCHECK. Bug: 1014227 Change-Id: Ic5a248f12467812e2b6b287565aa37f675935661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354713 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
