GitLab

Bug: 820198
Change-Id: If15c9ae81c1d43f7c45d5fcf28ecbad0a8ba8635
Reviewed-on: https://chromium-review.googlesource.com/956030
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542560}

Bug: 70225530
Test: build and push OTA to device.
Change-Id: I3e77b8e0ea55084c499de36169d80a195c0de74a
Reviewed-on: https://chromium-review.googlesource.com/958225Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Linkun Chen <lkchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542559}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0f4e29651e2..c5edef2fbc54

$ git log e0f4e2965..c5edef2fb --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If5511d6dc54fa7178ead91b99e8a2c2d9c60a440
Reviewed-on: https://chromium-review.googlesource.com/958334
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542558}

This is a workaround for enterprise setups (such as universities) where
the network topology assigns public IP addresses to their Cast devices
(presumably these devices are protected behind a firewall). Public IP
addresses were disallowed in crrev.com/519857 which causes such setup
to be broken, as users can no longer connect to those devices. To our
knowledge there are at least 2 EDU setups (and a handful of individual
users) that were affected by this.

The workaround is implemented as a feature that is disabled by default.
The intended target is affected users for whom the option of changing
the Cast devices is infeasible (mostly EDU organizations). It can be
enabled by passing in --enable-features=CastAllowAllIPs in the
command line, or by turning it on in chrome://flags.

Bug: 813974
Change-Id: Ia02702315f02544245862561dc6925f0e15725db
Reviewed-on: https://chromium-review.googlesource.com/954345Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542557}

Bug: 651022
Change-Id: I95d405ca9be1747abfe24f68f0837ed5981571ed
Reviewed-on: https://chromium-review.googlesource.com/958783Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542556}

The layout needs updating whenever a new
image is set.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If7e9d731f31bec7d28198a6f06275abd36071185
Reviewed-on: https://chromium-review.googlesource.com/954502Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542555}

It is possible to drop using wallpaper test client for the set of unit
tests where wallpaper test client is used to prevent crash from the
fake user manager.

Test: git cl try
Bug: N/A
Change-Id: I7a788656fe0558841523744dc5ada3a1d5ffde9b
Reviewed-on: https://chromium-review.googlesource.com/957788
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542554}

This is a reland of b513507c

Original change's description:
> tablet: Remove minimum time between taps for quick switch.
> 
> Previously relied on using tap_count in GestureEvent which has a minimum
> time between taps of 40ms for consecutive taps to have tap_count of 2.
> Remove that and track double taps in overview button tray.cc. Allows
> double tap from mice now.
> 
> Test: ash_unittests OverviewButtonTrayTest.*
> Bug: 817883
> Change-Id: Icce2e668223f938a7f8194c5f0a03279abff9907
> Reviewed-on: https://chromium-review.googlesource.com/956769
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542315}

Bug: 817883
Change-Id: Ifd6ecabf3f1702d8aeffa29a48a6475f0e6b5422
Reviewed-on: https://chromium-review.googlesource.com/958014Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542553}

The initial value used here shouldn't make a difference, so use the
initial value of 'fill' since that looks less confusing. It will also
simplify conversion to a different computed <paint> representation.

Bug: 769774
Change-Id: I5a08f73d4affc28f5804f3c3164051197721b2a4
Reviewed-on: https://chromium-review.googlesource.com/959009Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#542552}

There isn't much point in using any kind of download_to_file like
optimization when loading from a data URL, so just don't, and make
downloading data URLs as blob work.

Bug: 412752
Change-Id: I3cd1e9ae290cdbf34d6d045c91b5717d8b997f8c
Reviewed-on: https://chromium-review.googlesource.com/957302
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542551}

This reverts commit c83231b7.

Reason for revert: Should not have removed flags from enums.xml

Original change's description:
> VR: Remove VR Launch Intents flag
> 
> This flag was really only for development while we weren't sure how to
> handle VR Intents. With Chrome VR browsing already shipped, there's no
> reason not to allow Intents to launch it.
> 
> Change-Id: Ibbc7e5ea41668c073a4a04340ec45bfe40025b0f
> Reviewed-on: https://chromium-review.googlesource.com/959051
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542508}

TBR=yfriedman@chromium.org,mthiesse@chromium.org

Change-Id: I6b92369c483f7f0d8a11290bb9a50f6cfd1ea766
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/958021Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542550}

This CL also disables modern media controls on some Cast browser tests
that currently make pixel-based assumptions about the controls. There
will be a followup to fix those tests once the modern controls are in
a more stable state.

BUG=812893

Change-Id: Ibef663b0053a8adce80e8b057f76d3eb53f7dc88
Reviewed-on: https://chromium-review.googlesource.com/922917Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542549}

These rects should mirror the behavior of getBoundingClientRect,
which doesn't snap.

BUG=758587,737228

Change-Id: If735df6bd24414dfbbd58dce01dc2a90f71df381
Reviewed-on: https://chromium-review.googlesource.com/951640Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542548}

https://skia.googlesource.com/skia.git/+log/689d02d4b480..cf81fa995f38

$ git log 689d02d4b..cf81fa995 --date=short --no-merges --format='%ad %ae %s'
2018-02-15 benjaminwagner Use goma ensure_stop.
2018-03-12 reed update include path for SkBlurMask.h
2018-03-06 caryclark make paint flatten unflatten private
2018-03-12 scroggo Update piex
2018-03-12 herb Fix overflow in blur for VERY wide bitmaps.
2018-03-09 caryclark pathmeasure fuzzer
2018-03-09 herb Remove DetachCache and AttachCache.
2018-03-12 kjlubick Small cleanups suggested by ClangTidy

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I57dd28ba7867321e61e4120be0ffc5dcd84cb5e3
Reviewed-on: https://chromium-review.googlesource.com/959164
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542547}

changes:
Instead of using ScopedUmaRecorder, which is essentially implementing
in a "callback" way. This CL replaces it with base::OnceCallback, which
makes code more concise.

Bug: 817643
Test: covered by tests
Change-Id: Id99e9c08e8fe49886ca7c30a5901fb4128b04a42
Reviewed-on: https://chromium-review.googlesource.com/957816
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542546}

Bug: 821015
Change-Id: I60824857a26ea8660b80aa22dafd33bb3fc42289
Reviewed-on: https://chromium-review.googlesource.com/959120Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542545}

Make fast/css/acid2.html and http/tests/misc/acid2.html useful, by scrolling
the test face into view, rather than showing the instructional text at the top
of the document (which basically says "click here to run the test").

There was an acid2-pixel.html alongside the acid2.html test, which I'm
removing. The idea was apparently to keep an unmodified (and useless)
acid2.html test, in addition to a useful but modified one, i.e. one that made
the test face visible without first having to scroll (by adjusting margins and
stuff). But since acid2.html has already been modified by us anyway, let's just
go all in and scroll the face into view. Also no longer dump the render tree,
since it's not useful.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie4518d40b0376bfc7920e6789c1d13f8758b22c6
Reviewed-on: https://chromium-review.googlesource.com/958922
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542544}

https://chromium.googlesource.com/angle/angle.git/+log/391bda23b56d..529434a5a565

$ git log 391bda23b..529434a5a --date=short --no-merges --format='%ad %ae %s'
2018-03-08 jiawei.shao ES31: Update dEQP-GLES31 geometry shader related test expectations
2018-03-09 kvark Update driver constants on program change. Comes with a new SamplerMetadataUpdateOnSetProgram test.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I4ef48968020c342df6878d1d24cc424c96a54523
Reviewed-on: https://chromium-review.googlesource.com/959167
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542543}

https://webrtc.googlesource.com/src.git/+log/b619936dee28..3e77afd0d29b

$ git log b619936de..3e77afd0d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ifceb169cbffa4eaaf933b10492abb5d4583b8d35
Reviewed-on: https://chromium-review.googlesource.com/959165
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542542}

Bug: 813193
Change-Id: I939aee748e638ae6fc3e5171a27491d83df151c3
Reviewed-on: https://chromium-review.googlesource.com/957484Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542541}

This was introduced as an oversight in r541905. The original code safely
handled null element readers on a URLRequest. This CL restores that
safety.

Bug: 820764
Change-Id: I1c37dc546cda989d7796ea66f2f9c073813fe50f
Reviewed-on: https://chromium-review.googlesource.com/959227Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542540}

This reverts commit 0588d062.

Reason for revert: break Linux Builder (dbg) Build 121988 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29/121988

error: undefined symbol: device::internal::ScopedU2fDiscoveryFactory::ScopedU2fDiscoveryFactory()
>>> referenced by fake_u2f_discovery.cc:85 
error: undefined symbol: device::internal::ScopedU2fDiscoveryFactory::~ScopedU2fDiscoveryFactory()
>>> referenced by fake_u2f_discovery.cc:86 

Original change's description:
> Introduce a generic ScopedU2fDiscoveryFactory override.
> 
>  -- In preparation for introducing ScopedU2fVirtualDiscoveryFactory, create a
>     base class ScopedU2fDiscoveryFactory and let ScopedU2fFakeDiscoveryFactory
>     derive from that.
>  -- In preparation for a wider adoption of FakeU2fDiscovery in tests that could
>     not care less about when a discovery starts, add a version of the fake
>     discovery where SimulateStarted()/SimulateStopped() is called automatically.
> 
> Bug: 785955
> Change-Id: I4b1c9bd962c6e225be45971bbb0d5aad3b05a68a
> Reviewed-on: https://chromium-review.googlesource.com/959001
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542507}

TBR=engedy@chromium.org,jdoerrie@chromium.org

Change-Id: Iff7c0aa010fe3ae83262508795bdded90d1f620c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785955
Reviewed-on: https://chromium-review.googlesource.com/959282Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542539}

This has been disabled in release builds for a while, and might not work
anymore anyway.

Bug: none
Change-Id: I1cadea9d93944909958067eb75c3c64130da9d41
Reviewed-on: https://chromium-review.googlesource.com/959019Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542538}

Using wpt-import in Chromium 37496521.
With Chromium commits locally applied on WPT:
5abdda89 "Remove duplicate color parsing tests"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13764

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=foolip

No-Export: true
Change-Id: I80bec75d5d71873ffd2dfe86f14bdbb2fb9d4cff
Reviewed-on: https://chromium-review.googlesource.com/958220
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542537}

With this change, I've added a hover offset to the mic button. I've also
generalized some button code so that it can be reused by the mic button.
(Specifically, you can now set the corner radius of the disc button, and
we may want to rename this class eventually).

Bug: 818008
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0884b90ae19d34952c639653850ede4754e16fc8
Reviewed-on: https://chromium-review.googlesource.com/958221Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542536}

TBR=kinuko@chromium.org

Bug: 809583
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0050d598ad4531280085e397403e9597c54977f2
Reviewed-on: https://chromium-review.googlesource.com/959226
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542535}

They simply truncated x, y, width and height to integer, which may not
be what we want and may hide some errors.

The usages of them may be in the following cases:
1. The input rect is already in integral geometry, so all methods of
   IntRect conversion will get the same result;
2. The IntRect is just used for informative purpose so differences of
   1 to 2 pixels at the edges don't matter.

We should use EnclosingIntRect(), EnclosedIntRect(), etc. to explicitly
specify the way to convert.

Convert the usages of them to
- EnclosingIntRect if we are getting a visual rect or a rect that needs
  to cover the input rect;
- Floored size for page size when printing to keep the original behavior.
- PixelSnappedIntRect or RoundedIntRect for others.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ifc81334e39db105d32a046cfa868baa35340a479
Reviewed-on: https://chromium-review.googlesource.com/949571
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542534}

https://pdfium.googlesource.com/pdfium.git/+log/0e2e8db7e6e8..735eda96cf24

$ git log 0e2e8db7e..735eda96c --date=short --no-merges --format='%ad %ae %s'
2018-03-12 rharrison Remove all usages of FXSYS_iswASCIIalpha
2018-03-12 rharrison Remove all usages of FXSYS_iswASCIIalnum
2018-03-12 dsinclair Handle inserting negative values without a selection

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I6476233762914a1c9b23ecca6dc7044e85191e36
Reviewed-on: https://chromium-review.googlesource.com/959119Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542533}

The Ready callback passed to SetReadyCallback is executed
on the task runner thread, and not the UI thread.

This causes a crash in startup when launching Chrome.

Also adding a DCHECK to catch this in tests in the
future.

Bug: 820925, 734095
Change-Id: I59d2b152bbc6538d857f3e6884544217b347885e
Reviewed-on: https://chromium-review.googlesource.com/959017
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542532}

This reverts commit bae82629.

Reason for revert: Breaks Linux Builder (dbg):
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29/121988

Original change's description:
> Reland "Don't have two copies of //device/fido."
> 
> This is a reland of e23bd4d7, now without
> `dllimport`-annotated classes with inline MOCK_METHODs.
> 
> Original change's description:
> > Don't have two copies of //device/fido.
> >
> > Prior to this change, both libcontents.so and content_unittests would
> > each have a copy of //device/fido because the test_support code would
> > pull in a copy directly. This caused there two be two copies of
> > |U2fDiscovery::g_factory_func_| – one used by the test_support code and
> > one by the code that's used for actual processing. That obviously breaks
> > things.
> >
> > This CL makes //device/fido a `component` instead of a `source_set`,
> > which, however, necessitates adding COMPONENT_EXPORT annotations to all
> > exported classes/functions/constants.
> >
> > The CL also cleans up the components by:
> >  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
> >  -- moving dependencies included in public headers into `public_deps`.
> >
> > Bug: 785955, 820441
> > Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
> > Reviewed-on: https://chromium-review.googlesource.com/955698
> > Commit-Queue: Balazs Engedy <engedy@chromium.org>
> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Reviewed-by: Adam Langley <agl@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#542472}
> 
> TBR=jdoerrie@chromium.org
> 
> Bug: 785955, 820441
> Change-Id: I9ed13c7d1105f133c5f54cce7f0a4d74f1d57904
> Reviewed-on: https://chromium-review.googlesource.com/958863
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542523}

TBR=agl@chromium.org,engedy@chromium.org,jdoerrie@chromium.org

Change-Id: Ib21d588a4db7d1b3eed53f44d1ff82f4eb2ef8a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785955, 820441
Reviewed-on: https://chromium-review.googlesource.com/959242Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542531}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7e11bad4..fbbe951b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ia4647d0b841e3417f480583f9586c5c6ffa298e4
Reviewed-on: https://chromium-review.googlesource.com/957914Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542530}

A large amount of time hit testing is spent converting LayoutRects
to IntRects for the purposes of intersecting. This patch updates
HitTestLocation's bounding_box_ rect to be a LayoutRect which is
consistent with the LayoutPoint point and reduces conversions.

With this patch, blink_perf.events.hit-test-lots-of-layers improves
by between 2% and 5%.

Bug: 818772
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic3bc3b846b89e392b7b9f29a6affb42a5be81152
Reviewed-on: https://chromium-review.googlesource.com/957363Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542529}

This is a direct result of the Find Bar moving to under the OmniBox like a bubble and the added margins/spacing from Harmony.

Bug: 805806
Change-Id: Ib618cb80148dd02c24e8f7cae5a011439813d4ea
Reviewed-on: https://chromium-review.googlesource.com/926715Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542528}

The SchemeHostPort always considers tuples with SCHEME_WITHOUT_PORT to
have empty hosts without being invalid (to cater to cases like file
schemes which can have hosts or not).

This led to a mismatch in SchemeHostPost::GetURL where we always
considered URLs with empty hosts to be valid GURLs, but this is not an
assumption that holds true. This CL just punts the valid decision in this
case to GURL for re-parsing, since it should be a rare occurance.

Bug: 820194
Change-Id: I3f4441d8c71a9b9500c71dbe98f0769f42ad13b5
Reviewed-on: https://chromium-review.googlesource.com/956424Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542527}

This reverts commit cdcb0262.

Reason for revert: We believe that this causes the tests to flake on various platforms, due to issue 816620. We'll re-land it when the mojo::edk::Channel fix has landed.


Original change's description:
> Add missing message-received expectation to IPCMojoBootstrapTest.
> 
> Some of these tests expected a message from the child process, and would
> verify that it was valid/invalid as expected, but would still pass if
> no message were received at all.
> 
> Bug: 816620
> Change-Id: Ie8acf85086f4416c7023118673c40d00a2e190d7
> Reviewed-on: https://chromium-review.googlesource.com/955554
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542296}

TBR=wez@chromium.org,rockot@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 816620
Change-Id: I534fa23c12072cf08507ed4c8073e7505edaf262
Reviewed-on: https://chromium-review.googlesource.com/959241Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542526}

Fix 1:
If app_list_controller_ is not ready, which means the model adapter is
inactive, we add this item in Chrome first.

Fix 2:
While sending a whole trunk of model data to Ash, we also send folders
in case folder information was updated.

Bug: 733662
Bug: 820873
Change-Id: I60aa899acff2a5a5203496498b278f2d6e6cfddb
Reviewed-on: https://chromium-review.googlesource.com/958244
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542525}

Bug: 793323
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id1cb2ae98a0969fe324e3c521e6414c81152d23b
Reviewed-on: https://chromium-review.googlesource.com/957427Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542524}

This is a reland of e23bd4d7, now without
`dllimport`-annotated classes with inline MOCK_METHODs.

Original change's description:
> Don't have two copies of //device/fido.
>
> Prior to this change, both libcontents.so and content_unittests would
> each have a copy of //device/fido because the test_support code would
> pull in a copy directly. This caused there two be two copies of
> |U2fDiscovery::g_factory_func_| – one used by the test_support code and
> one by the code that's used for actual processing. That obviously breaks
> things.
>
> This CL makes //device/fido a `component` instead of a `source_set`,
> which, however, necessitates adding COMPONENT_EXPORT annotations to all
> exported classes/functions/constants.
>
> The CL also cleans up the components by:
>  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
>  -- moving dependencies included in public headers into `public_deps`.
>
> Bug: 785955, 820441
> Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
> Reviewed-on: https://chromium-review.googlesource.com/955698
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Adam Langley <agl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542472}

TBR=jdoerrie@chromium.org

Bug: 785955, 820441
Change-Id: I9ed13c7d1105f133c5f54cce7f0a4d74f1d57904
Reviewed-on: https://chromium-review.googlesource.com/958863
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542523}

In trying to change the Cronet sample app to use jars from the
cronet/ output directory I ran into various GN errors about
duplication of output files.  I worry from my crbug.com/816981
experience that this could be causing underlying issues, so
I'm proposing this change to address it here.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I5f05d54b2e6c06f7addad3894e576c7ba6c80dac
Reviewed-on: https://chromium-review.googlesource.com/959142Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542522}

This reverts to a pre crrev.com/c/726079 state, while ensuring that changes related to interactive doodles, the one google bar, using css variables, etc are not affected.

Bug: 812065
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I336351f35077cacecf4682bddfa47322db882eba
Reviewed-on: https://chromium-review.googlesource.com/950105
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542521}