- 19 May, 2020 33 commits
-
-
Yichen Zhou authored
Add histograms for tab dragging in clamshell mode. Bug: 1032766 Change-Id: I33b9a39598ff06aa2c343a86e5e2effa79523d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199501 Commit-Queue: Yichen Zhou <yichenz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#769943}
-
David Tseng authored
Bug: 1084359 Change-Id: I4d81939f0425e41cc4bf7747b04fac4dcbd8d349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208076 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#769942}
-
Hirokazu Honda authored
There is no way to specify codec profile that VideoEncodeAccelerator must produce in video_encode_accelerator_tests. This adds the command line option to specify it. Bug: 1045825 Test: video_encode_accelerator_tests on eve Change-Id: Iaaea9443abac4d6e1d6dd0ad8950538ea90185f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203556Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#769941}
-
Kelvin Jiang authored
This CL adds priority checking between matching modifyHeaders and allow/ allowAllRequests rules in an extension. Currently, if there is a matching allow/allowAllRequests rule, it will override any removeHeaders rules since removeHeaders rules don't have priority. Since modifyHeaders rules have priority, within an extension, the matching allow/allowAllRequests rule with the highest priority should override modifyHeaders rules with equal or lesser priority. Bug: 947591 Change-Id: Ifc8e4e18ea1d33811d4458574e474603cea44461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172640 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#769940}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3a999dcd95fd..4e79dd6ea5f3 git log 3a999dcd95fd..4e79dd6ea5f3 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 michael.liao@microsoft.com [Network Project]: Failing failure when attributionInfo is undefined Created with: gclient setdep -r src/third_party/devtools-frontend/src@4e79dd6ea5f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1082944 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9a5e138f65e777b33af46fcce726a5a45f44746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769939}
-
Sinan Sahin authored
AutofillAssistantCollectUserDataIntegrationTest#testEnterPayment AutofillAssistantPersonalDataManagerTest#testCreateAndEditProfileMultipleTimes TBR=marianfe,sandromaggi Bug: 1084324, 1084191 Change-Id: I3ca3cfc4479e59d5653c4387f9ed04c3e348682f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208253Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#769938}
-
Maggie Chen authored
TBR=kbr@chromium.org Bug: angleproject:4641 Change-Id: Ibc556e198ed1f12874a30bb4d4f8293ae5835ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208350Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#769937}
-
Natalie Chouinard authored
Remove workaround no longer needed due to K deprecation. Update documentation based on linked bug's current status. Bug: 1009058 Change-Id: I7cd585108d543d13158101a74b4cc5e78cbc34d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207626 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#769936}
-
Alexander Cooper authored
Updates the expiration date for a still-useful and in-use webxr metric by 1 year (per guidance for metrics that seem like they'll be useful indefinitely). Additionally, marks one metric that has already been removed from code as obsolete. Finally, replaces cassew@ with alcooper@ as owner for VR metrics, since cassew@ no longer works on VR. FIXED: 1084129,1084126 Change-Id: Ied4b89d9cef8a8bb95f83b579b5855d2efcc8e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208083 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#769935}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I18f0d149fdc083547b950f2cf7d998174df99dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769934}
-
Charlene Yan authored
This makes collapse looks slightly more useful. Without this the underline make the tab group still look not collapsed. This will need more work to spec, but thought it was a nice update. Bug: 1018230 Change-Id: I22343f34aea7d9f42e2a1cfd8205643973e50686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207504 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#769933}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/275a95c1dc64..e25ee25e7743 git log 275a95c1dc64..e25ee25e7743 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 bryan.bernhart@intel.com D3D12: De-duplicate sampler heap allocations. Created with: gclient setdep -r src/third_party/dawn@e25ee25e7743 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibcb65bf3d1c8dd129112218e9ad08a336e9c5127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769932}
-
Jon Mann authored
Change-Id: Ic8739fb31e786fb31f3e87ebc90a4b04d93691d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207622Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#769931}
-
My Nguyen authored
Stop showing tab to users after they have accepted the suggestion 10 times. Doing this by adding a pref value. Bug: 1081940 Change-Id: Ibbc9d8c3a7e5fcc03d3e1d0a6a2b92ae110b0c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196883 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#769930}
-
Dan Harrington authored
If the feature isn't enabled, make sure the background task doesn't keep running. Bug: 1044139 Change-Id: If1b9760c38570e3d278ebf078732859cdc941b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191271 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#769929}
-
Bailey Berro authored
This change updates the default input node gain to 50.0. Previously, the default input gain was the same as the default output volume, which is 75.0. Bug: 1083139 Change-Id: Icec8c175dbe2246d5693d61a961043d3a92b50b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204556 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#769928}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/293e1d8f8ba7..dbcf680f8fd3 git log 293e1d8f8ba7..dbcf680f8fd3 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 johnstiles@google.com Fix rendering of very-thin dashed lines when MSAA is enabled. Created with: gclient setdep -r src/third_party/skia@dbcf680f8fd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Iec454293d654f1fbc8107e76809a8994062621b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208006Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769927}
-
Bailey Berro authored
This change reapplies the mic gain value when the device starts up. Previously, the stored pref value was not applied on startup, so the UI and the underlying audio service were out of sync. Bug: 1083149 Change-Id: I422beb14f439ddd0fc36737e677125a48a0c9bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208092 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#769926}
-
Brian Sheedy authored
Rolls the goldctl revision DEPSed in via CIPD to pick up recent changes to fix the auto-triaging behavior with inexact matching. Bug: skia:10245 Change-Id: If5c915454eaa4b0b0bcc138ec54f9aa4634b29b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208096Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#769925}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec4698056847..3aab09d9c915 Created with: gclient setdep -r src-internal@3aab09d9c915 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029357,chromium:1044639,chromium:1083498,chromium:1083858 Tbr: tluk@google.com Change-Id: I49c0a9fca8e0cc346e46b4581622d08d56b350bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207852Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769924}
-
Saurabh Nijhara authored
This CL adds the handling for non critical updates (warning time greater than to zero) for the policy MinimumChromeVersionEnforced. A timer is started based on the current warning time which triggers when the deadline is reached. To persist the deadline across reboots, 2 new prefs are stored in the local state - one for timer start time and the other for warning time. According to the policy requirements, the warning time for a user cannot decrease for good user experience. When a new policy is received and update is required, the policy handler calculates the new deadline using the already existing timer start time from the local state (if it exists). The local state is updated with the new pref values and a timer is started to expire when deadline is reached which then blocks user session. The policy handler also observes BuildState for any updates in Chrome version. If Chrome is updated before deadline, the timer is stopped and update is no longer required. The CL does not fully implement the policy. Subsequent CLs will handle other cases of this policy like showing in-session notifications in case of EOL and network limitations. Bug: 1048607 Change-Id: Iddd3966a316b4f48417c3b8aeddefd70597f6799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189150 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769923}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/75cc116fa06d..be66dc5fd0e3 $ git log 75cc116fa..be66dc5fd --date=short --no-merges --format='%ad %ae %s' 2020-05-18 dalecurtis Update patches for memory leak fix. 2020-05-18 dalecurtis Free temp buffer upon negative sample_size error. Created with: roll-dep src/third_party/ffmpeg TBR=sandersd Fixed: 1083880 Change-Id: I678a50bf0b0f842ea25bb72ced5cc8c5b636f63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208093Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#769922}
-
Tibor Goldschwendt authored
This flag allows us to run experiments where the realbox is enabled but search suggest chips are disabled. Bug: 1082535 Change-Id: I50973578f96bde82654fdd23f7d8a0c9c15d601a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208079 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769921}
-
Nate Chapin authored
Bug: 1083623 Test: fast/canvas/canvas-toBlob-in-detached-document.html Change-Id: I9286d6e6e568a1faf7dcb99e2ea4b252b88aff0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207792 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#769920}
-
Thomas Lukaszewicz authored
Disable flaky media/video-aspect-ratio.html blink_web_test due to failures on Windows. TBR=chrishtr@chromium.org Bug: 963141 Change-Id: Icfd109600023f2cb0d5df5ff62e84f747a0e5d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208086Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#769919}
-
Jared Saul authored
Change-Id: I1e0085f57d839f0d34e16de191678dc6a2564d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188890 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#769918}
-
Maggie Chen authored
TBR=kbr@chromium.org Bug: angleproject:4641 Change-Id: I92e20c3a3c64f8481fc1f0671827ac689da23edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208179 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#769917}
-
Nate Chapin authored
Bug: 1083720 Test: fast/events/detach-frame-in-mousedown.html Change-Id: Ie44f1820756561af513595a1a2abefc3976ed889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208170 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#769916}
-
Dale Curtis authored
Chrome doesn't have monochrome pixel format support, since we expect this usage to be rare, just create fake UV planes for these video types. Also adds test data and hashing for a couple of existing tests which was disabled at launch. Fixed: 1083840 Test: New unittests. Manual inspection. Change-Id: I3b30d4da30abc4c39bbdc1f5f611ca56b229d710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208012 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#769915}
-
Liquan (Max) Gu authored
Context: Total is a field in the "new PaymentRequest()" API. It specifies the amount and currency of the payment request. However, when the merchant requests for the app-store billing (e.g., Google Play Store billing - by specifying "https://play.google.com/billing" as the method), the total field becomes unnecessary. This is because app-stores takes the total from elsewhere. Before: The total field is mandatory for PaymentRequest. After: The total field is optional if only app-store methods are requested. When total field is optional and left out, Chrome would add a total of amount 0, currency "ZZZ" and label "AppStoreBillingTotalPlaceHolder". Change: * Added a RuntimeEnabledFeature: PaymentRequestTotalOptional * Added an about flag: payment-request-optional-total * change the optionality of the total field and details field of PaymentRequest API. Related Doc: * Chrome Status: https://www.chromestatus.com/feature/5226111782879232 * Intent to Prototype: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TJVn0Ps9ugA/3unr2Vo8AgAJ * W3C explainer: https://github.com/w3c/payment-request/issues/912 Bug: 1066531 Change-Id: Id5ad87b9fc452fd41a1ebef066d981737545a235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150974Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#769914}
-
Xinghui Lu authored
Bug: 1058431 Change-Id: Id831530b726e63cfcba71dbcb86af8bf00e11dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198536Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#769913}
-
Brandon Jones authored
Bug: 1079007 Change-Id: If8e0addde48f51d5b02b79cb268740a752f98b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204549Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#769912}
-
Kurt Horimoto authored
This helper class stores a copy of an UnsafeResource while its allow list decision is pending. When the pending decision is finished (either by allowing or disallowing the threat), the resource is reset. This CL also adds a new util function that returns the allow list for an UnsafeResource. Bug: 1083557 Change-Id: Iec9e32fdc68a59f43c98c33e2f04f1ee2f5f5bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205115 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#769911}
-
- 18 May, 2020 7 commits
-
-
Hesen Zhang authored
- Fixed fetcher crash because ResourceRequest was null if a second request was asked but it was build in ctor. - Fixed a wrong usage of OneOffTaskInfo window. - Added unit test to verify the start/end window and backoff delay in task info. - If debug switch instant fetch on, we always schedule a fetch task on service startup once, don't do recurring fetching task. Bug: 1083532 Change-Id: I8c1a29bc7c7692b6c59a2de958589b41ca7957c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207616 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769910}
-
Jiewei Qian authored
The original CL that introduced the install duration metric contains one typo, which cause the reported value to be the additive inverse of the actual time. Because UMA clamps this value to be within 1 millisecond and 3 minutes, we always see 1 second in the UMA dashboard (and contradicting metrics that some installation times out). Fixed: 1083894 Change-Id: I7529bfb90fc737016d7c9948a7b8b6325ecb24a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207375 Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#769909}
-
Yusuke Sato authored
They are no longer used. This CL depends on https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2206261 BUG=b:155128030 TEST=try, arc.Boot.vm Change-Id: Iec89dac8bb9f16f7bcf3c4379261b1b8830dcbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206496Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#769908}
-
Sinan Sahin authored
TBR=nsatragno,manasverma Bug: 1083360 Change-Id: I7ea0d8d27b8241a171fec6452056c957cb4cc3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207989 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#769907}
-
My Nguyen authored
As an enterprise policy is required for emoji suggest addition, adding preference's value first. Bug: 1077629 Change-Id: I4a55ddc861c4c2216742c92cd90bd0c892ae0bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175762 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#769906}
-
Anders Hartvoll Ruud authored
This CL adds functionality which collects the observed dependencies for a given ComputedStyle. This is currently collected in three cases: - When "inherit" is applied for non-inherited properties. - When any property depending on direction/writing-mode is observed (i.e. css-logical properties). - When any CustomProperty is referenced. The properties observed in the above cases are stored in a HashSet on StyleResolverState, which is then later propagated to the MPC when the entry is added. The functionality is added behind a flag 'MPCDependencies'. Bug: 1057072 Change-Id: I59fc8d9faa7f9c417e0df0e37639840166869976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193587Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#769905}
-
Thomas Lukaszewicz authored
This reverts commit cfba7924. Reason for revert: Tests failing on the Linux ChromiumOS MSan Tests bot: - BrailleDisplayPrivateApiTest.WriteDots - BrailleDisplayPrivateApiTest.KeyEvents https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/19188 Original change's description: > Reland: Plumb through an api to get display cell size from brltty > > |cell_size| was not initialized during the test which expected it to be. The parameter is optional according to idl, but in this context, it probably should be initialized. > > Original change > https://chromium-review.googlesource.com/c/chromium/src/+/2206198 > > TBR=dtseng@chromium.org > > Change-Id: I744c7b567cf2c4d27653f4368edc9c0f635d7d8d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207412 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769736} TBR=dtseng@chromium.org Change-Id: I07143ad331dcb627ddd4a768525c1caf5330a70c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208103Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#769904}
-