- 26 Oct, 2020 40 commits
-
-
Andreas Haas authored
This CL brings WebAssembly UMA metrics to the v8-browsing benchmark in Telemetry. R=mythria@chromium.org, clemensb@chromium.org Bug: chromium:1084929 Change-Id: I28e72378774c3d599da1ad670ba036a3f0ea84e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497164Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#820779}
-
Reda Tawfik authored
Bug: 1138612, 1104132, 1006430 Change-Id: Ie9cb6105cb7612f56caa2d23b4cae010702f443d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497441 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820778}
-
Rohit Agarwal authored
This CL also adds test for non primary OTR profiles and refactors the tests as well. Bug: 1060940 Change-Id: Idd05876d98a058d0695829d75561aec9a2b67277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494868Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820777}
-
Bruce Dawson authored
The bisect-builds.py script is easier to use if the good and bad points can be specified as M85 (stable branch releases only) or 85.0.4183.121 instead of just 782793. This change adds support for translating stable milestone numbers into their most recent version numbers, and translating version numbers into commit positions (also known as revision numbers). Bug: 1141177 Change-Id: I0526ab4d1b472558d9c93e26c8561a8ef7f31277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491052 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820776}
-
Lily Chen authored
This removes the features: - kRecentHttpSameSiteAccessGrantsLegacyCookieSemantics - kRecentCreationTimeGrantsLegacyCookieSemantics which would modify SameSite cookie access semantics based on how recently the cookie was accessed or created. These features were never enabled, experimented with, or standardized, and are now obsolete. Bug: 1029099, 1029098 Change-Id: I0e91a29447f8a7579f1247797eb7aa644762390a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495350Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#820775}
-
Christian Dullweber authored
Replace dozens of content setting specific functions with generic functions. Change-Id: I52d5058ed1b6e1fd7f69baf25813ced83ad17ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494936 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820774}
-
Patrick Noland authored
Bug: 1140998 Change-Id: Ibf5c415e21cc0fd974be55c2628c712ba7205c9e TBR: aluo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499163Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#820773}
-
Hirokazu Honda authored
This is a reland of 8a1b573d Original change's description: > media/gpu/vaapiWrapper: Add WARN_UNUSED_RESULT to critical functions > > This adds WARN_UNUSED_RESULT to VaapiWrapper functions whose > result should have the critical impact enough to regard its > failure as video processing fatal. > VaapiVideoDecoder actually doesn't handle the failure of > VaapiWrapper::CreateContext. This CL also fixes it. > > Bug: b:171536540 > Test: Build media_unittest and vaapi_unittest > Change-Id: Iba6924849bfe8627fd328c3541c7a2c5cb0f0371 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493742 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820164} Bug: b:171536540 Change-Id: Ia10cad9549d099d1823419647f0f6473b6bc24dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497964 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#820772}
-
Sigurdur Asgeirsson authored
This is lifted from Pat's change at https://chromium-review.googlesource.com/c/chromium/src/+/2355089 Bug: 993029, 1088353, 1121069 Change-Id: Ibdc91c07a235be347cbe1704f0fe5e77cff73470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490221Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820771}
-
Ramin Halavati authored
Adds three browser tests for ephemeral Guest profiles. Bug: 1125474 Change-Id: I0a110ed75eef13a664f95e86628749c9ffecda38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489632Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#820770}
-
Ewann authored
This CL adds detailTextColor property to SettingsImageDetailTextItem and some unittests. It also replaces TableViewItem refererences by SettingsImageDetailTextItem in the SettingsTableViewController. Bug: 922511 Change-Id: I56ec9e5a841f30510505630de65a8e97b58c02f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461113 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#820769}
-
Nico Weber authored
We don't currently need it, and cmake currently fails when it's on. Bug: 1142191 Change-Id: I76a75c04884c57afb49f2f5d0ff989ada0c32d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497807Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#820768}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d039126f32d..ac42b7968549 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cfroussios@google.com,avi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139339 Tbr: cfroussios@google.com,avi@google.com Change-Id: If51173498986decdc71965fea01db0c4b4f30f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498841Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820767}
-
Steven Bingler authored
Add feature to kEnableExperimentalCookieFeatures. Update test expectations for failing tests. Invert virtual test to check disabled feature code paths for regressions. Update a failing test to match expected behavior. Bug: 1030938 Change-Id: I65d42efcc79c2601129b7df441968b9bb868b488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493261Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#820766}
-
Maria Kazinova authored
unique_renderer_id. Though unique renderer IDs are already available for iOS Password Manager, I noticed they were not used in fetching the right field in server predictions processing in FormDataParser. Change-Id: Id67a520a94c3a53ab4cd9b02d7c840d0235c5468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498601Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#820765}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aea82732415c..c493eabd56d0 2020-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ade9a5235c73 to 42103bc2e911 (12 revisions) 2020-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e47bf15e to d37162e0 (552 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: Ida430fcb5dd0e144645cc2cfba3650efa1cd3fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498788Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820764}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2c2f19bc. With Chromium commits locally applied on WPT: 2c2f19bc "[mathml] Support scriptlevel attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Icf304b76a61e443dbb3b8f01f365a8c44cd68d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497152Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820763}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/73fe59b5..da8c46c5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d51a459f6dfae19bdf33282d61580076ae4263c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497805Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820762}
-
Ken Rockot authored
This test was disabled due to flake. The flake was caused by a bug which was fixed by crrev.com/ae1a0ae1 quite a while ago. Fixed: 995181 Change-Id: Ic1afcbb3b25cdcf70d6179bf365dc4729e1c451d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495512 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#820761}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010260700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/d_W31KKgRgYuvgrFL3we1kiiq2UPrniL8Q6CCbFkclAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165720635,b/171275495 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia260895dcdcae8741cd2445944ff43d04376b1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498842Reviewed-by:
-
Titouan Rigoudy authored
These requests are not blocked by content/, so there is no point in counting them in Blink. When we get closer to having a plan for these requests, we will want to revisit this so as to gather data. Bug: chromium:1129326 Change-Id: Ib5829385727db3a29955c5246aa9c0ce07d55f09 Fixed: chromium:1134601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489918 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820759}
-
Jan Wilken Dörrie authored
This change adds C++ syntax highlighting to the code blocks found in //docs/pattern and removes unnecessary leading whitespace. While this highlighting is not visible in Code Search's markdown view, it is supported when viewed through gitiles: https://github.com/google/gitiles/blob/master/Documentation/markdown.md#compiled Bug: None Change-Id: Id2d4298fc69f57b7abe1aa589f547221785791ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494580Reviewed-by:
-
Chris Lu authored
The PasswordInfobarModalOverlayRequestCallbackInstaller class was written to handle both Save and Update Password Infobar Overlay actions. However, this caused problems with the overlay callback manager logic, which executed all callbacks that matched a request's config. Thus, each PasswordInfobarModalOverlayRequestCallbackInstaller instance needs to know which Password type it is handling, so that it can only handle logic if the triggering request was of the same type. Bug: 1141708 Change-Id: I12a6eb14a30ed9308c58a1cd7a1568da9736cb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493433 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#820757}
-
Illia Klimov authored
As part of http://crbug.com/1064647 this CL removes Flash from the Settings page and UI tests. Bug: 1133888 Change-Id: Iabe202b9d1c3529b117a4ec045bddb689cc80f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461344Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#820756}
-
Stephane Zermatten authored
With this change, it becomes possible, in Selectors, to evaluate a CSS expression against an element that was found previously and weed out elements that don't match that expression, such as: filters { css_selector: "label" } filters { inner_text { re2: "text" } } filters { labelled {} } filters { match_css_selector: ":checked" } This is necessary for the "check box" actions, that guarantee that they're going to check the checbox, not uncheck it. Currently, scripts cannot use labelled checkbox, because they can't figure out whether clicking on them will check or uncheck them. This change also allows checking the type of elements found with labelled: filters { css_selector: "label" } filters { inner_text { re2: "text" } } filters { labelled {} } filters { match_css_selector: "input[type='checkbox']" } Bug: b/171537366 Change-Id: Ifc9475b00d2ddf526c62ecca70aae5905ad5c093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494931 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#820755}
-
Nicolas Ouellet-Payeur authored
This objects holds an sql::Database, so its destructor can do IO. But it was destroyed on the UI thread. Bug: 1141999, 88586 Change-Id: I5ad15deaf7eb3ab5c234d1d4b629dc65216d780b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495351Reviewed-by:
-
Olesia Marukhno authored
Background::get_color() doesn't return the actual color for painter background. This caused wrong color for the dark theme. Also updated ink drop opacity because now buttons match row background. The base color now is darker so it would be darker than row background with default hover opacity. Bug: 1133847 Change-Id: Iaa942fbd4dc133cd64a671c105c31c45919c14ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498602Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#820753}
-
Nektarios Paisios authored
This is the only remaining occasion, as far as I can tell, where we are still forgetting to set the parent of a child object properly. All other cases have been fixed either by my previous patches or by patches recently authored by aleventhal@. Also added a few DCHECKs in AXSlider and AXMenuList. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I22af3f276cc325a71968f6b2956d17120ce03320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356484 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#820752}
-
Ramin Halavati authored
Incognito mode is not available in ephemeral Guest profiles, but other OTR profiles are allowed. Bug: 1125474 Change-Id: I78f5b86f11dac8572ab5198cb8e07012e87fd4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494940Reviewed-by:
-
Victor Hugo Vianna Silva authored
Before this CL, upon sign-out, Sync.StopSource was recorded both in the SIGN_OUT bucket and in one of the auto-sync buckets, i.e. ANDROID_MASTER_SYNC or ANDROID_CHROME_SYNC. This CL fixes this by adding a check for whether there's still a primary account by the time the auto-sync buckets are recorded. Bug: 1140912 Change-Id: Id00d0da70571a05c19af50a576b8cb1cb60ad2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495145Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#820750}
-
Christoph Schwering authored
This CL uses FieldRendererIds to retrieve an AutofillField from the FormStructure cache of AutofillHandler. Before this CL, the first AutofillField that satisfied SameFieldAs() was considered a hit. For forms with multiple identical fields, this may have been a false positive. In particular, this fixes the filling of the wrong section in forms like billing+shipping forms with multiple identical fields. Bug: 1141847 Change-Id: Ib95aef11be43ece7db001eb02c495ac14cc21685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495063Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#820749}
-
Marc Treib authored
"Model association" was a directory concept that doesn't exist anymore in the USS world. This CL renames the ModelAssociationManager class according to what it actually still does. Bug: 1102837 Change-Id: I66f07a6cd1726fef794b3c11d69ba89bd54d24d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497174Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#820748}
-
Jan Scheffler authored
This patch disables a test that blocks landing the following cl: https://crrev.com/c/2466187 Bug: chromium:1093791 Change-Id: Ibb9c14b30f346d6bda0a0b67bed1b3593b0aab55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498504Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::PositionForEndOfLine()| to use first or first item in line instead of hit-testing at inline start offset[1] of line box to handle position:relative[2], correctly. This patch is similar to the CL[3] which changes |PositionForEndOfLine|. [1] inline start offset: left-top offset for horizontal writing mode with left-to-right direction. [2] position:relative items can be outsize of line box or any point in line to place first item at last item. [3] http://crrev.com/c/2467046 Make NGInlineCursor:: PositionForEndOfLine() not to use hit-testing Bug: 1136740 Change-Id: I5004c8d9c32b89bd3d6e2d3f7031350e1777a804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497742 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#820746}
-
Matt Jones authored
Bug: 223587 Change-Id: I1b61f97f9c864d467593c490fa4fc5b7efd16989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493001Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#820745}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/08c34aef9625..b5ba693316fd 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8012e62471be to bb66fa41a163 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Id46802a16f2bb93083ed2a920fe81f300227fe98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498782Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7031d066796ec3be3cf8ac98b71eea09c199f852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498785Reviewed-by:
-
Rohit Rao authored
BOOL and bool are equivalent on arm64, but they map to different underlying types on other platforms, such as Mac Catalyst. BUG=1142431 Change-Id: I871e83e958ddc4619da634a972036599fc6d02db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498801Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#820742}
-
Leo Lai authored
A good reason to fix this typo is to apply gtest_filter with right spelling to include such a set of test items. BUG=b:158955123 TEST=unit_tests with filter as *CertProvision"; observe that the test items increase. Change-Id: Ide1389d59d40676b0bda001102a221280f366c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497385Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#820741}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603691326-ded4cf98fc57f32e31937f939ee80f292f889c4d.profdata to chrome-linux-master-1603713364-255d86fa5592c315dc7718e8b4c93f0ba1279e07.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie15332a756a6f35ed2804fcff061da0d269ffc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498786Reviewed-by:
-
