- 08 Jan, 2021 40 commits
-
-
Chris Cunningham authored
API and motivations described here: https://github.com/WICG/web-codecs/issues/98 Spec PR here: https://github.com/WICG/web-codecs/pull/120 Bug: 1141707 Test: new layout tests Change-Id: I3e53da5961119b4b36ec76666ad1a67cca19b963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612684 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#841376}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610052964-a33bb7f09ef1aa4be028cda8573fe902d004ec4a.profdata to chrome-win64-master-1610063718-6db51055255b71b3272f9db93116d992601c9633.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7524bcb489a28cfe1ccaa73831cba89c21f75af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841375}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e33046d8bd5..d39c0ebe595d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: qjw@google.com Change-Id: Iea0f21cf0c2a83655158fc2d9c4bb1a92ca7b542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617300Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841374}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d87c3006..4d379d2f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If4d7bfc57f594f566966b444af8f9ab608ac7e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617137Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841373}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610052964-246b43420c64aac53ecf14d1b97c19dc58b69e86.profdata to chrome-win32-master-1610063718-47f197c900d6e73c3c9b6aad05d4a947c6371a56.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I98e97b361e99104ccca27e3bbaf8ee50c7c4c7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616923Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibc7bab91b96364e35308205bcd6abbe8babb1224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616920Reviewed-by:
-
Bartek Nowierski authored
My crrev.com/c/2601894 broke the code, because it stopped reserving memory for PCScan on 32-bit, without realizing that PCScan still runs in Blink on 32-bit. The problem occurs only if PCScanBlinkPartitions experiment is on. Bug: 11297512, 1163824 Change-Id: I3a116d3b33ea3f83db1e413d3ae12005a07980a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617402 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841370}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I09c4298cbbeca724dde94b2e01df9177cd5e79b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617538Reviewed-by:
-
Alan Screen authored
This reverts commit ef8825ff. Reason for revert: A reliable method for reproducing this behavior has been identified in b/176864633. Remove this induced crash to reduce the impact being caused to a larger number of users while we work on moving forward with a proper fix to the underlying issue. Original change's description: > Turn a DCHECK() into a CHECK() in WebLocalFrameImpl. > > Turn |blink::WebLocalFrameImpl::is_in_printing_| from a variable only > used for DCHECKs into one that is always CHECKed. Do this to help debug > a printing crash that happens to users but not with any printing tests. > > Bug: 1121077 > Change-Id: Ieac894c4efdb67f028de13fc2a4bf5ed3a84c258 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373217 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801268} TBR=tkent@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121077 Change-Id: I551fbc8229eea16d6a5cd95bf9306a6a0e0a9f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616878Reviewed-by:
Alan Screen <awscreen@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841368}
-
Dale Curtis authored
R=chcunningham Fixed: 1164070 Change-Id: Ib3227d36de787bca195cffdb500f3688b3209cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616999 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#841367}
-
Etienne Bergeron authored
On windows, the Timezone modifications is detected by listening to WM_TIMECHANGE event but that event is emitted for any time property change. We are observing in slow-reports that on power suspend/resume that event is always sent (one or more time) which is triggering multiple Timezone notification to be sent to observers (a.k.a renderers). The proposed solution is to filter the time change by ensuring the platform specific timezone has changed. We do not rely on ICU timezone API since it's heavy to be added on the startup path. The goal is to detect platform changes to filter out the time change events. R=gab@chromium.org,fdoray@chromium.org,mark@chromium.org Bug: 1074036 Change-Id: I296e0735a04d6258a659688a987c58399d4c7ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583012 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#841366}
-
Tal Pressman authored
Change-Id: I28900d4ca5da0d1683828fb82fdb12e88386a1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617478 Commit-Queue: Tal Pressman <talp@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Tal Pressman <talp@google.com> Reviewed-by:
-
Luciano Pacheco authored
Manually checked that there were no JS errors in the background page. Test: browser_tests --gtest_filter="*FilesAppBrowserTest.*" Bug: 1133186 Change-Id: I71790b232204d09424ee7b7383ebad6e4bbaf596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612677Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#841364}
-
Ken Rockot authored
This was fixed for StorageAreaImpl usage in the Local Storage implementation, but Session Storage was overlooked. It turns out that Session Storage namespaces also own StorageAreaImpl objects, and these too can outlive their backing database. This ensures that the map of namespaces is cleared before SessionStorageImpl resets its database, avoiding the UAF. Bug: 1152800 Change-Id: I946841b20fa73754e8b8ac611b352db0319ce4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617239 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#841363}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: I0e15ab92a8925677b8d1e1462ddfda585ae44824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612877Reviewed-by:
-
adafang@google.com authored
[launcher-result-normalizer] Integrating into zero state providers and experimenting with normalizers Scores from providers have different distributions and ranges, this makes them difficult to compare. Here we have implemented a basic way to normalize ChromeSearchResults by subtracting the mean of the learned distribution. After experimentation with more complex normalization methods we will then update this normalization method. Further details at go/cros-launcher-normalization In this CL we have integrated the normalizer into the omnibox provider, drive zero state provider and zero state file provider Bug: 1156930 Change-Id: Ic232efb0b31eb712959b6d386b39366ff4c38a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601357Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Ada Fang <adafang@google.com> Cr-Commit-Position: refs/heads/master@{#841361}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/db2dad5c644f..f4ea30580c91 2021-01-08 reed@google.com Revert "Cache ICU break iterators in SkUnicode_icu" 2021-01-08 reed@google.com Always lerp when post-rotating tile in pictureshader 2021-01-08 csmartdalton@google.com Make Comparator& refs in GrTriangulator const If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I98d0ab1e5179ce43b07da8f10853dcb351dd528b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617207Reviewed-by:
-
Leonid Baraz authored
Signature is now mandatory in storage, when encryption is enabled. Bug: b:170054326 Change-Id: If0720332dfa84b296b49ee75dc95e14c557b0684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615099 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#841359}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I5ed331d6370562bd49b1ce5cc3f4d2f9e940bdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617578Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841358}
-
Ayu Ishii authored
Cookie Store has shipped in M87. This change removes origin trial integration that is no longer used. Bug: 1044245 Change-Id: I312d9e8d181cec908b15e2f999e6f78a2177bb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612102Reviewed-by:
-
Jiewei Qian authored
This reverts commit 5ac617b2. Reason for revert: Causing multiple builds to fail. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/22042/overview https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22108/overview MSAN suggests use-of-uninitialized-value. See: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8858716359442887296/+/steps/oobe_only_browser_tests__experimental_/0/logs/Deterministic_failure:_All__x2f_PendingUpdateScreenTest.UpdateScreenShown__x2f_1__status_CRASH_/0 Original change's description: > Scalable Status Area: Show date in status area in large screen. > > - Add a flag for the scalable status area feature. > - Add enum and helper function in SystemTrayModel to capture system tray > size. > - Add date to system tray when the screen is large. > > Bug: 1161557 > Change-Id: Id85a6bee9a30684c65b2253862ba30ab78583525 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600912 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Andre Le <leandre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841227} TBR=xiyuan@chromium.org,tbarzic@chromium.org,tetsui@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,leandre@chromium.org Change-Id: I4072db4a1267389478963dfebacb55551e2c3186 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1161557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617405Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#841356}
-
Melissa Zhang authored
OnWidgetBoundsChanged is invoked when the bounds of the widget changes, but was being used to indicate the bounds of its parent had changed. This was creating a bug when SharesheetBubbleView was updating to the NearbyShare view as the change in widget size was invoking OnWidgetBoundsChanged and causing the anchor position to update. Moving the anchor position stopped the NearbyShare view from animating, causing the view to only fill a portion of the sharesheet. Instead of overriding OnWidgetBoundsChanged, we call UpdateAnchorPosition directly when we observe a change in the bounds of the parent widget. Bug: 1152651 Change-Id: Ieeda8ceeb577fd0ce43a98550ac437a1ac4fad11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616643 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841355}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ic93ba719014ffcd7b3bdcf3c6b7f84fcd71cda57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616921Reviewed-by:
-
Shakti Sahu authored
Bug: None Change-Id: I16f6444538130e4d7a550dec7b82621608d46b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613889 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#841353}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d9d7213a6c08..e174329bab15 2021-01-08 wenbinzhang@google.com [telemetry] Add support to run stories in multiple index ranges 2021-01-08 yuhengh@chromium.org Revert "Add ability to modify trace config in a story" 2021-01-07 ddoman@chromium.org [typ] avoid duration value formatted in scientific notation 2021-01-07 yuhengh@chromium.org Add ability to modify trace config in a story If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1140389,chromium:1163637 Tbr: nuskos@google.com Change-Id: Ibf903402ac3a03e8152b9afb241b77f1f0b789f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617299Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e79039e774fb..b43fbe8a06ea 2021-01-08 yoichio@chromium.org Show WebTransport connections in the network panel. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152290 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3ed846d2cdf9f0bc58d77ef516076ee7c329ac32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617298Reviewed-by:
-
Peter Kasting authored
This also fixes a bug where alpha values were deserialized incorrectly. Bug: 1159562 Change-Id: Idb203b318e4d8481de376f0157339475bd79e1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614846 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#841350}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I012b526edf02a963e3e37dba4c09a07123f1f219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617029Reviewed-by:
-
Aaron Leventhal authored
Bug: 1163213 Change-Id: I98968924523541b490e293409b09b25aa6a81666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613155 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841348}
-
Alan Screen authored
Incorporate support for retrieving a printer's basic info, user defined papers, and semantic capabilities and defaults from the utility service. This combined collection of information is needed when preparing for print preview, so it reduces overhead and latency to enable these to all be collected with one mojom call instead of needing a chain of calls to assemble the data. Bug: 809738 Change-Id: I75518dca30f0113cadc7971ba2a87658aca7176b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578698Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841347}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I28dc27dd5766665a42455711141c3fd6d6cf0051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617030Reviewed-by:
-
Andrew Xu authored
This CL adds the multipaste option to the textfield's context menu under CrOS. In detail, this CL does the following jobs: (1) It creates a class called ViewsTextServicesContextMenuChromeos to support the text context menu under CrOS. (2) Because ViewsTextServicesContextMenuChromeos lives under ui/views, it cannot access the Ash side functions such as those related to the multipaste menu directly. To solve such a problem, a new class called ViewsTextServicesContextMenuImpl is created under ash/public/cpp and the function to build this new class is injected into the ui/views side from the ash side. Bug: 1157669 Change-Id: Ia5a26ab3e89637c4e55a4d8a86235ae2c21d3075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595203 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#841345}
-
Matt Reynolds authored
Each HID collection has an 8-bit value that defines the collection type. This CL adds a type parameter to the collection info exposed to javascript. Bug: 1162143 Change-Id: I56370783aaa8bb811dc77c62ee9b0ce90d589046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605006Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#841344}
-
Theo Johnson-kanu authored
Screenshot: https://screenshot.googleplex.com/788UBYwsmiFUoQV.png Bug: 1163556 Change-Id: I5724e5af92c02edd024cd93c3b2dbde7219704e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611615 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#841343}
-
Darren Shen authored
When an IME issues autocorrect related operations during a key event, the operation is not immediately executed, but stored as 'pending'. After the key event is handled, the pending operation is executed. However, there is a boolean guard to see if there is any pending operations in the first place. Unfortunately, the guard doesn't check for autocorrect related operations, only commits and compositions. So pending autocorrects are executed only when it is accompanied by a pending commit / composition. To fix this in a robust way, simply delete the guard, since we do the same check in the function that executes the pending operations anyway. Eliminating the check means we don't have to remember to update the guard whenever we add a new type of pending operation. Bug: b/176942429 Change-Id: Ie6178d1b139d27fb9ffb40cffe3d29ddd2b548d6 Fixed: b/176942429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612551Reviewed-by:
John Palmer <jopalmer@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#841342}
-
Shakti Sahu authored
This CL fixes IPH card rounded corner color for night mode. Also added test for video player URL builder. Bug: 1117148 Change-Id: Ia798a7122f6b992e758629d2d1d0830892090a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613933 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841341}
-
John Chen authored
Update bot dimensions for linux-perf after OS upgrade from Ubuntu 14.04 to 18.04. Bug: 1162000 Change-Id: Ia2f40977120ccf0ac4b2037114c3d20ba5bdeb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617240Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841340}
-
Matt Reynolds authored
The Device Class Definition for HID defines a bitfield that accompanies each Main item in the HID report descriptor. The bitfield is a 32-bit value that defines 9 attributes. Three of these attributes were already exposed in the HID report item dictionary (isAbsolute, isArray, hasNull), this CL adds the remaining six. Bug: 1156954 Change-Id: Ic0d7d069010bdc0c75369fbc1fb85586d5caeefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605585Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610042255-43b4d84a21124c058546cf1e621ecfbb55dbe4e7.profdata to chrome-linux-master-1610063718-75764fb6f7cc7a2d4d8119e0952784a5ac3fa72a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If182b483b8f8bb52c056e7a0682240110bf374a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617302Reviewed-by:
-
Tal Pressman authored
We are in the process of attributing as many mojo interfaces as possible to specific execution contexts, which would enable better control by the browser over those contexts. As part of that effort, this CL uses the execution context's BrowserInterfaceBroker to bind the PushMessaging remote and moves the code registering the binders accordingly. Bug: 1126758 Change-Id: Idfd27baf90fc2fa5e150f0d97753e21757104607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596587Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#841337}
-
