- 06 Aug, 2020 40 commits
-
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113845 Change-Id: Ib730ef14cc83593bc09b82640a469569612e2e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341153Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795602}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113835 Change-Id: Id7079fe52a1b35c8c5293db42bf9dccf0c4bd156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341151Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795601}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113821 Change-Id: I5174fce7966dd6e390a8c50bd427dc461a5b7874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341150Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795600}
-
Yu Han authored
Prior to this CL, the popup border, control's border and background color for color picker popup don't match spec. In addition, the suggested color picker popup wasn't styled. Updated the colors for color picker. And added a test for suggested color picker. The suggested color picker swatch control uses outline to indicate both hover (mouse) and focus (keyboard), [1]. Thus, I kept the existing behavior of using outline. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/forms/resources/colorSuggestionPicker.js;l=202 Bug: 1111926 Change-Id: Ib0608a85e6e2f276cff45446a7bac11e9726040a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336290 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#795599}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113839 Change-Id: I31ee8f7c4954f363a2f7b462091ff9fd5cf7c794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341152Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795598}
-
Natalie Chouinard authored
This test is flakily crashing on test-n-phone: https://ci.chromium.org/p/chrome/builders/ci/test-n-phone Example failure: https://ci.chromium.org/p/chrome/builders/ci/test-n-phone/10873 TBR=dominickn@chromium.org Bug: 1062843 Change-Id: Icd4539aa98dc09e90ef45cfc7599c36647b5894e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341405Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795597}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc68e3248ed9..e69d5b2de943 2020-08-06 treehugger-gerrit@google.com Merge "Tests: Add client library + service stress test" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I66ef754640d991285df6ea0aea38b08346bef78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795596}
-
Rainhard Findling authored
* Logs the Chrome cleaner result shown to users in an UMA histogram. Bug: 1087263 Change-Id: I25cdd664300632f3d893f59a01c3803ce3db6f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332802 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#795595}
-
Evan Stade authored
- stop explicitly disabling for WebLayer - add a play services java dependency to WebLayer Shell so the play services version metadata is added to the manifest - add some error logging to SmsUserConsentReceiver to make the case where apps lack that tag more apparent Bug: 1035836 Change-Id: I15a1a946479c1b5126e1458f548fa13d08e526d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337387 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795594}
-
Alison Maher authored
The following CL removed block fragmentation coverage from the virtual/layout_ng_fieldset test suite: https://chromium-review.googlesource.com/c/chromium/src/+/2331956 This change adds the related test directories to virtual/ layout_ng_block_frag to ensure that we don't lose any test coverage for fieldset block fragmentation. Bug: 875235 Change-Id: Ia79ab4b27daf58e7cad0e8f17ffc217cee7fe123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337423 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#795593}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/76488e6d8e63..dc68e3248ed9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia336cb6e1fb5cdbcc89ce89b3a98952efff15fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795592}
-
Ana Salazar authored
Extend histogram expiry one more year. Bug: 1112394, 1112393, 1112394 Change-Id: Ib03bdf8bcc806c24e06cb601b1764ce16c5b3352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337283Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795591}
-
Nick Burris authored
This patch adds the model for the secure payment confirmation UI. This model holds all of the cross-platform data to be displayed in the UI. Bug: 1110322 Change-Id: I4bc041b3712e7795028f37dcd8d883a4aee0d32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333211Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#795590}
-
Caleb Raitto authored
These can affect text rendering [0], so we need to capture these too. [0] https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-filltext Bug: 973801 Change-Id: Idae252d52f6831bc237bbe6afb4abc6061b5a18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305037 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795589}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37009c358bdf..a6e1d2d16082 2020-08-06 jacktfranklin@chromium.org Fix type reference detection in bridge generator 2020-08-06 kprokopenko@google.com [issues] Add element reporting to CSP issues 2020-08-06 changhaohan@chromium.org Toggle adorner state before click callback to sync state correctly If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1066772,chromium:1082628 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7d8617e26ce107d48c880da286597bcb452f5cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340308Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795588}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113702 Change-Id: I5fb0e53da39289d2f32be1f9ba0dd78a168fb2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341147Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795587}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8351dc1fb7c4..24289f2e94f3 2020-08-06 ehmaldonado@google.com Roll git to 2.28.0 on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1070694 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ibf0cda5bd7e68f6bdec2e69748878b2d1a1d4888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795586}
-
Brian Sheedy authored
This reverts commit 6ae1f421. Reason for revert: Incorrect test disabled. Original change's description: > Disable minidump tests on Linux > > Disables the Telemetry minidump symbolization tests on Linux, as they > are currently flaking pretty badly. > > TBR=johnchen@chromium.org > > Bug: 1108432 > Change-Id: I3fab14b82de7440eff534169cf028d324d6f37c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333667 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794208} TBR=bsheedy@chromium.org,johnchen@chromium.org Change-Id: I3cd4f00497602c008664e83413d6016e66e0b64d Bug: 1108432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335482Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795585}
-
Hyunjune authored
Remove |EnsureComputedStyle| on SVGPathElement::getPointAtLength. Although <path> is in an inactive document, <path> element can compute the total length of path. Because the equivalent path of a ‘path’ element is simply the path itself. Bug: 972979, 1108966 Change-Id: I5194352c1d4452dacc721f3ae223019998859d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339714 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#795584}
-
Tibor Goldschwendt authored
This CL: - Enforces a max height of 200px for image and unexpanded interactive doodles. - Anchors the doodle and logo 38px above the search box. This reflects the current behavior for 200px tall doodles and improves the layout for smaller ones. Before: https://screenshot.googleplex.com/7kaNU6rktGD After: https://screenshot.googleplex.com/QNbQg9F1bHi Fixed: 1113319 Change-Id: I56deedc2127c5421fcecd85fc862cba38993a763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340502 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795583}
-
ziyangch authored
We need to report the audio render position to the Android system, which is the amount of already played audio frames. Bug: Internal b/162079069 Test: On device. Change-Id: Idb86deccf2e24e7ab1b7864647596bc04a503a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334410Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#795582}
-
Guido Urdaneta authored
WebRtcGetUserMediaBrowserTest.ApplyConstraintsVideoTwoStreams flakes due to crbug.com/1113820 Bug: 1055012 Change-Id: I65017937e76c8547a374e2c588fb3350dcc111ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340918 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#795581}
-
Xinghui Lu authored
Per Android UI guidance, radio buttons should not be used in settings list. To follow the guidance, the "Security" section is renamed to "Safe Browsing" section. The "DNS over HTTPS" preference remains in the "Privacy and security" section. For more details, see: go/ep-clank. To avoid mixing refactoring with functional changes, further renaming will be done in a followup CL. * Changes on the "Privacy and security" section before: http://screen/SoETXTjFKe2 after: http://screen/vH6PVX423xN * Changes on the "Safe Browsing" section(previous "Security" section) before: http://screen/02ZdA6rFHK9 after: http://screen/gusmNtHYgnH Bug: 1097310 Change-Id: Id6de4a38fafad64e4daa39e42f4aa44a28e5ac50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337390Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795580}
-
David Tseng authored
A node can be both a combo box and editable. This is given by the textFieldWithComboBox role. R=anastasi@google.com Bug: 1110157Text Test: place focus over Gmail's compose dialog and the to text field. Verify an EditableTextNode wrapper is created and not a ComboBoxNode. Change-Id: Ia6726a5c3e687b225cd3b20d2e5f69300c1a585c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336957Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795579}
-
Sven Zheng authored
More tests are failing. List is based on union set of several jobs. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/666? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/656? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/642? Bug: 1111979 Change-Id: Id2749cfc298fe98eee90c65a7a15873b06dcaf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341169 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795578}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113700 Change-Id: I2f463115198f538b99dcfdc27df4c99ca01378fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341146Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795577}
-
Chris Lu authored
When attempting to get the source languages to switch to, a crash can occur if the self.newSourceLanguageIndex is -1. In this line of code, it should be self.newTargetLanguageIndex Bug: 1113818 Change-Id: I4260bc32ba620927a60a966ee8b67c4b1586bc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341388 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#795576}
-
Dominic Mazzoni authored
Bug: 1111418 Change-Id: I64d56920ebe10412e311e5ca3b4b633b864e5160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340794 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795575}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113831 Change-Id: I8b0c5cf2d29cd5c1396e26f7e4c46ca0ea9bfea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341149 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795574}
-
Travis Skare authored
Bug: 1107466 Change-Id: If904c34d51be80412b3a1d077216f3dffeb1a406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309797 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#795573}
-
spdonghao authored
Bug: 1111388 Change-Id: I9170271535bc110c92994440dbc92cbe3ba0e084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329738Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795572}
-
Dominic Mazzoni authored
When a node's children have changed, accessibility code enqueues information about that in order to examine the accessibility tree after layout is clean. However, under some circumstances that led to enqueuing the same node over and over again. Fix that by adding a set to keep track of nodes already in the queue. This patch also adds tracing for AXObjectCacheImpl::ProcessDeferredAccessibilityEvents and adds a new perf test to track this optimization. I'm seeing a ~20x speedup. Bug: 1107988 Change-Id: I1263c5139991287a35b89c9c0e6e021f07628c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340384 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#795571}
-
Etienne Bergeron authored
The rounding APIs on a Range are not used anymore. We fixed the use cases where the call to Round was incorrect. Typically, the code was looking for an "enclosing-range" or and "enclosed-range". It is preferable to remove the API since it's misleading the devs. R=rsesek@chromium.org Bug: 1111044 Change-Id: I7f11c9c28c2a5c93d3fe8cfcbd38a6b077e90105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339713Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795570}
-
Kevin Ellis authored
CompositorAnimations::ConvertTimingForCompositor does not take the play direction into account when adjusting the time offset for the start delay. Note that a similar trick might work for end delays; however, deferring to a separate CL given the comment: // FIXME: Compositor does not know anything about endDelay. which suggests that other CC changes may be required to accommodate end delays properly. Difference between composited and main thread animation can be observed in the following CodePen without the patch. https://codepen.io/kevers-google/pen/NWNPGRg Bug: 1095813 Change-Id: I3d5d09618f6e58795bc527c18bc6deabe9abed13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339712Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#795569}
-
Reilly Grant authored
This test appears to time out flakily. TBR=ftirelo@chromium.org Bug: 1113802 Change-Id: Id6280cac06c7deed2b8c2c7ae7c1a524e6246ded No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340277Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795568}
-
Amy Huang authored
The default upstream was recently set to ON, which broke the linux_upload_clang bot because its binutils is older than 2.26. Bug: 1113475 Change-Id: Ifcce2f9ab6181e45fe89182dca45dac3b5b10c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341369Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Amy Huang <akhuang@google.com> Cr-Commit-Position: refs/heads/master@{#795567}
-
Keren Zhu authored
Also make the constructor interface of MenuButton consistent with LabelButton. This CL is part of the effort to make Views default constructible, allowing UI to be built in a declarative fashion. Bug: 1108460 Change-Id: Ib46d0491d85bbd068c1a82a4d4dc3aaf47e63972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339586Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795566}
-
K. Moon authored
Creates a skeletal blink::WebPlugin counterpart to the Pepper-based OutOfProcessInstance. This will support migrating the PDF viewer from a Pepper plugin to a plain Blink plugin. Note that the ultimate intent is _not_ to run the PDF viewer as a plain Blink plugin, without other changes to isolate it. This is just a starting point for the final implementation. Bug: 1085334 Change-Id: I6bea3ddd7fc1b27879af5cd5614071cb02491d77 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328030Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#795565}
-
Mansi Awasthi authored
This CL sets the ax::mojom::NameFrom property for static text nodes and inline text nodes in PdfAccessibilityTree. This property is used by AXNode::GetInnerText() to compute the inner text of the nodes. This CL also includes the relevant tests to validate the change. Bug: 1112890 Change-Id: I782ceb4d93a07146a81b1d23ff9696af3267d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337195 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795564}
-
Fabio Tirelo authored
This reverts commit 1f9a9579. Reason for revert: Can't generate build files on mac-arm64-rel Bug: 1113849 Original change's description: > Infra: Rename mac-arm64 builder to mac-arm64-rel > > Bug: 1106950 > Change-Id: Ie1c1fac0955afe6908335d2360a07954c718c25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337103 > Commit-Queue: Gary Tong <gatong@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795517} TBR=gbeaty@chromium.org,gatong@chromium.org Change-Id: I4c0fca2e541852704f57c843bfb14f874ddffcc5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341810Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795563}
-