GitLab

This CL modifies the overlay play button ShouldCausePlayPause function
to take CSS and Document zoom into account. This fixes a bug where a
zoomed video had an incorrect hitbox for the overlay play button.

Bug: 862063
Change-Id: I3f51454618e5c455bba62b4b019701d67fd8886c
Reviewed-on: https://chromium-review.googlesource.com/1135663Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575051}

This was only used for the new tab button, but the new tab button now reports
the relevant size as its preferred size.  So we can use that directly
everywhere.

This will make it easier to add padding around the new tab button, because the
button can report a larger size to other callers without having to keep the
layout size in sync with a padding value local to new_tab_button.cc.

Bug: none
Change-Id: Id513c23ba458857032b05ed8e266387d9e1f1f55
Reviewed-on: https://chromium-review.googlesource.com/1135764
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575050}

Since we haven't used ContentVideoView for video playback since ~M64,
this CL removes it.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3f9b005bf2b4c7e8d3dd1b1250e42c0089cc1092
Reviewed-on: https://chromium-review.googlesource.com/1112741
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575049}

Bug: 863042

Change-Id: Ibde119026dfc6d7a4ba470cc836a834b9a4e5d2f
Reviewed-on: https://chromium-review.googlesource.com/1135592
Commit-Queue: Mike Reed <reed@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575048}

Two changes:

- Make all Views windows layer backed (they mostly were already).

- Use _titlebarHeight to hide the titlebar for app windows. _hidingTitlebar
  resulted in the top corners not being clipped (as if the window were a
  sheet).

Bug: 863264, 862672
Change-Id: I9647afdcba464cc17b88cc2d752bf273a0f6ab89
Reviewed-on: https://chromium-review.googlesource.com/1136520
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575047}

This is only necessary to eliminate a presubmit error about the use
of the banned method Time::ToInternalValue. No functional change.

BUG=752327
R=chrishtr@chromium.org,vmpstr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id0ecab92b4605da1c25398a539be7dc87a250547
Reviewed-on: https://chromium-review.googlesource.com/1135988Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575046}

Having a NOTREACHED here is problematic for two reasons:
. A bad client could trigger the NOTREACHED by setting a random value.
. Because the registry is a separate pipe then that to the WindowService it
  is entirely possible for the property to be set on the window before the
  property has been set in the registry.

BUG=863520
TEST=none
TBR=estade@chromium.org

Change-Id: I08b047e871c39d46cfcd548b078df6af9e334032
Reviewed-on: https://chromium-review.googlesource.com/1136937Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575045}

Bug: 771792
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I34ffae8b8ff4d1372eedcdc0b6549bd68a521b84
Reviewed-on: https://chromium-review.googlesource.com/1073888Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575044}

Defaults to target_name if bundle_name is not specified.

Bug: 863115
Change-Id: I37ae90190742305d3f2116f8481017535c6daa42
Reviewed-on: https://chromium-review.googlesource.com/1136461Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575043}

Bug:862741

Change-Id: I181f6ddb1f43b5710e72ab8babad0dbd465e6507
Reviewed-on: https://chromium-review.googlesource.com/1136736Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575042}

Bug: 863166
Change-Id: I024feeb9c3e687632841da11e44222dc1b1f8acb
Reviewed-on: https://chromium-review.googlesource.com/1136722
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575041}

This reverts commit cf4c67a7.

Reason for revert: I believe that this change is responsible for https://crbug.com/862196 ("Text in omnibox completely reset while typing"). Rather than try a speculative fix, I'm going to revert this and we can try to re-land post-branch with an associated fix.

Original change's description:
> omnibox: reset display url when re-navigating to the current page by clicking a link
> 
> Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow`
> logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained
> unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is
> reset.
> 
> Bug: 830491
> Change-Id: I9819fa29ca1d86467a660e0e40ddb149cf210f1d
> Reviewed-on: https://chromium-review.googlesource.com/1114337
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Commit-Queue: manuk hovanesian <manukh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571479}

TBR=mpearson@chromium.org,thakis@chromium.org,tommycli@chromium.org,manukh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 830491
Change-Id: Ie9a30f656a0e0faabeaf690b865fa49e37e8bc7f
Reviewed-on: https://chromium-review.googlesource.com/1134099Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575040}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/74aa8cb5bd4e..a50a4e11ae0f


git log 74aa8cb5bd4e..a50a4e11ae0f --date=short --no-merges --format='%ad %ae %s'
2018-07-13 xixuan@chromium.org SkylabHWTest: Add skylab tag for kicking off/aborting skylab suites.
2018-07-13 dgarrett@google.com InitSDKStage: Remove chroot_replace argument.
2018-07-13 vapier@chromium.org cros_build_lib: drop unused ParseDurationToSeconds


Created with:
  gclient setdep -r src/third_party/chromite@a50a4e11ae0f

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ic378d2ad6e274ac668abe024c85d7199cea63c86
Reviewed-on: https://chromium-review.googlesource.com/1136739Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575039}

If running component updates in a background task we won't instantiate
an activity. As a consequence we won't register the VR assets component
and never get updates for it in the background. To solve this, register
the component in native.

The component gets only registered if the user has a Daydream headset
paired. Checking this is expensive. Thus, we save whether the component
should be registered in user preferences. At Chrome startup (which may
happen when running an update task in the background) read this flag
and conditionally register the component. Reading the flag took less
than 1 ms in my tests.

Change-Id: I1e9d0f6caab094307f8f3397c913cc1b7431d8fa
Reviewed-on: https://chromium-review.googlesource.com/1132147Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575038}

This reverts commit 9b785217.

Reason for revert: The tests for this class weren't actually running. https://crrev.com/c/1136864 breaks because of this CL when re-enabling the tests.

Original change's description:
> Migrate PrivetTrafficDetector to use NetworkConnectionTracker.
> 
> This migrates PrivetTrafficDetector from using
> net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
> works with the network service enabled.
> 
> Bug: 859134
> Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581
> Reviewed-on: https://chromium-review.googlesource.com/1123681
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574700}

TBR=pastarmovj@chromium.org,thestig@chromium.org,rmcelrath@chromium.org

Change-Id: I15aeff8eed59935b9640d73e95a638c9ffb35f71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859134
Reviewed-on: https://chromium-review.googlesource.com/1136398Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575037}

This is a reland of https://chromium-review.googlesource.com/1133972.
The double end session issue was fixed by
https://chromium-review.googlesource.com/1136725.

This is a no-op cleanup before adding more stuff in
TabManager::PerformStateTransitions().

TBR=sebmarchand@chromium.org

Bug: 775644
Change-Id: I35a7b3cbb877a26fb41dfce7340bf3a4b2c777b9
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1136792
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575036}

This addresses a TODO from a preview CL. No functional changes.

Change-Id: I21e99b55f285475d8321fea260751be3f18d811b
Reviewed-on: https://chromium-review.googlesource.com/1135519Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575035}

Archives without a valid main resource were returned from
MHTMLArchive::Create. Since these cannot be used for rendering pages, we
can instead return nullptr.

Bug: 857022
Change-Id: I5afd27d3bd6d1484c7ff28f98652558f38ee9cfd
Reviewed-on: https://chromium-review.googlesource.com/1136795
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575034}

- Log format changed to pass values instead of hashes.
- Log.path will now be passed untouched, preserving original case from
  section path.  This allows for potentially case-sensitive operations
  later.
- Testing added to ensure the expected case behaviour,
  ThirdPartyTest.PathCaseSensistive.
- Also, reordered arguments for GetFingerprintString, to be more
  intuitively tied to the format string.

R: pmonette@chromium.org
Test: chrome_elf_unittests.exe, ThirdParty*
Bug: 769590
Change-Id: Ib28ec13da7bf27168513031f583bd47e47da0dcc
Reviewed-on: https://chromium-review.googlesource.com/1136660Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575033}

This is a reland of https://chromium-review.googlesource.com/1130470.
The double end session issue was fixed by
https://chromium-review.googlesource.com/1136725.

Previously, a tab was proactively discarded when it had spent T time hidden,
where T depends on the number of non-discarded tabs and the amount of
physical memory. Unfortunately, that meant that if a user kept Chrome
open during the night without touching it, all hidden tabs were discarded
in the morning.

With this CL, we use the "Chrome usage time since hidden" to determine
if a tab should be proactively discarded. That will prevent the unwanted
behavior of finding all tabs discarded after a long period of inactivity.

TBR=sebmarchand@chromium.org

Bug: 775644
Change-Id: I57a08a47aad76087b54277d19849228e1ed00305
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1136791
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575032}

Split the custom links feature from kNtpIcons.

Bug: 856394
Change-Id: Iedff0c5ecf2ee780cbd40106b2f764595d603a8c
Reviewed-on: https://chromium-review.googlesource.com/1135849Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575031}

This is a reland of https://chromium-review.googlesource.com/1133593.
The double end session issue was fixed by
https://chromium-review.googlesource.com/1136725.

With this CL, the total Chrome usage time measured by UsageClock is
recorded in a LifecycleUnit when it is hidden. In an upcoming CL, this
will be used to discard a LifecycleUnit after a given amount of Chrome
usage time has elapsed since it was hidden.

We also record the wall time when a LifecycleUnit is hidden, because
freezing occurs when a LifeycleUnit has been hidden for a given amount
of wall clock time, not Chrome usage time.

TBR=sky@chromium.org,sebmarchand@chromium.org

Bug: 775644
Change-Id: I4accaee333f8907695c672505e295734d7206566
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1136726
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575030}

Network traffic annotations are enforced in Windows, Linux. In other platforms
the annotation IDs are undefined. This leads to data use of android specific
services being bucketed to undefined bucket. This CL adds an annotation ID
for the codepath.

Bug: 762621
Change-Id: I5676680f3fb7c0f70cc1cd34ff36c898134990e7
Reviewed-on: https://chromium-review.googlesource.com/1128439Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575029}

Remove GPU.CreateBrowserCompositor metric, which measures how long it
takes to create an instance of cc::LayerTreeHosts. This time is 0us at
96+%ile, and < 20us in 99%ile. I don't think this metric has much value
at the moment. It was initially added for crbug.com/311259, but was not
particular useful even at that time.

Change-Id: I08d9b77cbc3ad65d1b8685448bcbdcdf312a3e2e
Reviewed-on: https://chromium-review.googlesource.com/1127322Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575028}

Screenshot: https://drive.google.com/open?id=1HyMQ4s95UdTZVXdTqawSS4zIM8vDY_uF

Change-Id: I91a2a0e337cb4b43985f1307ff05abbddc3ed71f
Reviewed-on: https://chromium-review.googlesource.com/1133740Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575027}

THis also makes the test behavior closer to
actual behavior.

Bug: 862791, b/110171997
Test: Covered by unit tests
Change-Id: I289a28d99ac8aee39218ff65fc5095de21b226c5
Reviewed-on: https://chromium-review.googlesource.com/1135759Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575026}

When switching tabs, report the time it takes for the browser to send
the request to the renderer to become visible.

BUG=858944

Change-Id: Id11569162c433a66f61a4fd8dc8ef8c8b2f70327
Reviewed-on: https://chromium-review.googlesource.com/1136217Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575025}

This is needed to avoid ODR violations due to both the generated protozero
sourcesets as well as libperfetto having dependencies on
third_party/perfetto/src/protozero (the protozero base library) which
causes ODR violations in component builds.

Requires https://android-review.googlesource.com/c/platform/external/perfetto/+/711693 to land.

R=hjd@chromium.org
BUG=853872

Change-Id: I805092df1a3e62662f478a7bac015686322d00db
Reviewed-on: https://chromium-review.googlesource.com/1120694Reviewed-by: Hector Dearman <hjd@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575024}

Bug: 851636
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4f6bd4f1e90efc1f6b986dcda2decf88246c80f7
Reviewed-on: https://chromium-review.googlesource.com/1136211
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575023}

- Remove support for 'key_removals', which is unused after
  https://chromium-review.googlesource.com/c/1136516/
-- As a knock-on effect, update_and_cleanup_test() can now no longer
   throw, so remove several try:/except: blocks to keep the coverage
   script happy.
- Remove support for having "$bot_name $waterfall_name" in
  'modifications' since that's no longer needed and there was a TODO
  about removing it already.

Bug: 843511
Change-Id: I2d9d89e60ad404f78c97f448db017091b4d18b57
Reviewed-on: https://chromium-review.googlesource.com/1136893
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575022}

Previously, this scenario could cause the same session to end twice:
 - Chrome becomes visible.
 - User event -> Session starts.
 - Chrome becomes hidden -> Session ends.
 - Inactivity timeout expires -> Session ends again.

This CL fixes the issue by stopping the inactivity timer when a
session ends.

Bug: 863243
Change-Id: I3d903844ab07775ebc5d653f34fa6b91a3623021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1136725Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575021}

R=cmasso@chromium.org

Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6518574ca0b1be4ce469090f8a95848a7d29cdcf
Reviewed-on: https://chromium-review.googlesource.com/1136891Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575020}

Removing the old UI now that we've reached feature parity.

Bug: 847599
Change-Id: I2163241f53a4e5eb2b14e14f7fab12ecb1639f24
Reviewed-on: https://chromium-review.googlesource.com/1136844Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#575019}

Currently, we have a single generated class that registers all the
extension features in the constructor. For instance,
ChromeAPIFeatureProvider registers both features from both //chrome
and //extensions.

Refactor this to generate a method that takes a FeatureProvider and adds
features to it, rather than generating a FeatureProvider subclass. This
allows us to have multiple feature registration methods called for a
single provider, rather than needing a single class per build.

This is necessary in order to split out app and extension feature
registration.

Bug: 862310

Change-Id: I9fba5ea57d8b14ca9f893a2694661163c8bc4140
Reviewed-on: https://chromium-review.googlesource.com/1132124Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Albert Chaulk <achaulk@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575018}

This will allow the icon insertion logic to be shared across different
implementations of the Reading List empty state.

Bug: 851962
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibd4abe71be34ae019786620ba88ba6f226b75456
Reviewed-on: https://chromium-review.googlesource.com/1135983
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575017}

Register a context loss callback with the GLES2Implementation to find
out about lost context. Implement AddObserver() and RemoveObserver() for
VizProcessContextProvider to notify the observers on context loss.

viz::Display is already registered as the context loss observer for the
ContextProvider. It gets notified and calls out to DisplayClient.
Implement a handler for DisplayOutputSurfaceLost() so the root
CompositorFrameSink shuts down the display on context loss. The client
will see a connection error and reinitialize the display.

Also make VizProcessContextProvider log UMA on context loss. This
requires moving ContextLossReason enum somewhere visible to
VizProcessContextProvider and adding a new histogram for
GPU.ContextLost.DisplayCompositor.

Bug: 859068
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4c1fb6f00a893003e9b65dde1a7c5802a8f27692
Reviewed-on: https://chromium-review.googlesource.com/1126482Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575016}

Having these API wrapper objects be globals is dangerous because each
BluetoothTaskManagerWin creates a new task runner on which to run
Bluetooth tasks. Since this is the only class that uses these objects
it can just own them instead.

To simplify things the weak HANDLE reference in BluetoothTaskManagerWin
has also been removed.

Bug: 820864
Change-Id: I2abaca53c1b7388503e0f18ac6a004426f0e95ac
Reviewed-on: https://chromium-review.googlesource.com/1117445
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575015}

This patch changes ColdModeSpellCheckRequester to store a Range instead
of Position to memorize the checking progress, so that the state is
less vulnerable to DOM changes. It also adds more data validity check
to make sure that the class is in a valid state when calling
RequestCheckingForNextChunk().

Bug: 862932
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I15b71545fad68b1061c2d075f56d849f1ef8e009
Reviewed-on: https://chromium-review.googlesource.com/1135899
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575014}

Help make sure ShutdownSDK() gets called when needed.

Change-Id: I9be9e521892c3dd9f49e4141e93a4dbe46c7f5ce
Reviewed-on: https://chromium-review.googlesource.com/1135914Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575013}

If we always want the output, we should add the flag in testing/buildbot/gn_isolate_map.pyl
or waterfalls.pyl for all bots, and not set this for a small arbitrary subset.

Bug: 843511
Change-Id: I8a1e1f32ec22da2b02bc05ac56ecee659b4448ee
Reviewed-on: https://chromium-review.googlesource.com/1136517Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575012}