- 29 Dec, 2015 40 commits
-
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/427ee9ea6162..58d01d4a8c8c $ git log 427ee9ea6..58d01d4a8 --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1552703002 Cr-Commit-Position: refs/heads/master@{#367110}
-
thestig authored
Fix some small nits along the way. Review URL: https://codereview.chromium.org/1554533002 Cr-Commit-Position: refs/heads/master@{#367109}
-
dcheng authored
A few more things that are present in GYP builds but not GN builds... (╯^□^)╯︵
❄ ☃ ❄ BUG=557422 R=vmpstr@chromium.org TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1558513002 Cr-Commit-Position: refs/heads/master@{#367108} -
Walter Korman authored
https://chromium.googlesource.com/chromium/src/+/f03ecfc1e BUG=571248 TBR=jzern@chromium.org Review URL: https://codereview.chromium.org/1551833002 . Cr-Commit-Position: refs/heads/master@{#367107}
-
miu authored
Introduces RtpTimeDelta and RtpTimeTicks to media::cast, modeled after base::TimeDelta and base::TimeTicks, that track RTP time and provide a strict set of valid math and comparison operators, bit truncation and re-expansion, and timebase conversion. All instances of raw uint32 used to represent RTP timestamps has been replaced with the new data type. BUG=530839 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1515433002 Cr-Commit-Position: refs/heads/master@{#367106}
-
jbroman authored
In particular: - when hovering or pressing the thumb, repaint only the thumb - when thumb position changes, repaint the track only if it changes (e.g. due to a button being disabled upon reaching the end) BUG=549277 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_oilpan_rel,mac_blink_oilpan_rel Review URL: https://codereview.chromium.org/1558493002 Cr-Commit-Position: refs/heads/master@{#367105}
-
Nico Weber authored
BUG=572987,572240 TBR=marja@chromium.org Review URL: https://codereview.chromium.org/1550193003 . Cr-Commit-Position: refs/heads/master@{#367104}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56baa6c6..eecaedd7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1553553002 Cr-Commit-Position: refs/heads/master@{#367103}
-
jam authored
The seccomp bpf filter was complaining because getsockopt and setsockopt were being called but they're not allowed. I had fixed this for x86-64 in r360114 but the change should have also allowed ARM. Really, it's anything other than 32 bit Linux (which doesn't have a specific id for these methods). BUG=572795,561803 Review URL: https://codereview.chromium.org/1553543002 Cr-Commit-Position: refs/heads/master@{#367102}
-
jzern authored
BUG=571248 Review URL: https://codereview.chromium.org/1546003002 Cr-Commit-Position: refs/heads/master@{#367101}
-
sky authored
This case fixes clicking on an item with no children to show the menu, then right clicking on the (empty) text and choosing 'delete'. In this case 'delete' removes the item, so the menu needs to close. BUG=571362 TEST=create folder with no bookmarks on the bookmark bar, click on folder so it opens, right click in '(empty)' area, and choose delete. The menu should close. R=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/1550173002 Cr-Commit-Position: refs/heads/master@{#367100}
-
kbr authored
This currently describes just the building and running of the WebGL conformance tests on the new Linux and Mac Release and Debug builders and testers. Once this is working, the other tests will be added. BUG=542370 Review URL: https://codereview.chromium.org/1547383002 Cr-Commit-Position: refs/heads/master@{#367099}
-
bustamante authored
testHTTPResponseTimelineRecorder was failing due to an occasional favicon request which would occassional cause the test to fail. To fix the issue it will now filter out any favicon requests before validation. testChromeProxyMetricForBlockOnce failed to due not being updated when the BlockOnce case was changed. I also renamed the metrics we store in the test to be consistent with other cases. Last item is adding myself to OWNERS for chrome_proxy tests. BUG=452279,449979,455269 Review URL: https://codereview.chromium.org/1550973002 Cr-Commit-Position: refs/heads/master@{#367098}
-
yolandyan authored
BUG=561190 Review URL: https://codereview.chromium.org/1553533002 Cr-Commit-Position: refs/heads/master@{#367097}
-
jbroman authored
Revert of Make ScrollbarThemeAura selectively invalidate scrollbar parts. (patchset #10 id:180001 of https://codereview.chromium.org/1525803002/ ) Reason for revert: Oilpan unit test failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/builds/28217 Original issue's description: > Make ScrollbarThemeAura selectively invalidate scrollbar parts. > > In particular: > - when hovering or pressing the thumb, repaint only the thumb > - when thumb position changes, repaint the track only if it changes > (e.g. due to a button being disabled upon reaching the end) > > BUG=549277 > > Committed: https://crrev.com/0e8396ada46f085c23343450d850d81751053c94 > Cr-Commit-Position: refs/heads/master@{#367082} TBR=ccameron@chromium.org,skobes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549277 Review URL: https://codereview.chromium.org/1550983002 Cr-Commit-Position: refs/heads/master@{#367096}
-
schenney authored
To avoid scrollbars ruining the ref test, I removed a non-test-relevent line. Patch based on https://bugs.webkit.org/show_bug.cgi?id=113970 by Benjamin Poulain. R=timloh BUG=cr227282 Review URL: https://codereview.chromium.org/1482493003 Cr-Commit-Position: refs/heads/master@{#367095}
-
estade authored
Problem 1: the cross-fading was not executed properly. It should start by drawing the attached bar at full opacity and transition to detached by painting detached on top of that at partial opacity (defined by animation state). Problem 2: it painted as fully detached when current_state was 0. At this point it should be painting as fully attached. This led to a single-frame flash of lightness at the start of the attached->detached animation. BUG=none Review URL: https://codereview.chromium.org/1547563003 Cr-Commit-Position: refs/heads/master@{#367094}
-
estade authored
Also delete some old file that's not in use. BUG=none TBR=erg@chromium.org Review URL: https://codereview.chromium.org/1534303002 Cr-Commit-Position: refs/heads/master@{#367093}
-
thestig authored
https://pdfium.googlesource.com/pdfium.git/+log/1f1c197..8be8a44 BUG=482206 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1553503003 Cr-Commit-Position: refs/heads/master@{#367092}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3a2f751e..56baa6c6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1556513002 Cr-Commit-Position: refs/heads/master@{#367091}
-
fmeawad authored
Reland of Fix bootstraps_deps of tools/perf to include build/android/pylib/. (patchset #1 id:1 of https://codereview.chromium.org/1557473002/ ) Reason for revert: Sorry I do not think this is the culprit CL anymore, relanding. Original issue's description: > Revert of Fix bootstraps_deps of tools/perf to include build/android/pylib/. (patchset #1 id:2 of https://codereview.chromium.org/1556463002/ ) > > Reason for revert: > Speculative revert: > Failed power benchmarks on N5 > > See https://code.google.com/p/chromium/issues/detail?id=572954 for details. > > BUG=572954 > > Original issue's description: > > Fix bootstraps_deps of tools/perf to include build/android/pylib/. > > > > After John's work in crbug.com/560559, telemetry project no longer depends > > on pylib, hence tools/perf which is a user of telemetry must specify this > > deps explictly. > > > > BUG=572700, 560559 > > TBR=jbudorick@chromium.org > > > > Committed: https://crrev.com/89fe15bf1183cd781a6d27983e7ce792f4641e88 > > Cr-Commit-Position: refs/heads/master@{#367045} > > TBR=llozano@chromium.org,nednguyen@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=572700, 560559 > > Committed: https://crrev.com/5fc45b53137022c58150279fb62a0c2ef18bff80 > Cr-Commit-Position: refs/heads/master@{#367088} TBR=llozano@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=572954 Review URL: https://codereview.chromium.org/1550313002 Cr-Commit-Position: refs/heads/master@{#367090}
-
kmackay authored
* Use signal-safe logging. * Ignore signals that are not to the main thread. As far as I can tell, the runloop's quit closure is safe to run in a signal handler, so that should be OK. BUG= internal b/26253582 Review URL: https://codereview.chromium.org/1542233002 Cr-Commit-Position: refs/heads/master@{#367089}
-
fmeawad authored
Revert of Fix bootstraps_deps of tools/perf to include build/android/pylib/. (patchset #1 id:2 of https://codereview.chromium.org/1556463002/ ) Reason for revert: Speculative revert: Failed power benchmarks on N5 See https://code.google.com/p/chromium/issues/detail?id=572954 for details. BUG=572954 Original issue's description: > Fix bootstraps_deps of tools/perf to include build/android/pylib/. > > After John's work in crbug.com/560559, telemetry project no longer depends > on pylib, hence tools/perf which is a user of telemetry must specify this > deps explictly. > > BUG=572700, 560559 > TBR=jbudorick@chromium.org > > Committed: https://crrev.com/89fe15bf1183cd781a6d27983e7ce792f4641e88 > Cr-Commit-Position: refs/heads/master@{#367045} TBR=llozano@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=572700, 560559 Review URL: https://codereview.chromium.org/1557473002 Cr-Commit-Position: refs/heads/master@{#367088}
-
xidachen authored
Currently, the expected.txt for this layout test is different comparing the virtual/gpu with platform/win-xp/virtual/gpu. Also, This test is marked as failure under platform/win-xp/virtual/gpu/, and the reason is that the actual output is the same as virtual/gpu. So this CL removes the expected.txt under platform/win-xp/virtual/gpu and the failure line under TestExpectations. BUG=568678 Review URL: https://codereview.chromium.org/1551793002 Cr-Commit-Position: refs/heads/master@{#367087}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/8895b72f789e..e3c2f80006e7 $ git log 8895b72f7..e3c2f8000 --date=short --no-merges --format='%ad %ae %s' 2015-12-29 kkinnunen Use device-independent text for nvprmsaa4/16 in nanobench and dm CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=mtklein@google.com Review URL: https://codereview.chromium.org/1550943002 Cr-Commit-Position: refs/heads/master@{#367086}
-
jdonnelly authored
This avoids the case where an available answer is not shown because of a case mismatch (e.g. "US population" vs. "us population"). BUG=563621 Review URL: https://codereview.chromium.org/1543803004 Cr-Commit-Position: refs/heads/master@{#367085}
-
Walter Korman authored
https://chromium.googlesource.com/chromium/src/+/c579aa1f4 BUG=322039 TBR=robhogan@gmail.com Review URL: https://codereview.chromium.org/1554593002 . Cr-Commit-Position: refs/heads/master@{#367084}
-
sunxd authored
The property is retrieved from TransformTree; Fix the order of updating the page scale layer and adding transform tree node; Fix the problem that transform tree sequence number not correctly updated for mask layers; Fix related cc unit tests where a property tree was not created. BUG=568777 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1544103002 Cr-Commit-Position: refs/heads/master@{#367083}
-
jbroman authored
In particular: - when hovering or pressing the thumb, repaint only the thumb - when thumb position changes, repaint the track only if it changes (e.g. due to a button being disabled upon reaching the end) BUG=549277 Review URL: https://codereview.chromium.org/1525803002 Cr-Commit-Position: refs/heads/master@{#367082}
-
estade authored
Reland of Change extension icon load errors to warnings (patchset #2 id:300001 of https://codereview.chromium.org/1554583002/ ) Reason for revert: this revert managed to break the tree Original issue's description: > Revert of Change extension icon load errors to warnings (patchset #8 id:140001 of https://codereview.chromium.org/1537473003/ ) > > Reason for revert: > file read from wrong thread > > Original issue's description: > > Change extension icon load errors to warnings > > > > During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary. > > > > Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake. > > > > BUG=570249 > > > > Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b > > Cr-Commit-Position: refs/heads/master@{#366253} > > TBR=rdevlin.cronin@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=570249 > > Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31 > Cr-Commit-Position: refs/heads/master@{#367080} TBR=rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570249 Review URL: https://codereview.chromium.org/1547413002 Cr-Commit-Position: refs/heads/master@{#367081}
-
estade authored
Revert of Change extension icon load errors to warnings (patchset #8 id:140001 of https://codereview.chromium.org/1537473003/ ) Reason for revert: file read from wrong thread Original issue's description: > Change extension icon load errors to warnings > > During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary. > > Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake. > > BUG=570249 > > Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b > Cr-Commit-Position: refs/heads/master@{#366253} TBR=rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570249 Review URL: https://codereview.chromium.org/1554583002 Cr-Commit-Position: refs/heads/master@{#367080}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b238476a..3a2f751e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1550293002 Cr-Commit-Position: refs/heads/master@{#367079}
-
lhchavez authored
This should have not been committed in r366657, but it was not removed during the rebase. BUG=None TEST=ninja Review URL: https://codereview.chromium.org/1546343002 Cr-Commit-Position: refs/heads/master@{#367078}
-
tzik authored
BUG= Review URL: https://codereview.chromium.org/1546263002 Cr-Commit-Position: refs/heads/master@{#367077}
-
sdefresne authored
Add a method to check whether a BrowserState has an ActiveStateManager to avoid unnecessary object creation during shutdown. BUG=569515 Review URL: https://codereview.chromium.org/1547393002 Cr-Commit-Position: refs/heads/master@{#367076}
-
zhaoqin authored
TBR=sergeyu@chromium.org BUG=572936 NOTRY=true Review URL: https://codereview.chromium.org/1556503002 Cr-Commit-Position: refs/heads/master@{#367075}
-
robhogan authored
Another attempt at https://codereview.chromium.org/1406163003. Sometimes when we remove a child we end up with a float or out-of-flow object beside an anonymous block. When that happens, fold the float/out-of-flow object into the anonymous box as that is where it would have lived if they were siblings in the first place. BUG=322039 Review URL: https://codereview.chromium.org/1543283002 Cr-Commit-Position: refs/heads/master@{#367074}
-
https://codereview.chromium.org/1552613003Nico Weber authored
BUG=82385 TBR=vitalybuka@chromium.org Review URL: https://codereview.chromium.org/1550173003 . Cr-Commit-Position: refs/heads/master@{#367073}
-
alemate authored
BUG=571940 TEST=manual Review URL: https://codereview.chromium.org/1544243002 Cr-Commit-Position: refs/heads/master@{#367072}
-
sdefresne authored
Keep the Shutdown method as removing it will require some downstream refactoring first. BUG=560854 Review URL: https://codereview.chromium.org/1547403002 Cr-Commit-Position: refs/heads/master@{#367071}
-