- 13 Oct, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602525418-295b1a16e5c5eb1a611980e5afdf689a2be9286a.profdata to chrome-mac-master-1602546992-4541e834d35741f8358d6360b79d19523776e3ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3131be67528b610555601bc6876242259482081b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816412}
-
dpapad authored
Leverage latest improvements to autogenerate WebUI .grd files for optimized builds as well. Bug: 1132403 Change-Id: Idb3a80ac6336521397b111902f375ae7bbcc83b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465096 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#816411}
-
Lukasz Anforowicz authored
The "RequestInitiatorSiteLockEnfocement" feature is enabled on desktop platforms in M87, because we want to be more careful on Android, since a mojo::ReportBadMessage might lead there to renderer kills (if NetworkService is hosted in the Browser process, something that never happens on desktop platforms). Since the M87 data so far looks good so far [1], this CL enables the enforcement on all platforms for M88. [1] https://docs.google.com/document/d/132ZPqDZdH-rcvBvHEAd-m86P2udVCi07ccnI0DXmJgE/edit# Bug: 920634 Change-Id: I5f27d9402b3e60668305312aa437252554890bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465803 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#816410}
-
Hsinyu Chao authored
This reverts commit 21620925. Reason for revert: The Bluetooth WBS feature has been enabled for 2+ releases and doing well. We think it's the good time to make BT mic auto selected instead of waiting for user to manually selecting it. Bug: b/170388719 Original change's description: > Lower the priority of Bluetooth mic even in wideband > > Bug: b/156333981 > Change-Id: Ieec9421a98119684f3ad901b16c1ad8dbe8998ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196082 > Reviewed-by: Jenny Zhang <jennyz@chromium.org> > Commit-Queue: Hsinyu Chao <hychao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772093} TBR=hychao@chromium.org,jennyz@chromium.org,cychiang@chromium.org,yshavit@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/156333981 Change-Id: I855eb8f92c94d72f54379b4bdac15ff07c410c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462901Reviewed-by:
Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Cr-Commit-Position: refs/heads/master@{#816409}
-
Maggie Cai authored
This reverts commit 052bc3e7. Reason for revert: Suspect this CL causes build failure in mac-arm64-rel that closed the tree (https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/2680). Original change's description: > Update V8 to version 8.8.74. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/ba88e59b..7bb48090 > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I95a61574ebdaa9fcab1866231cd4a46092517bd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462181 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#816339} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I40e3934738ef5889554da388738b4dfd2b8a979f No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467043Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#816408}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4efaf5e9fead..a587865e0537 2020-10-13 michaelludwig@google.com Enable new GrClipStack for flutter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ia3de534048166f7d5f070b02c02b8c5966bccaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465059Reviewed-by:
-
Avi Drissman authored
For apps compiled against the macOS 11.0 SDK, TCC will crash if the NSBluetoothAlwaysUsageDescription string isn't available and Bluetooth APIs are called. Provide an NSBluetoothAlwaysUsageDescription string. For now, just reuse the generic IDS_RUNTIME_PERMISSION_OS_REASON_TEXT string, but in the future, perhaps better strings could be used. Bug: 1126246 Fixed: 1134360 Change-Id: I6252d43fb98ce5bd4be0504260347b933c09834b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466148Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816406}
-
Lei Zhang authored
In OutOfProcessInstance::HandleUpdateScrollMessage(), the messages received from JS sometimes contain integers and sometimes contain doubles. As such, check validate them with is_number() rather than is_int(). Bug: 1136983 Change-Id: Id3112e660a96d596b9da92c453caa5f697e5a5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466514Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38f6d78eae8f..d21d9e8681bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com,mahmadi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1081649,chromium:1100278 Tbr: mxcai@google.com,mahmadi@google.com Change-Id: Ib69942f61138041997fb61e0abee6f2fa89e6025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466820Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816404}
-
Peter Boström authored
This enables removing overrides to CalculatePreferredSize() that try to return a fixed size to fit within a specific dialog width. It also fixes infinite recursion in such overrides where there's no LayoutManager and GetHeightForWidth() defaults to calling GetPreferredSize(), which calls the CalculatePreferredSize() override that calls GetHeightForWidth(). Bug: 1128500 Change-Id: I75508e790cd6d7fdc31a40b5dad96366ddf8545c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466141 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816403}
-
Charlene Yan authored
Changing dragging collapsed group header tests to checking that the group expands when drag starts. There are other tests for dragging an expanded header. It was also bugged since functionality was added to auto create a bubble on tab group creation, and the tests were not updated. Change-Id: I456b4b1c0e6b834fcc553b1dfd7619b8a7e5c893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457370Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816402}
-
Maggie Cai authored
This reverts commit c67306a2. Reason for revert: This breaks build Linux ChromiumOS MSan Tests in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20900 Failed test is DevToolsListenerBrowserTest.CanCollectCodeCoverage Original change's description: > [filesapp] Add a browser_test for DevToolsListener class > > Test that JS code coverage of a JS IFFE injected in a WebContents gets > collected by DevToolsListener and stored in a ScopedTempDir. > > Test: browser_tests --gtest_filter="*DevToolsListener*" > Bug: 1113941 > Change-Id: I8f04f2e704d677823ffa154272605798b7046f77 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461602 > Commit-Queue: Ben Reich <benreich@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816064} TBR=noel@chromium.org,benreich@chromium.org Change-Id: I2d838b427cd407a19ac7eb82bae1cf3ffe13592a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467039Reviewed-by:
-
Maggie Cai authored
This reverts commit 4734ecf2. Reason for revert: https://crrev.com/c/2461602 breaks build Linux ChromiumOS MSan Tests in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20900 Failed test is DevToolsListenerBrowserTest.CanCollectCodeCoverage Original change's description: > [filesapp] Add missing includes and fail if host crashed > > Adds #include's that were missing from the initial patch, and FAIL the > test if the DevToolsAgentHost attached to crashes during the test. > > Fix HostString() helper to *actually* take an optional prefix: use C++ > c++17 {} style initializer. > > Test: browser_test --gtest_filter="*DevToolsListener*" > Bug: 1113941 > Change-Id: I5901019add9fea92b6e3a8b5b881b8d3d197b6c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465456 > Commit-Queue: Ben Reich <benreich@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816070} TBR=noel@chromium.org,benreich@chromium.org Change-Id: I87ec9b3db970807af8fc75ca137fc83397f775bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466016Reviewed-by:
-
Michael Bai authored
SentNodes is a wrapper of HeapHashSet and has little value be a separated class. This patch also moves SentNodes to TaskSession, it was used to share the SentNode between the different ContentCaptureTasks, but ContentCaptureTask will never be recreated. Bug: 1137463 Change-Id: Ic8f958a8ae4da957fd3ab49e1b65faa9508acac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466505Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#816399}
-
Dale Curtis authored
Wrapped frame should always take precedent and the DCHECK prevents wrapping frames that have textures. R=ccameron, sandersd Bug: None Test: Passes existing tests. Change-Id: Ibfbc5b329918a9223699dc6b01187a3b283d126c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466838 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#816398}
-
Yulun Wu authored
This CL addresses changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2425623 Bug: 1134800 Change-Id: I95d8508a817e2b2d32885db84c5ce5129eee52d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464443 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#816397}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/182a24a6540b..9103d0e4fc9b 2020-10-12 jegarc@microsoft.com Fix enum sending telemetry for issues panel opened resource. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135327 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I584a23c314f481ffde4d9b05cc1d30646db735b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466172Reviewed-by:
-
Anupam Snigdha authored
Removed the keyboard bounding rectangle from geometrychange event. The keyboard rectangle is now a property of virtualKeyboard object. It gets updated when the geometrychange event is fired. The keyboard rectangle can also be captured from CSS env variables: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/VirtualKeyboardAPI/explainer.md#virtual-keyboard-visibility-change-css-environment-variables This was also a feedback from TAG: https://github.com/w3ctag/design-reviews/issues/507#issuecomment-665473068 Bug: 1127749 Change-Id: Id7f19b0e091b820fa45ba4181d482559846d40ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466402 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816395}
-
Gyuyoung Kim authored
This CL replaces all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy to reduce unnecessary type conversion. Bug: 1097943 Change-Id: I16cbe3223fcfd62375cd7fac1e697cdb90d2b248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463049 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#816394}
-
Minoru Chikamune authored
[Context] This is a part of an effort to achieve MBI. We want to avoid per-thread task runner as much as possible. [Previous code] RenderFrameImpl::GetInterfaceProvider was using per-thread default task runner because task_runner was not specified. [What this CL does] Use per-frame task runner for RenderFrameImpl::GetInterfaceProvider instead of per-thread task runner. [Rlated stack trace] base::SequencedTaskRunnerHandle::Get() mojo::internal::GetTaskRunnerToUseFromUserProvidedTaskRunner() mojo::internal::BindingStateBase::BindInternal() mojo::internal::BindingState<>::Bind() mojo::Receiver<>::Bind() mojo::Receiver<>::Receiver() mojo::ReceiverSetBase<>::Entry::Entry() std::__Cr::make_unique<>() mojo::ReceiverSetBase<>::AddImpl() mojo::ReceiverSetBase<>::Add() content::RenderFrameImpl::GetInterfaceProvider() content::mojom::FrameStubDispatch::Accept() Bug: 1105403 Change-Id: I9a9c8110ed0746b80cab30604f7ac6f6707211e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465607Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#816393}
-
James Cook authored
Ash stopped handling these fields in M87. Going forward, all Lacros releases will target M87 beta or later (M87 beta + M88 dev/canary). Therefore Lacros can stop sending these fields. Clean up SkBitmapFromBitmap utility function, since it is no longer used. We can't clean up BitmapFromSkBitmap yet, since it's still used by ScreenManager. Bug: 1123969 Test: lacros unit_tests Test: trigger notifications using Notifications Galore test app Change-Id: I631d1d955cdbe6c34cfecf00d701eec57c9455dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466491Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816392}
-
Tomasz Tylenda authored
The changelist modifies code locations where the caller explicitly requires base::OnceCallback. BUG=764795 TESTED=build Change-Id: I1717303bbdbd42ce3cbe2c33a5db6031b9266d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462858Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#816391}
-
Wan-Teh Chang authored
There is an API change in this libavif update. avifDecoderParse() no longer takes the image data as input. Instead, an avifIO object needs to be associated with an avifDecoder, and the avifDecoder calls the read() method of the avifIO object to read image data incrementally. Eventually Chrome will use its custom avifIO implementation. For now just use the built-in avifIO object that reads from a memory buffer. https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/1d32f88ab33e..0265cd7a10d1 $ git log 1d32f88ab..0265cd7a1 --date=short --no-merges --format='%ad %ae %s' 2020-10-08 jdrago Add some clarifying comments to the avifDecodeSample struct 2020-10-08 wtc Declare the sizeHint field of avifIO as uint64_t 2020-10-08 wtc avifDecoderReadItem callers can rely on contract 2020-10-08 wtc Change prototypes of functions for memory avifIO 2020-10-08 wtc More cleanup for avifDecoderReadItem() 2020-10-08 wtc Compare frameIndex with INT_MAX before int cast 2020-09-23 wtc Check for avifImageRGBToYUV failures 2020-10-07 wtc Use CHECKERR in avifDecoderFindMetadata() 2020-10-08 wtc Rewrite a loop as a do-while loop 2020-10-08 wtc Miscellaneous comment fixes (...) 2020-09-24 jdrago Reintroduce an important size check in avifROStreamReadBoxHeader() 2020-09-23 wtc Fix GCC -Wclobbered warnings 2020-09-23 derek.buitenhuis avifIO: Remove API functions that take FILE* arguments 2020-09-22 jdrago avifdec: Error out properly when RGB conversion fails 2020-09-22 dnovomesky Use new API in gdk-pixbuf loader 2020-09-21 jdrago Mark avifIOCreateTestReader as static 2020-09-21 jdrago avifenc: Allow the setting/overriding of XMP, Exif, and ICC profiles 2020-09-21 jdrago Move Exif and XMP metadata (if present) to the front of the mdat for streaming considerations 2020-09-21 jdrago Rename sizeLimit to sizeHint, it better matches the comment and conveys its optional nature 2020-09-21 jdrago avifIO reader API Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org,pkasting@chromium.org Bug: 1136922 Change-Id: I53e9600ec3650aa59212483e3281c9765b935533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462936Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#816390}
-
Dominic Mazzoni authored
cr-checkbox uses a hidden element as the target of the aria-describedby attribute. However, while that element is hidden visually it's still part of the accessibility tree so screen reader users perceive two different elements - the checkbox, followed by the description. To fix this, we can just hide the description with aria-hidden=true. Its text is still computed correctly by aria-describedby. Bug: 1101148 Change-Id: I213d2164dad6f0f4a9caa194b16b14e7a4b85580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466060Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#816389}
-
Hiroki Sato authored
CL:2424854 changed automation event generation and as a result some ARC events are dispatched duplicately. Specially, value range change events are dispatched twice, and tast test started to fail. This change fixes it by changing the event type that ARC dispatches from value changed event to aria attribute changed so that we can delegate AXEventGenerator to generate this type of event. AX-Relnotes: n/a Bug: b:169201305 Test: tast arc.AccessiblityEvent Test: unit_test AXTreeSourceArcTest,ArcAccessibilityUtilTest Change-Id: Ie635619c13d605b0bf9ec3633f9ac5eb0109f89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462883 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Auto-Submit: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#816388}
-
Maggie Cai authored
This reverts commit 725f9a2e. Reason for revert: This CL is likly cause components_unittests failure for Linux ChromiumOS MSan Tests build starting from: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20905 The failed tests are ArcDataSnapshotdManagerFlowTest and ArcDataSnapshotdManagerBasicTest Original change's description: > arc: auto-login to MGS with blocked UI screen > > Add an auto-login to Managed Guest Session / public account to start ARC > snapshot creation. > Block auto-login flow even if specified by policy. > Wait for ArcDataSnapshotdManager successfully generates a key pair and > auto-login to MGS once it is ready. > > BUG=b:161221001 > TEST=components_unittests > TEST=browser_tests > > Change-Id: Ib7895f49f9295b3959226cde3e304c9c78614e93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440872 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Polina Bondarenko <pbond@chromium.org> > Auto-Submit: Polina Bondarenko <pbond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816186} TBR=yusukes@chromium.org,achuith@chromium.org,rsorokin@chromium.org,pbond@chromium.org Change-Id: Idfc1e81798a013b6f86f57d7fe3de2d2dabeb09a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:161221001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465894Reviewed-by:
-
Gang Wu authored
Search widget tests involve two activities, the search activity and the chrome tabbed activity, so switching between two activities takes time, especially on some slow devices. Therefore, increase time out to make the tests more stable. Bug: 1114938 Change-Id: Ia02c40df5250ebeec43e2540575edadef3b9ec83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464906 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#816386}
-
Maggie Cai authored
This reverts commit 7ea4118e. Reason for revert: This CL is likely the cause that create ash_unittests and browser_tests failures in linux-chromeos-dbg build starting from https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20815. The failed tests are FrameSizeButtonTest, ImmersiveModeBrowserViewTestNoWebUiTabStrip and ImmersiveModeBrowserViewTest. Original change's description: > Move //ash/public/cpp/caption_buttons to //chromeos/ui > > This is step 1.2 on the design document [1]. > > [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit > > BUG=1113900 > R=jamescook@chromium.org, sky@chromium.org > > Change-Id: Ic625b887b00538d758260a3f35426c346bcdbabf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458768 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816200} TBR=jamescook@chromium.org,sky@chromium.org,oshima@chromium.org,tonikitoo@igalia.com Change-Id: I405b3bcbc62d1076f45579cb1bb29eaf5a526f99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465893Reviewed-by:
-
Maggie Cai authored
This reverts commit 2ad3f0c5. Reason for revert: CL:https://crrev.com/c/2458768 is likely the cause that create ash_unittests and browser_tests failures in linux-chromeos-dbg build starting from https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20815. The failed tests are FrameSizeButtonTest, ImmersiveModeBrowserViewTestNoWebUiTabStrip and ImmersiveModeBrowserViewTest. I'm not 100% sure this CL is depend on the culprit, but it is linked from that CL, so I reverted this just in case. Original change's description: > Add TabletState::Observer and adopt in BrowserNonClientFrameViewAsh > > This replaces the use of ash::TabletMode and ash::TabletModeObserver in > BrowserNonClientFrameViewAsh. > > This corresponds to phase 2.6 on the design document [1]. > > Covered by existing tests, eg > > BrowserNonClientFrameViewAshTest.BrowserHeaderVisibilityInTabletModeTest > HomeLauncherBrowserNonClientFrameViewAshTest.TabletModeBrowserCaptionButtonVisibility > > [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ > > BUG=1113900 > R=sky@chromium.org > > Change-Id: I6a21ca44538e52a2712bbb936221aa24063daa36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462560 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816316} TBR=jamescook@chromium.org,sky@chromium.org,tonikitoo@igalia.com Change-Id: I8f8ad38e07c26eee09fec0efc6ca3cbf882a2719 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466014Reviewed-by:
-
Moe Ahmadi authored
This reverts commit 2c428e54. Reason for revert: Breaking: https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/72572 Original change's description: > Fix TextChanged UIA events > > Blink fires the TextChanged event for all sorts of reasons, and it > leads to flakiness and difficulty fixing other bugs. > > Instead, fire this event when a static text node has changed its text > using AXEventGenerator, which is more stable and predictable. > > When static text changes under UIA, fire a text-changed event > rather than raising a property-changed for UIA_NamePropertyId. > > Add AXEventGenerator::Event::EDITABLE_TEXT_CHANGED which is fired on an > editable root when static text within an editable text region changes. > > Bug: 904977, 1062063, 1085481, 1105262 > Change-Id: Ic655deba0d1a5ab1fb575ffa8a56cef1c538c923 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393067 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#816341} TBR=dmazzoni@chromium.org,kschmi@microsoft.com,iapres@microsoft.com,Adam.Ettenberger@microsoft.com Change-Id: I5232e81f268194fb38ee1349cee8ea51497bba59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904977 Bug: 1062063 Bug: 1085481 Bug: 1105262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466998Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816383}
-
Moe Ahmadi authored
This reverts commit 04ee981e. Reason for revert: Breaking win-chrome See: https://ci.chromium.org/p/chrome/builders/ci/win-chrome/15856 Original change's description: > Enable "Immersive-AR" session for OpenXR runtime > > The OpenXR runtime on Windows supports both "opaque" (WMR VR devices) and "additive" (Hololens). This change simply turns on support for Immersive-AR session according to the WebXR AR-module spec. The majority of the change is to let the runtime to decide about the blend_mode and interaction_mode instead of the current guessing logic at at the renderer layer. > > Bug: 1069350, 944936 > Change-Id: Ie5f1b56857f9ca5357dbd1dde6585687773d0b56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432759 > Commit-Queue: Phu Le <phle@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816352} TBR=dcheng@chromium.org,bajones@chromium.org,rafael.cintron@microsoft.com,klausw@chromium.org,alcooper@chromium.org,phle@microsoft.com Change-Id: I0882e685902eb584ee2e417369a16697d21d1dfa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069350 Bug: 944936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466997Reviewed-by:
-
Ted Meyer authored
Enable buildflag USE_VAAPI_IMAGE_CODECS when we're not on linux and still using vaapi. Change-Id: Id46698262b81c262a8b92636d0373cba4ebb5b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441959 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#816381}
-
Alex Turner authored
Currently, mainframes which do not have a committed load (e.g. due to their initial load being aborted by a document.write() call) never have the subresource filter activated. Further, each popup mainframe that is same-origin to its opener (whether or not it has a committed load) should share the activation of its opener as the opener determines its contents including, for example, through document.write() calls. There are two cases to consider for same-origin popups. First, a popup with an inherited origin (e.g. an about:blank frame) should inherit the activation of its opener; it would not otherwise be activated as its URL wouldn't match the filter list. Second, a popup with a URL that is handled by the network stack and is same-origin does not need to inherit its activation as activation-rules are site-based, i.e. apply equally to all pages with the same eTLD+1. The activation resulting from the normal process for committed navigations will therefore be the same as the opener's. This cl creates a filter with the activation of the opener for mainframes without a committed load or with an inherited origin. If the inherited activation is disabled, no filter is created. This inheritance behavior is similar to that of subframes with an aborted initial load and of about:blank subframes, both of which inherit the activation of their parent frames. Design doc (internal-only): https://docs.google.com/document/d/12ocy5qgoMZh0Ntl6Ah3Q0GShXzRxHmSmArDy7gWGtJM/edit?usp=sharing Bug: 1055558 Change-Id: I46d3d73d193f86323fe5b9e4c90ceba989ab7abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219104 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816380}
-
Garrett Beaty authored
Bug: 1137576 Change-Id: I40c5647cbdf6773e0c37285b1b4d4b4c7c8c0f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466839 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#816379}
-
Karandeep Bhatia authored
Add tests for remotely hosted code in isolated worlds for Mv2 and Mv3 extensions. This tests that operations in an isolated world which execute remotely hosted code are prohibited using a strict CSP. BUG=896041 Change-Id: Iec0433d023445adf27d463b5f259d6a2b63196e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451501 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816378}
-
Chan Li authored
Bug: 1108016 Change-Id: Iad39bda46a2dfbdebfd7f709ec0ce90ea6cec778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466167Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#816377}
-
Zentaro Kavanagh authored
- Takes a list of routines and runs them sequentially using the mojo interface SystemRoutineController Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ia535db169eb141d611ecf94cd600a0e6920339b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464072Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#816376}
-
Matthew Mourgos authored
This CL adds text to the nudge view and an inline icon to represent the key to press to activate the keyboard shortcut. The icon shows as either a search icon or a launcher icon, depending on what the device supports. If the launcher icon is to be shown, then the icon is changed depending on if assistant is available. Bug: 1105541 Change-Id: Ieaad19c899af545f38410350ece2d30a48409a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463869Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816375}
-
Timothy Loh authored
This CL simplifies the code for downloading Plugin VM images: - Remove PluginVmInstaller::OnDownloadCancelled(). It is not necessary for us to wait for the download to cancel. If the download service takes a while to (or fails to) cancel, we will still be able to retry the installation. - Instead of tracking pre-existing downloads, compare download guid to the current download guid. - Remove excess VLOGs Bug: b/169973809 Change-Id: Icea90298768ad66e102d6af127e739a768687975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465349Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816374}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a7b0fdc90fea..51af1b428f5f 2020-10-12 natlee@microsoft.com Have Queue timeline tasks resolve in order If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I1460c559b300eedd0161e48e42d0c302f2346d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466722Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816373}
-
