- 13 May, 2015 40 commits
-
-
geofflang authored
https://chromium.googlesource.com/angle/angle/+log/b11e24..71632d BUG=484963 BUG=483252 Review URL: https://codereview.chromium.org/1141753002 Cr-Commit-Position: refs/heads/master@{#329727}
-
felt authored
The UwS interstitial launch went well, so there's no longer any reason for a Finch gate. This kills the Finch-related logic. BUG=451123 Review URL: https://codereview.chromium.org/1134603004 Cr-Commit-Position: refs/heads/master@{#329726}
-
wnwen authored
Fixes 6 out of 8 slow StrictMode violations. BUG=473357 Review URL: https://codereview.chromium.org/1129283004 Cr-Commit-Position: refs/heads/master@{#329725}
-
estark authored
This CL moves |GetSecurityLevelForWebContents| and the |SecurityLevel| enum into a class of their own: |ConnectionSecurityHelper| in //chrome/browser/ssl (since it is applying Chrome-specific security policy to determine the security level of a page). Later, we will use the new |ConnectionSecurityHelper| class to compute a security level for a page to send to the DevTools Security panel. Specifically, we need to be able to calculate the security level for a given page, not just the WebContents for the active tab. BUG=484392 Committed: https://crrev.com/ca7c0a3374c21ab10c821f4f3a890afc79182acf Cr-Commit-Position: refs/heads/master@{#329591} Review URL: https://codereview.chromium.org/1123943002 Cr-Commit-Position: refs/heads/master@{#329724}
-
estark authored
The pre-existing |CertificateErrorReporter| class (in //chrome/browser/net) is now only in charge of sending reports over the network. A new class (|CertificateErrorReport| in //chrome/browser/ssl) is in charge of building and serializing the reports. The motivation for this change is to allow reports to include interstitial-specific information (such as the type of interstitial that was shown, whether the user clicked through, etc.). So as to avoid introducing interstitial knowledge into //c/b/net, all the report building and serializing knowledge (including the report protobuf) has been moved into //c/b/ssl. |SSLBlockingPage| now sends a serialized report through |ChromeContentBrowserClient| to the SafeBrowsing UIManager to be sent over the network. |ChromeFraudulentCertificateReporter| (responsible for reporting Google-property pinning violations) has also been moved into //c/b/ssl so that it can use the new |CertificateErrorReport| class to build reports before sending them with a |CertificateErrorReporter|. BUG=462713,461588 Review URL: https://codereview.chromium.org/1117173004 Cr-Commit-Position: refs/heads/master@{#329723}
-
simonhatch authored
Right now we have no easy visibility on time taken for individual tests, since everything runs under one massive "Sharded Perf Tests" step. We're trying to balance the tests across devices to improve cycle time, so we need a way to see how long each test is actually taking. BUG=466101 Review URL: https://codereview.chromium.org/1140783002 Cr-Commit-Position: refs/heads/master@{#329722}
-
jdduke authored
There are ongoing improvements to smart selection that likely will not land before M44 branch. Disable it for now, avoiding the need to cherry-pick any eventual updates. BUG=451255 Review URL: https://codereview.chromium.org/1135313003 Cr-Commit-Position: refs/heads/master@{#329721}
-
jyquinn authored
Implements WebUI for WKWebView by using URLFetcher to manually request and retrieve WebUI resources and subresources, and load the page via loadHTMLString. Sets favicons for history page using JavaScript. BUG=450362 Review URL: https://codereview.chromium.org/1137143004 Cr-Commit-Position: refs/heads/master@{#329720}
-
halliwell authored
Rotations and flips were listed in the enum, but not being allowed by OverlayCandidate::GetOverlayTransform. BUG= Review URL: https://codereview.chromium.org/1135813005 Cr-Commit-Position: refs/heads/master@{#329719}
-
jvoung authored
StartSrpcServices will require using the service_runtime pointer, to set up the srpc_client pointer. So we cannot destroy the service_runtime at the same time. E.g., if I add a sleep() to induce the race, I get: ../../native_client/src/include/nacl_scoped_ptr.h:96: C *nacl::scoped_ptr<plugin::SelLdrLauncherChrome>::operator->() const [C = plugin::SelLdrLauncherChrome]: Assertion `ptr_ != __null' failed. Received signal 6 #0 0x7f687f4aef7e base::debug::StackTrace::StackTrace() #1 0x7f687f4aeabf base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f6879dee340 <unknown> #3 0x7f6876504cc9 gsignal #4 0x7f68765080d8 abort #5 0x7f68764fdb86 <unknown> #6 0x7f68764fdc32 __assert_fail #7 0x7f688e2887f2 nacl::scoped_ptr<>::operator->() #8 0x7f688e288487 plugin::ServiceRuntime::SetupAppChannel() #9 0x7f688e28cb76 plugin::NaClSubprocess::StartSrpcServices() #10 0x7f688e281810 plugin::PnaclTranslateThread::DoLink() #11 0x7f688e27fe7d plugin::PnaclTranslateThread::DoLinkThread() #12 0x7f6879de6182 start_thread #13 0x7f68765c847d clone Should have checked this in previous refactoring: https://codereview.chromium.org/1128943003 BUG=473474 Review URL: https://codereview.chromium.org/1128373005 Cr-Commit-Position: refs/heads/master@{#329718}
-
dnicoara authored
Otherwise we lose track of display layout. In particular this is a problem when dealing with software mirror mode since the state goes out of sync and the second monitor will have the same origin as the primary even though it's supposed to be right-of primary. Follow-up to https://codereview.chromium.org/1129923004/ to fix software mirror mode. BUG=484294 TEST=Test software mirror mode and make sure it works Review URL: https://codereview.chromium.org/1140773003 Cr-Commit-Position: refs/heads/master@{#329717}
-
reillyg authored
JSON string literals are hard to work with because of all the escaping necessary. The DictionaryBuilder class makes it easy to construct a base::Value with code. Review URL: https://codereview.chromium.org/1138013006 Cr-Commit-Position: refs/heads/master@{#329716}
-
trchen authored
Revert of Fix WebViewPlugin::scheduleAnimation crash (patchset #2 id:20001 of https://codereview.chromium.org/1137663006/) Reason for revert: This is converting the original crash to another crash. Will need another null check. Original issue's description: > Fix WebViewPlugin::scheduleAnimation crash > > The crash was probably due to accessing a dangling pointer to the plugin > container during a small time frame between PepperWebPluginImpl::destroy() > and the destructor being called. (Speculated from source since no reliable > repro is found.) > > This CL clears eveything in the destroy() function as if the destructor has > been called, only delaying memory release. > > R=tommycli > BUG=483068 > > Committed: https://crrev.com/6a9b5b10ff3515adb47718fc23ebe039a9e3b9ff > Cr-Commit-Position: refs/heads/master@{#329309} TBR=tommycli@chromium.org,raymes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487607,483068 Review URL: https://codereview.chromium.org/1127293004 Cr-Commit-Position: refs/heads/master@{#329715}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/ce97eb7..7a62fa1 TBR=alancutter@chromium.org,jsbell@chromium.org Review URL: https://codereview.chromium.org/1140083003 Cr-Commit-Position: refs/heads/master@{#329714}
-
bcwhite authored
BUG=477632 Review URL: https://codereview.chromium.org/1143443002 Cr-Commit-Position: refs/heads/master@{#329713}
-
patrikackland authored
BUG=412250 Review URL: https://codereview.chromium.org/1136283007 Cr-Commit-Position: refs/heads/master@{#329712}
-
jamiewalch authored
Without this, the downscoped token was being revoked, but the call to get a fresh one was returning the cached non-downscoped token. Also adds an assert to catch regressions. BUG=b/20662147 Review URL: https://codereview.chromium.org/1123183005 Cr-Commit-Position: refs/heads/master@{#329711}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/38a017b..1ba8cc9 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1137353002 Cr-Commit-Position: refs/heads/master@{#329710}
-
andresantoso authored
Reduce GPU watchdog's polling interval from 2 seconds to 5 seconds. Also remove unnecessary CheckArmed() call from DidProcessTask(). Although CheckArmed() checks first whether it needs to post the task, WillProcessTask and DidProcessTask is called so quickly that armed() still returns true, so we ended up posting the task twice most of the time. BUG=483622 Review URL: https://codereview.chromium.org/1133703002 Cr-Commit-Position: refs/heads/master@{#329709}
-
kenrb authored
In order to enable renderer processes to create SurfaceSequences, they have to receive Surface ID namespaces from the browser process so that they can avoid collisions. BUG=478802 Review URL: https://codereview.chromium.org/1129883003 Cr-Commit-Position: refs/heads/master@{#329708}
-
sergeyu authored
Previously SSLServerSocketOpenSSL was ignoring disabled_cipher_suites list and require_forward_secrecy flag from SSLConfig. Fixed SSLServerSocketOpenSSL to trim the list of cipher suites used in BoringSSL. BUG=481163 Committed: https://crrev.com/d0eae58087e6f45088d6ef349d9ebaa2da450ea1 Cr-Commit-Position: refs/heads/master@{#329528} Review URL: https://codereview.chromium.org/1138813003 Cr-Commit-Position: refs/heads/master@{#329707}
-
erg authored
This moves the resource provider into the main core service process, too, eliminating one of the processes. BUG=477435 Review URL: https://codereview.chromium.org/1137223002 Cr-Commit-Position: refs/heads/master@{#329706}
-
fmalita authored
Drawing LCD text into non-opaque layers is never correct - we should update DrawProperties.can_use_lcd_text during animations also. BUG=486892 R=danakj@chromium.org,enne@chromium.org Review URL: https://codereview.chromium.org/1132253003 Cr-Commit-Position: refs/heads/master@{#329705}
-
xiaolingbao authored
Only update icon if the new one is not null on x11, no-op for null icon (follow the same way as Windows platform does in HWNDMessageHandler::SetWindowIcons) BUG=478714. Review URL: https://codereview.chromium.org/1138343003 Cr-Commit-Position: refs/heads/master@{#329704}
-
mpearson authored
In the days of yore, there was an HQP crash: https://code.google.com/p/chromium/issues/detail?id=359270 I put a band-aid on the crash: https://codereview.chromium.org/222783006 Later, I fixed the root cause: https://codereview.chromium.org/255423002 Or at least I thought I did and close that days-of-yore bug. Apparently this didn't entirely fix the problem. (See the linked bug below.) This change adds some information to the minidumps to allow me to investigate what kinds of inputs are causing trouble. BUG=464926 Review URL: https://codereview.chromium.org/1133533003 Cr-Commit-Position: refs/heads/master@{#329703}
-
sky authored
Latest changes broke the android side. R=ben@chromium.org BUG=none TEST=none Review URL: https://codereview.chromium.org/1134443005 Cr-Commit-Position: refs/heads/master@{#329702}
-
newt authored
These stats are currently used by internal code, but that code will be moved into Chromium soon. BUG=483656 Review URL: https://codereview.chromium.org/1123243006 Cr-Commit-Position: refs/heads/master@{#329701}
-
rsesek authored
BUG=487674 Review URL: https://codereview.chromium.org/1136953012 Cr-Commit-Position: refs/heads/master@{#329700}
-
avi authored
BUG=369661 TEST=All navigation tests remain green. Review URL: https://codereview.chromium.org/1131183004 Cr-Commit-Position: refs/heads/master@{#329699}
-
jlklein authored
BUG= Review URL: https://codereview.chromium.org/1131713006 Cr-Commit-Position: refs/heads/master@{#329698}
-
vmpstr authored
Raster source moved to be in PrioritizedTile returned by the priority queues. This patch cleans up the ctor to remove the now unused raster source parameter. R=hendrikw Review URL: https://codereview.chromium.org/1130303004 Cr-Commit-Position: refs/heads/master@{#329697}
-
skyostil authored
This patch was mostly autogenerated with https://codereview.chromium.org/1010073002/. BUG=465354 Review URL: https://codereview.chromium.org/1134113002 Cr-Commit-Position: refs/heads/master@{#329696}
-
yoshiki authored
BUG=480489 TEST=run newly added tests Review URL: https://codereview.chromium.org/1139963004 Cr-Commit-Position: refs/heads/master@{#329695}
-
jpawlowski authored
This patch adds wiring to expose TxPower field during device discovery. BUG=407773 R=armansito@chromium.org Review URL: https://codereview.chromium.org/1133173002 Cr-Commit-Position: refs/heads/master@{#329694}
-
samuong authored
BUG=413075 Review URL: https://codereview.chromium.org/1135203005 Cr-Commit-Position: refs/heads/master@{#329693}
-
rockot authored
This is an addendum to r329262 which still didn't quite get it right. The assumption here is now that the IPCSupportInitializer must outlive the IO thread anyway, so the IO loop observer may (and should) call ForceShutdown immediately rather than posting a task. BUG=486004 R=jam@chromium.org Review URL: https://codereview.chromium.org/1143433003 Cr-Commit-Position: refs/heads/master@{#329692}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/046ebcb..ce97eb7 TBR=alancutter@chromium.org,jsbell@chromium.org Review URL: https://codereview.chromium.org/1133823005 Cr-Commit-Position: refs/heads/master@{#329691}
-
bshe authored
After user decided to switch back to FULL_WIDTH mode, Chrome should: 1. immediately position the virtual keyboard to the bottom of screen and use the screen width as its window width 2. notify web contents about the new virtual keyboard bounds so web contents can be scrolled correctly to avoid occlussion. BUG=487343 Review URL: https://codereview.chromium.org/1138873003 Cr-Commit-Position: refs/heads/master@{#329690}
-
tedchoc authored
I do not have a win7 machine, so I'm assuming the issue is with rounding of some sort. Setting to more standard sizing (700 for weight to match bold) and removing the font-size declaration as it was not really needed. Also added a drop shadow above the relaunch bar...for flair! BUG=487597 Review URL: https://codereview.chromium.org/1135423002 Cr-Commit-Position: refs/heads/master@{#329689}
-
aurimas authored
Due to b/20882793 bug in AppCompat we need to use system AlertDialog.Builder for all the dialogs that contain EditText. BUG=484658 Review URL: https://codereview.chromium.org/1128683004 Cr-Commit-Position: refs/heads/master@{#329688}
-