GitLab

BUG=919789,1021627
TBR=waffles

Change-Id: I890aa4c6573f16ad66a353083bae85449313e3e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899320Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712734}

It's still useful, see e.g. crbug.com/1021537

Bug: 1021168
Change-Id: I4f870f93c65532277763fb5dab1eb3096f5ea680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899846
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712733}

This prevents SelectFileDialog::Listener methods implemented by
MediaRouterFileDialog from getting called after it is destroyed.

Bug: 907273
Change-Id: I5ec03d832f1062ff1c2259f765f397b7af4c90a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898404Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712732}

Bug: 429358
Change-Id: I8703b47bb3094f7918456685545b786d78f09ddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900291
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712731}

Previously SysmemBufferWriterQueue wasn't handling properly the case
when a packet is destroyed after ResetBuffers(). Updated ResetBuffers()
to drop weak pointers, to ensure that ReleaseBuffer() is not called
after ResetBuffers().

Bug: 1021646
Change-Id: I75045ce7427eb0c539bd198bb73a5a742531f0f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899319
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712730}

https://swiftshader.googlesource.com/SwiftShader.git/+log/b0a1f0a96806..215bc7949b35

git log b0a1f0a96806..215bc7949b35 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 jonahr@google.com Add VK_EXT_metal_surface extension support

Created with:
  gclient setdep -r src/third_party/swiftshader@215bc7949b35

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:1015454
Change-Id: I84f888801317b9e8c761f94887ae89b12c9ccbda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900111Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712729}

There is an edge case where ARC returns an empty list of handlers for
tel links. Usually there is at least the Contacts app installed but in
case there was an error we still want to append devices to select from.

With this change we always call through
ShowExternalProtocolDialogWithoutApps which then calls
ShowFallbackExternalProtocolDialog if there are no devices.

Test: Added a test case that verifies that for an empty list of apps we
correctly show the external protocol dialog with devices.

Bug: 1020155
Change-Id: Idb55d8548d8c428c6864a3f6cdf50baa8ffff663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890440Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712728}

BUG=1020806
TBR=khmel

Change-Id: Ia6d051c5b4e5408312d8247085821fc27780df92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899318Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712727}

Content layer doesn't need to know about this message and can be solely
defined in blink.

Remove LifecycleStateChanged from WebLocalFrameClient interface and
move to blink's mojo interface.

BUG=1008432

Change-Id: I72b7e7b8c9b43b990de57f72ed3e48d8852570e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896766
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712726}

We've previously relied on almost all code in Chromium to start
with a license header, and therefore placing <include> behind
single-line JS comments, as in:

  // <include src="blah.js">

Harmlessly expands to:

  // // Copyright the Chromium Authors

But this is not always the case, and is kind of a hack. So
instead, detect the case of "// " in front of a <include> and
remove it. So that same "// <include" becomes:

  // Copyright the Chromium Authors

or in the case that the file doesn't have a copyright, the
first line of source code (like in dom_distiller).

Sure, it adds more magic to the system, but it's probably fine.

R=dpapad@chromium.org

Fixed: 1021374
Change-Id: Ie7dbf9607c0a78caa20d0e60662efc9d81f88f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898870Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712725}

Extensions outside Chrome Web Store (self-hosted ones) don't have
hashes signed by Chrome Web Store (stored in verified_contents.json
file), so historically are not checked.

This commit adds support for extensions to be "should check, but
shouldn't verify": if such an extension has computed_hashes.json file,
we'll use it to check extension's content and report appropriately to
delegate.

Bug: 958794
Change-Id: Id8bce11fa42e5a8099f65d3013cb25f2271f51c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735454
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712724}

This reverts commit f1326b9e and
relands 549944d5 without change.

Reason for revert: The flaky test has been fixed in
https://chromium-review.googlesource.com/c/chromium/src/+/1900158

Original change's description:
> Revert "media: Move Renderer creation to PipelineImpl"
> 
> This reverts commit 549944d5.
> 
> Reason for revert: Suspected culprit of WebMediaPlayerImplTest.Encrypted test failures
> 
> The failure appears deterministic on windows: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/42005
> 
> but also will flake often on other platforms:
> https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySgsSBUZsYWtlIj9jaHJvbWl1bUBtZWRpYV9ibGlua191bml0dGVzdHNAV2ViTWVkaWFQbGF5ZXJJbXBsVGVzdC5FbmNyeXB0ZWQM
> 
> Original change's description:
> > media: Move Renderer creation to PipelineImpl
> > 
> > Instead of creating the Renderer in PipelineController before pipeline
> > start which includes Demuxer initialization, this CL moves Renderer
> > creation to PipelineImpl as a step in PipelineImpl::Start() so that the
> > Renderer is only created after the Demuxer has been initialized. This
> > makes it possible to have more flexible Renderer creation, e.g. create
> > different Renderers based on different stream or CDM.
> > 
> > Bug: 1018372, 827990
> > Test: No functionality change.
> > Change-Id: I7398d90915df7905bd627f4e4cf82fae40252ee1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895747
> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#712397}
> 
> TBR=dalecurtis@chromium.org,xhwang@chromium.org
> 
> Change-Id: Iac06fd02de8b4e436ecb16638994cd1b9fb1f7e7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1018372, 827990
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899873
> Reviewed-by: Andy Paicu <andypaicu@chromium.org>
> Commit-Queue: Andy Paicu <andypaicu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712594}

TBR=dalecurtis@chromium.org,xhwang@chromium.org,andypaicu@chromium.org

Change-Id: I64ab3d453034bf0faf7250bcfb3d0015972a9bc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1018372, 827990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900287Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712723}

Content/renderer does not need to know about this message so define
it solely on the blink interface.

BUG=1008432

Change-Id: I522c1bb8462c75e85b480f7784900da75d72e7ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895511
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712722}

TBR=govind@chromium.org

Change-Id: I97baf50eab960fc9cbd6577ad1da4b2bda9632c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900150Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712721}

Bug: 1021543
Change-Id: I794550c57e46d78bbca1ae9ec857e2a27d338874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899779
Auto-Submit: Matthias Körber <koerber@google.com>
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712720}

The function is anonymous::SelectedLinuxBackendToString() and it is
called from KeyStorageLinux::CreateService from under a bunch of
#ifdef's

Change-Id: Ia087cf602b0fc09c76e2f3c77322a66680ed6d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900114
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712719}

This adds a bool to BrowserController.executeScript() which allows
running the script in the main world instead of an isolate.

Change-Id: I0574de6493c99b187963217341c7e003fcfedb3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895320Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712718}

The main purpose of the java heap profiler is to obtain a heap dump in
the form of an hprof file and then parse the hprof file.

Currently,there exists a way to obtain the heap dump but there is no
way to parse the hprof file. This CL includes a barebones parser for
these hprof files.

Bug: 1012072
Change-Id: I7a5d19ba8a4c0284fcae41d7057ad44a0b0acdab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861103
Commit-Queue: George Zhang <zhanggeorge@google.com>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712717}

Before this patch, multiple places in code either used literals for
payment method names (such as "basic-card", "https://google.com/pay") or
defined constants, which were sometimes redundant across platforms. This
slowed down the process of management of these constants, e.g., adding
new method names or tracking down all usage of a single method name.

This patch adds payment_strings.cc (similar to error_strings.cc) with
several constants for payment method names used across iOS, Android, and
desktop non-test code. The patch adds PaymentStrings.java generated from
payment_strings.cc (similarto ErrorStrings.java).

After this patch, iOS, Android, and desktop non-test code re-use the
same string constants for payment method identifiers. This makes adding
a new method names and tracking down usage of each method name easier.

Bug: 1017348
Change-Id: I3a879192a6a383d53089547a567f4127897a7bf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876756
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712716}

The public API is not needed any more now that the WebRTC/Peerconnection
implementation resides solely in Blink.
Hence, this CL uses RtcSessionDescriptionRequest directly.

Note that the CL temporarily duplicates some template definitions
in blink/renderer/modules/peerconnection/rtc_peer_connection_test.cc,
but it will be sorted out when RTCVoidRequest replaces the uses of
WebRTCVoidRequest. The duplication is removed right way in
https://crrev.com/c/1899786 (see relation chain).

Similar CLs: https://crrev.com/c/1890794 and https://crrev.com/c/1884931.

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ic23698aa0fcee899f19ac17c3fe464bf2c11c395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897772
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712715}

https://chromium.googlesource.com/catapult.git/+log/6e71a5063590..bce667b745aa

git log 6e71a5063590..bce667b745aa --date=short --no-merges --format='%ad %ae %s'
2019-11-05 perezju@chromium.org [Telemetry] Do not percent encode story names

Created with:
  gclient setdep -r src/third_party/catapult@bce667b745aa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=skyostil@google.com

Bug: chromium:981349
Change-Id: I74905d3cb5cee230d5ec2f79f6a7430b9f6efea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900110Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712714}

Reland #2 "Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode."

This is a reland of 9d6a01ba

//base now supports ::GetThreadPriority() returning 3, so this
shouldn't cause problems on bots. https://crrev.com/712564

Original change's description:
> Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode.
>
> This experiment enables:
> - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of
>   background threads. This affects memory and IO priority in addition
>   to CPU priority.
> - Increase thread priority to "normal" in scopes where background
>   threads load modules.
>
> The expectation is that this will improve responsiveness of Chrome
> (input delay, first contentful paint), without regressing jank.
>
> We are adding the testing config in preparation for enabling this
> via Finch in M79.
>
> Bug: 973868
> Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023
> Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Auto-Submit: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705960}

TBR=rkaplow@chromium.org

Bug: 973868
Change-Id: I26127cc8e545a1f187a806ed5247c6b91f2f4db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899790Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712713}

This property was added for Mus and it's been here, though it is
always true now. Let's just remove it.

Bug: none
Test: build passes
Change-Id: I1ddbf44e5563984a4516b5800191c5f3b00a0f58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898399
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712712}

This CL prepares the way for the addition of SetFeatureStatus() to the
DeviceSync mojo service. See http://crrev/c/1831010.

Bug: 951969
Change-Id: I488984c741ed7050bef2a78163ef6e93f7aee2b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895887Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712711}

https://pdfium.googlesource.com/pdfium.git/+log/69dd6b02511c..14c3436191d3

git log 69dd6b02511c..14c3436191d3 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 tsepez@chromium.org Add some missing ObservedPtr<> comparison operators

Created with:
  gclient setdep -r src/third_party/pdfium@14c3436191d3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: I0c6d437c58d3cba4f762ac6041b1b61a44658c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900107Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712710}

The current test has a race condition that by the time MetaData is
reported (right after Demuxer initialization), the Renderer might not
have been initialized (which triggers the "waitingforkey" event, that
will trigger DidBlockPlaybackWaitingForKey().

This CL fixes the test so that Load() will wait for
DidBlockPlaybackWaitingForKey() to avoid this race condition.

Bug: 1021574
Test: Fix flaky test.
Change-Id: Icd3bdae9ceb2a5bb7791418e729e68e323ff74fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900158Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712709}

When feature libraries for DFMs were introduced, the library name
matched the .so name (eg. libvr.so).  This made library loading
easier.  However, it necessitated placing these libraries into a build
subdirectory, so that Monochrome's libvr.so wouldn't collide with
Chrome's libvr.so (with the same applying to the test dummy module, and
any future DFMs).

Since then, we've learned that this puts a tax on other parts of the
system, such as stack decoding tools, when trying to locate such
libraries. Further, the module build framework has been improved to
package and load feature libraries automatically, which means the files
can have arbitrary names. This lets us move to a system where (using VR
as an example), we have libmonochrome.so and libmonochrome_vr.so created
in the conventional build output directory.

VR, for now, still has a factory that loads its own library. Normally,
this wouldn't be an issue, since loading a library twice results in a
no-op the second time. However, we've been warned that because the
soname ("vr") and the library file name don't match, that there could be
issues with Android actually loading the library twice.  This shouldn't
be a problem for VR, but if it is, we could temporarily blacklist VR
from being loaded by the module library, until it's native code is fully
in the VR DFM, and it's custom factory disappears.

Bug: 1015159
Change-Id: Icd20399756d1c4876df922d9c111cda0e67773d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897910Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712708}

Even '*' can be injected as valid js object name and used as window
property. This is a test to show that.

Bug: 918065
Change-Id: I1a91b658e1c6357a7b61197a487c848a1980b5b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899183Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712707}

This CL disables Split Cache explicitly for the test
NetworkContextTest.NotifyExternalCacheHit
and updates expectations accordingly. This is because the test
NetworkContextTest.NotifyExternalCacheHit_Split is already testing the
expectations for when split cache is enabled.

Bug: 1009597
Change-Id: If987208f59cd9d41de52d2f2aacc3ff7e78644b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899893Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712706}

https://chromium.googlesource.com/breakpad/breakpad.git/+log/c46151db0ffd..5915ea929c43

$ git log c46151db0..5915ea929 --date=short --no-merges --format='%ad %ae %s'
2019-11-04 cjgrant Add fallthrough annotations on new C++ switches
2019-11-01 mark Revert "Remove use of "register" keyword, deprecated in C++17"
2019-10-29 jperaza linux, client: set module name from DT_SONAME
2019-10-29 cjgrant linux, dump_syms: Make style consistent in module unittest
2019-10-29 cjgrant linux, dump_syms: Filter module entries outside specified ranges
2019-10-04 jakehehrlich Add options to set OS and filename
2019-10-24 jperaza linux, dump_syms: set module name from DT_SONAME
2019-08-03 vapier convert_UTF: rewrite in C++
2019-08-14 vapier codereview.settings: do not force squashing behavior
2019-08-12 mark Remove use of "register" keyword, deprecated in C++17
2019-08-07 mark Mac dump_syms: accept __DWARF segment without __debug_info section
2019-08-03 vapier string_conversion: fix pointer math
2019-08-03 vapier guid_creater: include string.h for memcpy
2019-08-03 vapier minidump_processor: fix typo in BUS_ADRALN
2019-08-03 henri.hyyrylainen Updated lss to fix compiling with GCC 9
2019-07-22 jperaza arm64: strip PACs from link register values
2019-07-11 ivanpe Improving the support for Fuchsia in Breakpad Processor.
2019-07-03 mark Remove base_logging::LogMessage

Created with:
  roll-dep src/third_party/breakpad/breakpad

Bug: 990190
Change-Id: If18e57e7f360e8bb514ab61164c1049135c5d27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894258Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712705}

This CL is a refactoring on the way RenderText do
ItemizeTextToRuns for the corner cases where a run
should be split in grapheme clusters.

The previous code was naming these cases:
  * Unusual characters
  * Special characters
  * Non-regular characters
But they should be more specific on the purpose of splitting the runs.

Also, the algorithm used for splitting a sequence of codepoint
was based on the code block of the corresponding codepoints
and few cases where trying to merge adjacent codepoint in
a grapheme. The algorithm was incorrect multiple cases (e.g. emoji).

Unicode provide a way to split a sequence of codepoints into
grapheme and grapheme clusters.
They provide a state machine which is using the codepoint proporties
to decide if the current location is a grapheme boundaries.

The ICU library is providing an API over the character properties
to help iterating over graphemes.
  * ubrk_open
  * ubrk_first
  * ubrk_next
  * ubrk_close

The class base::i18n::BreakIterator(..., BREAK_CHARACTER) is
providing an easy to use wrapper over that API.


The current CL is replacing the previous characters based splitting
algorithm by the graphemes based version.



See emoji sequence:
  http://www.unicode.org/reports/tr51/
  1.4.5 Emoji Sequences

The full emoji list:
  * http://unicode.org/emoji/charts/full-emoji-list.html
Emoji data, used to make our unittests:
  * http://www.unicode.org/Public/emoji/12.0/emoji-data.txt


see: UNICODE TEXT SEGMENTATION (http://unicode.org/reports/tr29/)
see: https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubrk.h
see: https://cs.chromium.org/chromium/src/base/i18n/break_iterator.h
Change-Id: I6b9a9c79021f2ce0e2db7cdefdd0838b5911f445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788804
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712704}

If the touch to fill sheet is dismissed, it triggers a second call to
BottomSheetController#hideContent.

That call triggers an observer in the BottomContainer again which then
moves itself out of the visible view port.
(The latter can only happen since a division by zero bypasses some guard
conditions. It might make sense to abort attempts at repeatedly
dismissing the bottomsheet but this exceeds the scope of this CL.)

Bug: 1021550
Change-Id: Ida2b6bc9ffd18513419bed40b29ca84528310907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899882Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712703}

Adds an AppMenuTest for app menu integration tests
 - #testShowHideAppMenu
 - #testShowDestroyAppMenu
 - #testClickMenuItem
 - #testAppMenuBlockers
 - #testSetMenuHighlight_StandardItem
 - #testSetMenuHighlight_Icon
 - #testMenuItemContentChnaged
 - #testHeaderFooter
 - #testAppMenuHiddenOnStopWithNative
 - #testAppMenuHiddenOnConfigurationChange

Also adds a few more tests to AppMenuAdapterTest to shore up test
coverage and adds an AppMenuAdapterRenderTest that runs a suite of
render tests for the various types of menu items supported natively
by the app menu.

This patch includes an update to AnimationFrameTimeHistogram to allow
histogram recording to be disabled for tests.

BUG=966644

Change-Id: I035b10557a9e35ef0e86b315ccd926230bb18bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893984
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712702}

https://skia.googlesource.com/skia.git/+log/e9b546970ec2..7a13b461e6e0

git log e9b546970ec2..7a13b461e6e0 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 mtklein@google.com x86-64 JIT support for Op::index
2019-11-05 csmartdalton@google.com ccpr: Fail gracefully when atlas instantiation fails

Created with:
  gclient setdep -r src/third_party/skia@7a13b461e6e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@google.com

Bug: None
Change-Id: Ifae4d72e4f1461a247a03c17cf72df7bea4522d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899419Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712701}

When an app is profile-agnostic, change the Info.plist to:
- Not embed the profile name in the kCFBundleIdentifierKey value
- Not specify the kCrAppModeProfileDirKey value at all
- Not specify the kCrAppModeProfileNameKey value at all
- Strip the profile path out of the kCrAppModeUserDataDirKey value
  - Note that the user data dir still references the launching user's
    home directory, so these shims cannot be moved to /Applications.
  - That is tracked in the separate https://crbug.com/1021237

When searching for an app shim via bundle identifier, allow profile-
agnostic apps to use either the profile-scoped or profile-agnostic
shim. This will allow users to continue using pre-existing shims. A
follow-on patch will add UMAs to query how often this occurs, so we can
decide when to remove that code.

This is all still behind a flag.

Bug: 1001222
Change-Id: I2515fb179b6fde5ffa3b04c32e50fb93c6329860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894164
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712700}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ia7250dd603ab0edaf6e49dcf60058b311b401842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900108Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712699}

Now that launching waits for a first paint, this no longer
seems flaky. At least I couldn't repro locally after ~10ish
tries.

BUG=1020065
TEST=test only change

Change-Id: I1530fcb3f9811b0251a20bd151be5d55322283f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899336Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712698}

The only left warnings were recently introduced by CL
https://chromium-review.googlesource.com/c/chromium/src/+/1811197
in files compositor_frame_reporter.cc and frame_sequence_tracker.cc.

Bug: 999871
Change-Id: I77d50266a87ee8b3dbe9d9ed313b5019a364a8c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899986
Auto-Submit: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712697}

https://dawn.googlesource.com/dawn.git/+log/dbf9f7c39cbe..c277c38d9064

git log dbf9f7c39cbe..c277c38d9064 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 cwallez@chromium.org Suppress failing VertexFormat tests on Mac Intel
2019-11-05 kainino@chromium.org Enable EmulateStoreAndMSAAResolve correctly by platform
2019-11-05 cwallez@chromium.org Vulkan: Reuse descriptor pools

Created with:
  gclient setdep -r src/third_party/dawn@c277c38d9064

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I59a112ca5266d4138cc573ea4acfda2337225366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900089Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712696}

https://chromium.googlesource.com/angle/angle.git/+log/ac36a55cc2de..1bae56151db3

git log ac36a55cc2de..1bae56151db3 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 jmadill@chromium.org Remove some ignores from export_targets.py.

Created with:
  gclient setdep -r src/third_party/angle@1bae56151db3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@google.com

Bug: None
Change-Id: I3e42c4e358433232327556b899f483de3467a3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899484Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712695}