GitLab

This patch provides a way to notify backend agents about starting a profiler.
Each agent should switch to a mode which doesn't affect the performance.
As example DebuggerAgent needs to disable breakpoints, allow v8 optimizations, etc.
DOM and Network agents may simple disable themselves.

BUG=381115
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/321173002

git-svn-id: svn://svn.chromium.org/blink/trunk@175946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces Blink specific editing events usage with |addEventListener| for
 - textInput
 - webkitBeforeTextInserted
 - webkitEditableContentChanged

We would like to deprecate these Blink specific events and replace them standard one, e.g. beforeinput, or use another way to implement editing functionality if community agreed.

The usage data collected from use counter introduced by this patch are important for decision.

BUG=382814
TEST=n/a

Review URL: https://codereview.chromium.org/328513004

git-svn-id: svn://svn.chromium.org/blink/trunk@175945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- This CL adds an ASSERT to ScriptValue to verify that ScriptValue::v8Value() is used in the same world that created the ScriptValue.

- To insert the check, we need to get a current world in ScriptValue::v8Value(). For that goal, this CL makes sure that we're in some context when calling ScriptValue::v8Value().

BUG=341032

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175837

Review URL: https://codereview.chromium.org/314953005

git-svn-id: svn://svn.chromium.org/blink/trunk@175944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Safeguard for webMediaPlayer() access in createImageBitmap() incase webMediaPlayer() and m_readystate of media element are out of sync

BUG=350571

Review URL: https://codereview.chromium.org/320843002

git-svn-id: svn://svn.chromium.org/blink/trunk@175943 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the renderer for the plugin always gets either a NormalLayer
or a ForcedLayer, it will have a RenderLayer whether it's composited
or not, so all we have to do is update it's self painting layer bit.

This is a followup to https://codereview.chromium.org/328553004.

Review URL: https://codereview.chromium.org/322193002

git-svn-id: svn://svn.chromium.org/blink/trunk@175942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function doesn't do anything. The repaint it generates is redundant and
marking the RenderLayerCompositor as needing a rebuild is redundant because
RenderLayerStackingNode will already mark the same dirty bit. It's more
sensible for RenderLayerStackingNode to be responsible for setting this dirty
bit because the reason it needs to be set is that the stacking tree has changed.

Review URL: https://codereview.chromium.org/325063003

git-svn-id: svn://svn.chromium.org/blink/trunk@175941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They generate Element factory function like |PassRefPtrWillBeRawPtr<T>
create(const QualifiedName&, Document&)|.

We're going to change element factories at least twice.
 1. Replace adoptRefWillBeRefCountedGarbageCollected with adoptRefWillBeNoop
 2-1. Replace PassRefPtrWillBeRawPtr<T> with T* and remove adoptRefWillBeNoop if
   we switch to Oilpan successfully.
 2-2. Replace PassRefPtrWillBeRawPtr<T> with PassRefPtr<T>, and
   adoptRefWillBeNoop with adoptRef if we decide not to switch Oilpan.

This CL makes these changes easier.

BUG=357163

Review URL: https://codereview.chromium.org/327133002

git-svn-id: svn://svn.chromium.org/blink/trunk@175940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This call site was already trigginer a CompositingUpdateAfterCompositingInputChange.
Calling updateLayerCompositingState could upgrade to CompositingUpdateRebuildTree,
but there's no reason to do that eagerly. We compute whether that upgrade is
necessary during the compositing update itself.

BUG=343756

Review URL: https://codereview.chromium.org/327963005

git-svn-id: svn://svn.chromium.org/blink/trunk@175939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function ignores both its arguments and is one line. It's clearer if
we just inline it and match it up with the call to
setNeedsCompositingInputsUpdate.

Review URL: https://codereview.chromium.org/326253002

git-svn-id: svn://svn.chromium.org/blink/trunk@175938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Conceptually, there's no reason for RenderLayerScrollableArea to call
updateLayerCompositingState and no tests fail when the call is removed.

BUG=343756,336251

Review URL: https://codereview.chromium.org/321283003

git-svn-id: svn://svn.chromium.org/blink/trunk@175937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This comment previously referred to a bug that's already been marked as fixed.
The new bug is dedicated to this issue. Turns out we're pretty close.

NOTRY=true
TBR=chrishtr@chromium.org
BUG=383191

Review URL: https://codereview.chromium.org/327143002

git-svn-id: svn://svn.chromium.org/blink/trunk@175935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink half of change.

BUG=382738

Review URL: https://codereview.chromium.org/328883002

git-svn-id: svn://svn.chromium.org/blink/trunk@175934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was a suggestion by dcheng in https://codereview.chromium.org/309143002/. Added a // Navigation transitions ----- section and moved the function there.

BUG=

Review URL: https://codereview.chromium.org/324153003

git-svn-id: svn://svn.chromium.org/blink/trunk@175933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Simplify finalization of 'slaved' media elements by not requiring them
to unregister with their MediaController, but have it (the controller)
weakly refer to them instead.

Previously, a RefPtr<> was kept on the media element to make that
unregistration safe during finalization. This is no longer needed, and
a simpler Member reference from the media element is used instead.

R=haraken@chromium.org,ager@chromium.org,acolwell@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/314113008

git-svn-id: svn://svn.chromium.org/blink/trunk@175930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are redundant as force compositing mode is on by default.

BUG=361729

Review URL: https://codereview.chromium.org/328503002

git-svn-id: svn://svn.chromium.org/blink/trunk@175928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We are going to disallow CORS-disabled font fetching.
Also adding a test case to check whether CORS is working.

BUG=286681

Review URL: https://codereview.chromium.org/316353003

git-svn-id: svn://svn.chromium.org/blink/trunk@175927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a form "action" attribute is pointing to insecure location from a secure one, this is flagged as mixed content. This is even checked if the pages dynamically changes the "action" attribute after the initial loading. The mixed content is non-blocking by default, however, this can be overridden in the preferences, and this will cause a submit to silently fail, other than a console message.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175714

Review URL: https://codereview.chromium.org/311033003

git-svn-id: svn://svn.chromium.org/blink/trunk@175926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This state on RenderLayer is specific to the compositor. The name
AncestorDependentProperties hasn't aged well. In other places, we call these
CompositingInputs, which seems more appropriate.

Review URL: https://codereview.chromium.org/322163003

git-svn-id: svn://svn.chromium.org/blink/trunk@175925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No one uses this geometry map. We shouldn't pay the cost of maintaining it.

BUG=382770

Review URL: https://codereview.chromium.org/321223003

git-svn-id: svn://svn.chromium.org/blink/trunk@175924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Requested by jam@, because of WebViewClient being doomed to a painful death.

BUG=162827

Review URL: https://codereview.chromium.org/319633007

git-svn-id: svn://svn.chromium.org/blink/trunk@175923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We also have a function called updateLayerPosition and having both was
confusing.

Review URL: https://codereview.chromium.org/327053002

git-svn-id: svn://svn.chromium.org/blink/trunk@175922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows RemoteFrames to be added to the FrameTree.

BUG=346764
R=dcheng@chromium.org
TBR=japhet@chromium.org,eseidel@chromium.org

Review URL: https://codereview.chromium.org/317493002

git-svn-id: svn://svn.chromium.org/blink/trunk@175921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/325053002

git-svn-id: svn://svn.chromium.org/blink/trunk@175920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Then clean up the errors that result from changing that.

For me, this reduces the number of targets built on a trivial change to
GraphicsContext.h from 888 to 297.

Review URL: https://codereview.chromium.org/319183004

git-svn-id: svn://svn.chromium.org/blink/trunk@175919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

From the stack trace in the bug, it looks like this function is entered during
DOMWindow teardown which means the dereference of the document() member on
the Frame is invalid. We can simply use m_frame->settings() since it's
guaranteed to be there because of the check for m_frame->page() at the
function's entrance.

BUG=377916

Review URL: https://codereview.chromium.org/326073007

git-svn-id: svn://svn.chromium.org/blink/trunk@175918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the GN equivalent of public/all.gyp's all_blink target which
defines all test targets that blink contains. As more test targets start
linking in the GN build they should be added to this file. For now, this
just includes wtf_unittests and the /platform/ and /core/ components.

Review URL: https://codereview.chromium.org/324963007

git-svn-id: svn://svn.chromium.org/blink/trunk@175917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The meaning of a secure origin is defined by:
http://www.chromium.org/Home/chromium-security/security-faq#TOC-Which-origins-are-secure-

In essence, "secure origins" are those that load resources either from the local machine or over the network from a cryptographically-authenticated server.

For example these are considered secure origins:
  * chrome-extension://xxx
  * https://xxx
  * wss://xxx
  * file://xxx
  * http://localhost/
  * http://127.0.0.1/

Whereas these are considered insecure:
  * http://foobar
  * ws://foobar

crypto.subtle itself is visible from insecure origins. However all of its methods will fail by returning a rejected Promise for NotSupportedError.

BUG=373032, 245025, 362214

Review URL: https://codereview.chromium.org/299253003

git-svn-id: svn://svn.chromium.org/blink/trunk@175916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This case can never occur. This function is now only called from a full
compositing update, which cleans out all the dirty bits in the z-list. I ran
all the LayoutTests with a CRASH() in this codepath and it never hit.

Review URL: https://codereview.chromium.org/329613002

git-svn-id: svn://svn.chromium.org/blink/trunk@175915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to store a bit on the RenderStyle as to whether it needs
to be accelerated due to the plugin having a layer so that when
we recalc style on it, we actually get a different style and
call setStyle. This is needed so styleChanged gets called
and we get a NormalLayer RenderLayer.

This is better than the current hack because we'd like it to
be an invariant that setStyle is only called when the style
actually changed.

Revert "Psuedo revert "s/scheduleLayerUpdate/setNeedsCompositingUpdate in setWebLayer.""

This reverts commit 2c54e3cf4c74a20c2319bc3bae26904fbb462330.

Review URL: https://codereview.chromium.org/328553004

git-svn-id: svn://svn.chromium.org/blink/trunk@175914 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes the bindings basically run although not all of core links so there may be some items left to do.

R=nbarth@chromium.org

Review URL: https://codereview.chromium.org/319983003

git-svn-id: svn://svn.chromium.org/blink/trunk@175913 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Sometimes grid children are wrapped into an anonymous blocks to become grid
items. Those anonymous blocks could be eventually removed by
RenderBlock::removeLeftoverAnonymousBlock() (called for example when adding
a new child to the grid). That method does not notify the hierarchy about
the removal since those anonymous blocks are not part of the
DOM. This means that further accesses to the m_grid contents will trigger
invalid accesses to the already deleted RenderObjects (the anonymous blocks).

To fix it we invalidate the contents of m_grid by setting the dirty flag in
the grid.

Based on the previous work in r161127 by <jchaffraix@chromium.org>

BUG=313293

Review URL: https://codereview.chromium.org/302083005

git-svn-id: svn://svn.chromium.org/blink/trunk@175912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

instead of anchorPoint.

The hack is no longer necessary because transformOrigin is an additive offset,
as opposed to a multiplicative one.

BUG=372837

Review URL: https://codereview.chromium.org/329553003

git-svn-id: svn://svn.chromium.org/blink/trunk@175911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=abarth
BUG=382129

Review URL: https://codereview.chromium.org/328783002

git-svn-id: svn://svn.chromium.org/blink/trunk@175910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target. (https://codereview.chromium.org/320933003/)

Reason for revert:
event-listener-breakpoints.html always timing out on Mac 10.6 (dbg):
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(dbg)

Original issue's description:
> DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target.
> 
> This will allow debugger to pause on "load", "error" and etc. event breakpoints only
> when they happen on XHR event targets.
> 
> BUG=381470
> R=yurys, pfeldman@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175882

TBR=pfeldman@chromium.org,yurys@chromium.org,aandrey@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=381470

Review URL: https://codereview.chromium.org/322893006

git-svn-id: svn://svn.chromium.org/blink/trunk@175909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix InternalsGeolocation::setGeolocationClientMock to actually set the test client for all GeolocationController.

This was caught by kenrb. It didn't manifest itself because it's a test-only method, and none of the geolocation tests which use this do so for an iframe.

Review URL: https://codereview.chromium.org/322583002

git-svn-id: svn://svn.chromium.org/blink/trunk@175907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid branching in createAttributeEventListener, also it should not be needed to test for SVG specific stuff in this spot.

Review URL: https://codereview.chromium.org/321023002

git-svn-id: svn://svn.chromium.org/blink/trunk@175902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376194

Review URL: https://codereview.chromium.org/324013005

git-svn-id: svn://svn.chromium.org/blink/trunk@175901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/323873007

git-svn-id: svn://svn.chromium.org/blink/trunk@175900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These represent the same concept, and having two separate
enumerations is redundant.

BUG=382916

Review URL: https://codereview.chromium.org/328453004

git-svn-id: svn://svn.chromium.org/blink/trunk@175899 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Timeline front-end used to assume that if call stack is present, it contains at
least one call frame. Let's not break that expectation when transitioning to
trace-based instrumentation and return null, not empty array, for the absent stack.

BUG=361045

Review URL: https://codereview.chromium.org/327793002

git-svn-id: svn://svn.chromium.org/blink/trunk@175898 bbb929c8-8fbe-4397-9dbb-9b2b20218538