- 10 Sep, 2019 40 commits
-
-
Antonio Gomes authored
... from std::unique_ptr<content::P2PPortAllocator> to std::unique_ptr<cricket::PortAllocator>. This is a precursor CL that prepares peer_connection_dependency_factory.h to move temporarily to Blink's exposed API (which will have no access to P2PPortAllocator). The full solution is described in the design document [1], phase 5. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Iedf28f1261bbf57d5e8cc556ab0b3b99d55f6d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795667 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#695339}
-
Peter Kasting authored
Bug: 23697 Change-Id: I4d3a21d2393d4f6dd2583e7a25cb985dde2cde7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793947Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695338}
-
Dale Curtis authored
- Expands logging in key failure points. - Enables DumpWithoutCrashing for media browsertests. - Checks pa_context_t state before trying the only blocking method in the linux default device authorization path. BUG=986021 R=tguilbert Change-Id: I4b03313e4431cb847e8a8bd926dd810471fb21ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796311 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695337}
-
Rob Hueber authored
In cast audio devices there are a number of libraries that statically link in libbase, resulting in each library having its own copy of tcmalloc. During static initialization of a library, the tcmalloc in that library is called directly, and tcmalloc can call sbrk() which is not thread safe. By disabling tcmalloc, we avoid the possibility of multiple calls to sbrk() causing crashes on cast audio devices. Bug: 1002281 Test: Build and run cast_shell and chrome Change-Id: Ib5707d0132596ea73cc8dd9ef68fac049334e17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795754 Commit-Queue: Rob Hueber <rhueber@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695336}
-
Ted Meyer authored
For each initialization segment, this will log: init start init complete playback completed Change-Id: I989b67d9a86b484c79bac48e20fed408bd85b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793807 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#695335}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9c1c856c64c..53a5a5042e54 git log d9c1c856c64c..53a5a5042e54 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 dpranke@chromium.org Add a COMPONENT entry to the OWNERS file. Created with: gclient setdep -r src/third_party/depot_tools@53a5a5042e54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I10d063197a47f3648b67bbf693dac4a105c23dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695334}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66d325b6e26e..1e47094cfbc5 Created with: gclient setdep -r src-internal@1e47094cfbc5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id164d6bce18f3f9b6d18a9ac3e90b89a0be95164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796748Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695333}
-
Xiyuan Xia authored
- Add ShelfLayoutManager::OnWorkAreaInsetsChanged that notifies Shelf when it updates the Shelf insets in WorkAreaInsets; - Add ShelfObserver::OnShelfWorkAreaInsetsChanged that gets called when Shelf gets a OnWorkAreaInsetsChanged call; - AshPopupAlignmentDelegate observes OnShelfWorkAreaInsetsChanged and update its work area instead Shelf visibility or autohide state change; Bug: 1002003 Change-Id: I1239713a1d1dd7c27d84cfe4f81621f4ab638ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795907 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#695332}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/dbus/audio. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=hychao@chromium.org Bug: 891670 Change-Id: I55a04b25e80b979196259ec1c593cad76481163f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786960 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695331}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /url/mojom/url_gurl_mojom_traits_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=kerrnel@chromium.org Bug: 891670 Change-Id: I0432a4253c14c5a160d6716e41af7d61eb1c52a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786812 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695330}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/79ad0411911b..0b8eca795349 git log 79ad0411911b..0b8eca795349 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 jmadill@chromium.org Capture/Replay: Fix CaptureShaderSource_string. Created with: gclient setdep -r src/third_party/angle@0b8eca795349 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: Id4265b9aef376226664a5f9aa5f24112ea1f5c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796750Reviewed-by:
-
Owen Min authored
Add a log indicates first report remaining time. Bug: 956237 Change-Id: I266c5ae59a52cf11e9e9d4ad340032af43d32dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796763Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695328}
-
Ben Pastene authored
Bug: 1002652 Change-Id: Ib5a8c411a85df3bd9a12c3e9f67e8cdc31b7d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795499 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#695327}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/ntp_snippets. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=noyau@chromium.org Bug: 891670 Change-Id: Ib3206c1a7c5241a2f8f6d515f7f321be5058519f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787205 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695326}
-
Jonathan Ross authored
The crash affecting this test has been fixed. Re-enabling it. TBR=backer@chromium.org TEST=media/alpha-video-playback skia_renderer_swiftshader_blink_web_tests Bug: 988120 Change-Id: I4cbeb7d38bb42536a76e8834c8f1a63c85a74360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764108Reviewed-by:Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#695325}
-
Tommy Li authored
This CL contains the implementation a for the flag to preserve the default match during the async pass. It's a minimally-interventionist approach (the smallest possible hammer) that simply promotes the previous default match to the top, if it can be found in the new result set from the async pass. It won't inject in the old default match if it's truly no longer present after the async pass, because I think there will be unwanted side effects from that. It also adds a test. Bug: 398135 Change-Id: I9be0f18820436d3d29b8ba7a80835d456d771cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788313Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#695324}
-
Eliot Courtney authored
This fixes the case where the occlusion is changed while we are updating all the pending properties. This caused some wrong occlusion updates. Bug: 140563748 Test: Spurious occlusion update no longer occurs when leaving PIP. Change-Id: Ic9bdbf62c655285eb8fbe1c80d221ff95bbbd096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794526 Commit-Queue: Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#695323}
-
Scott Violet authored
I had to change //component/version_info as generate_version_info is not externally visibile and should be a public_dep of version_info. BUG=none TEST=none Change-Id: I8e27071b70f5c888eb33456283b7794bb166e270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790745Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695322}
-
Sharon Yang authored
This is a reland of b02a397f Original change's description: > [fuchsia] Register Views with Fuchsia Accessibility APIs > > * Add the AccessibilityBridge class skeleton, which will eventually > handle the logic for conversion between Chromium and Fuchsia > accessibility data structures. > * Register a ViewRef to the Fuchsia SemanticsManager. > > Test: Added AccessibilityBridgeUnitTest.* > > Bug: 973095 > Change-Id: Ie8eb6a8cdd68e0082d3479b9b1288f8aaa68a600 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708043 > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693914} Bug: 973095 Change-Id: Ia13e5f80383abe6d22f3e3049a07b6204861b400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796627Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#695321}
-
John Chen authored
Dsiabling the following failing perf tests on android-pixel2-perf: system_health.memory_mobile/browse:chrome:newtab system_health.common_mobile/browse:chrome:newtab v8.browsing_mobile/browse:chrome:newtab v8.browsing_mobile-future/browse:chrome:newtab system_health.memory_mobile/browse:chrome:omnibox system_health.common_mobile/browse:chrome:omnibox v8.browsing_mobile/browse:chrome:omnibox v8.browsing_mobile-future/browse:chrome:omnibox TBR=crouleau@chromium.org NOTRY=true Bug: 1002640, 1002665 Change-Id: Ie0d5edfb7f47b2e3d7d6266c6b727cf12b02bbc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795892Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695320}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/058a26f57015..a9e27d5c7f1b git log 058a26f57015..a9e27d5c7f1b --date=short --no-merges --format='%ad %ae %s' 2019-09-10 dpranke@chromium.org Add a COMPONENT (Platform>NaCl) entry to //OWNERS. Created with: gclient setdep -r src/native_client@a9e27d5c7f1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=mseaborn@chromium.org Bug: None Change-Id: I4e55a36ffd97c3afef87df8a72f89629fdf04dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796747Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/de5f63910e24..467073a0c18f git log de5f63910e24..467073a0c18f --date=short --no-merges --format='%ad %ae %s' 2019-09-10 qingsi@webrtc.org Revert "Adds peer scenario connection interface." 2019-09-10 qingsi@webrtc.org Revert "Reland "Refactor SCTP data channels to use DataChannelTransportInterface."" 2019-09-10 peah@webrtc.org First step for introducing multichannel support for the AEC3 capture 2019-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a87779d3..56140e7d (695071:695187) Created with: gclient setdep -r src/third_party/webrtc@467073a0c18f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I9b2e099671c1a60fcdc1e0a1d1ddf32a4cbd85de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795305Reviewed-by:
-
Alexandre Frechette authored
Bug: 872096 Change-Id: I9401f3ea3b88c86a959eee3d59c8faedd3e764de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772320Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#695317}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the content.mojom.FrameSinkProvider interface, and adapt unit tests. Bug: 955171 Change-Id: I1b4d9769549648ee7f9dd30c310445093736b354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795329Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#695316}
-
Alex Gough authored
During process creation, a job tracker (JobTracker as before) or a process tracker (ProcessTracker) is created in the process launching thread. These are then posted to the tracking thread (TargetEventsThread) (before the job is associated with the thread). New control keys are provided for the tracking thread to receive these objects and take ownership. For jobs, they are stored in a job tracking list (jobs) and job notifications are used to determine if a job has finished. Now, when finished, the tracking is removed from the job tracking list and destroyed, freeing the related target policy. For processes, these are now stored in a process tracking list (processes) and a wait registered on the default thread pool for a duplicated copy of the process’s handle to signal process exit. The wait’s callback simply posts a message to the tracking thread indicating that the process is done. When a process is done, the process tracker is removed from the process tracking list and freed. The related target policy is freed. As there may be more than MAXIMUM_WAIT_OBJECTS(=64) children we use RegisterWaitForSingleObject and a lightweight callback to post back to the tracking thread. No manipulation of these lists is done outside of the tracking thread. Policies used to be destroyed in the BrokerServices dtor so this may move some crashes around, especially if there are many processes and shutdown is stalled by a busy host. child_process_ids can now be manipulated entirely within the tracking thread so does not need locking. The working of WaitForAllTargets() could be improved but is not addressed in this effort. The lock is no longer required. This CL prepares for chrome://sandbox on Windows by moving access to stored policy objects to a single thread. I have manually tested by simulating a job-free chrome. Notes for this CL https://docs.google.com/document/d/1_9lde2MOX96VxE6k7IYtQFb5Zwpom5ZLFhCsfI7xXIc/edit#heading=h.3jv39q2gpdkw Change-Id: I35d7970fc285d80bd6ea2143cdab7d82b42d57cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743294 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#695315}
-
Michael Crouse authored
Bug: 932707 Change-Id: If73900c292289d4646af04a9ff6801d2d52d8049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795982Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.CacheStorageCache interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I863f4bc37756af961c545e693c4bdd760f637340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791151Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#695313}
-
Jan Wilken Dörrie authored
This change replaces usages of base::Value::GetList() followed by either emplace_back() or push_back() with base::Value::Append(). This is because of the upcoming change to GetList() to return a base::span instead, which does not support either emplace_back() or push_back(). This is a completely mechanical change. Steps to reproduce: - sed -i 's/GetList().push_back/Append/g' - sed -i 's/GetList().emplace_back/Append/g' - git cl format Bug: 646113 Change-Id: I2a1e6297174eaf71643f0706dd6ce19f704002ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796346Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695312}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f57b7cb8f0bc..8e63cab2e8fb git log f57b7cb8f0bc..8e63cab2e8fb --date=short --no-merges --format='%ad %ae %s' 2019-09-10 bsalomon@google.com Revert "Separate texture creation from uploading in GrGpu subclasses." 2019-09-10 senorblanco@chromium.org Dawn: implement staging buffer manager. 2019-09-10 senorblanco@chromium.org Update Dawn backend to accommodate recent Skia API changes. 2019-09-10 bsalomon@google.com Update new blurrect_compare GM to skip when SkCanvas::makeSurface will fail 2019-09-10 bsalomon@google.com Remove unused GM deferred canvas feature 2019-09-10 bsalomon@google.com Separate texture creation from uploading in GrGpu subclasses. 2019-09-10 ethannicholas@google.com fixed an assertion error with unspecified sksl array sizes Created with: gclient setdep -r src/third_party/skia@8e63cab2e8fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I3ff625d428e0936c6ac2dd9fb962b831334b352b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796782Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6d242c0..e1cf2cc2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2e1f74807f1982011e88d63d75fd0facea90bf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795670Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695310}
-
Ben Mason authored
Bug: 1002642 Change-Id: Ibd238eae9c86de75279cddf281c931a9fb1ec3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795496Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#695309}
-
Jacob DeWitt authored
Now that both position and orientation are used, some expected view matrices had to be updated. Bug: 1001733 Change-Id: I3dacd02ff724c0f173fae2c3473014df9fc6d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795492 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#695308}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b07dda63ef03..548a26302ef5 git log b07dda63ef03..548a26302ef5 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 thestig@chromium.org Use pdfium::form_flags constants in CPDF_FormField. 2019-09-10 thestig@chromium.org Remove redundant assertions in more CFFL classes. 2019-09-10 thestig@chromium.org Add more test cases for AFSimple_Calculate(). 2019-09-10 thestig@chromium.org Roll build/ b8866fdd3..f0964b29a (143 commits) 2019-09-10 thestig@chromium.org Roll third_party/googletest/src/ a45c24ac1..3a4503986 (68 commits) 2019-09-10 thestig@chromium.org Roll third_party/catapult/ 2861f86d3..884c81e17 (125 commits) 2019-09-10 thestig@chromium.org Roll third_party/depot_tools/ 59bb8cce8..e5641be5f (97 commits; 27 trivial rolls) 2019-09-10 thestig@chromium.org Roll third_party/binutils/ 92bfa0a5d..01aa7745b (1 commit) 2019-09-10 thestig@chromium.org Roll buildtools/ aeda9c123..fce87d1a3 (2 commits) 2019-09-10 thestig@chromium.org Roll build/ e7232efeb..b8866fdd3 (12 commits) Created with: gclient setdep -r src/third_party/pdfium@548a26302ef5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:611744 Change-Id: I32dfaa60b8a4715a7718f0003c45f0fedb7866b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795304Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces usages of base::Value::GetList() followed by either emplace_back() or push_back() with base::Value::Append(). This is because of the upcoming change to GetList() to return a base::span instead, which does not support either emplace_back() or push_back(). This is a completely mechanical change. Steps to reproduce: - sed -i 's/GetList().push_back/Append/g' - sed -i 's/GetList().emplace_back/Append/g' - git cl format Bug: 646113 Change-Id: I36d53904d2be2d95d410ef88e3c973884a7777c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796428Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695306}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/4baa46a5d104..5903ef1f95a0 git log 4baa46a5d104..5903ef1f95a0 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 stevenperron@google.com Have update_build_version.py new parameter (#805) Created with: gclient setdep -r src/third_party/shaderc/src@5903ef1f95a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I30f9dec6756add748eb7d7215f98189288a09f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796762Reviewed-by:
-
Chris Mumford authored
In the prior implementation the exception was uncaught which resulted in the lower level JNI layer failing a CHECK. This resulted in the Java exception being logged to adb, but then a second stack trace which was purely in native code. This caused many developers to think the problem was in WebView. This change eliminates the native crash by catching the exception, rethrowing it on the UI thread, and also failing the resource load. TEST=Manual Bug: 718929 Change-Id: I7dc4226e6f95023cc841a0fb23bcac33c330fd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742956 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#695304}
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I47b47236a4baa9f508373bf74e66130a6236c2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774920 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695303}
-
wutao authored
Bug: b/140765499 Test: new unittests in AmbientContainerViewTest Change-Id: I3ca9427ca225187b513bceec64f854f0c3567357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794032 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#695302}
-
Bailey Berro authored
Opens directly to native printer settings rather than the printing page Bug: 980230 Change-Id: I77900a57fc1491d5e20ea991ed34d4da48b12e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796313 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695301}
-
Eric Willigers authored
If any of the border-*-radius values have distinct horizontal and vertical radii, the serialized border-radius shorthand contains / Bug: 817471 Change-Id: I647ea57e6989def0677b16f79ba89cacf5ed809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695686 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#695300}
-
