GitLab

I'm going to be splitting these up a lot and there will be more
files. They need a home.

Review URL: http://codereview.chromium.org/7980055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102198 0039d316-1c4b-4281-b951-d872f2087c98

This is a D-Bus config file that will be installed on /etc/dbus-1/system.d
on Chromium OS. The original file comes from libcros.

BUG=chromium-os:18904
TEST=none

Review URL: http://codereview.chromium.org/7982020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102197 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102196 0039d316-1c4b-4281-b951-d872f2087c98

These had gotten out of sync with the comments and intended behavior when we reduced the max time per chunk to 20ms.

BUG=none
TEST=PhishingDOMFeaturExtractorTest.Continuation


Review URL: http://codereview.chromium.org/7981027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102195 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r6737: (khim) Partial rollback of r6734.
r6738: (mcgrathr) Add gyp/scons configury and buildbot option to build trusted code with Clang
r6739: (jvoung) Update llvm/llvm-gcc revs to pull in trivial merge
r6740: (mcgrathr) Roll back gtest_rev 364
r6741: (mcgrathr) Make Mac clang bot 32-bit
r6742: (kschimpf) Speed up x86-64 validator by inlining buffer segment reads. Speeds up x86-64 validator by approximately 11%.
r6743: (kschimpf) Speed up x86-64 validator by inlining heavily called routines. Speeds up

BUG=none
TEST=nacl_integration


Review URL: http://codereview.chromium.org/7977028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102194 0039d316-1c4b-4281-b951-d872f2087c98

When XmppConnection is deleted, its TaskPump member is not deleted immediately.
The destructor enqueues a task to the message loop to have it deleted later.  A
comment in ~XmppConnection that explains why it does this.

In the unit tests, the TaskPump would get leaked because the message loop would
never get a chance to run that deletion task.  This commit fixes the problem by
running all pending tasks on that message loop before we exit the test.

This commit removes the suppression for bug_80238.  Issue 80238 hasn't been
seen for a while, so it's probably safe to remove.  It's only relation to issue
79651 is that it happened in the same set of tests; the two issues probably had
different root causes.

This commit renames the suppression bug_79651, which is still necessary, but
isn't actually related to issue 79651.  When I tried to remove it, I ran into
the issue now known as issue 96904.  I've renamed the suppression to match the
issue it's actually suppressing.

Discussion of these changes can be found on the bug tracker, spread across the
pages for issues 79651, 80238 and 96904.

BUG=79651, 80238, 96904
TEST=InvalidationNotifierTest


Review URL: http://codereview.chromium.org/7919026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102193 0039d316-1c4b-4281-b951-d872f2087c98

Since it is default on now.

BUG=chromium-os:20537
TEST=Verify fix for chromium-os:20537.


Review URL: http://codereview.chromium.org/7980040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96742
TEST=See bug


Review URL: http://codereview.chromium.org/7982037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/7980018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102189 0039d316-1c4b-4281-b951-d872f2087c98

Chrome uses an explicit third_party copy of this library,
however, temporarily the nacl_integration_tests require the system
version to be installed to build sel_ldr.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2265
TEST=None
R=nfullagar@google.com
Review URL: http://codereview.chromium.org/7977035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102188 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7979033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102187 0039d316-1c4b-4281-b951-d872f2087c98

Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.

Add sync/util/time.h, with utility functions to manage the sync proto
time format.

Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).

Update SessionChangeProcessor/SessionModelAssociator
to use base::Time, too.

Remove hackish Now() function.

Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7981006

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/7977034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102186 0039d316-1c4b-4281-b951-d872f2087c98

Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.

Add sync/util/time.h, with utility functions to manage the sync proto
time format.

Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).

Update SessionChangeProcessor/SessionModelAssociator
to use base::Time, too.

Remove hackish Now() function.

Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7981006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102184 0039d316-1c4b-4281-b951-d872f2087c98

Instead add DemuxerStream::audio_decoder_config() to break FFmpegAudioDecoder's dependency on the AVCodecContext object maintained by FFmpegDemuxer.


Review URL: http://codereview.chromium.org/7867051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=no
TEST=no


Review URL: http://codereview.chromium.org/7982023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102182 0039d316-1c4b-4281-b951-d872f2087c98

make sure menus are shown rather then something meaningful.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7979021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102180 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=no


Review URL: http://codereview.chromium.org/7978032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7979029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102178 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7979014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102177 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jennb

Review URL: http://codereview.chromium.org/7981037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102176 0039d316-1c4b-4281-b951-d872f2087c98

To stave off future collisions, I went ahead and prefixed all of the Autofill label names.

BUG=97322
TEST=none


Review URL: http://codereview.chromium.org/7978010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102175 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97498
TEST=

Review URL: http://codereview.chromium.org/7977032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102174 0039d316-1c4b-4281-b951-d872f2087c98

Rename PanelMouseWatcherGtk into PanelMouseWatcherTimer. Added implementation of gfx::Point GetCursorScreenPoint() on Mac.

Review URL: http://codereview.chromium.org/7981012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102173 0039d316-1c4b-4281-b951-d872f2087c98

Use Chrome's user agent string for content_shell, since some sites (i.e. Gmail) give a degraded experience otherwise.

BUG=90445
Review URL: http://codereview.chromium.org/7980044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102172 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7980051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102171 0039d316-1c4b-4281-b951-d872f2087c98

It had turned off after June 30, 2011 builds. Extend to 2013. This is useful to gather SPDY over SSL vs HTTP over SSL metrics, which have disappeared now :(

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7946009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102170 0039d316-1c4b-4281-b951-d872f2087c98

Create new classes SyncManager::Change{Delegate,Observer} to handle
and observe changes.

Make SyncBackendRegistrar the SyncManager::ChangeDelegate.

Make SyncBackendHost call RefreshEncryption asynchronously and wait for it.
Also make the initialization state machine more explicit.

Remove the hack done to make use of observers_ in SyncManager::SyncInternal
almost thread-safe.

Comment which SyncManager member functions can be called from any thread.

Introduce helper struct WriteTransactionInfo and have DirectoryChangeDelegate
take that instead of just an EntryKernelMutationMap.

Beef up thread safety checks in SyncBackendHost.

Limit number of ChangeRecord -> value conversions done.

Move ChangeRecord unit tests into their own file.

BUG=89658,85481
TEST=

Review URL: http://codereview.chromium.org/7926001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=see unittest
Review URL: http://codereview.chromium.org/7983039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual.


Review URL: http://codereview.chromium.org/7867018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102167 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7955001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=binji,gbillock,jhawkins

Review URL: http://codereview.chromium.org/7983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102165 0039d316-1c4b-4281-b951-d872f2087c98

Use DISABLE_RUNNABLE_METHOD_REFCOUNT macro in several places I've previously specialized RunnableMethodTraits.

Review URL: http://codereview.chromium.org/7980014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102164 0039d316-1c4b-4281-b951-d872f2087c98

http://src.chromium.org/viewvc/chrome?view=rev&revision=102006

fix know issues in RenderText

1. add tests.
2. change SelectWord() to use BreakIterator, so it works for Chinese and Complex script.
3. DELETE/ReplaceChar delete/replace a whole grapheme. ReplaceTextInternal should only replace one grapheme when there is no selection.
4. pointing to position outside of text returns HOME/END position.
5. based on Chrome Linux omnibox and gedit, given 
"abc|   def", double click should select "   " instead of "abc". Change test expectation.

BUG=90426
TEST=compile with touchui=1 test omnibox. run views_unittests.NativeTextfieldViewsTest/TextfieldViewsModelTest
Review URL: http://codereview.chromium.org/7841056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102160 0039d316-1c4b-4281-b951-d872f2087c98

matched by the whitelist regexp.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7980032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=SafeBrowsingDatabaseTest


Review URL: http://codereview.chromium.org/7863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102158 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581

Review URL: http://codereview.chromium.org/7915008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102157 0039d316-1c4b-4281-b951-d872f2087c98

Removes the dependency on chromeos-specific code in the extension-based file picker.  Compiles, links, and runs, but the dialog doesn't function yet - there's still some work to do to wire up the private JavaScript API calls.  See crbug.com/97424

BUG=chromium-os:20583
TEST=On plain ChromeOS, can still open a file with control-O file picker.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102113

Review URL: http://codereview.chromium.org/7941014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102156 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org
BUG=64887
TEST=none

Review URL: http://codereview.chromium.org/7982036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102154 0039d316-1c4b-4281-b951-d872f2087c98

Retry r100017. This time, prevent a potential shutdown race by moving the call to DownloadManager.Shutdown() from ExitedOffTheRecordMode() to ~OTRProfileImpl() to match ProfileImpl and guarantee that Shutdown() is called.

Make a new integer field in sql::MetaTable (a per-profile db) containing a counter for the next download id, so that this id is unique across sessions. This id will allow us to merge download id with db_handle and merge most/all of the maps in DownloadManager in future CLs.

Make DownloadManager read this field to initialize its next_id_ counter in Init().

Put a fine-grained mutex in DownloadManager::GetNextId() so that it can be called directly from any thread.
Define a thunk wrapping DM::GNI() to be passed around between threads to guard against other threads calling any other DM methods.

This thunk owns a scoped_refptr<DM> to manage life-time issues. This pattern is implemented for DM elsewhere.
Store this thunk in ResourceContext to be called by ResourceDispatchHost/DownloadThrottlingResourceHandler on the IO thread. Pass the returned DownloadId into DownloadResourceHandler.

The alternative way to obtain ids on the IO thread is to jump over to the UI thread and back. This way would add significant latency to a critical path. GetNextId() should be fast and easily accessible from any thread.

Now that ids are per-profile, define a class DownloadId containing a per-profile id and an indication of which profile, currently the DownloadManager*. DownloadIds are hashable, comparable, globally unique, not persistent, and are used by DownloadFileManager.

When the download is added to the history, MetaTable.next_download_id will be set to the new download's id +1 if that number is greater than MT.next_download_id. Increasing this counter at the same time as the download is added to the db prevents the counter from desyncing from the db, which was the primary concern re storing the counter in the BrowserPrefs.

Owners:
Randy: downloads/* (no change from 7776012)
(Done) John: content/browser/{renderer_host/,resource_context.}* (no change from 7776012)
(Done) Will, Miranda: profiles/* (small bugfix)

Review URL: http://codereview.chromium.org/7847027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102149 0039d316-1c4b-4281-b951-d872f2087c98

This avoids the need for NPObjectStub to use PluginThread::plugin_path() and allows us to remove the content/plugin/ include from npobject_stub.cc. We can also remove PluginThread::plugin_path().

Refactoring only, no functional change.

BUG=96703

Review URL: http://codereview.chromium.org/7982026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102145 0039d316-1c4b-4281-b951-d872f2087c98